Re: [O] proposed patch for org-export-latex-hyperref-options-format

2013-10-01 Thread Nicolas Goaziou
Hello,

Andrea Rossetti andrea.rosse...@gmail.com writes:

   I'd like to suggest a customizable hypersetup string
 as a future, non-urgent enhancement of ox-latex.el; the
 defcustom at line 324 of this old file:

 http://repo.or.cz/w/emacs.git/blob/HEAD:/lisp/org/org-latex.el

 could fit reasonably well for variable name, default value,
 type and docstring.

You can disable the hypersetup with `org-latex-with-hyperref' (or
locally with #+options: texht:nil) and install you own
with #+latex_header, or in your class.

I don't think we need yet another way to provide a customized hypersetup
string. Do we?


Regards,

-- 
Nicolas Goaziou



Re: [O] proposed patch for org-export-latex-hyperref-options-format

2013-10-01 Thread Andrea Rossetti

  Thanks Nicolas for your last directions,
I will apply them.

  The accidental coexistence of two Org versions
on my Emacs installation (built-in versus ELPA)
confused me a bit, apologies for the noise.

  Kindest regards,

  Andrea

Nicolas Goaziou n.goaz...@gmail.com writes:

 You can disable the hypersetup with `org-latex-with-hyperref' (or
 locally with #+options: texht:nil) and install you own
 with #+latex_header, or in your class.

 I don't think we need yet another way to provide a customized hypersetup
 string. Do we?


 Regards,



Re: [O] proposed patch for org-export-latex-hyperref-options-format

2013-09-30 Thread Nicolas Goaziou
Hello,


Andrea Rossetti andrea.rosse...@gmail.com writes:

   may I please ask if this tiny patch looks reasonable and can
 be committed by the mantainers.

   Customizable option org-export-latex-hyperref-options-format
 is currently available in Org, but is ignored by the export.
 This patch enables use of org-export-latex-hyperref-options-format.

There is no such variable in Org. It probably comes from the old export
engine.


Regards,

-- 
Nicolas Goaziou



Re: [O] proposed patch for org-export-latex-hyperref-options-format

2013-09-30 Thread Andrea Rossetti

Hello,

  apologies for my mistake. Nicolas you were right,
org-export-latex-hyperref-options-format was present
only in the old exporter, in a file named org-latex.el.

  I'd like to suggest a customizable hypersetup string
as a future, non-urgent enhancement of ox-latex.el; the
defcustom at line 324 of this old file:

http://repo.or.cz/w/emacs.git/blob/HEAD:/lisp/org/org-latex.el

could fit reasonably well for variable name, default value,
type and docstring. 

  Thanks for your attention, kindest regards.

Andrea
http://github.com/thesoftwarebin



Nicolas Goaziou n.goaz...@gmail.com writes:

 Hello,


 Andrea Rossetti andrea.rosse...@gmail.com writes:

   may I please ask if this tiny patch looks reasonable and can
 be committed by the mantainers.

   Customizable option org-export-latex-hyperref-options-format
 is currently available in Org, but is ignored by the export.
 This patch enables use of org-export-latex-hyperref-options-format.

 There is no such variable in Org. It probably comes from the old export
 engine.


 Regards,



[O] proposed patch for org-export-latex-hyperref-options-format

2013-09-29 Thread Andrea Rossetti

Hello everyone, 

  may I please ask if this tiny patch looks reasonable and can
be committed by the mantainers.

  Customizable option org-export-latex-hyperref-options-format
is currently available in Org, but is ignored by the export.
This patch enables use of org-export-latex-hyperref-options-format.

  A simple test case (to see the effect before/after patching) is
reported in the How to reproduce section at the bottom of this
mail.

Kindest regards,

Andrea
https://github.com/thesoftwarebin

---8--patch file start--8
diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
index 196e50f..91dbeff 100644
--- a/lisp/ox-latex.el
+++ b/lisp/ox-latex.el
@@ -1120,7 +1120,7 @@ holding export options.
  (format \\title{%s}\n title)
  ;; Hyperref options.
  (when (plist-get info :latex-hyperref-p)
-   (format \\hypersetup{\n  pdfkeywords={%s},\n  pdfsubject={%s},\n  
pdfcreator={%s}}\n
+   (format org-export-latex-hyperref-options-format
   (or (plist-get info :keywords) )
   (or (plist-get info :description) )
   (if (not (plist-get info :with-creator)) 
---8--patch file end8

 From: andrea.rosse...@gmail.com
 Subject: Bug: Customization of Org Export Latex Hyperref Options Format 
 ignored
 To: emacs-orgmode@gnu.org
 Date: Sat, 21 Sep 2013 18:58:12 +0200 (1 week, 1 day, 6 hours ago)

 Hello everyone,

   option Org Export Latex Hyperref Options Format
 (aka org-export-latex-hyperref-options-format)
 seems to have no effect on my latex exports, i.e.
 the latex pramble always contains this same text:

 ===
 \hypersetup{
   pdfkeywords={},
   pdfsubject={},
   pdfcreator={Emacs 24.3.1 (Org mode 8.2)}}
 ===

   May I please ask if this is reproducible on
 your installation as well, or if it's just me.

 Thanks in advance, kindest regards.

   Andrea
   https://github.com/thesoftwarebin

 =
 How to reproduce:

 1) check that option Org Latex With Hyperref
 is enabled

 2) create a simple example.org file:
 * hello
 ** blah
 ** bleah
 * end

 3) export to latex buffer (C-c C-e l L),
 look at the \hypersetup{...} lines

 4) close the *Org LATEX Export* buffer
 with C-x k

 5) add text blah somewhere in the value of
 option Org Export Latex Hyperref Options Format

 6) export again to latex buffer (C-c C-e l L)

 7) \hypersetup{...} lines should have changed
 accordingly to changes made in step 3), but 
 they don't change for me
 =