Re: [O] typo in org-track.el manual
binZMEXuhGks6.bin Description: application/pgp-encrypted binoD3igvt0Pw.bin Description: Binary data
[O] typo in org-track.el manual
binV_LTZlQ4nF.bin Description: application/pgp-encrypted bin8UiPPrykhr.bin Description: Binary data
Re: [O] typo, sp at C++ Source Code Blocks in Org Mode
> my guess is that it would be a lot of work to mark up the Worg sources to get > well-formatted info output. The orgmode manual is going to be an org-file which I guess will output to info:org.
Re: [O] typo, sp at C++ Source Code Blocks in Org Mode
Aloha Van L, On Sat, Nov 10, 2018 at 12:17 AM, Van L wrote: AFAIK there is no mechanism to have changes in one propagate changes in the other. It should be possible to link the two because both are org files. Worg would need to render to info:worg. That's an interesting idea. AFAICT it should be possible. Nevertheless, my guess is that it would be a lot of work to mark up the Worg sources to get well-formatted info output. All the best, Tom
Re: [O] typo, sp at C++ Source Code Blocks in Org Mode
> AFAIK there is no mechanism to have changes in one propagate changes in the > other. It should be possible to link the two because both are org files. Worg would need to render to info:worg.
Re: [O] typo, sp at C++ Source Code Blocks in Org Mode
Aloha Van L, Thanks for your contribution. The Org mode manual and Worg are separate documents. AFAIK there is no mechanism to have changes in one propagate changes in the other. If you'd like to propose a change to the manual, please submit a patch following the instructions here: https://orgmode.org/worg/org-contribute.html. All the best, Tom
Re: [O] typo, sp at C++ Source Code Blocks in Org Mode
> Thanks for your interest in Org mode and Worg. I hope the worg entry will backprob to the info:org page.
Re: [O] typo, sp at C++ Source Code Blocks in Org Mode
Aloha Van L, Worg is maintained by the community. You can find information on how to make these changes yourself: https://orgmode.org/worg/worg-git.html Thanks for your interest in Org mode and Worg. All the best, Tom
[O] typo, sp at C++ Source Code Blocks in Org Mode
Hello, At the following page: https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-C.html // CC+ should be C++ :main can be set to "no" to inhibit wrapping of the code block in a main function call. :includes (C & CC+ only) accepts either a single string name, or a list of names of files to #include in the execution of the code block. // Spelling should be ‘explicitly' C++ needs to explicitely include either stdio.h or
Re: [O] Typo on org-tag-alist
Nicolas Goaziouwrites: > Bernt Hansen writes: > >> Nope. I think you found another one (org-tag-persistent-alist) and >> fixed that instead. org-tag-alist is the one I reported. >> >> $ git grep -n engroup >> lisp/org.el:3424:`:startgrouptag', `:grouptags', `:engroup', >> `:endgrouptag' or >> >> Thanks for finding the other one :) > > Ah. Fixed too. Thank you. Confirmed. Thanks! Bernt
Re: [O] Typo on org-tag-alist
Bernt Hansenwrites: > Nope. I think you found another one (org-tag-persistent-alist) and > fixed that instead. org-tag-alist is the one I reported. > > $ git grep -n engroup > lisp/org.el:3424:`:startgrouptag', `:grouptags', `:engroup', > `:endgrouptag' or > > Thanks for finding the other one :) Ah. Fixed too. Thank you.
Re: [O] Typo on org-tag-alist
Nicolas Goaziouwrites: > Hello, > > Bernt Hansen writes: > >> I think there is a typo in the output of >> >> C-h v org-tag-alist RET >> >> ':engroup' instead of ':endgroup' > > Fixed. Thank you. Nope. I think you found another one (org-tag-persistent-alist) and fixed that instead. org-tag-alist is the one I reported. $ git grep -n engroup lisp/org.el:3424:`:startgrouptag', `:grouptags', `:engroup', `:endgrouptag' or Thanks for finding the other one :) Regards, Bernt
Re: [O] Typo on org-tag-alist
Hello, Bernt Hansenwrites: > I think there is a typo in the output of > > C-h v org-tag-alist RET > > ':engroup' instead of ':endgroup' Fixed. Thank you. Regards, -- Nicolas Goaziou
[O] Typo on org-tag-alist
Hi, I think there is a typo in the output of C-h v org-tag-alist RET ':engroup' instead of ':endgroup' Regards, Bernt org-tag-alist is a variable defined in .org.el.. Its value is shown below. Documentation: Default tags available in Org files. The value of this variable is an alist. Associations either: (TAG) (TAG . SELECT) (SPECIAL) where TAG is a tag as a string, SELECT is character, used to select that tag through the fast tag selection interface, and SPECIAL is one of the following keywords: .:startgroup., .:startgrouptag., .:grouptags., .:engroup., .:endgrouptag. or ^ .:newline.. These keywords are used to define a hierarchy of tags. See manual for details.
Re: [O] Typo org-switchb org-iswitchb
"Th. Rikl"writes: > Newest ... The manual and the guide talk about "org-iswitchb", the > code contains only "org-switchb". Fix, thanks! -- Bastien
Re: [O] Typo in the compact Org Mode Guide
Hello, sira...@disroot.org writes: > I have encountered a typo. It's on page 10 of the PDF of the latest > release (9.1.7). The sentence in question is: > >> Org mode providing methods to give you an overview of all the things that >> you have to do, collected >> from many files. > > The corrected version should appear as follows: > >> Org mode *provides* methods to give... > > Please let me know if it's an legitimate grammatical error. Fixed. Thank you. Regards, -- Nicolas Goaziou
[O] Typo org-switchb org-iswitchb
Newest ... The manual and the guide talk about "org-iswitchb", the code contains only "org-switchb". Thanks
[O] Typo in the compact Org Mode Guide
Hello, I'm not completely sure if this mailing list is the appropriate place to put it, but it was the e-mail address listed under section 1.4 (Feedback) of the compact Org mode Guide. I have encountered a typo. It's on page 10 of the PDF of the latest release (9.1.7). The sentence in question is: > Org mode providing methods to give you an overview of all the things that you > have to do, collected > from many files. The corrected version should appear as follows: > Org mode *provides* methods to give... Please let me know if it's an legitimate grammatical error. Ben Siraphob
Re: [O] Typo in README
Hello, Jonas Bernoulliwrites: > There is a typo in the first word of the README. > I was surprised to learn that it existed for five years. Fixed. Thank you. Regards, -- Nicolas Goaziou
[O] Typo in README
There is a typo in the first word of the README. I was surprised to learn that it existed for five years. Cheers, Jonas
Re: [O] Typo in manual
Daniel E. Doherty ded-...@ddoherty.net writes: Carsten et al., I just noticed in footnote 2 of section 2.2 of the org manual, the following typo: , | (2) Clocking only works with headings indented less then 30 stars. ` The 'less then' should be 'less than'. Thank you. Fixed in master. -- Nick
[O] Typo in manual
Carsten et al., I just noticed in footnote 2 of section 2.2 of the org manual, the following typo: , | (2) Clocking only works with headings indented less then 30 stars. ` The 'less then' should be 'less than'. Regards, -- Daniel E. Doherty ded-...@ddoherty.net
[O] Typo in org guide
Hi all, the org guide Release 8.2.7c says in page 32, 12.1 Export options: The whole set of lines can be inserted into the buffer with C-c C-e t. It should say: The whole set of lines can be inserted into the buffer with C-c C-e #. Regards
Re: [O] Typo in org guide
Hello, Alexis Roda alexis.roda.villalo...@gmail.com writes: the org guide Release 8.2.7c says in page 32, 12.1 Export options: The whole set of lines can be inserted into the buffer with C-c C-e t. It should say: The whole set of lines can be inserted into the buffer with C-c C-e #. Fixed. Thank you. Regards, -- Nicolas Goaziou
Re: [O] typo Catching-invisible-edits
Hi Cyprien, Cyprien Gay cyprien@aful.org writes: Here is a typo I encountered. Fixed, thanks! -- Bastien
[O] typo Catching-invisible-edits
Hi! Here is a typo I encountered. Thanks for your wonderful work! Cyprien. http://orgmode.org/manual/Catching-invisible-edits.html and be confused on what as been edited = has -- Cyprien Gay http://aful.org/ http://non.aux.racketiciels.info/ http://bons-constructeurs-ordinateurs.info/
[O] Typo in manual
A trivial typo in the manual. Not sure where else to report this. 12.13 Advanced configuration Three arguments must be provided to a fiter: the code being changed, Guess it should be filter. Kind regards Bart
Re: [O] Typo in manual
Bart Bunting b...@bunting.net.au writes: A trivial typo in the manual. Not sure where else to report this. 12.13 Advanced configuration Three arguments must be provided to a fiter: the code being changed, Guess it should be filter. Fixed, thanks! -- Bastien
[O] Typo in doc string of org-small-year-to-year
The doc string of org-small-year-to-year says: , | Convert 2-digit years into 4-digit years. | 38-99 are mapped into 1938-1999. 1-37 are mapped into 2001-2007. ` That 2007 should be 2037. -- Nick
Re: [O] Typo in doc string of org-small-year-to-year
Fixed, thanks. - Carsten On 16.4.2013, at 05:01, Nick Dokos ndo...@gmail.com wrote: The doc string of org-small-year-to-year says: , | Convert 2-digit years into 4-digit years. | 38-99 are mapped into 1938-1999. 1-37 are mapped into 2001-2007. ` That 2007 should be 2037. -- Nick
[O] Typo in info documentation for =org-agenda-to-appt= [7.9.3e (7.9.3e-elpa @ /Users/sean/.emacs.d/elpa/org-20130204/)]
Pardon the copypasta, I've yet to muddle my way through configuring Gmail and Gnus. The 'bug' is just a documentation typo. From: Sean Allred s...@dhcp-892bd3ca.ucd.ie To: emacs-orgmode@gnu.org Subject: Bug: Typo in info documentation for =org-agenda-to-appt= [7.9.3e (7.9.3e-elpa @ /Users/sean/.emacs.d/elpa/org-20130204/)] Date: Wed, 20 Feb 2013 12:26:01 + Message-ID: m1bobfmasm@dhcp-892bd3ca.ucd.ie --text follows this line-- Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See http://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org-mode mailing list. Use =grep -lr If an entry as a APPT_WARNTIME *= on the directory in which org-mode is installed. These strings should read If an entry /has/ a APPT_WARNTIME, etc. Emacs : GNU Emacs 24.2.1 (x86_64-apple-darwin, NS apple-appkit-1038.36) of 2012-08-27 on bob.porkrind.org Package: Org-mode version 7.9.3e (7.9.3e-elpa @ /Users/sean/.emacs.d/elpa/org-20130204/) current state: == (setq org-export-preprocess-final-hook '((lambda nil (replace-string --\n -- \n)) ) org-export-preprocess-before-selecting-backend-code-hook '(org-beamer-select-beamer-code) org-tab-first-hook '(org-hide-block-toggle-maybe org-src-native-tab-command-maybe org-babel-hide-result-toggle-maybe org-babel-header-arg-expand) org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook) org-occur-hook '(org-first-headline-recenter) org-metaup-hook '(org-babel-load-in-session-maybe) org-export-preprocess-before-normalizing-links-hook '(org-remove-file-link-modifiers) org-log-done 'note org-confirm-shell-link-function 'yes-or-no-p org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc org-beamer-auto-fragile-frames org-beamer-place-default-actions-for-lists) org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars) org-default-notes-file ~/Dropbox/org/notes.org org-after-todo-state-change-hook '(org-clock-out-if-current) org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer) org-agenda-before-write-hook '(org-agenda-add-entry-text) org-babel-pre-tangle-hook '(save-buffer) org-mode-hook '(#[nil \300\301\302\303\304$\207 [org-add-hook change-major-mode-hook org-show-block-all append local] 5] #[nil \300\301\302\303\304$\207 [org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec org-babel-hide-all-hashes) org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe) org-directory ~/Dropbox/org org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines org-optimize-window-after-visibility-change) org-export-latex-format-toc-function 'org-export-latex-format-toc-default org-export-blocks '((src org-babel-exp-src-block nil) (export-comment org-export-blocks-format-comment t) (ditaa org-export-blocks-format-ditaa nil) (dot org-export-blocks-format-dot nil)) org-export-first-hook '(org-beamer-initialize-open-trackers) org-export-interblocks '((src org-babel-exp-non-block-elements)) org-modules '(org-bbdb org-bibtex org-docview org-gnus org-info org-jsinfo org-habit org-irc org-mew org-mhe org-rmail org-vm org-wl org-w3m) org-confirm-elisp-link-function 'yes-or-no-p org-metadown-hook '(org-babel-pop-to-session-maybe) org-agenda-files /Users/sean/Dropbox/.emacs.d/org-agenda-files.list org-clock-out-hook '(org-clock-remove-empty-clock-drawer) ) -- Sean Allred
Re: [O] Typo in info documentation for =org-agenda-to-appt= [7.9.3e (7.9.3e-elpa @ /Users/sean/.emacs.d/elpa/org-20130204/)]
Hi Sean, Allred, Sean seall...@smcm.edu writes: Pardon the copypasta, I've yet to muddle my way through configuring Gmail and Gnus. The 'bug' is just a documentation typo. Fixed, thanks. -- Bastien
Re: [O] typo in support for sidewaystable in the new latex exporter
Hi Andres, Andreas Leha andreas.l...@med.uni-goettingen.de writes: attached is a tiny patch for the new latex exporter that fixes a small typo. Applied, thanks. -- Bastien
[O] typo in support for sidewaystable in the new latex exporter
Hi all, attached is a tiny patch for the new latex exporter that fixes a small typo. Regards, Andreas From 0733a2a6882338a2fc507304069fa2ed12fdbf05 Mon Sep 17 00:00:00 2001 From: Andreas Leha andr...@lehas.net Date: Tue, 11 Sep 2012 09:33:45 +0200 Subject: [PATCH] fix typo in support of sidewaystables in the new latex exporter * contrib/lisp/org-e-latex.el (org-e-latex-table--org-table): Typo. sidewaystables - sidewaystable. --- contrib/lisp/org-e-latex.el |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/lisp/org-e-latex.el b/contrib/lisp/org-e-latex.el index 17bdad9..8b7c292 100644 --- a/contrib/lisp/org-e-latex.el +++ b/contrib/lisp/org-e-latex.el @@ -2315,7 +2315,7 @@ This function assumes TABLE has `org' as its `:type' attribute. (float-env (cond ((string= longtable table-env) nil) ((and attr (string-match \\sidewaystable\\ attr)) - sidewaystables) + sidewaystable) ((and attr (or (string-match (regexp-quote table*) attr) (string-match \\multicolumn\\ attr))) -- 1.7.10.4
[O] Typo in orgmode.org/worg/org-faq about inline tasks
To insert an inline task the keys _are_: C-c C-x t But the FAQ, Can I add a TODO to a list item? says, the keys were C-c C-x C-t The last key isn't C-t, but only t. The documentation in Emacs has it the right way. Regards, Alexander
Re: [O] Typo in orgmode.org/worg/org-faq about inline tasks
AW alexander.will...@t-online.de writes: To insert an inline task the keys _are_: C-c C-x t But the FAQ, Can I add a TODO to a list item? says, the keys were C-c C-x C-t The last key isn't C-t, but only t. The documentation in Emacs has it the right way. Fixed, thanks. -- Bastien
[O] Typo in worg page about org-checkbox
Last line in section Quick Example in [1] misses a _ in the property. It reads RESET_CHECKBOXES but org-checklist.el checks for RESET_CHECK_BOXES. Just spent a few minutes tracking down why org-checklist wasn't working for me. [1]: http://orgmode.org/worg/org-contrib/org-checklist.html -- Moritz Ulrich
Re: [O] Typo in worg page about org-checkbox
Moritz Ulrich ulrich.mor...@googlemail.com writes: Last line in section Quick Example in [1] misses a _ in the property. It reads RESET_CHECKBOXES but org-checklist.el checks for RESET_CHECK_BOXES. Fixed, thanks for reporting this. Just spent a few minutes tracking down why org-checklist wasn't working for me. Sorry for this! -- Bastien
[O] typo in org.texi
Hi. Bastien, Japanese translation team of the manual found a small typo in org.texi. Please check the attached patch. Best regards, Takaaki Ishikawa @@ -15246,7 +15246,7 @@ not accept any arguments, and return the full link with prefix. @vindex org-ctrl-c-ctrl-c-hook Org has several commands that act differently depending on context. The most -important example it the @kbd{C-c C-c} (@pxref{The very busy C-c C-c key}). +important example is the @kbd{C-c C-c} (@pxref{The very busy C-c C-c key}). Also the @kbd{M-cursor} and @kbd{M-S-cursor} keys have this property. Add-ons can tap into this functionality by providing a function that detects
Re: [O] typo in org.texi
Hi Takaaki, Takaaki ISHIKAWA tak...@ieee.org writes: Japanese translation team of the manual found a small typo in org.texi. Please check the attached patch. Fixed, thanks. And hello to the team! Best, -- Bastien
Re: [O] typo in doc/orgguide.texi
Hi Guido, Guido Arnold watsoll...@googlemail.com writes: Hello, please forgive me for not filing a proper bug report, I am not even a org-mode user yet, but I am very interested. I just had a look at the quick guide and found a typo in line 1908: http://orgmode.org/w/?p=org-mode.git;a=blob;f=doc/orgguide.texi;h= 0e6295a121a6ac0b2eb8738c1156f2672c24548d;hb=minted s/will also works/will also work/ ^ I hope someone with write privileges on this list can fix this. Fixed, thanks! http://orgmode.org/w/?p=org-mode.git;a=commit;h=8a7799473c90e71bff460c63a71e7551dfa4e4e2 -- Bastien
[O] typo in doc/orgguide.texi
Hello, please forgive me for not filing a proper bug report, I am not even a org-mode user yet, but I am very interested. I just had a look at the quick guide and found a typo in line 1908: http://orgmode.org/w/?p=org-mode.git;a=blob;f=doc/orgguide.texi;h=0e6295a121a6ac0b2eb8738c1156f2672c24548d;hb=minted s/will also works/will also work/ ^ I hope someone with write privileges on this list can fix this. Greetings, Guido
[O] Typo on French web page
Hi! A tiny typo on page http://orgmode.org/fr/org-mode-support.html: 3 deniers commits git should read 3 derniers commits git François.
Re: [O] Typo on French web page
pin...@iro.umontreal.ca (François Pinard) writes: A tiny typo on page http://orgmode.org/fr/org-mode-support.html: 3 deniers commits git should read 3 derniers commits git Fixed, thanks. -- Bastien
Re: [O] Typo in 'org-without-partial-completion'
Hi Nick, David, David Maus dm...@ictsoc.de writes: Yes and yes. (and (boundp 'partial-completion-mode) partial-completion-mode (fboundp 'partial-completion-mode)) Is the right condition. Bound, non-nil and callable. @Bastien: Pushed fix for this to master. Thanks! -- Bastien
Re: [O] Typo in 'org-without-partial-completion'
At Thu, 30 Jun 2011 21:28:08 +0200, David Maus wrote: At Thu, 30 Jun 2011 11:12:15 +0200, Bastien wrote: Hi Paul, Paul Sexton psex...@xnet.co.nz writes: I think there's an error in 'org-without-partial-completion' in org-macs.el. The variable pc-mode gets bound to the value of partial-completion-mode - but this is a VARIABLE (t if that mode is enabled). Funcalling the value of the variable produces an error, unsurprisingly. This breaks insertion of properties with 'org-set-property'. Fixing it involves quoting the the symbol as shown below: (defmacro org-without-partial-completion (rest body) `(let ((pc-mode (and (boundp 'partial-completion-mode) 'partial-completion-mode))) ; -- quote added (unwind-protect (progn (when pc-mode (funcall pc-mode -1)) ,@body) (when pc-mode (funcall pc-mode 1) I've just reverted this modification, per Sebastian report. Can you be more precise about the problem it creates with org-set-property? Can you check if this version fixes the problems, if any? #+begin_src emacs-lisp (defmacro org-without-partial-completion (rest body) `(let ((pc-mode ,(and (boundp 'partial-completion-mode) 'partial-completion-mode))) (unwind-protect (progn (when pc-mode (funcall pc-mode -1)) ,@body) (when pc-mode (funcall pc-mode 1) #+end_src emacs-lisp No, I think this won't work. On compile time the byte compiler will expand the macro and place the expansion in the byte compiled lisp. Thus it will evaluate the ,(and ...) condition at compile time. http://www.gnu.org/software/emacs/elisp/html_node/Compiling-Macros.html#Compiling-Macros #+begin_quote When a macro call appears in a Lisp program being compiled, the Lisp compiler calls the macro definition just as the interpreter would, and receives an expansion. But instead of evaluating this expansion, it compiles the expansion as if it had appeared directly in the program. As a result, the compiled code produces the value and side effects intended for the macro, but executes at full compiled speed. This would not work if the macro body computed the value and side effects itself—they would be computed at compile time, which is not useful. #+end_quote What about this: #+begin_src emacs-lisp (defmacro org-without-partial-completion (rest body) `(let ((pc-mode-p (and (boundp 'partial-completion-mode) (fboundp 'partial-completion-mode (when pc-mode-p (unwind-protect (progn (partial-completion-mode -1) ,@body) (partial-completion-mode 1) #+end_src This will turn off partial-completion-mode if the symbol is non-nil and callable. Or even better: #+begin_src emacs-lisp (defmacro org-without-partial-completion (rest body) `(when (and (boundp 'partial-completion-mode) (fboundp 'partial-completion-mode)) (unwind-protect (progn (partial-completion-mode -1) ,@body) (partial-completion-mode 1 #+end_src This avoids leaking if 'body happens to uses a symbol 'pc-mode-p in a different context. Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber dmj...@jabber.org Email. dm...@ictsoc.de pgpgpK7S42BCW.pgp Description: PGP signature
Re: [O] Typo in 'org-without-partial-completion'
Hi David and Paul, David Maus dm...@ictsoc.de writes: #+begin_src emacs-lisp (defmacro org-without-partial-completion (rest body) `(when (and (boundp 'partial-completion-mode) (fboundp 'partial-completion-mode)) (unwind-protect (progn (partial-completion-mode -1) ,@body) (partial-completion-mode 1 #+end_src That's clearly better -- thanks for this. I applied this change, thanks for this improvement! Paul, please let me know if things don't behave as expected. -- Bastien
Re: [O] Typo in 'org-without-partial-completion'
At Sat, 02 Jul 2011 11:26:59 +0200, Bastien wrote: Hi David and Paul, David Maus dm...@ictsoc.de writes: #+begin_src emacs-lisp (defmacro org-without-partial-completion (rest body) `(when (and (boundp 'partial-completion-mode) (fboundp 'partial-completion-mode)) (unwind-protect (progn (partial-completion-mode -1) ,@body) (partial-completion-mode 1 #+end_src That's clearly better -- thanks for this. I applied this change, thanks for this improvement! Paul, please let me know if things don't behave as expected. da086f9606d1875b5270dd367d7f5326b7ed8e9a ;) david (sloppy-mode -1) -- OpenPGP... 0x99ADB83B5A4478E6 Jabber dmj...@jabber.org Email. dm...@ictsoc.de pgp7ujEyaQWqH.pgp Description: PGP signature
Re: [O] Typo in 'org-without-partial-completion'
David Maus dm...@ictsoc.de wrote: #+begin_src emacs-lisp (defmacro org-without-partial-completion (rest body) `(when (and (boundp 'partial-completion-mode) (fboundp 'partial-completion-mode)) (unwind-protect (progn (partial-completion-mode -1) ,@body) (partial-completion-mode 1 #+end_src This avoids leaking if 'body happens to uses a symbol 'pc-mode-p in a different context. Won't this turn on the mode even if it was off before the macro ws called? And if so, isn't that a problem? Nick
Re: [O] Typo in 'org-without-partial-completion'
At Sat, 02 Jul 2011 10:40:31 -0400, Nick Dokos wrote: David Maus dm...@ictsoc.de wrote: #+begin_src emacs-lisp (defmacro org-without-partial-completion (rest body) `(when (and (boundp 'partial-completion-mode) (fboundp 'partial-completion-mode)) (unwind-protect (progn (partial-completion-mode -1) ,@body) (partial-completion-mode 1 #+end_src This avoids leaking if 'body happens to uses a symbol 'pc-mode-p in a different context. Won't this turn on the mode even if it was off before the macro ws called? And if so, isn't that a problem? Yes and yes. (and (boundp 'partial-completion-mode) partial-completion-mode (fboundp 'partial-completion-mode)) Is the right condition. Bound, non-nil and callable. @Bastien: Pushed fix for this to master. Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber dmj...@jabber.org Email. dm...@ictsoc.de pgp86YD9MvVKA.pgp Description: PGP signature
Re: [O] Typo in 'org-without-partial-completion'
Hi Paul, Paul Sexton psex...@xnet.co.nz writes: I think there's an error in 'org-without-partial-completion' in org-macs.el. The variable pc-mode gets bound to the value of partial-completion-mode - but this is a VARIABLE (t if that mode is enabled). Funcalling the value of the variable produces an error, unsurprisingly. This breaks insertion of properties with 'org-set-property'. Fixing it involves quoting the the symbol as shown below: (defmacro org-without-partial-completion (rest body) `(let ((pc-mode (and (boundp 'partial-completion-mode) 'partial-completion-mode))) ; -- quote added (unwind-protect (progn (when pc-mode (funcall pc-mode -1)) ,@body) (when pc-mode (funcall pc-mode 1) I've just reverted this modification, per Sebastian report. Can you be more precise about the problem it creates with org-set-property? Can you check if this version fixes the problems, if any? #+begin_src emacs-lisp (defmacro org-without-partial-completion (rest body) `(let ((pc-mode ,(and (boundp 'partial-completion-mode) 'partial-completion-mode))) (unwind-protect (progn (when pc-mode (funcall pc-mode -1)) ,@body) (when pc-mode (funcall pc-mode 1) #+end_src emacs-lisp Thanks! -- Bastien
Re: [O] Typo in 'org-without-partial-completion'
At Thu, 30 Jun 2011 11:12:15 +0200, Bastien wrote: Hi Paul, Paul Sexton psex...@xnet.co.nz writes: I think there's an error in 'org-without-partial-completion' in org-macs.el. The variable pc-mode gets bound to the value of partial-completion-mode - but this is a VARIABLE (t if that mode is enabled). Funcalling the value of the variable produces an error, unsurprisingly. This breaks insertion of properties with 'org-set-property'. Fixing it involves quoting the the symbol as shown below: (defmacro org-without-partial-completion (rest body) `(let ((pc-mode (and (boundp 'partial-completion-mode) 'partial-completion-mode))) ; -- quote added (unwind-protect (progn (when pc-mode (funcall pc-mode -1)) ,@body) (when pc-mode (funcall pc-mode 1) I've just reverted this modification, per Sebastian report. Can you be more precise about the problem it creates with org-set-property? Can you check if this version fixes the problems, if any? #+begin_src emacs-lisp (defmacro org-without-partial-completion (rest body) `(let ((pc-mode ,(and (boundp 'partial-completion-mode) 'partial-completion-mode))) (unwind-protect (progn (when pc-mode (funcall pc-mode -1)) ,@body) (when pc-mode (funcall pc-mode 1) #+end_src emacs-lisp No, I think this won't work. On compile time the byte compiler will expand the macro and place the expansion in the byte compiled lisp. Thus it will evaluate the ,(and ...) condition at compile time. http://www.gnu.org/software/emacs/elisp/html_node/Compiling-Macros.html#Compiling-Macros #+begin_quote When a macro call appears in a Lisp program being compiled, the Lisp compiler calls the macro definition just as the interpreter would, and receives an expansion. But instead of evaluating this expansion, it compiles the expansion as if it had appeared directly in the program. As a result, the compiled code produces the value and side effects intended for the macro, but executes at full compiled speed. This would not work if the macro body computed the value and side effects itself—they would be computed at compile time, which is not useful. #+end_quote What about this: #+begin_src emacs-lisp (defmacro org-without-partial-completion (rest body) `(let ((pc-mode-p (and (boundp 'partial-completion-mode) (fboundp 'partial-completion-mode (when pc-mode-p (unwind-protect (progn (partial-completion-mode -1) ,@body) (partial-completion-mode 1) #+end_src This will turn off partial-completion-mode if the symbol is non-nil and callable. For Sebastien's problem: Strange thing. Looks like the symbol partial-completion-mode is non-nil but not callable. Maybe an Emacs 24 development version issue? Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber dmj...@jabber.org Email. dm...@ictsoc.de pgpSgkbBOKcQh.pgp Description: PGP signature
Re: [O] Typo in 'org-without-partial-completion'
Hi Paul, Paul Sexton psex...@xnet.co.nz writes: I think there's an error in 'org-without-partial-completion' in org-macs.el. The variable pc-mode gets bound to the value of partial-completion-mode - but this is a VARIABLE (t if that mode is enabled). Funcalling the value of the variable produces an error, unsurprisingly. This breaks insertion of properties with 'org-set-property'. Fixing it involves quoting the the symbol as shown below: (defmacro org-without-partial-completion (rest body) `(let ((pc-mode (and (boundp 'partial-completion-mode) 'partial-completion-mode))) ; -- quote added (unwind-protect (progn (when pc-mode (funcall pc-mode -1)) ,@body) (when pc-mode (funcall pc-mode 1) You're right -- thanks for spotting this, and for the clear analysis. I've committed a patch. -- Bastien
[O] Typo in 'org-without-partial-completion'
I think there's an error in 'org-without-partial-completion' in org-macs.el. The variable pc-mode gets bound to the value of partial-completion-mode - but this is a VARIABLE (t if that mode is enabled). Funcalling the value of the variable produces an error, unsurprisingly. This breaks insertion of properties with 'org-set-property'. Fixing it involves quoting the the symbol as shown below: (defmacro org-without-partial-completion (rest body) `(let ((pc-mode (and (boundp 'partial-completion-mode) 'partial-completion-mode))) ; -- quote added (unwind-protect (progn (when pc-mode (funcall pc-mode -1)) ,@body) (when pc-mode (funcall pc-mode 1)
Re: [O] typo
Cor Ninaber cornina...@gmail.com writes: This bug is a very silly little thing but there is missing a letter in the description of Org Mobile Index File in the settings. Namely inks should be links (see the copy below). Fixed. http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=c735d62f0 Thanks for reporting this.
[O] typo
Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See http://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org-mode mailing list. Hi First of I've got to say I love org-mode. The more I work with it the more I am amazed by the possibility, haven't encounter anything I miss. This bug is a very silly little thing but there is missing a letter in the description of Org Mobile Index File in the settings. Namely inks should be links (see the copy below). Sorry for not fixing it myself, but I don't (yet) know how to change it myself. Regards and keep up the great work, Cor Org Mobile Index File: Hide Value index.org State: STANDARD. The index file with inks to all Org files that should be loaded by MobileOrg. Hide Rest Relative to `org-mobile-directory'. The Address field in the MobileOrg setup should point to this file. Emacs : GNU Emacs 23.3.1 (i486-pc-linux-gnu, GTK+ Version 2.24.3) of 2011-04-10 on raven, modified by Debian Package: Org-mode version 7.5
Re: [O] typo in the info file
Hi Xiao-Yong, Xiao-Yong Jin xj2...@columbia.edu writes: Two lines in the file doc/org.texi doc/org.texi:8529:@vindex org-overriding-columns-format doc/org.texi:8533:Org first checks if the variable @code{org-overriding-columns-format} is mention the variable org-overriding-columns-format. I believe it should be org-agenda-overriding-columns-format, instead. That's right, I just fixed this. Thanks, -- Bastien
[O] typo in the info file
Hi, Two lines in the file doc/org.texi --8---cut here---start-8--- doc/org.texi:8529:@vindex org-overriding-columns-format doc/org.texi:8533:Org first checks if the variable @code{org-overriding-columns-format} is --8---cut here---end---8--- mention the variable org-overriding-columns-format. I believe it should be org-agenda-overriding-columns-format, instead. -- Jc/*__o/* X\ * (__ Y*/\
[O] typo in org.texi
diff --git a/doc/org.texi b/doc/org.texi index 50febbc..bc66319 100644 --- a/doc/org.texi +++ b/doc/org.texi @@ -2282,7 +2282,7 @@ operator that looks like this: @end example @noindent -and allows relative relative references, i.e. references relative to the +and allows relative references, i.e. references relative to the row/column of the field whose value is being computed. These relative references make it possible to store a formula only once and use it in many fields without copying and modifying it. Nick
[Accepted] [O] typo in org.texi
Patch 652 (http://patchwork.newartisans.com/patch/652/) is now Accepted. Maintainer comment: none This relates to the following submission: http://mid.gmane.org/%3C9447.1299285313%40alphaville.usa.hp.com%3E Here is the original message containing the patch: Content-Type: text/plain; charset=utf-8 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [O] typo in org.texi Date: Sat, 05 Mar 2011 05:35:13 - From: Nick Dokos nicholas.do...@hp.com X-Patchwork-Id: 652 Message-Id: 9447.1299285...@alphaville.usa.hp.com To: emacs-orgmode@gnu.org Cc: nicholas.do...@hp.com Nick diff --git a/doc/org.texi b/doc/org.texi index 50febbc..bc66319 100644 --- a/doc/org.texi +++ b/doc/org.texi @@ -2282,7 +2282,7 @@ operator that looks like this: @end example @noindent -and allows relative relative references, i.e. references relative to the +and allows relative references, i.e. references relative to the row/column of the field whose value is being computed. These relative references make it possible to store a formula only once and use it in many fields without copying and modifying it.