Re: [Orgmode] Git Store Link Broken?
Carsten & David, I'm dumbfounded at good you guys are. Thanks to both of you for this fix and all the work on org-mode. Regards, Dan Doherty Carsten Dominik wrote: Applied, thanks. - Carsten On Feb 20, 2010, at 7:48 PM, David Maus wrote: Hi Daniel, Daniel E. Doherty wrote: Hello all, I noticed when I upgraded org from 6.21 (which comes with Emacs) to the git version (6.34trans), org-store-link stopped working. When I try to store a link from dired, I get a stringp nil error, with this debugger output: It's a small glitch in `org-git-store-link': Orgmode calls all registered store-link functions to see if one declares itself of being responsible for the particular file or buffer. `org-git-store-link' tries to make an assumption on whether the file that is currently visited is inside a git repository w/o taking into consideration that there are buffers that are not associated with a file -- like a dired buffer. Attached patch fixes this. HTH -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber dmj...@jabber.org Email. maus.da...@gmail.com <0001-Avoid-trying-to-run-org-git-store-link-on-buffers-th.patch>___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Git Store Link Broken?
Applied, thanks. - Carsten On Feb 20, 2010, at 7:48 PM, David Maus wrote: Hi Daniel, Daniel E. Doherty wrote: Hello all, I noticed when I upgraded org from 6.21 (which comes with Emacs) to the git version (6.34trans), org-store-link stopped working. When I try to store a link from dired, I get a stringp nil error, with this debugger output: It's a small glitch in `org-git-store-link': Orgmode calls all registered store-link functions to see if one declares itself of being responsible for the particular file or buffer. `org-git-store-link' tries to make an assumption on whether the file that is currently visited is inside a git repository w/o taking into consideration that there are buffers that are not associated with a file -- like a dired buffer. Attached patch fixes this. HTH -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber dmj...@jabber.org Email. maus.da...@gmail.com <0001-Avoid-trying-to-run-org-git-store-link-on-buffers- th.patch>___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Git Store Link Broken?
Hi Daniel, Daniel E. Doherty wrote: >Hello all, >I noticed when I upgraded org from 6.21 (which comes with Emacs) to the >git version (6.34trans), org-store-link stopped working. When I try to >store a link from dired, I get a stringp nil error, with this debugger >output: It's a small glitch in `org-git-store-link': Orgmode calls all registered store-link functions to see if one declares itself of being responsible for the particular file or buffer. `org-git-store-link' tries to make an assumption on whether the file that is currently visited is inside a git repository w/o taking into consideration that there are buffers that are not associated with a file -- like a dired buffer. Attached patch fixes this. HTH -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber dmj...@jabber.org Email. maus.da...@gmail.com 0001-Avoid-trying-to-run-org-git-store-link-on-buffers-th.patch Description: Binary data pgpu4PFbRsAMK.pgp Description: PGP signature ___ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Git Store Link Broken?
Hello all,
I noticed when I upgraded org from 6.21 (which comes with Emacs) to the
git version (6.34trans), org-store-link stopped working. When I try to
store a link from dired, I get a stringp nil error, with this debugger
output:
##
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
string-match("^/tmp_mnt/" nil)
abbreviate-file-name(nil)
org-git-store-link()
run-hook-with-args-until-success(org-git-store-link)
org-store-link(nil)
call-interactively(org-store-link nil nil)
##
It looks like something is going wrong when it enters
org-git-store-link, even though it is not a git link that I'm storing.
From what I can tell from the lisp code (I'm no lisper), it looks like
it cycles trhough all the link types until one succeeds. Mine always
chokes on the org-git-store-link.
Is anyone else having this problem, or do I perhaps have something
configured badly?
By the way, Org-mode is fantastic.
--
Daniel E. Doherty
7300 W. 110th Street, Suite 930
Overland Park, KS 66210
913.338.7182 (Phone)
913,338.7164 (FAX)
Up the airy mountain,
Down the rushy glen,
We daren't go a-hunting,
For fear of little men.
--- William Allingham (Donegal, Ireland)
___
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
