Re: [Orgmode] Problem with org-mac-message.el
On 4 Apr 2009, at 11:33, Carsten Dominik wrote: Hi Christopher, I have applied the patch, thanks. Also I made the following modification: The new function is defined as org-mac-message-insert-selected, and then the old name org-mac-message-insert-link is introduced as an alias. So you get your consisten function naming, and compatibility as well. I believe the file commentary may not be fully correct anymore, it still mentions the old function names. I have already pushed the new version, if you fix the commentary, please diff against that new version. Thanks, Carsten. Here's the fixed commentary. Changes to Worg have been pushed. Christopher org-mac-message.patch Description: Binary data ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Problem with org-mac-message.el
On 3 Apr 2009, at 17:58, Carsten Dominik wrote: On Apr 3, 2009, at 4:49 PM, Christopher Suckling wrote: On 1 Apr 2009, at 21:21, Ed Hirgelt wrote: I've found that org-mac-message-get-link has a problem inserting [[]] as the first item. I can't replicate this. Could you provide an example? The following change makes it better... Unfortunately, this change breaks the code for all other possibilities, and, if I understand the problem correctly, simply omits a link that begins [[ My beginner's elisp is rather clumsy; I'm going to attempt to tidy up the code anyway, so I'll be on the lookout for your difficulty whilst I do so. I think I already fixed it. Thanks! I've never used mapcar before... I've made things more modular so that your changes are reflected in searches for both selected and flagged mail. In doing so, I may have been rather naughty - I've changed the function names so that they are consistent: (org-mac-message-insert-link) becomes (org-mac-message-insert-selected) (org-mac-create-flagged-mail) becomes (org-mac-message-insert-flagged) both of which call the function (org-mac-message-get-links) to do their stuff. If this is not on, then I'll resubmit the patch with the original function names. Otherwise, new documentation is primed for pushing to Worg. Best, Christopher org-mac-message.patch Description: Binary data ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Problem with org-mac-message.el
On 4 Apr 2009, at 09:25, Carsten Dominik wrote: the patch and the abstraction looks good. However, I am sure that there are quite a few people who have remember templates which call %(org-mac-message-insert-link) Let's not break their setup. Could you modify your patch so that this function still works? Here you go. Christopher org-mac-message.patch Description: Binary data ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Problem with org-mac-message.el
Hi Christopher, I have applied the patch, thanks. Also I made the following modification: The new function is defined as org-mac-message-insert-selected, and then the old name org-mac-message-insert-link is introduced as an alias. So you get your consisten function naming, and compatibility as well. I believe the file commentary may not be fully correct anymore, it still mentions the old function names. I have already pushed the new version, if you fix the commentary, please diff against that new version. Thanks. - Carsten On Apr 4, 2009, at 10:52 AM, Christopher Suckling wrote: On 4 Apr 2009, at 09:25, Carsten Dominik wrote: the patch and the abstraction looks good. However, I am sure that there are quite a few people who have remember templates which call %(org-mac-message-insert-link) Let's not break their setup. Could you modify your patch so that this function still works? Here you go. Christopher org-mac-message.patch ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Problem with org-mac-message.el
On 1 Apr 2009, at 21:21, Ed Hirgelt wrote: I've found that org-mac-message-get-link has a problem inserting [[]] as the first item. I can't replicate this. Could you provide an example? The following change makes it better... Unfortunately, this change breaks the code for all other possibilities, and, if I understand the problem correctly, simply omits a link that begins [[ My beginner's elisp is rather clumsy; I'm going to attempt to tidy up the code anyway, so I'll be on the lookout for your difficulty whilst I do so. Best, Christopher diff --git a/lisp/org-mac-message.el b/lisp/org-mac-message.el index 4e10062..e8697c4 100644 --- a/lisp/org-mac-message.el +++ b/lisp/org-mac-message.el @@ -119,7 +119,7 @@ active mail in AppleMail and make a link out of it. (setq split-link (split-string (pop link-list) ::split::)) (setq URL (car split-link)) (setq description (cadr split-link)) - (if (not (string= URL )) + (if (not (string= URL \)) (progn (setq orglink (org-make-link-string URL description)) (push orglink orglink-list) ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
Re: [Orgmode] Problem with org-mac-message.el
On Apr 3, 2009, at 4:49 PM, Christopher Suckling wrote: On 1 Apr 2009, at 21:21, Ed Hirgelt wrote: I've found that org-mac-message-get-link has a problem inserting [[]] as the first item. I can't replicate this. Could you provide an example? The following change makes it better... Unfortunately, this change breaks the code for all other possibilities, and, if I understand the problem correctly, simply omits a link that begins [[ My beginner's elisp is rather clumsy; I'm going to attempt to tidy up the code anyway, so I'll be on the lookout for your difficulty whilst I do so. I think I already fixed it. - Carsten Best, Christopher diff --git a/lisp/org-mac-message.el b/lisp/org-mac-message.el index 4e10062..e8697c4 100644 --- a/lisp/org-mac-message.el +++ b/lisp/org-mac-message.el @@ -119,7 +119,7 @@ active mail in AppleMail and make a link out of it. (setq split-link (split-string (pop link-list) ::split::)) (setq URL (car split-link)) (setq description (cadr split-link)) - (if (not (string= URL )) + (if (not (string= URL \)) (progn (setq orglink (org-make-link-string URL description)) (push orglink orglink-list) ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
[Orgmode] Problem with org-mac-message.el
I've found that org-mac-message-get-link has a problem inserting [[]] as the first item. The following change makes it better... diff --git a/lisp/org-mac-message.el b/lisp/org-mac-message.el index 4e10062..e8697c4 100644 --- a/lisp/org-mac-message.el +++ b/lisp/org-mac-message.el @@ -119,7 +119,7 @@ active mail in AppleMail and make a link out of it. (setq split-link (split-string (pop link-list) ::split::)) (setq URL (car split-link)) (setq description (cadr split-link)) - (if (not (string= URL )) + (if (not (string= URL \)) (progn (setq orglink (org-make-link-string URL description)) (push orglink orglink-list) Thanks, Ed ___ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
