Re: [PATCH] Create commands for org-read-date-minibuffer-local-map

[Laurence Warne]

Great, thanks!

Re: [PATCH] Create commands for org-read-date-minibuffer-local-map

[Ihor Radchenko]

Bastien Guerry  writes:

> Ihor Radchenko  writes:
>
>> Bastien, may you please check FSF records?
>
> Yes, Laurence copyright status is okay.

Updated our records.
https://git.sr.ht/~bzg/worg/commit/aaa9cd38

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [PATCH] Create commands for org-read-date-minibuffer-local-map

[Bastien Guerry]

Ihor Radchenko  writes:

> Bastien, may you please check FSF records?

Yes, Laurence copyright status is okay.

-- 
 Bastien Guerry

Re: [PATCH] Create commands for org-read-date-minibuffer-local-map

[Ihor Radchenko]

Laurence Warne  writes:

>> Applied, onto main; with minor amendments to the commit message format.
>> I also added TINYCHANGE cookie as I do not see in our records that you
>> have FSF copyright assignment
>
> I believe I have signed it previously in order to contribute to Emacs core
> and ELPA packages, is that not applicable here?  Apologies - I am not too
> familiar with the process (:

It is applicable. It is just that you were not listed in our
housekeeping list at https://orgmode.org/worg/contributors.html.

Bastien, may you please check FSF records?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [PATCH] Create commands for org-read-date-minibuffer-local-map

[Laurence Warne]

> You are also now listed as an Org mode contributor.
> https://git.sr.ht/~bzg/worg/commit/fbc3129d


Nice, thanks!

> Applied, onto main; with minor amendments to the commit message format.
> I also added TINYCHANGE cookie as I do not see in our records that you
> have FSF copyright assignment

I believe I have signed it previously in order to contribute to Emacs core
and ELPA packages, is that not applicable here?  Apologies - I am not too
familiar with the process (:

Re: [PATCH] Create commands for org-read-date-minibuffer-local-map

[Ihor Radchenko]

Laurence Warne  writes:

> I have attached a small patch which switches out inline commands in
> org-read-date-minibuffer-local-map for new analogous commands.
>
> The intent is to aid documentation and user configuration, so the user gets
> a nice description and source code when any corresponding key is looked up
> via help, and can rebind it without copying the lambda themselves.

Thank you!
Applied, onto main; with minor amendments to the commit message format.
I also added TINYCHANGE cookie as I do not see in our records that you
have FSF copyright assignment (see
https://orgmode.org/worg/org-contribute.html#first-patch)
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=990b89d32

You are also now listed as an Org mode contributor.
https://git.sr.ht/~bzg/worg/commit/fbc3129d

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

[PATCH] Create commands for org-read-date-minibuffer-local-map

[Laurence Warne]

Hi,

I have attached a small patch which switches out inline commands in
org-read-date-minibuffer-local-map for new analogous commands.

The intent is to aid documentation and user configuration, so the user gets
a nice description and source code when any corresponding key is looked up
via help, and can rebind it without copying the lambda themselves.

Any comments are welcome!

Thanks, Laurence
From f10dc28a72c8c0fb179b0446b4869c71b24c4e52 Mon Sep 17 00:00:00 2001
From: Laurence Warne 
Date: Sun, 24 Mar 2024 15:10:25 +
Subject: [PATCH] Create commands for org-read-date-minibuffer-local-map

Create commands for org-read-date-minibuffer-local-map for use in
place of the inline lambda commands in order to aid user discoverability.

* org.el (org-calendar-goto-today-or-insert-dot)
(org-calendar-goto-today, org-calendar-backward-month)
(org-calendar-forward-month, org-calendar-backward-year)
(org-calendar-forward-year, org-calendar-backward-week)
(org-calendar-forward-week, org-calendar-backward-day)
(org-calendar-forward-day, org-calendar-view-entries)
(org-calendar-scroll-month-left, org-calendar-scroll-month-right)
(org-calendar-scroll-three-months-left)
(org-calendar-scroll-three-months-right): New functions
* org-keys.el (org-read-date-minibuffer-local-map): Use new functions
for keybindings instead of inline functions
---
 lisp/org-keys.el | 99 +---
 lisp/org.el  | 86 +
 2 files changed, 120 insertions(+), 65 deletions(-)

diff --git a/lisp/org-keys.el b/lisp/org-keys.el
index eb5b98726..50e05efa1 100644
--- a/lisp/org-keys.el
+++ b/lisp/org-keys.el
@@ -90,6 +90,21 @@
 (declare-function org-end-of-line "org" ( n))
 (declare-function org-entry-put "org" (pom property value))
 (declare-function org-eval-in-calendar "org" (form  keepdate))
+(declare-function org-calendar-goto-today-or-insert-dot "org" ())
+(declare-function org-calendar-goto-today "org" ())
+(declare-function org-calendar-backward-month "org" ())
+(declare-function org-calendar-forward-month "org" ())
+(declare-function org-calendar-backward-year "org" ())
+(declare-function org-calendar-forward-year "org" ())
+(declare-function org-calendar-backward-week "org" ())
+(declare-function org-calendar-forward-week "org" ())
+(declare-function org-calendar-backward-day "org" ())
+(declare-function org-calendar-forward-day "org" ())
+(declare-function org-calendar-view-entries "org" ())
+(declare-function org-calendar-scroll-month-left "org" ())
+(declare-function org-calendar-scroll-month-right "org" ())
+(declare-function org-calendar-scroll-three-months-left "org" ())
+(declare-function org-calendar-scroll-three-months-right "org" ())
 (declare-function org-evaluate-time-range "org" ( to-buffer))
 (declare-function org-export-dispatch "org" ( arg))
 (declare-function org-feed-goto-inbox "org" (feed))
@@ -349,71 +364,25 @@ COMMANDS is a list of alternating OLDDEF NEWDEF command names."
 (defvar org-read-date-minibuffer-local-map
   (let* ((map (make-sparse-keymap)))
 (set-keymap-parent map minibuffer-local-map)
-(org-defkey map (kbd ".")
-(lambda () (interactive)
-		  ;; Are we at the beginning of the prompt?
-		  (if (looking-back "^[^:]+: "
-(let ((inhibit-field-text-motion t))
-  (line-beginning-position)))
-		  (org-eval-in-calendar '(calendar-goto-today))
-		(insert "."
-(org-defkey map (kbd "C-.")
-(lambda () (interactive)
-		  (org-eval-in-calendar '(calendar-goto-today
-(org-defkey map (kbd "M-S-")
-(lambda () (interactive)
-  (org-eval-in-calendar '(calendar-backward-month 1
-(org-defkey map (kbd "ESC S-")
-(lambda () (interactive)
-  (org-eval-in-calendar '(calendar-backward-month 1
-(org-defkey map (kbd "M-S-")
-(lambda () (interactive)
-  (org-eval-in-calendar '(calendar-forward-month 1
-(org-defkey map (kbd "ESC S-")
-(lambda () (interactive)
-  (org-eval-in-calendar '(calendar-forward-month 1
-(org-defkey map (kbd "M-S-")
-(lambda () (interactive)
-  (org-eval-in-calendar '(calendar-backward-year 1
-(org-defkey map (kbd "ESC S-")
-(lambda () (interactive)
-  (org-eval-in-calendar '(calendar-backward-year 1
-(org-defkey map (kbd "M-S-")
-(lambda () (interactive)
-  (org-eval-in-calendar '(calendar-forward-year 1
-(org-defkey map (kbd "ESC S-&quo