Re: [PATCH] Don't quote symbols in defcustom types
Robert Pluim writes: > >> What's a TINYCHANGE? > > Ihor> See https://orgmode.org/worg/org-contribute.html#first-patch > Ihor> We need to put this word at the end of commit messages for > contributors > Ihor> without FSF copyright assignment. > > The first patch I sent last week in <87ilp81pcx@gmail.com> > mentioned that I have assigned copyright to the FSF for Emacs. Sorry, I missed this fact when I was checking this email thread. I am bad at remembering names and you are not yet listed in https://orgmode.org/worg/contributors.html. Should be fixed soon. Best, Ihor
Re: [PATCH] Don't quote symbols in defcustom types
> On Tue, 14 Jun 2022 22:19:23 +0800, Ihor Radchenko > said: Ihor> Robert Pluim writes: >>> On Tue, 14 Jun 2022 22:04:10 +0800, Ihor Radchenko said: >> Ihor> Daniel Fleischer writes: >> >> Thanks for the patch, merged. >> Ihor> BTW, should it be a TINYCHANGE? >> >> What's a TINYCHANGE? Ihor> See https://orgmode.org/worg/org-contribute.html#first-patch Ihor> We need to put this word at the end of commit messages for contributors Ihor> without FSF copyright assignment. The first patch I sent last week in <87ilp81pcx@gmail.com> mentioned that I have assigned copyright to the FSF for Emacs. Robert --
Re: [PATCH] Don't quote symbols in defcustom types
Robert Pluim writes: >> On Tue, 14 Jun 2022 22:04:10 +0800, Ihor Radchenko >> said: > > Ihor> Daniel Fleischer writes: > >> Thanks for the patch, merged. > > Ihor> BTW, should it be a TINYCHANGE? > > What's a TINYCHANGE? See https://orgmode.org/worg/org-contribute.html#first-patch We need to put this word at the end of commit messages for contributors without FSF copyright assignment. Best, Ihor
Re: [PATCH] Don't quote symbols in defcustom types
> On Tue, 14 Jun 2022 22:04:10 +0800, Ihor Radchenko > said: Ihor> Daniel Fleischer writes: >> Thanks for the patch, merged. Ihor> BTW, should it be a TINYCHANGE? What's a TINYCHANGE? Robert --
Re: [PATCH] Don't quote symbols in defcustom types
Daniel Fleischer writes: > Thanks for the patch, merged. BTW, should it be a TINYCHANGE? Best, Ihor
Re: [PATCH] Don't quote symbols in defcustom types
Thanks for the patch, merged. Daniel Fleischer
Re: [PATCH] Don't quote symbols in defcustom types
>>>>> On Tue, 14 Jun 2022 13:12:54 +0300, Daniel Fleischer >>>>> said: Daniel> Robert Pluim [2022-06-14 Tue 11:28] wrote: >> A couple of places in org main quoted symbols in defcustom types, but >> the type itself is already quoted, so thatʼs not necessary. Daniel> Is it harmful though? Thereʼs the absolutist argument of "itʼs wrong!", or the practical argument of "it causes warnings when byte compiling". Take your pick. >> - (const :tag "Overlays" 'overlays) >> - (const :tag "Text properties" 'text-properties))) >> + (const :tag "Overlays" overlays) >> + (cnost :tag "Text properties" text-properties))) Daniel> Typo here `cnost`. Of course there is. Murphy and all that. Updated patch attached Robert -- >From 2c75a28bff8842f731611ebd7838c5f13122ac4d Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Mon, 13 Jun 2022 16:15:10 +0200 Subject: [PATCH] Don't quote symbols in defcustom types * lisp/org-fold-core.el (org-fold-core-style): * lisp/org-persist.el (org-persist-remote-files): (org-persist-default-expiry): Don't quote the symbol given as value for a const. --- lisp/org-fold-core.el | 4 ++-- lisp/org-persist.el | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/org-fold-core.el b/lisp/org-fold-core.el index 5dda133fb..3ba63b725 100644 --- a/lisp/org-fold-core.el +++ b/lisp/org-fold-core.el @@ -302,8 +302,8 @@ (defcustom org-fold-core-style 'text-properties :group 'org :package-version '(Org . "9.6") :type '(choice - (const :tag "Overlays" 'overlays) - (const :tag "Text properties" 'text-properties))) + (const :tag "Overlays" overlays) + (const :tag "Text properties" text-properties))) (defvar-local org-fold-core-isearch-open-function #'org-fold-core--isearch-reveal "Function used to reveal hidden text found by isearch. diff --git a/lisp/org-persist.el b/lisp/org-persist.el index 068f58cec..ab1365220 100644 --- a/lisp/org-persist.el +++ b/lisp/org-persist.el @@ -196,7 +196,7 @@ (defcustom org-persist-remote-files 100 :type '(choice (const :tag "Never" nil) (const :tag "Always" t) (number :tag "Keep not more than X files") - (const :tag "Check if exist on remote" 'check-existence))) + (const :tag "Check if exist on remote" check-existence))) (defcustom org-persist-default-expiry 30 "Default expiry condition for persistent data. @@ -207,7 +207,7 @@ (defcustom org-persist-default-expiry 30 it should be a function returning non-nil when the data is expired. The function will be called with a single argument - collection." :group 'org-persist - :type '(choice (const :tag "Never" 'never) + :type '(choice (const :tag "Never" never) (const :tag "Always" nil) (number :tag "Keep N days") (function :tag "Function"))) -- 2.35.1.607.gf01e51a7cf
Re: [PATCH] Don't quote symbols in defcustom types
Robert Pluim [2022-06-14 Tue 11:28] wrote: > A couple of places in org main quoted symbols in defcustom types, but > the type itself is already quoted, so thatʼs not necessary. Is it harmful though? > - (const :tag "Overlays" 'overlays) > - (const :tag "Text properties" 'text-properties))) > + (const :tag "Overlays" overlays) > + (cnost :tag "Text properties" text-properties))) Typo here `cnost`. -- Daniel Fleischer
[PATCH] Don't quote symbols in defcustom types
A couple of places in org main quoted symbols in defcustom types, but the type itself is already quoted, so thatʼs not necessary. Thanks Robert -- >From 3163652a7eecbf84c767c6740822e00cf842e607 Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Mon, 13 Jun 2022 16:15:10 +0200 Subject: [PATCH] Don't quote symbols in defcustom types * lisp/org-fold-core.el (org-fold-core-style): * lisp/org-persist.el (org-persist-remote-files): (org-persist-default-expiry): Don't quote the symbol given as value for a const. --- lisp/org-fold-core.el | 4 ++-- lisp/org-persist.el | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/org-fold-core.el b/lisp/org-fold-core.el index 5dda133fb..939702c5c 100644 --- a/lisp/org-fold-core.el +++ b/lisp/org-fold-core.el @@ -302,8 +302,8 @@ (defcustom org-fold-core-style 'text-properties :group 'org :package-version '(Org . "9.6") :type '(choice - (const :tag "Overlays" 'overlays) - (const :tag "Text properties" 'text-properties))) + (const :tag "Overlays" overlays) + (cnost :tag "Text properties" text-properties))) (defvar-local org-fold-core-isearch-open-function #'org-fold-core--isearch-reveal "Function used to reveal hidden text found by isearch. diff --git a/lisp/org-persist.el b/lisp/org-persist.el index 068f58cec..ab1365220 100644 --- a/lisp/org-persist.el +++ b/lisp/org-persist.el @@ -196,7 +196,7 @@ (defcustom org-persist-remote-files 100 :type '(choice (const :tag "Never" nil) (const :tag "Always" t) (number :tag "Keep not more than X files") - (const :tag "Check if exist on remote" 'check-existence))) + (const :tag "Check if exist on remote" check-existence))) (defcustom org-persist-default-expiry 30 "Default expiry condition for persistent data. @@ -207,7 +207,7 @@ (defcustom org-persist-default-expiry 30 it should be a function returning non-nil when the data is expired. The function will be called with a single argument - collection." :group 'org-persist - :type '(choice (const :tag "Never" 'never) + :type '(choice (const :tag "Never" never) (const :tag "Always" nil) (number :tag "Keep N days") (function :tag "Function"))) -- 2.35.1.607.gf01e51a7cf
