Re: [PATCH] Re: [STYLE] :version tags in defcustom definitions

[Ihor Radchenko]

Bastien Guerry  writes:

> Ihor Radchenko  writes:
>
>> Let me know if there are any objections.
>
> None on my side, thanks for this.

Applied onto master.
https://git.sr.ht/~bzg/worg/commit/8dd5762e28876fce7193f96eed65356698e917f0

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [PATCH] Re: [STYLE] :version tags in defcustom definitions

[Bastien Guerry]

Ihor Radchenko  writes:

> Let me know if there are any objections.

None on my side, thanks for this.

-- 
 Bastien

[PATCH] Re: [STYLE] :version tags in defcustom definitions (was: [PATCH] Improve look of agenda on graphical displays)

[Ihor Radchenko]

Timothy  writes:

>>> Sure. Just trying to clarify my confusion. The inconsistency with some
>>> defcustoms using :version and some not is bugging me.
>>
>> Agreed.  It would be better to be consistent with this.
>
> Given that org-mode is distributed separately to Emacs, and I get the 
> impression
> having a newer org-mode version that Emacs version is not uncommon, I think it
> would make sense to have /just/ org-mode version tags.

I have just updated the :package-version tags in the new and changed
variables in Org 9.6.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5a10517d021acba071cd4a2c3b90de84c8e9f3cb

I also plan to push the attached change to org-maintenance document in
WORG.

I think we can replace the old :package keywords as needed, similar to
the Emacs' whitespace policy.

Let me know if there are any objections.

>From f1e2b8daca3bb4bdde0d6d98376d2f1e4c608e94 Mon Sep 17 00:00:00 2001
Message-Id: 
From: Ihor Radchenko 
Date: Sun, 13 Nov 2022 15:33:50 +0800
Subject: [PATCH] org-maintenance.org: Document updating :package-version

* org-maintenance.org (For minor and major releases): Document that it
is necessary to update :package-version in the new and changed
`defcustom' statements.
---
 org-maintenance.org | 4 
 1 file changed, 4 insertions(+)

diff --git a/org-maintenance.org b/org-maintenance.org
index 3cc1ea53..35b70e0a 100644
--- a/org-maintenance.org
+++ b/org-maintenance.org
@@ -274,6 +274,10 @@ *** For minor and major releases
 When doing a minor or major release, the =main= branch should be merged
 into the =bugfix= branch.
 
+Also, ~:package-version~ tags should be added to new and changed
+~defcustom~ statements as needed.  If a statement also contain ~:version~
+tag, it should be removed in favor of ~:package-version~.
+
 *** Releasing by adding a new tag
 :PROPERTIES:
 :CUSTOM_ID: release-tags
-- 
2.35.1


-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at