Re: [PATCH] lisp/org.el: Use `org-document-info' face for subtitles
On 2020-11-07 Sa 23:04, Kyle Meyer wrote:
> Titus von der Malsburg writes:
>
>> On 2020-11-06 Fr 07:18, Kyle Meyer wrote:
>>> Titus von der Malsburg writes:
>>>
Subject: [PATCH] lisp/org.el: Use face org-document-info for subtitle
* lisp/org.el: The value for the #+subtitle: property is now displayed
with face `org-document-info' instead of `org-meta-line'.
Like the title, author, e-mail, date, the subtitle is information
that is displayed in the exported document.
>>>
>>> Makes sense to me, and I guess it was left out just because #+subtitle
>>> wasn't around until v8.3.
>>>
---
lisp/org.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index 03df139fb..27f09645b 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5307,7 +5307,7 @@ by a #."
(min (point-max) end-of-endline))
'(face org-block-end-line)))
t))
- ((member dc1 '("+title:" "+author:" "+email:" "+date:"))
+ ((member dc1 '("+title:" "+subtitle:" "+author:" "+email:" "+date:"))
(org-remove-flyspell-overlays-in
(match-beginning 0)
(if (equal "+title:" dc1) (match-end 2) (match-end 0)))
>>>
>>> Please also update org-document-info-keyword's docstring.
>>
>> Done. I also updated the docstring for `org-document-info'. See attached
>> patch.
>
> Thanks. Applied (e2fe59683), add entries to the changelog for the
> faces.
Attached is a follow-up patch that allows users to hide the #+SUBTITLE: keyword
via `org-hidden-keywords' just like #+TITLE, #+AUTHOR:, and similar.
Titus
>From 794e126fa1ab3cebc8de3bf35324e8353bc8a427 Mon Sep 17 00:00:00 2001
From: Titus von der Malsburg
Date: Thu, 12 Nov 2020 18:03:33 +0100
Subject: [PATCH] lisp/org.el: Allow hiding #+SUBTITLE: keyword via
`org-hidden-keywords'
* lisp/org.el: Allow users to include 'subtitle in
`org-hidden-keywords' to hide #+SUBTITLE: keyword.
This way #+SUBTITLE is treated like similar keywords for title, date,
e-mail, and author.
---
lisp/org.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/org.el b/lisp/org.el
index 73b270712..0d2fbddda 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -3573,6 +3573,7 @@ appear in the buffer without the initial \"#+TITLE:\" part."
:type '(set (const :tag "#+AUTHOR" author)
(const :tag "#+DATE" date)
(const :tag "#+EMAIL" email)
+ (const :tag "#+SUBTITLE" subtitle)
(const :tag "#+TITLE" title)))
(defcustom org-custom-properties nil
--
2.25.1
Re: [PATCH] lisp/org.el: Use `org-document-info' face for subtitles
Titus von der Malsburg writes:
> On 2020-11-06 Fr 07:18, Kyle Meyer wrote:
>> Titus von der Malsburg writes:
>>
>>> Subject: [PATCH] lisp/org.el: Use face org-document-info for subtitle
>>>
>>> * lisp/org.el: The value for the #+subtitle: property is now displayed
>>> with face `org-document-info' instead of `org-meta-line'.
>>>
>>> Like the title, author, e-mail, date, the subtitle is information
>>> that is displayed in the exported document.
>>
>> Makes sense to me, and I guess it was left out just because #+subtitle
>> wasn't around until v8.3.
>>
>>> ---
>>> lisp/org.el | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lisp/org.el b/lisp/org.el
>>> index 03df139fb..27f09645b 100644
>>> --- a/lisp/org.el
>>> +++ b/lisp/org.el
>>> @@ -5307,7 +5307,7 @@ by a #."
>>> (min (point-max) end-of-endline))
>>>'(face org-block-end-line)))
>>> t))
>>> -((member dc1 '("+title:" "+author:" "+email:" "+date:"))
>>> +((member dc1 '("+title:" "+subtitle:" "+author:" "+email:" "+date:"))
>>> (org-remove-flyspell-overlays-in
>>>(match-beginning 0)
>>>(if (equal "+title:" dc1) (match-end 2) (match-end 0)))
>>
>> Please also update org-document-info-keyword's docstring.
>
> Done. I also updated the docstring for `org-document-info'. See attached
> patch.
Thanks. Applied (e2fe59683), add entries to the changelog for the
faces.
Re: [PATCH] lisp/org.el: Use `org-document-info' face for subtitles
On 2020-11-06 Fr 07:18, Kyle Meyer wrote:
> Titus von der Malsburg writes:
>
>> Subject: [PATCH] lisp/org.el: Use face org-document-info for subtitle
>>
>> * lisp/org.el: The value for the #+subtitle: property is now displayed
>> with face `org-document-info' instead of `org-meta-line'.
>>
>> Like the title, author, e-mail, date, the subtitle is information
>> that is displayed in the exported document.
>
> Makes sense to me, and I guess it was left out just because #+subtitle
> wasn't around until v8.3.
>
>> ---
>> lisp/org.el | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lisp/org.el b/lisp/org.el
>> index 03df139fb..27f09645b 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -5307,7 +5307,7 @@ by a #."
>> (min (point-max) end-of-endline))
>> '(face org-block-end-line)))
>> t))
>> - ((member dc1 '("+title:" "+author:" "+email:" "+date:"))
>> + ((member dc1 '("+title:" "+subtitle:" "+author:" "+email:" "+date:"))
>>(org-remove-flyspell-overlays-in
>> (match-beginning 0)
>> (if (equal "+title:" dc1) (match-end 2) (match-end 0)))
>
> Please also update org-document-info-keyword's docstring.
Done. I also updated the docstring for `org-document-info'. See attached
patch.
Titus
>From 3d27f195a635f9ef8cbf43e1549663bef447c8fa Mon Sep 17 00:00:00 2001
From: Titus von der Malsburg
Date: Tue, 3 Nov 2020 10:32:57 +0100
Subject: [PATCH] lisp/org.el: Display subtitle lines with document info faces
* lisp/org.el: The #+SUBTITLE: keyword is now displayed with
`org-document-info-keyword' and its value with
`org-document-info' (instead of `org-meta-line').
Like the title, author, e-mail, date, the subtitle is information
that is displayed in the exported document, not meta information.
---
lisp/org-faces.el | 8 +---
lisp/org.el | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/lisp/org-faces.el b/lisp/org-faces.el
index 94b283ad6..2f3273f55 100644
--- a/lisp/org-faces.el
+++ b/lisp/org-faces.el
@@ -414,12 +414,14 @@ changes."
'class color) (background light)) (:foreground "midnight blue"))
(((class color) (background dark)) (:foreground "pale turquoise"))
(t nil))
- "Face for document date, author and email; i.e. that which
-follows a #+DATE:, #+AUTHOR: or #+EMAIL: keyword."
+ "Face for document subtitle, date, author and email; i.e. that
+which follows a #+SUBTITLE:, #+DATE:, #+AUTHOR: or #+EMAIL:
+keyword."
:group 'org-faces)
(defface org-document-info-keyword '((t :inherit shadow))
- "Face for #+TITLE:, #+AUTHOR:, #+EMAIL: and #+DATE: keywords."
+ "Face for #+TITLE:, #+SUBTITLE:, #+AUTHOR:, #+EMAIL: and
+#+DATE: keywords."
:group 'org-faces)
(defface org-block `((t :inherit shadow
diff --git a/lisp/org.el b/lisp/org.el
index 9a13f03d6..89cb09fe1 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5307,7 +5307,7 @@ by a #."
(min (point-max) end-of-endline))
'(face org-block-end-line)))
t))
- ((member dc1 '("+title:" "+author:" "+email:" "+date:"))
+ ((member dc1 '("+title:" "+subtitle:" "+author:" "+email:" "+date:"))
(org-remove-flyspell-overlays-in
(match-beginning 0)
(if (equal "+title:" dc1) (match-end 2) (match-end 0)))
--
2.25.1
Re: [PATCH] lisp/org.el: Use `org-document-info' face for subtitles
Titus von der Malsburg writes:
> Subject: [PATCH] lisp/org.el: Use face org-document-info for subtitle
>
> * lisp/org.el: The value for the #+subtitle: property is now displayed
> with face `org-document-info' instead of `org-meta-line'.
>
> Like the title, author, e-mail, date, the subtitle is information
> that is displayed in the exported document.
Makes sense to me, and I guess it was left out just because #+subtitle
wasn't around until v8.3.
> ---
> lisp/org.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 03df139fb..27f09645b 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -5307,7 +5307,7 @@ by a #."
>(min (point-max) end-of-endline))
> '(face org-block-end-line)))
> t))
> - ((member dc1 '("+title:" "+author:" "+email:" "+date:"))
> + ((member dc1 '("+title:" "+subtitle:" "+author:" "+email:" "+date:"))
> (org-remove-flyspell-overlays-in
> (match-beginning 0)
> (if (equal "+title:" dc1) (match-end 2) (match-end 0)))
Please also update org-document-info-keyword's docstring.
[PATCH] lisp/org.el: Use `org-document-info' face for subtitles
Org currently uses `org-meta-line' to display the value of the #+subtitle:
property. However, the subtitle isn’t meta information, but document
information supposed to be displayed in the exported document like title,
author, date, e-mail. The attached patch uses the face `org-document-info' to
display subtitles, which is the same face as for title, author, date, e-mail.
Titus
>From ffb43ad434031ff0ae335711d7ac29c8a4973417 Mon Sep 17 00:00:00 2001
From: Titus von der Malsburg
Date: Tue, 3 Nov 2020 10:32:57 +0100
Subject: [PATCH] lisp/org.el: Use face org-document-info for subtitle
* lisp/org.el: The value for the #+subtitle: property is now displayed
with face `org-document-info' instead of `org-meta-line'.
Like the title, author, e-mail, date, the subtitle is information
that is displayed in the exported document.
---
lisp/org.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index 03df139fb..27f09645b 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5307,7 +5307,7 @@ by a #."
(min (point-max) end-of-endline))
'(face org-block-end-line)))
t))
- ((member dc1 '("+title:" "+author:" "+email:" "+date:"))
+ ((member dc1 '("+title:" "+subtitle:" "+author:" "+email:" "+date:"))
(org-remove-flyspell-overlays-in
(match-beginning 0)
(if (equal "+title:" dc1) (match-end 2) (match-end 0)))
--
2.25.1
