[SOLVED] (kinda) Calendar vs. org-agenda exit
On Wed, Jun 23, 2021 at 05:28:36PM +0200, to...@tuxteam.de wrote: [calendar insert-diary-entry doing funny things] OK, I solved it by setting `org-calendar-insert-diary-entry-key' to [106], which is a ?j. It was set to ?i, which hijacked calendar's original key map. Now I still don't know whether it's intended that Org hijacks that key in calendar, whether I did something stupid, but at least I have my toys back. Just remember to not push ?j. Anyway, you set me on the right track, so thanks for that! Cheers - t signature.asc Description: Digital signature
Re: [SOLVED] (kinda) Calendar vs. org-agenda exit
On Wed, 23 Jun 2021 18:16:52 +0200 to...@tuxteam.de wrote: > On Wed, Jun 23, 2021 at 05:28:36PM +0200, to...@tuxteam.de wrote: > > [calendar insert-diary-entry doing funny things] > > OK, I solved it by setting `org-calendar-insert-diary-entry-key' to > [106], which is a ?j. It was set to ?i, which hijacked calendar's > original key map. > > Now I still don't know whether it's intended that Org hijacks that > key in calendar, whether I did something stupid, but at least I have > my toys back. Just remember to not push ?j. > > Anyway, you set me on the right track, so thanks for that! See also bug#48199 (also CC'd at https://lists.gnu.org/archive/html/emacs-orgmode/2021-05/msg00582.html). I continue to use the patch I posted there and have had no problems with it (but I don't use org-mode much). Steve Berman
Re: [SOLVED] (kinda) Calendar vs. org-agenda exit
On Thu, Jun 24, 2021 at 12:13:40PM +0200, Stephen Berman wrote: > On Wed, 23 Jun 2021 18:16:52 +0200 to...@tuxteam.de wrote: > > > On Wed, Jun 23, 2021 at 05:28:36PM +0200, to...@tuxteam.de wrote: > > > > [calendar insert-diary-entry doing funny things] > > > > OK, I solved it by setting `org-calendar-insert-diary-entry-key' to > > [106], which is a ?j. It was set to ?i, which hijacked calendar's > > original key map. > > > > Now I still don't know whether it's intended that Org hijacks that > > key in calendar, whether I did something stupid, but at least I have > > my toys back. Just remember to not push ?j. > > > > Anyway, you set me on the right track, so thanks for that! > > See also bug#48199 (also CC'd at > https://lists.gnu.org/archive/html/emacs-orgmode/2021-05/msg00582.html). > I continue to use the patch I posted there and have had no problems with > it (but I don't use org-mode much). Oh, I see, thanks. For me, it's a bit confusing that this bug receives so little attention. Hijacking other modes's keymaps isn't... friendly, after all. I can't imagine that it is happening by intention. Cheers & thanks for the background. -- tomás signature.asc Description: Digital signature
Re: [SOLVED] (kinda) Calendar vs. org-agenda exit
On Thu, 24 Jun 2021 14:09:46 +0200 to...@tuxteam.de wrote: > On Thu, Jun 24, 2021 at 12:13:40PM +0200, Stephen Berman wrote: >> On Wed, 23 Jun 2021 18:16:52 +0200 to...@tuxteam.de wrote: >> >> > On Wed, Jun 23, 2021 at 05:28:36PM +0200, to...@tuxteam.de wrote: >> > >> > [calendar insert-diary-entry doing funny things] >> > >> > OK, I solved it by setting `org-calendar-insert-diary-entry-key' to >> > [106], which is a ?j. It was set to ?i, which hijacked calendar's >> > original key map. >> > >> > Now I still don't know whether it's intended that Org hijacks that >> > key in calendar, whether I did something stupid, but at least I have >> > my toys back. Just remember to not push ?j. >> > >> > Anyway, you set me on the right track, so thanks for that! >> >> See also bug#48199 (also CC'd at >> https://lists.gnu.org/archive/html/emacs-orgmode/2021-05/msg00582.html). >> I continue to use the patch I posted there and have had no problems with >> it (but I don't use org-mode much). > > Oh, I see, thanks. For me, it's a bit confusing that this bug receives > so little attention. Hijacking other modes's keymaps isn't... friendly, > after all. I can't imagine that it is happening by intention. Yeah, the next time Org is merged to the Emacs master branch, forcing me to first stash and then reapply my patch locally, I'll ask if anyone objects to the patch being committed to master. Maybe that will get someone's attention (and if not, I may just go ahead and commit it -- if it then still gets no one's attention, it must be ok ;-). Steve Berman
Re: [SOLVED] (kinda) Calendar vs. org-agenda exit
Hello, Stephen Berman writes: > Yeah, the next time Org is merged to the Emacs master branch, forcing me > to first stash and then reapply my patch locally, I'll ask if anyone > objects to the patch being committed to master. Sure, go ahead. Regards, -- Nicolas Goaziou
Re: [SOLVED] (kinda) Calendar vs. org-agenda exit
On Thu, Jun 24, 2021 at 05:04:02PM +0200, Nicolas Goaziou wrote: > Hello, > > Stephen Berman writes: > > > Yeah, the next time Org is merged to the Emacs master branch, forcing me > > to first stash and then reapply my patch locally, I'll ask if anyone > > objects to the patch being committed to master. > > Sure, go ahead. Warm thanks, you both! :) Cheers - t signature.asc Description: Digital signature
Re: [SOLVED] (kinda) Calendar vs. org-agenda exit
Stephen Berman writes: > On Thu, 24 Jun 2021 14:09:46 +0200 to...@tuxteam.de wrote: > >> On Thu, Jun 24, 2021 at 12:13:40PM +0200, Stephen Berman wrote: >>> On Wed, 23 Jun 2021 18:16:52 +0200 to...@tuxteam.de wrote: >>> >>> > On Wed, Jun 23, 2021 at 05:28:36PM +0200, to...@tuxteam.de wrote: >>> > >>> > [calendar insert-diary-entry doing funny things] >>> > >>> > OK, I solved it by setting `org-calendar-insert-diary-entry-key' to >>> > [106], which is a ?j. It was set to ?i, which hijacked calendar's >>> > original key map. >>> > >>> > Now I still don't know whether it's intended that Org hijacks that >>> > key in calendar, whether I did something stupid, but at least I have >>> > my toys back. Just remember to not push ?j. >>> > >>> > Anyway, you set me on the right track, so thanks for that! >>> >>> See also bug#48199 (also CC'd at >>> https://lists.gnu.org/archive/html/emacs-orgmode/2021-05/msg00582.html). >>> I continue to use the patch I posted there and have had no problems with >>> it (but I don't use org-mode much). >> >> Oh, I see, thanks. For me, it's a bit confusing that this bug receives >> so little attention. Hijacking other modes's keymaps isn't... friendly, >> after all. I can't imagine that it is happening by intention. > > Yeah, the next time Org is merged to the Emacs master branch, forcing me > to first stash and then reapply my patch locally, I'll ask if anyone > objects to the patch being committed to master. Maybe that will get > someone's attention (and if not, I may just go ahead and commit it -- if > it then still gets no one's attention, it must be ok ;-). > My view is that if org-mode is stealing the calendar bindings by default i.e. user has not enabled some specific option/configuration to do this, then this is a bug. Org should not interfere with the key bindings of any mode unless asked to. Some people still like to use traditional Emacs diary rather than org agenda for scheduling meetings/appointments, but like to use (load) org for other things (like document authoring and TODO lists). Org should only override the calendar bindings if requested. If your patch fixes this, I vote to apply it to master. -- Tim Cross
Re: [SOLVED] (kinda) Calendar vs. org-agenda exit
On Fri, Jun 25, 2021 at 06:54:25AM +1000, Tim Cross wrote: [...] > My view is that if org-mode is stealing the calendar bindings by default > i.e. user has not enabled some specific option/configuration to do this, > then this is a bug [...] AFAIU, Stephen just gave his green light to Stephen's patch :-) Cheers - t signature.asc Description: Digital signature
