Re: [org-promote-subtree + undo] adds one star

[Ihor Radchenko]

Ihor Radchenko  writes:

> alain.coch...@unistra.fr writes:
>
>> I fear that, even if the emacs people fix the problem, it still won't
>> work with, say, emacs 27 or 28.
>>
>> Oh, well...
>
> If they fix this, we will at least have a clue what is causing it.

The bug has been fixed for Emacs 29.
Earlier Emacs will still suffer.
I committed a workaround onto bugfix.
Fixed.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=af1bb1b06

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [org-promote-subtree + undo] adds one star

[Ihor Radchenko]

alain.coch...@unistra.fr writes:

> I fear that, even if the emacs people fix the problem, it still won't
> work with, say, emacs 27 or 28.
>
> Oh, well...

If they fix this, we will at least have a clue what is causing it.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [org-promote-subtree + undo] adds one star

[Alain . Cochard]

Ihor Radchenko writes on Sun  1 Jan 2023 14:13:

 > It is indeed Org 9.6 issue. Likely related to some obscure
 > interaction between what Org does and `combine-after-change-calls'.
 > 
 > Note that I am reporting for Emacs master, which ships with Org
 > 9.6.

I'm afraid it is a bit complicated for me :-)

I fear that, even if the emacs people fix the problem, it still won't
work with, say, emacs 27 or 28.

Oh, well...

-- 
EOST (École et Observatoire des Sciences de la Terre) 
ITE (Institut Terre & Environnement) | alain.coch...@unistra.fr
5 rue René Descartes   [bureau 110]  | Phone: +33 (0)3 68 85 50 44 
F-67084 Strasbourg Cedex, France | [ slot available for rent ]

Re: [org-promote-subtree + undo] adds one star

[Ihor Radchenko]

alain.coch...@unistra.fr writes:

>  > Confirmed.
>  > 
>  > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60467
>
> Funny: since the problem was not present in previous versions of org,
> I would have thought it was an org 9.6 issue...

It is indeed Org 9.6 issue. Likely related to some obscure interaction
between what Org does and `combine-after-change-calls'.

Note that I am reporting for Emacs master, which ships with Org 9.6.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [org-promote-subtree + undo] adds one star

[Alain . Cochard]

 > Confirmed.
 > 
 > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60467

Funny: since the problem was not present in previous versions of org,
I would have thought it was an org 9.6 issue...

-- 
EOST (École et Observatoire des Sciences de la Terre) 
ITE (Institut Terre & Environnement) | alain.coch...@unistra.fr
5 rue René Descartes   [bureau 110]  | Phone: +33 (0)3 68 85 50 44 
F-67084 Strasbourg Cedex, France | [ slot available for rent ]

Re: [org-promote-subtree + undo] adds one star

[Ihor Radchenko]

alain.coch...@unistra.fr writes:

> Under release_9.6-173-g24740a
>
> I have file
>
> #+begin_src org
> ,* h1
> ,** h2
> #+end_src
>
> I do
>
>M-x org-promote-subtree
>
> on h2, which works as expected; then
>
>M-x undo
> ...
> and I have the message
>
>primitive-undo: Changes to be undone by function different from
>announced

Confirmed.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60467

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

[org-promote-subtree + undo] adds one star

[Alain . Cochard]

Under release_9.6-173-g24740a

I have file

#+begin_src org
,* h1
,** h2
#+end_src

I do

   M-x org-promote-subtree

on h2, which works as expected; then

   M-x undo

The file becomes

#+begin_src org
,* h1
,** * h2
#+end_src

and I have the message

   primitive-undo: Changes to be undone by function different from
   announced


-- 
EOST (École et Observatoire des Sciences de la Terre) 
ITE (Institut Terre & Environnement) | alain.coch...@unistra.fr
5 rue René Descartes   [bureau 110]  | Phone: +33 (0)3 68 85 50 44 
F-67084 Strasbourg Cedex, France | [ slot available for rent ]