Re: [PATCH] Bug: Tag Selection Face Doesn't Toggle
> Daniel Fleischer writes: > >> Hi, when selecting tags using fast selection and then de-selecting, the >> face doesn't toggle back to regular face. >> It's better to have a default face instead of 'org-default face. >From f269d3ad99b8ad570c19961831f38653046f07fb Mon Sep 17 00:00:00 2001 From: Daniel Fleischer Date: Fri, 8 Oct 2021 12:55:04 +0300 Subject: [PATCH] lisp/org.el: fast tag selection disabled tag face A tag can be either selected in "current", "inherited" or disabled. When disabled, it should have the 'org-default face. Previously, if a tag was already selected, upon deselection it will still have an 'org-todo face. --- lisp/org.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 18cb53af6..1dfe70735 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -12440,8 +12440,7 @@ (defun org-fast-tag-selection (current inherited table todo-table) (cond ((member tag current) c-face) ((member tag inherited) i-face) -(t (get-text-property (match-beginning 1) ' - face +(t 'default))) (goto-char (point-min) (delete-overlay org-tags-overlay) (if rtn -- 2.33.0
[PATCH] Bug: Tag Selection Face Doesn't Toggle
Daniel Fleischer writes: > Hi, when selecting tags using fast selection and then de-selecting, the > face doesn't toggle back to regular face. > > Fast selection means `org-use-fast-tag-selection' is t. See attached. >From 0352757d7012dc543bae4039deaed7bbd401bb9f Mon Sep 17 00:00:00 2001 From: Daniel Fleischer Date: Fri, 8 Oct 2021 12:55:04 +0300 Subject: [PATCH] lisp/org.el: fast tag selection disabled tag face A tag can be either selected in "current", "inherited" or disabled. When disabled, it should have the 'org-default face. Previously, if a tag was already selected, upon deselection it will still have an 'org-todo face. --- lisp/org.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 18cb53af6..e6a0350c1 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -12440,8 +12440,7 @@ (defun org-fast-tag-selection (current inherited table todo-table) (cond ((member tag current) c-face) ((member tag inherited) i-face) -(t (get-text-property (match-beginning 1) ' - face +(t 'org-default))) (goto-char (point-min) (delete-overlay org-tags-overlay) (if rtn -- 2.33.0 -- Daniel Fleischer
Bug: Tag Selection Face Doesn't Toggle
Hi, when selecting tags using fast selection and then de-selecting, the face doesn't toggle back to regular face. Fast selection means `org-use-fast-tag-selection' is t. Checked with emacs -Q + (setq org-use-fast-tag-selection t). Org 9.5, commit cc2490a7061955395c4f5a1a23a088044554a2f7. Emacs 29.0.50, hash 9f041cdfaca0f3def74eb7d3348bbf35c12bcc5b. -- Daniel Fleischer
