Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Björn Bidar  writes:

> On another related note are `org-add-note` also follow the same pattern as
> e.g. `org-src`? Maybe it should have something like `org-note-window-setup`
> similar to `org-src-window-setup`?

Now, it should respect display-buffer-alist.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Ihor Radchenko  writes:

> Björn Bidar  writes:
>
 E.g.:
 1. I capture a link using org-protocol
 2. Switch to the org-buffer
 3. C-c C-l
 4. RET  <- frame closes however links isn't inserted into the target 
 org-buffer 
>>>
>>> May you provide more details about how to reproduce?
>>
>> What do you miss after the initial details?
>

> In other words, I need detailed steps starting from emacs -Q, if possible.

Never mind the issue was caused by my own setup. I had a hook killing
the frame spawned by org-store-link which cause a race condition.

On another related note are `org-add-note` also follow the same pattern as
e.g. `org-src`? Maybe it should have something like `org-note-window-setup`
similar to `org-src-window-setup`?

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Björn Bidar  writes:

>>> E.g.:
>>> 1. I capture a link using org-protocol
>>> 2. Switch to the org-buffer
>>> 3. C-c C-l
>>> 4. RET  <- frame closes however links isn't inserted into the target 
>>> org-buffer 
>>
>> May you provide more details about how to reproduce?
>
> What do you miss after the initial details?

1. Did you start from emacs -Q?
2. What kind of protocol did you use?
3. Did you need to switch to specific Org buffer or it gotta be some an
arbitrary org buffer?

In other words, I need detailed steps starting from emacs -Q, if possible.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Ihor Radchenko  writes:

>>> Fixed, on main. Alongside with other similar places.
>>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=78e9dd0c4
>>
>> I noticed after the change that captured links are not picked up.
>>
>> E.g.:
>> 1. I capture a link using org-protocol
>> 2. Switch to the org-buffer
>> 3. C-c C-l
>> 4. RET  <- frame closes however links isn't inserted into the target 
>> org-buffer 
>
> May you provide more details about how to reproduce?

What do you miss after the initial details?

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Björn Bidar  writes:

>> Fixed, on main. Alongside with other similar places.
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=78e9dd0c4
>
> I noticed after the change that captured links are not picked up.
>
> E.g.:
> 1. I capture a link using org-protocol
> 2. Switch to the org-buffer
> 3. C-c C-l
> 4. RET  <- frame closes however links isn't inserted into the target 
> org-buffer 

May you provide more details about how to reproduce?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Ihor Radchenko  writes:

> Björn Bidar  writes:
>
>> The bug also seems to affect `org-attach`.
>
> Fixed, on main. Alongside with other similar places.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=78e9dd0c4

I noticed after the change that captured links are not picked up.

E.g.:
1. I capture a link using org-protocol
2. Switch to the org-buffer
3. C-c C-l
4. RET  <- frame closes however links isn't inserted into the target org-buffer 

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Björn Bidar  writes:

> The bug also seems to affect `org-attach`.

Fixed, on main. Alongside with other similar places.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=78e9dd0c4

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Ihor Radchenko  writes:

> Björn Bidar  writes:
>
>>> Fixed, on main.
>>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fef873b1c
>>
>> I noticed that `org-insert-structure-template' and possibly others are
>> also affected
>>
>> Is a new bug needed or this one enough?
>
> This one is enough.
> Fixed, on main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a1b8554f6

The bug also seems to affect `org-attach`.

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Björn Bidar  writes:

>> Fixed, on main.
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fef873b1c
>
> I noticed that `org-insert-structure-template' and possibly others are
> also affected
>
> Is a new bug needed or this one enough?

This one is enough.
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a1b8554f6

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Ihor Radchenko  writes:

> Ihor Radchenko  writes:
>
>>> 0. emacs -Q
>>> 1. Paste this into the scratch buffer:
>>> (setq org-agenda-window-setup 'other-frame)
>>> (setq pop-up-frames t)
>>> 2. Eval
>>> 3. Org-agenda
>>
>> This is now expected.
>> We changed Org agenda to respect user settings, including
>> `pop-up-frames' setting.
>> ...
>
> Oops. I missed that the problem is not with a new frame with agenda
> commands, but with the frame not being closed.
>
> Fixed, on main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fef873b1c

I noticed that `org-insert-structure-template' and possibly others are
also affected

Is a new bug needed or this one enough?

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Thank you.

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Ihor Radchenko  writes:

>> 0. emacs -Q
>> 1. Paste this into the scratch buffer:
>> (setq org-agenda-window-setup 'other-frame)
>> (setq pop-up-frames t)
>> 2. Eval
>> 3. Org-agenda
>
> This is now expected.
> We changed Org agenda to respect user settings, including
> `pop-up-frames' setting.
> ...

Oops. I missed that the problem is not with a new frame with agenda
commands, but with the frame not being closed.

Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fef873b1c

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Björn Bidar  writes:

>> I cannot reproduce on the latest main using the latest Emacs master.
>> May you please provide a reproducer starting from emacs -Q?
>> See https://orgmode.org/manual/Feedback.html#Feedback
>
> 0. emacs -Q
> 1. Paste this into the scratch buffer:
> (setq org-agenda-window-setup 'other-frame)
> (setq pop-up-frames t)
> 2. Eval
> 3. Org-agenda

This is now expected.
We changed Org agenda to respect user settings, including
`pop-up-frames' setting.

In your reproducer, you set `pop-up-frames' to t, telling Emacs to
create frames for new buffers by default. So, what you see is expected -
Org mode follows your settings. You may customize `display-buffer-alist'
to make agenda buffers ignore your `pop-up-frames' setting.

Not a bug.
Canceled.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Ihor Radchenko  writes:

>> The problem is that org-mode leaves the agenda command selection frame around
>> after selecting the specific agenda to be displayed
>
> I cannot reproduce on the latest main using the latest Emacs master.
> May you please provide a reproducer starting from emacs -Q?
> See https://orgmode.org/manual/Feedback.html#Feedback

0. emacs -Q
1. Paste this into the scratch buffer:
(setq org-agenda-window-setup 'other-frame)
(setq pop-up-frames t)
2. Eval
3. Org-agenda

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Björn Bidar  writes:

> The problem is that org-mode leaves the agenda command selection frame around
> after selecting the specific agenda to be displayed

I cannot reproduce on the latest main using the latest Emacs master.
May you please provide a reproducer starting from emacs -Q?
See https://orgmode.org/manual/Feedback.html#Feedback

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Björn Bidar]

Ihor Radchenko  writes:

> Björn Bidar  writes:
>> I noticed thatOrg-agenda leaves frame around if org-agenda-window-setup
>> is set to other-frame since
>> 78dc58508ddbf97b6f44c0a6dd222eab3d13b50a. 
>
> May you please explain more what the problem is?

The problem is that org-mode leaves the agenda command selection frame around
after selecting the specific agenda to be displayed

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

[Ihor Radchenko]

Björn Bidar  writes:
> I noticed thatOrg-agenda leaves frame around if org-agenda-window-setup
> is set to other-frame since
> 78dc58508ddbf97b6f44c0a6dd222eab3d13b50a. 

May you please explain more what the problem is?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at