Re: [BUG] ob-sql sql-connection-alist

[Daniel Kraus]

Hi!

Andreas Gerler  writes:

> I added the missing changelog entry.

Thanks.
I installed the patch.

(I'll also answer to your dbconnection engine mail soon.
Just very busy atm)

Thanks,
  Daniel

Re: [BUG] ob-sql sql-connection-alist

[Andreas Gerler]

Hi!

I added the missing changelog entry.



0001-lisp-ob-sql.el-allow-string-in-sql-connection-alist.patch
Description: Binary data


> On 27. Jan 2023, at 17:58, Andreas Gerler  
> wrote:
> 
> Hi!
> 
> I can prepare a new commit this weekend.
> 




so long…

Andreas Gerler
—

http://www.bundesbrandschatzamt.de/~baron


signature.asc
Description: Message signed with OpenPGP

Re: [BUG] ob-sql sql-connection-alist

[Andreas Gerler]

Hi!

I can prepare a new commit this weekend.

so long...

Andreas

> On Jan 27, 2023, at 2:18 PM, Ihor Radchenko  wrote:
> 
> Bastien Guerry  writes:
> 
>> It was missing in the FSF copyright.list file, but it has been fixed
>> and Andreas can be added as a regular contributor.
> 
> Done.
> https://git.sr.ht/~bzg/worg/commit/3dbeb2db
> 
> -- 
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at .
> Support Org development at ,
> or support my work at 

Re: [BUG] ob-sql sql-connection-alist

[Ihor Radchenko]

Bastien Guerry  writes:

> It was missing in the FSF copyright.list file, but it has been fixed
> and Andreas can be added as a regular contributor.

Done.
https://git.sr.ht/~bzg/worg/commit/3dbeb2db

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] ob-sql sql-connection-alist

[Ihor Radchenko]

Bastien Guerry  writes:

>> Bastien, could you please confirm the copyright status of Andreas
>> Gerler?
>
> It was missing in the FSF copyright.list file, but it has been fixed
> and Andreas can be added as a regular contributor.

Daniel, there is thus no obstacle installing the patch. And no need to
add TINYCHANGE cookie.

Note, however, that the commit message lacks changelog entry. We may
either ask Andreas to add it or you can do it manually, install the
patch, and take note about the amendment in the email thread (see my
other email replies).

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] ob-sql sql-connection-alist

[Bastien Guerry]

Hi,

Ihor Radchenko  writes:

> Bastien, could you please confirm the copyright status of Andreas
> Gerler?

It was missing in the FSF copyright.list file, but it has been fixed
and Andreas can be added as a regular contributor.

Best,

-- 
 Bastien

Re: [BUG] ob-sql sql-connection-alist

[Bastien Guerry]

Hi,

Ihor Radchenko  writes:

> Bastien, could you please confirm the copyright status of Andreas
> Gerler?

I cannot find any entry with "Gerler" as a name, or with the email
"ba...@bundesbrandschatzamt.de".

Andreas, can you write me in private with a copy of the signed FSF
copyright assignment?  We can sort this out with the FSF copyright
clerk.

Thanks,

-- 
 Bastien

Re: [BUG] ob-sql sql-connection-alist

[Andreas Gerler]

The copyright assignment was in April 2017.
gnu.org #1203873 if that helps.

> On 21. Jan 2023, at 09:48, Ihor Radchenko  wrote:
> 
> Daniel Kraus  writes:
> 
>> @Ihor, since this is the first patch I install from another contributor,
>> is there anything I should look out for?
> 
>> E.g. does this need a TINYCHANGE entry or something?
> 
> 1. General checks for tests passing and sanity of the patches
> 2. Ensuring copyright status, when total contributed nuber of LOC is
>   around 15
> 
> See https://orgmode.org/worg/org-maintenance.html and
> https://www.gnu.org/prep/maintain/
> 
> Also, make sure that you are familiar with general contribution
> guidelines listed at https://orgmode.org/worg/org-contribute.html
> 
>> Or do you have already copyright assignments filled out, Andreas and
>> then it's not necessary?
>> Can I see somewhere who I need to ask for copyright assignments or not?
> 
> We list all (well, most of) the past contributors and their copyright
> assignment status at https://orgmode.org/worg/contributors.html
> 
> I also have a small hook for my Emacs mail client that automatically
> checks the contributor status and number of contributed LOCs for Org
> mailing list:
> https://github.com/yantar92/emacs-config/blob/master/config.org#detect-fsf-contribution-status-of-sender-for-org-ml
> 
> Bastien has access to official FSF records. We need to ask him when
> copyright assignment status cannot be determined from the Org
> contributors page.
> 
> In this case, Andreas is not listed on
> https://orgmode.org/worg/contributors.html
> I also cannot find anything relevant in the mailing list archives.
> (well, there is
> https://orgmode.org/list/b664b5e8-b6a8-4b20-b0cb-f6149c720...@bundesbrandschatzamt.de,
> but I do not see any confirmation of the copyright assignment status).
> 
> Bastien, could you please confirm the copyright status of Andreas Gerler?
> 
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at .
> Support Org development at ,
> or support my work at 
> 



so long…
Andreas Gerler
—

http://www.bundesbrandschatzamt.de/~baron



signature.asc
Description: Message signed with OpenPGP

Re: [BUG] ob-sql sql-connection-alist

[Ihor Radchenko]

Daniel Kraus  writes:

> @Ihor, since this is the first patch I install from another contributor,
> is there anything I should look out for?

> E.g. does this need a TINYCHANGE entry or something?

1. General checks for tests passing and sanity of the patches
2. Ensuring copyright status, when total contributed nuber of LOC is
   around 15

See https://orgmode.org/worg/org-maintenance.html and
https://www.gnu.org/prep/maintain/   

Also, make sure that you are familiar with general contribution
guidelines listed at https://orgmode.org/worg/org-contribute.html

> Or do you have already copyright assignments filled out, Andreas and
> then it's not necessary?
> Can I see somewhere who I need to ask for copyright assignments or not?

We list all (well, most of) the past contributors and their copyright
assignment status at https://orgmode.org/worg/contributors.html

I also have a small hook for my Emacs mail client that automatically
checks the contributor status and number of contributed LOCs for Org
mailing list:
https://github.com/yantar92/emacs-config/blob/master/config.org#detect-fsf-contribution-status-of-sender-for-org-ml

Bastien has access to official FSF records. We need to ask him when
copyright assignment status cannot be determined from the Org
contributors page.

In this case, Andreas is not listed on
https://orgmode.org/worg/contributors.html
I also cannot find anything relevant in the mailing list archives.
(well, there is
https://orgmode.org/list/b664b5e8-b6a8-4b20-b0cb-f6149c720...@bundesbrandschatzamt.de,
but I do not see any confirmation of the copyright assignment status).

Bastien, could you please confirm the copyright status of Andreas Gerler?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] ob-sql sql-connection-alist

[Andreas Gerler]

Hi Daniel,

I already contributed to Orgmode a few years ago for Vertica support and filled 
the copyright assignment back then.

Andreas

> On Jan 20, 2023, at 9:47 PM, Daniel Kraus  wrote:
> 
> Thanks.
> 
> @Ihor, since this is the first patch I install from another contributor,
> is there anything I should look out for?
> 
> E.g. does this need a TINYCHANGE entry or something?
> Or do you have already copyright assignments filled out, Andreas and
> then it's not necessary?
> Can I see somewhere who I need to ask for copyright assignments or not?
> 
> Thanks,
>  Daniel
> 

Re: [BUG] ob-sql sql-connection-alist

[Daniel Kraus]

Thanks.

@Ihor, since this is the first patch I install from another contributor,
is there anything I should look out for?

E.g. does this need a TINYCHANGE entry or something?
Or do you have already copyright assignments filled out, Andreas and
then it's not necessary?
Can I see somewhere who I need to ask for copyright assignments or not?

Thanks,
  Daniel

Re: [BUG] ob-sql sql-connection-alist

[Andreas Gerler]

Sorry. That was the wrong patch.



0001-lisp-ob-sql.el-allow-string-in-sql-connection-alist.patch
Description: Binary data


> On 20. Jan 2023, at 18:24, Andreas Gerler  
> wrote:
> 
> <0001-lisp-ob-eval.el-Display-error-fix.patch>
> 
>> On 16. Jan 2023, at 11:25, Daniel Kraus  wrote:
>> 
>> Hi!
>> 
>> Andreas Gerler  writes:
>> 
>>> Last week I heard about using ob-sql with credentials stored in the 
>>> variable used by isql.
>>> However I had to modify ob-sql to get it actually working.
>>> Can somebody test the pach before I send in a commit?
>>> 
>>> #+begin_src sql :engine mysql :dbconnection testdb
>>> show tables;
>>> #+end_src
>> 
>> I actually use this feature daily.
>> You have to quote the dbconnection. So this works currently:
>> 
>>> #+begin_src sql :engine mysql :dbconnection 'testdb
>> 
>> but I would agree that not needing the quote makes sense.
>> And since `assoc-string` works with symbol and string (i.e. it's backwards 
>> compatible)
>> I would install the patch if you send it.
>> 
>>> I was considering writing another patch to map the sql-product to engine.
>>> That way we could get rid of another parameter in the src block.
>>> Opinions?
>> 
>> I agree. Specifying :engine when it's already in the connection-alist is 
>> unnecessary.
>> 
>> Thanks,
>> Daniel
> 



signature.asc
Description: Message signed with OpenPGP

Re: [BUG] ob-sql sql-connection-alist

[Andreas Gerler]

0001-lisp-ob-eval.el-Display-error-fix.patch
Description: Binary data


> On 16. Jan 2023, at 11:25, Daniel Kraus  wrote:
> 
> Hi!
> 
> Andreas Gerler  writes:
> 
>> Last week I heard about using ob-sql with credentials stored in the variable 
>> used by isql.
>> However I had to modify ob-sql to get it actually working.
>> Can somebody test the pach before I send in a commit?
>> 
>> #+begin_src sql :engine mysql :dbconnection testdb
>> show tables;
>> #+end_src
> 
> I actually use this feature daily.
> You have to quote the dbconnection. So this works currently:
> 
>> #+begin_src sql :engine mysql :dbconnection 'testdb
> 
> but I would agree that not needing the quote makes sense.
> And since `assoc-string` works with symbol and string (i.e. it's backwards 
> compatible)
> I would install the patch if you send it.
> 
>> I was considering writing another patch to map the sql-product to engine.
>> That way we could get rid of another parameter in the src block.
>> Opinions?
> 
> I agree. Specifying :engine when it's already in the connection-alist is 
> unnecessary.
> 
> Thanks,
>  Daniel



signature.asc
Description: Message signed with OpenPGP

Re: [BUG] ob-sql sql-connection-alist

[Ihor Radchenko]

Daniel Kraus  writes:

>> I am looking at the docstring of `sql-connection-alist':
>>
>> An alist of connection parameters for interacting with a SQL product.
>>  Each element of the alist is as follows:
>>
>>(CONNECTION \(SQL-VARIABLE VALUE) ...)
>>
>>  Where CONNECTION is a case-insensitive string identifying the
>>  connection, ...
>>
>> So, your "setq" example is incorrect: must use "testdb" instead of
>> `testdb' symbol.
>
> I'm not sure why but I also have the connection as a symbol in my
> `sql-connection-alist`.
> Looking in `sql.el` `(sql-connect)`, they also use
> `assoc-string` to receive the connection:
> https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el?h=ac2a6fc83fac6390892b068a830ebe0f22364e05#n4398
>
> So I think that change is good and supports both formats
> (same as `sql-connect`).

Agree. In fact, I missed "insensitive" part of the docstring, reading it
opposite.

Andreas, feel free to send a proper patch with commit message. But
please do not decrease the copyright years :)

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] ob-sql sql-connection-alist

[Daniel Kraus]

Ihor Radchenko  writes:

> Andreas Gerler  writes:

>> (setq sql-connection-alist
>>   '((testdb (sql-product 'mysql)
>> (sql-server "127.0.0.1")
>> (sql-user "mysql”)
>> (sql-port 3306)
>> (sql-password “foo")
>> (sql-database "mysql"
>
> I am looking at the docstring of `sql-connection-alist':
>
> An alist of connection parameters for interacting with a SQL product.
>  Each element of the alist is as follows:
>
>(CONNECTION \(SQL-VARIABLE VALUE) ...)
>
>  Where CONNECTION is a case-insensitive string identifying the
>  connection, ...
>
> So, your "setq" example is incorrect: must use "testdb" instead of
> `testdb' symbol.

I'm not sure why but I also have the connection as a symbol in my
`sql-connection-alist`.
Looking in `sql.el` `(sql-connect)`, they also use
`assoc-string` to receive the connection:
https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el?h=ac2a6fc83fac6390892b068a830ebe0f22364e05#n4398

So I think that change is good and supports both formats
(same as `sql-connect`).

Cheers,
  Daniel

Re: [BUG] ob-sql sql-connection-alist

[Ihor Radchenko]

Andreas Gerler  writes:

> Last week I heard about using ob-sql with credentials stored in the variable 
> used by isql.
> However I had to modify ob-sql to get it actually working.
> Can somebody test the pach before I send in a commit?
>
> #+begin_src sql :engine mysql :dbconnection testdb
> show tables;
> #+end_src
>
> (setq sql-connection-alist
>   '((testdb (sql-product 'mysql)
> (sql-server "127.0.0.1")
> (sql-user "mysql”)
> (sql-port 3306)
> (sql-password “foo")
> (sql-database "mysql"

I am looking at the docstring of `sql-connection-alist':

An alist of connection parameters for interacting with a SQL product.
 Each element of the alist is as follows:
 
   (CONNECTION \(SQL-VARIABLE VALUE) ...)
 
 Where CONNECTION is a case-insensitive string identifying the
 connection, ...

So, your "setq" example is incorrect: must use "testdb" instead of
`testdb' symbol.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] ob-sql sql-connection-alist

[Daniel Kraus]

Hi!

Andreas Gerler  writes:

> Last week I heard about using ob-sql with credentials stored in the variable 
> used by isql.
> However I had to modify ob-sql to get it actually working.
> Can somebody test the pach before I send in a commit?
>
> #+begin_src sql :engine mysql :dbconnection testdb
> show tables;
> #+end_src

I actually use this feature daily.
You have to quote the dbconnection. So this works currently:

> #+begin_src sql :engine mysql :dbconnection 'testdb

but I would agree that not needing the quote makes sense.
And since `assoc-string` works with symbol and string (i.e. it's backwards 
compatible)
I would install the patch if you send it.

> I was considering writing another patch to map the sql-product to engine.
> That way we could get rid of another parameter in the src block.
> Opinions?

I agree. Specifying :engine when it's already in the connection-alist is 
unnecessary.

Thanks,
  Daniel