Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ihor Radchenko]

Ihor Radchenko  writes:

> From 1efdf049475dfa9d4cdf219d665c4afcb32ed7cc Mon Sep 17 00:00:00 2001
> Message-Id: 
> <1efdf049475dfa9d4cdf219d665c4afcb32ed7cc.1664765817.git.yanta...@gmail.com>
> From: Ihor Radchenko 
> Date: Mon, 3 Oct 2022 10:55:33 +0800
> Subject: [PATCH] org-manual: Clarify `org-timer-start' command description

Applied onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=cce846e5f7a4900cc97d2c10b16abf3cf7f9056c

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ihor Radchenko]

Ypo  writes:

> Sorry for my delayed answer. But I don't see it either :/
>
> "The prompt will default to a timer string at
> +  point (if any),"
>
> I can't see it well related to the C-u prefix. For example why the "(if 
> any)"? It should be unnecessary, since it is the previous explained 
> general case.

I feel that you missed the context by reading only the diff in the commit.
The full text in the manual after applying the patch reads like:

- {{{kbd(C-c C-x 0)}}} (~org-timer-start~) ::

  #+kindex: C-c C-x 0
  #+findex: org-timer-start
  Start or reset the relative timer.  By default, the timer is set
  to 0.  When called with a {{{kbd(C-u)}}} prefix, prompt the user for
  a starting offset.  The prompt will default to a timer string at
  point (if any), providing a convenient way to restart taking notes
  after a break in the process.  When called with a double prefix
  argument {{{kbd(C-u C-u)}}}, change all timer strings in the active
  region by a certain amount.  This can be used to fix timer strings
  if the timer was not started at exactly the right moment.



-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ypo]

Sorry for my delayed answer. But I don't see it either :/

"The prompt will default to a timer string at
+  point (if any),"

I can't see it well related to the C-u prefix. For example why the "(if 
any)"? It should be unnecessary, since it is the previous explained 
general case.


Best regards


El 03/10/2022 a las 4:57, Ihor Radchenko escribió:

Ypo  writes:


Oh! Thanks

I didn't understand. Maybe this would be more understandable?:


   When called with a ‘C-u’ prefix, prompt the user for a starting
  offset or, if there is a timer string at point, this is taken as the
  default, ...

Or:


   When called with a ‘C-u’ prefix, there are 2 options: prompt the user for a 
starting
  offset.  Or, if there is a timer string at point, this is taken as the
  default, ...

Your versions still feel a bit confusing.
What about the attached patch?

Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ihor Radchenko]

Ypo  writes:

> Oh! Thanks
>
> I didn't understand. Maybe this would be more understandable?:
>
>>   When called with a ‘C-u’ prefix, prompt the user for a starting
>>  offset or, if there is a timer string at point, this is taken as the
>>  default, ...
> Or:
>
>>   When called with a ‘C-u’ prefix, there are 2 options: prompt the user for 
>> a starting
>>  offset.  Or, if there is a timer string at point, this is taken as the
>>  default, ...

Your versions still feel a bit confusing.
What about the attached patch?

>From 1efdf049475dfa9d4cdf219d665c4afcb32ed7cc Mon Sep 17 00:00:00 2001
Message-Id: <1efdf049475dfa9d4cdf219d665c4afcb32ed7cc.1664765817.git.yanta...@gmail.com>
From: Ihor Radchenko 
Date: Mon, 3 Oct 2022 10:55:33 +0800
Subject: [PATCH] org-manual: Clarify `org-timer-start' command description

* doc/org-manual.org (Taking Notes with a Relative Timer): Emphasize
that timer at point is only taken into account when called with prefix
argument.

Reported-by: Ypo 
Link: https://orgmode.org/list/ae3befcf-1f62-fc84-e63c-16cd45bba...@gmail.com
---
 doc/org-manual.org | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/doc/org-manual.org b/doc/org-manual.org
index d249f32d6..618feb5fd 100644
--- a/doc/org-manual.org
+++ b/doc/org-manual.org
@@ -7126,12 +7126,12 @@ ** Taking Notes with a Relative Timer
   #+findex: org-timer-start
   Start or reset the relative timer.  By default, the timer is set
   to 0.  When called with a {{{kbd(C-u)}}} prefix, prompt the user for
-  a starting offset.  If there is a timer string at point, this is
-  taken as the default, providing a convenient way to restart taking
-  notes after a break in the process.  When called with a double
-  prefix argument {{{kbd(C-u C-u)}}}, change all timer strings in the
-  active region by a certain amount.  This can be used to fix timer
-  strings if the timer was not started at exactly the right moment.
+  a starting offset.  The prompt will default to a timer string at
+  point (if any), providing a convenient way to restart taking notes
+  after a break in the process.  When called with a double prefix
+  argument {{{kbd(C-u C-u)}}}, change all timer strings in the active
+  region by a certain amount.  This can be used to fix timer strings
+  if the timer was not started at exactly the right moment.
 
 - {{{kbd(C-c C-x ;)}}} (~org-timer-set-timer~) ::
 
-- 
2.35.1



-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ypo]

Oh! Thanks

I didn't understand. Maybe this would be more understandable?:


  When called with a ‘C-u’ prefix, prompt the user for a starting
 offset or, if there is a timer string at point, this is taken as the
 default, ...

Or:


  When called with a ‘C-u’ prefix, there are 2 options: prompt the user for a 
starting
 offset.  Or, if there is a timer string at point, this is taken as the
 default, ...



El 02/10/2022 a las 15:37, Ihor Radchenko escribió:

Ypo  writes:


In the manual, it says:


C-c C-x 0 (|org-timer-start|)

 ... If there is a timer string at point, this is taken as the
 default, providing a convenient way to restart taking notes after
 a break in the process...
 https://orgmode.org/manual/Timers.html


I am trying it, but the timer starts at 0:00:00

You missed the previous sentence in the manual.

 When called with a ‘C-u’ prefix, prompt the user for a starting
 offset.  If there is a timer string at point, this is taken as the
 default, ...

The value at point is only taken into account with prefix argument.

Re: [BUG] org-timer-start doesn't seem to take the timer string at point [9.5.5 (release_9.5.5 @ z:/emacs-i686/share/emacs/28.2/lisp/org/)]

[Ihor Radchenko]

Ypo  writes:

> In the manual, it says:
>
>> C-c C-x 0 (|org-timer-start|)
>>
>> ... If there is a timer string at point, this is taken as the
>> default, providing a convenient way to restart taking notes after
>> a break in the process...
>> https://orgmode.org/manual/Timers.html
>>
>
> I am trying it, but the timer starts at 0:00:00

You missed the previous sentence in the manual.

When called with a ‘C-u’ prefix, prompt the user for a starting
offset.  If there is a timer string at point, this is taken as the
default, ...

The value at point is only taken into account with prefix argument.

-- 
Ihor Radchenko (yantar92),
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at