Re: [O] [PATCH] Synchronize slideshow exporters to ox-html changes.
Rick Frankel writes: > On Mon, Feb 25, 2013 at 10:22:54AM +0100, Nicolas Goaziou wrote: >> Hello, >> >> Rick Frankel writes: >> >> > This patch fixes a couple of bugs in the s5 exporter and brings both >> > exporters in-sync w/ the updates to ox-html (uppercase properties, and >> > HTML_CONTAINER_CLASS fix). >> > >> > Note that ox-deck has so many lines of change due to whitespace >> > cleanup (won't happen again :). > >> I have trouble applying this patch. Could you rebase it against current >> master and resend it? > > Attached. > > Also attached is a separate patch to cleanup the whitespace in > ox-deck. > >> Also, would you mind replacing in both files >> (+ (org-element-property :level headline) >> (plist-get info :headline-offset)) >> >> occurrences with: >> >> (org-export-get-relative-level headline info) > > Fix included. Applied. Thank you. Regards, -- Nicolas Goaziou
Re: [O] [PATCH] Synchronize slideshow exporters to ox-html changes.
Hi Rick, Rick Frankel writes: > Note that ox-deck has so many lines of change due to whitespace > cleanup (won't happen again :). It's better to make those whitespace changes into separate commits. Thanks! -- Bastien
Re: [O] [PATCH] Synchronize slideshow exporters to ox-html changes.
Nicolas Goaziou writes: > I have trouble applying this patch. Could you rebase it against current > master and resend it? If I may nitpick, Rick, please take care of using proper sentences in the change log: start with an uppercase letter, end with a full stop. Your patch will go into Emacs, and this is the Emacs policy. Otherwise Nicolas will have to fix typos in the change log... Thanks in advance for this! -- Bastien
Re: [O] [PATCH] Synchronize slideshow exporters to ox-html changes.
Hello, Rick Frankel writes: > This patch fixes a couple of bugs in the s5 exporter and brings both > exporters in-sync w/ the updates to ox-html (uppercase properties, and > HTML_CONTAINER_CLASS fix). > > Note that ox-deck has so many lines of change due to whitespace > cleanup (won't happen again :). I have trouble applying this patch. Could you rebase it against current master and resend it? Also, would you mind replacing in both files (+ (org-element-property :level headline) (plist-get info :headline-offset)) occurrences with: (org-export-get-relative-level headline info) Thank you. Regards, -- Nicolas Goaziou
