Re: [O] Bug: org-dblock-update regression in case of :maxlevel 0 [9.0.5 (9.0.5-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20170210/)]

[Nicolas Goaziou]

Hello,

Christoph LANGE  writes:

> I have a clocktable that looks as follows.  (Once more, I'll be happy to
> work this out as a minimum working example – later, don't have time
> right now.)
>
> #+BEGIN: clocktable :block 2017-W01 :maxlevel 0 :scope ("filename.org")
> :indent
>
> The output I got for this from an older Org version (9.0.something,
> definitely < 9.0.4) was:
>
>   | File | Headline | Time   |
>   |--+--+|
>   |  | ALL *Total time* | *1:00* |
>   |--+--+|
>   | filename.org | *File time*  | *1:00* |
>
> :maxlevel 1 would include level-1 headings _in_ this file, like this:
>
>   | File | Headline | Time   |
>   |--+--+|
>   |  | ALL *Total time* | *1:00* |
>   |--+--+|
>   | filename.org | *File time*  | *1:00* |
>   |  | Task 1   | 0:05   |
>   |  | Task 2   | 0:55   |
>
> where filename.org looks like
>
> * Task 1
> * Task 2
> ...
>
>> It sounds like a user error to me.
>
> Maybe the truth is that the handling of :maxlevel 0 was an undocumented
> feature?

I see. It makes sense. I just couldn't find it. Thanks for the
explanation. This is now fixed.

Regards,

-- 
Nicolas Goaziou

Re: [O] Bug: org-dblock-update regression in case of :maxlevel 0 [9.0.5 (9.0.5-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20170210/)]

[Christoph LANGE]

Hi Nicolas,

Nicolas Goaziou on 2017-02-13 16:46:
> I can reproduce the problem. However, I'm not sure to understand the
> meaning of ":maxlevel 0". Don't you mean ":maxlevel 1"?

I have a clocktable that looks as follows.  (Once more, I'll be happy to
work this out as a minimum working example – later, don't have time
right now.)

#+BEGIN: clocktable :block 2017-W01 :maxlevel 0 :scope ("filename.org")
:indent

The output I got for this from an older Org version (9.0.something,
definitely < 9.0.4) was:

  | File | Headline | Time   |
  |--+--+|
  |  | ALL *Total time* | *1:00* |
  |--+--+|
  | filename.org | *File time*  | *1:00* |

:maxlevel 1 would include level-1 headings _in_ this file, like this:

  | File | Headline | Time   |
  |--+--+|
  |  | ALL *Total time* | *1:00* |
  |--+--+|
  | filename.org | *File time*  | *1:00* |
  |  | Task 1   | 0:05   |
  |  | Task 2   | 0:55   |

where filename.org looks like

* Task 1
* Task 2
...

> It sounds like a user error to me.

Maybe the truth is that the handling of :maxlevel 0 was an undocumented
feature?

Cheers,

Christoph

-- 
Dr. Christoph Lange, Enterprise Information Systems Department
Applied Computer Science @ University of Bonn; Fraunhofer IAIS
http://langec.wordpress.com/about, Skype duke4701

Re: [O] Bug: org-dblock-update regression in case of :maxlevel 0 [9.0.5 (9.0.5-elpaplus @ c:/Users/clange/.emacs.d/elpa/org-plus-contrib-20170210/)]

[Nicolas Goaziou]

Hello,

Christoph LANGE  writes:

> I believe the following fix
>
> http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=ccf832e8317dbac7d3ac2b7dfbb515b1292a329c
>
> introduced a regression.  When I want to run org-dblock-update on a
> clocktable with :maxlevel 0 (I'll be happy to provide an example), it
> fails with
>
> Debugger entered--Lisp error: (wrong-type-argument wholenump -1)
>   make-string(-1 124)
>
> in org-clocktable-write-default, I think in
>
>  (make-string (1- (min maxlevel (or ntcol 100))) ?|)
>
> to be exact, because (1- maxlevel) is -1.

I can reproduce the problem. However, I'm not sure to understand the
meaning of ":maxlevel 0". Don't you mean ":maxlevel 1"?

It sounds like a user error to me.

Regards,

-- 
Nicolas Goaziou