Re: [O] Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

2016-05-22 Thread Nicolas Goaziou
Hello,

Alex  writes:

> Thank you for the fixes. However, the fix in 4914f89 does not work for
> me. When I run it (type backspace) in a graphical Emacs I get:
>
> user-error: This key has no function outside tables
>
> When I run it in a terminal Emacs the command is not rebound at all.
>
> Replacing [(del)] with (kbd "DEL") fixed the issue for me.

Done. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

2016-05-21 Thread Alex
Hello,

Nicolas Goaziou  writes:

> Hello,
>
> Alex G  writes:
>
>> Oh, it seems like backspace works fine in text modes like
>> fundamental-mode and message-mode, but not prog-derived modes. I'd say
>> that's another bug.
>>
>> A git bisect says that this commit by Bastien Guerry is the culprit:
>> f0a64ab3b5c46c8c7b1c838de2ed20511357e43d
>
> Fixed. Thank you.
>
> Regards,

Thank you for the fixes. However, the fix in 4914f89 does not work for
me. When I run it (type backspace) in a graphical Emacs I get:

user-error: This key has no function outside tables

When I run it in a terminal Emacs the command is not rebound at all.

Replacing [(del)] with (kbd "DEL") fixed the issue for me.



Re: [O] Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

2016-05-21 Thread Nicolas Goaziou
Hello,

Alex G  writes:

> Oh, it seems like backspace works fine in text modes like
> fundamental-mode and message-mode, but not prog-derived modes. I'd say
> that's another bug.
>
> A git bisect says that this commit by Bastien Guerry is the culprit:
> f0a64ab3b5c46c8c7b1c838de2ed20511357e43d

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou



Re: [O] Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

2016-05-20 Thread Alex
Alex G  writes:

>> > Backspace works as expected, however.
>> I'm afraid that as of org-20160516 on ELPA, backspace also does not
>> overwrite whitespace.
>
> Oh, it seems like backspace works fine in text modes like
> fundamental-mode and message-mode, but not prog-derived modes. I'd say
> that's another bug.
>
> A git bisect says that this commit by Bastien Guerry is the culprit:
> f0a64ab3b5c46c8c7b1c838de2ed20511357e43d
>
> Does anyone know why it also affects orgtbl-self-insert-command?

I believe I have figured out the issue for both problems:

a) orgtbl-self-insert-command wasn't updated along with
org-self-insert-command in the commit
73a5c27cc1751721344886e7518f20ff382265b5. Changing it accordingly fixes
the issue.


b) Backspace doesn't work in prog-derived modes as orgtbl-mode seems to
just remap delete-backward-char to orgtbl, but in prog modes backspace
is bound to backward-delete-char-untabify.

Perhaps something extra should be done about backspace in orgtbl-mode
instead of just a simple remapping?




Re: [O] Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

2016-05-20 Thread Nicolas Goaziou
Hello,

Alex  writes:

> As per the title, orgtbl-mode doesn't overwrite whitespace in tables
> like it does normally in org-mode.

Fixed. Thank you.


Regards,

-- 
Nicolas Goaziou



Re: [O] Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

2016-05-19 Thread Alex G
> > Backspace works as expected, however.
> I'm afraid that as of org-20160516 on ELPA, backspace also does not
> overwrite whitespace.


Oh, it seems like backspace works fine in text modes like
fundamental-mode and message-mode, but not prog-derived modes. I'd say
that's another bug.

A git bisect says that this commit by Bastien Guerry is the culprit:
f0a64ab3b5c46c8c7b1c838de2ed20511357e43d

Does anyone know why it also affects orgtbl-self-insert-command?


Re: [O] Bug: orgtbl-self-insert-command does not overwrite whitespace [8.3.4 (8.3.4-50-g83e373-elpa @ /home/alex/.emacs.d/elpa/org-20160509/)]

2016-05-18 Thread Alex
The following message is a courtesy copy of an article
that has been posted to gmane.emacs.orgmode as well.

> Backspace works as expected, however.
I'm afraid that as of org-20160516 on ELPA, backspace also does not
overwrite whitespace.