Re: [O] Icalendar export and contacts

[Nicolas Goaziou]

Hello,

Simon Thum  writes:

> Well, I had intended the link target to become visible but now that
> you ask, my primary concern was "not wrecking the export". I expect
> that tel links are only relevant to the vcard export, which handles
> them on its own terms (and which still works).
>
> So perhaps the patch is a bit premature. Any export function would
> need not to interfere with the vcard handling, which is why
> I refrained from adding one.

Since no one chimed in, I applied your patch. We'll see if something is
left to be done (e.g., defining a better export function).

Thank you.

Regards,

-- 
Nicolas Goaziou

Re: [O] Icalendar export and contacts

[Simon Thum]

Well, I had intended the link target to become visible but now that you 
ask, my primary concern was "not wrecking the export". I expect that tel 
links are only relevant to the vcard export, which handles them on its 
own terms (and which still works).


So perhaps the patch is a bit premature. Any export function would need 
not to interfere with the vcard handling, which is why I refrained from 
adding one.


Cheers,

Simon

On 02/20/2016 01:55 PM, Nicolas Goaziou wrote:

Hello,

Simon Thum  writes:


would the attached patch be enough?


Thank you. I do not maintain org-contact.el, tho.


+;; Add the link type supported by org-contacts-strip-link
+;; so everything is in order for its use in Org files
+(org-add-link-type "tel")


This means that no export function is defined for "tel" links. Is it the
intended behaviour?

Regards,

Re: [O] Icalendar export and contacts

[Nicolas Goaziou]

Hello,

Simon Thum  writes:

> would the attached patch be enough?

Thank you. I do not maintain org-contact.el, tho.

> +;; Add the link type supported by org-contacts-strip-link
> +;; so everything is in order for its use in Org files
> +(org-add-link-type "tel")

This means that no export function is defined for "tel" links. Is it the
intended behaviour?

Regards,

-- 
Nicolas Goaziou

Re: [O] Icalendar export and contacts

[Simon Thum]

Then let's just hope it got fixed by accident ;)

On 02/14/2016 05:49 PM, Nicolas Goaziou wrote:

Hello,

Simon Thum  writes:


Yes, but the exporter stalls on the [[fails]] link although it
resolves in org. Provided you're right the reasoning seems off.


I cannot reproduce it.

Regards,

Re: [O] Icalendar export and contacts

[Nicolas Goaziou]

Hello,

Simon Thum  writes:

> Yes, but the exporter stalls on the [[fails]] link although it
> resolves in org. Provided you're right the reasoning seems off.

I cannot reproduce it.

Regards,

-- 
Nicolas Goaziou

Re: [O] Icalendar export and contacts

[Simon Thum]

On 02/12/2016 11:43 PM, Nicolas Goaziou wrote:

Hello,

Simon Thum  writes:


I noticed one more strange thing:

the new exporter fails to resolve links to radio targets (which are
slightly pointless but worked before). I'm not sure it needs fixing,
just thought I'd let you know.

I.e. <<>>   <>

[[works]]
[[fails]]


It doesn't need to be fixed. Radio targets bring their own linking
mechanism.


Yes, but the exporter stalls on the [[fails]] link although it resolves 
in org. Provided you're right the reasoning seems off.


Cheers,

Simon

Re: [O] Icalendar export and contacts

[Simon Thum]

Hi,

would the attached patch be enough?

Cheers,

Simon

On 02/12/2016 11:41 PM, Nicolas Goaziou wrote:

Hello,

Simon Thum  writes:


do you refer to master, maint or something else? I'm on 8.3 but am
considering an upgrade.


Development version = master.


Also I think org-contacts should declare the link type if it has
support for it (in the vcard export). I'd be happy to do that if it
can be done as a TINYCHANGE.


org-contacts is in contrib/ directory. TINYCHANGE tag is not required.

Regards,

>From fe28fb1eec7b8435f2ce9d30853fc3df707149c4 Mon Sep 17 00:00:00 2001
From: Simon Thum 
Date: Sat, 13 Feb 2016 17:20:05 +0100
Subject: [PATCH] Register tel link from org-contacts

This has the added benefit of not screwing up the exporter.

Signed-off-by: Simon Thum 
---
 contrib/lisp/org-contacts.el | 5 +
 1 file changed, 5 insertions(+)

diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
index 3236a7c..1aa2cab 100644
--- a/contrib/lisp/org-contacts.el
+++ b/contrib/lisp/org-contacts.el
@@ -1113,6 +1113,11 @@ link string and return the pure link target."
 (setq colonpos (string-match ":" link))
 (if startpos (substring link (1+ colonpos)) link)
 
+;; Add the link type supported by org-contacts-strip-link
+;; so everything is in order for its use in Org files
+(org-add-link-type "tel")
+
+
 (defun org-contacts-split-property (string  separators omit-nulls)
   "Custom version of `split-string'.
 Split a property STRING into sub-strings bounded by matches
-- 
2.1.3

Re: [O] Icalendar export and contacts

[Simon Thum]

I noticed one more strange thing:

the new exporter fails to resolve links to radio targets (which are 
slightly pointless but worked before). I'm not sure it needs fixing, 
just thought I'd let you know.


I.e. <<>>   <>

[[works]]
[[fails]]

Cheers,

Simon

On 02/12/2016 12:01 AM, Nicolas Goaziou wrote:

Hello,

Simon Thum  writes:


Unfortunately I now get

user-error: Unable to resolve link "tel:xxx"

and the icalendar export full stops. Is there a way to declare the
link type (I am loading org-contact)


See `org-add-link-type' in particular with the export argument.


or avoid the exporter messing with it?


This is only possible in development version.

Regards,

Re: [O] Icalendar export and contacts

[Nicolas Goaziou]

Hello,

Simon Thum  writes:

> do you refer to master, maint or something else? I'm on 8.3 but am
> considering an upgrade.

Development version = master.

> Also I think org-contacts should declare the link type if it has
> support for it (in the vcard export). I'd be happy to do that if it
> can be done as a TINYCHANGE.

org-contacts is in contrib/ directory. TINYCHANGE tag is not required.

Regards,

-- 
Nicolas Goaziou

Re: [O] Icalendar export and contacts

[Nicolas Goaziou]

Hello,

Simon Thum  writes:

> I noticed one more strange thing:
>
> the new exporter fails to resolve links to radio targets (which are
> slightly pointless but worked before). I'm not sure it needs fixing,
> just thought I'd let you know.
>
> I.e. <<>>   <>
>
> [[works]]
> [[fails]]

It doesn't need to be fixed. Radio targets bring their own linking
mechanism.

Regards,

-- 
Nicolas Goaziou

Re: [O] Icalendar export and contacts

[Simon Thum]

Hi,

do you refer to master, maint or something else? I'm on 8.3 but am 
considering an upgrade.


Also I think org-contacts should declare the link type if it has support 
for it (in the vcard export). I'd be happy to do that if it can be done 
as a TINYCHANGE.


Cheers,

Simon

On 02/12/2016 12:01 AM, Nicolas Goaziou wrote:

Hello,

Simon Thum  writes:


Unfortunately I now get

user-error: Unable to resolve link "tel:xxx"

and the icalendar export full stops. Is there a way to declare the
link type (I am loading org-contact)


See `org-add-link-type' in particular with the export argument.


or avoid the exporter messing with it?


This is only possible in development version.

Regards,

Re: [O] Icalendar export and contacts

[Nicolas Goaziou]

Hello,

Simon Thum  writes:

> Unfortunately I now get
>
> user-error: Unable to resolve link "tel:xxx"
>
> and the icalendar export full stops. Is there a way to declare the
> link type (I am loading org-contact)

See `org-add-link-type' in particular with the export argument.

> or avoid the exporter messing with it?

This is only possible in development version.

Regards,

-- 
Nicolas Goaziou