Re: [O] Org-todo-yesterday broken?

2014-12-09 Thread Nicolas Goaziou
Hello,

Kyle Meyer k...@kyleam.com writes:

 I'd guess this is because org-use-effective-time is set to nil (based on
 this previous issue [1]).  Setting it to non-nil should work, but I
 think org-todo-yesterday and org-agenda-todo-yesterday should override
 this, as in the attached patch.

Applied. Thank you.


Regards,

-- 
Nicolas Goaziou



Re: [O] Org-todo-yesterday broken?

2014-12-07 Thread Kyle Meyer
Nikolay Kudryavtsev nikolay.kudryavt...@gmail.com wrote:
 org-todo-yesterday and org-agenda-todo-yesterday do not seem to work
 in all recent versions of org that I've tried.

I'd guess this is because org-use-effective-time is set to nil (based on
this previous issue [1]).  Setting it to non-nil should work, but I
think org-todo-yesterday and org-agenda-todo-yesterday should override
this, as in the attached patch.

From 10e5dfb5854473fa97b8299a0f059c233c349ef1 Mon Sep 17 00:00:00 2001
From: Kyle Meyer k...@kyleam.com
Date: Sun, 7 Dec 2014 19:21:42 -0500
Subject: [PATCH 1/1] org-todo-yesterday: Ignore org-use-effective-time

* lisp/org.el (org-todo-yesterday): Ignore global org-use-effective-time
value.

* lisp/org-agenda.el (org-agenda-todo-yesterday): Ignore global
org-use-effective-time value.

Otherwise, if org-use-effective-time being nil, org-extend-today-until
will not be considered, resulting in the current time being used instead
of 23:59 yesterday.

Reported-by: Nikolay Kudryavtsev nikolay.kudryavt...@gmail.com
http://permalink.gmane.org/gmane.emacs.orgmode/93224
---
 lisp/org-agenda.el | 3 ++-
 lisp/org.el| 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index b2e54e6..5990bbb 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -10143,7 +10143,8 @@ (defun org-agenda-todayp (date)
 (defun org-agenda-todo-yesterday (optional arg)
   Like `org-agenda-todo' but the time of change will be 23:59 of yesterday.
   (interactive P)
-  (let* ((hour (third (decode-time
+  (let* ((org-use-effective-time t)
+	 (hour (third (decode-time
(org-current-time
  (org-extend-today-until (1+ hour)))
 (org-agenda-todo arg)))
diff --git a/lisp/org.el b/lisp/org.el
index 142407c..22a0c17 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12469,7 +12469,8 @@ (defun org-todo-yesterday (optional arg)
   (interactive P)
   (if (eq major-mode 'org-agenda-mode)
   (apply 'org-agenda-todo-yesterday arg)
-(let* ((hour (third (decode-time
+(let* ((org-use-effective-time t)
+	   (hour (third (decode-time
 			 (org-current-time
 	   (org-extend-today-until (1+ hour)))
   (org-todo arg
-- 
2.1.3


[1] https://lists.gnu.org/archive/html/emacs-orgmode/2011-11/msg00320.html

-- 
Kyle