Re: [O] Re: [PATCH][ANN] org-html/org-odt

2011-03-21 Thread Jambunathan K

Hi,

> I see. Would you like to continue to receive bug reports based on
> byte-compilation, or should I just load the sources for now?
>

Just pushed a fix that nukes all the warnings that the byte-compiler was
generating.

Jambunathan K.



Re: [O] Re: [PATCH][ANN] org-html/org-odt

2011-03-21 Thread Christian Moe

Hi,

I see. Would you like to continue to receive bug reports based on 
byte-compilation, or should I just load the sources for now?


Yours,
Christian

On 3/21/11 2:31 PM, Jambunathan K wrote:


Hello Christian

Thanks for your first bug report. I have the habit of not using
byte-compilation.

The reason for the crash you have reported is that
`with-org-html-preserve-paragraph-state' is a macro and some of the
references to it preceded the definition. As a result the byte compiler
was mistaken in to thinking that this was a function.

Jambnathan K.


With a minimal Emacs as per the old instructions, and with one minor
change to your test file (`LaTeX:verbatim' -- I don't have dvipng
installed), I get this:


Debugger entered--Lisp error: (invalid-function
with-org-html-preserve-paragraph-state)
   with-org-html-preserve-paragraph-state(nil)
   byte-code("[...THIS LINE DIDN'T COPY-PASTE WELL... CHRISTIAN]
   org-do-export(nil nil nil nil nil nil)
   (let* ((org-parse-get-callback ...)
(org-export-html-special-string-regexps
org-export-odt-special-string-regexps)) (org-do-export arg hidden
ext-plist to-buffer body-only pub-dir))
   org-export-as-odt(nil)
   call-interactively(org-export-as-odt)
   org-export(nil)
   call-interactively(org-export nil nil)








Re: [O] Re: [PATCH][ANN] org-html/org-odt

2011-03-21 Thread Christian Moe

Hi,

I'd love to try it out, but I'm not good at git. Would someone be kind 
enough to post directions?


I thought this would do it:

git checkout 3d802
git checkout -b ooo
git apply 
../0001-Re-implement-org-export-as-html-and-add-support-for-.patch


But I got:

error: patch failed: lisp/org.el:8711
error: lisp/org.el: patch does not apply

Yours,
Christian


On 3/21/11 9:21 AM, Bastien wrote:

Hi Jambunathan,

Jambunathan K  writes:


This is a formal request to integrate my org-html.el&  org-odt.el
changes in to the master branch.


Thanks a *LOT* for this work!  I'm willing to help as much as possible
to get this integrated.


This patch introduces 3 major features:
1. A generic exporter


Let me understand: this is more a generalization of the HTML export than
a true generic exporter, right?  The docstring of org-do-export suggests
so.  Rewriting org-html.el so that the HTML export is done in a more
generic way is a *good* thing, but we should be careful with the naming
of the functions here.


2. All new html backend re-implemented as a plugin to (1).
3. A odt backend as a plugin to (1).


This makes sense.


The patch is based on git commit 3d802.


Please everyone test it and report any problem.  I was kept away from
Org due to personal issues the last week, but I'm available again.

All best,