Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict
Bastien writes: > Hi Jack, > > Jack Kamm writes: > >> Thanks Bastien, the Woof! tool looks interesting. > > Thanks! I'm working on a small woof.el package to make it more > useful for both maintainers (setting headers) and users (checking > upcoming changes or help requests). > This is great and helpful! Thanks Bastien. >> By the way, on seeing this thread again, I realized this patch >> probably should have been applied to the maint branch. So I've cherry >> picked it into there, and merged back into master. > > Thanks for this! -- [ stardiviner ] I try to make every word tell the meaning that I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict
Hi Jack, Jack Kamm writes: > Thanks Bastien, the Woof! tool looks interesting. Thanks! I'm working on a small woof.el package to make it more useful for both maintainers (setting headers) and users (checking upcoming changes or help requests). > By the way, on seeing this thread again, I realized this patch > probably should have been applied to the maint branch. So I've cherry > picked it into there, and merged back into master. Thanks for this! -- Bastien
Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict
Thanks Bastien, the Woof! tool looks interesting. By the way, on seeing this thread again, I realized this patch probably should have been applied to the maint branch. So I've cherry picked it into there, and merged back into master. Bastien writes: > Hi Jack and Adrian, > > Jack Kamm writes: > >> Adrian Kummerländer writes: >> >>> I noticed that after updating to Org 9.4 many of my Python-based Org >>> files fail to execute with various `io.TextIOWrapper' related error >>> messages. The reason for this is that opening the exec tmpfile as `f' >>> shadows this possibly user-defined variable. >>> >>> The attached patch fixes this problem for me. As this is my first >>> time contributing to Org I am especially open for any suggestions! >> >> The patch looks good. I've pushed it to master, after making a couple >> minor fixes to the commit message (adding a TINYCHANGE cookie and >> adjusting some of the spacing). > > Thanks for applying the patch, I'm marking it as "applied" through > Woof! adding "X-Woof-Patch: applied" in the headers. > > Best, > > -- > Bastien
Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict
Hi Jack and Adrian, Jack Kamm writes: > Adrian Kummerländer writes: > >> I noticed that after updating to Org 9.4 many of my Python-based Org >> files fail to execute with various `io.TextIOWrapper' related error >> messages. The reason for this is that opening the exec tmpfile as `f' >> shadows this possibly user-defined variable. >> >> The attached patch fixes this problem for me. As this is my first >> time contributing to Org I am especially open for any suggestions! > > The patch looks good. I've pushed it to master, after making a couple > minor fixes to the commit message (adding a TINYCHANGE cookie and > adjusting some of the spacing). Thanks for applying the patch, I'm marking it as "applied" through Woof! adding "X-Woof-Patch: applied" in the headers. Best, -- Bastien
Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict
Hi Adrian, Adrian Kummerländer writes: > I noticed that after updating to Org 9.4 many of my Python-based Org > files fail to execute with various `io.TextIOWrapper' related error > messages. The reason for this is that opening the exec tmpfile as `f' > shadows this possibly user-defined variable. > > The attached patch fixes this problem for me. As this is my first > time contributing to Org I am especially open for any suggestions! The patch looks good. I've pushed it to master, after making a couple minor fixes to the commit message (adding a TINYCHANGE cookie and adjusting some of the spacing). Thanks for your contribution! Jack
