bug#41584: 26.3; org-indent-mode's line-prefix text property flickers near overlays
> From: Kévin Le Gouguec > Cc: 41584-d...@debbugs.gnu.org, dgu...@yandex.ru > Date: Fri, 29 May 2020 22:32:11 +0200 > > (I guess xdisp.c is something we won't to touch with a 10-foot pole on > the release branch, especially for a bug that users have lived with for > so long?) Exactly.
bug#41584: 26.3; org-indent-mode's line-prefix text property flickers near overlays
Eli Zaretskii writes: > Fixed. AFAICT you've scared the moles away, so I'll boldly close this report. Thanks a lot for the efficient whacking! (I guess xdisp.c is something we won't to touch with a 10-foot pole on the release branch, especially for a bug that users have lived with for so long?)
bug#41584: 26.3; org-indent-mode's line-prefix text property flickers near overlays
> From: Kévin Le Gouguec > Cc: 41...@debbugs.gnu.org, dgu...@yandex.ru > Date: Fri, 29 May 2020 20:11:40 +0200 > > This time, instead of hitting RET, insert a pair of parentheses, and > wait blink-matching-delay seconds until the opening parenthesis stops > being highlighted. Before and after your fix, the line-prefix > disappears until I enter another command. Fixed.
bug#41584: 26.3; org-indent-mode's line-prefix text property flickers near overlays
Eli Zaretskii writes: > Should be fixed now on the master branch. Thanks a lot! I'm sorry I didn't notice it earlier, but I may have found another mole for you to whack; starting with the same recipe: > - emacs -Q > - C-x C-f repro.org > - M-x org-indent-mode > - M-: (insert "* heading\ntext") > - M-: > (let ((ov (make-overlay (point-at-bol) (point-at-bol))) > (val (propertize " " 'display '((left-fringe right-triangle) > (overlay-put ov 'before-string val)) This time, instead of hitting RET, insert a pair of parentheses, and wait blink-matching-delay seconds until the opening parenthesis stops being highlighted. Before and after your fix, the line-prefix disappears until I enter another command.
bug#41584: 26.3; org-indent-mode's line-prefix text property flickers near overlays
> Date: Fri, 29 May 2020 10:12:27 +0300 > From: Eli Zaretskii > Cc: 41...@debbugs.gnu.org, dgu...@yandex.ru > > In fact, it's enough to type "M-x". Which is a clear sign that some > redisplay optimization kicks in where it shouldn't. And indeed, > setting inhibit-try-window-id non-nil solves the problem. > > I will look into this when I have time, thanks for an easy reproducer. Should be fixed now on the master branch.
Re: bug#41584: 26.3; org-indent-mode's line-prefix text property flickers near overlays
> From: Kévin Le Gouguec
> Date: Thu, 28 May 2020 21:54:09 +0200
> Cc: emacs-orgmode@gnu.org, Dmitry Gutov
>
> - emacs -Q
> - C-x C-f repro.org
> - M-x org-indent-mode
> - M-: (insert "* heading\ntext")
> - M-:
> (let ((ov (make-overlay (point-at-bol) (point-at-bol)))
> (val (propertize " " 'display '((left-fringe right-triangle)
> (overlay-put ov 'before-string val))
> - RET
> - a
>
> When "a" is inserted, org-indent-mode's line-prefix disappears on the
> *previous* line ("text"). It remains gone as long as I type
> self-inserting characters, until
>
> - I type certain commands, e.g. RET or C-j, or
>
> - I insert a closing delimiter that makes
> blink-paren-post-self-insert-function blink the corresponding opening
> delimiter, e.g. ')' or ']'.
>
> Then the line-prefix shows up again.
In fact, it's enough to type "M-x". Which is a clear sign that some
redisplay optimization kicks in where it shouldn't. And indeed,
setting inhibit-try-window-id non-nil solves the problem.
I will look into this when I have time, thanks for an easy reproducer.
