Re: org-cite: how to force a reparsing of the .bib file

[Leo Butler]

On Thu, Aug 24 2023, Ihor Radchenko  wrote:

> Leo Butler  writes:
>
>>> Does the attached patch fix the problem?
>>
>> ...
>> To avoid an unneeded setq, I applied the patch:
>>
>>   (dolist (file (mapcar #'file-truename 
>> (org-cite-list-bibliography-files)))
>
> This would create an extra list and increase GC pressure. So, I prefer setq.
>
>> This caused the bibtex file to be re-parsed when I changed it.
>
> Thanks for testing!
> Applied.
> Fixed, on main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3c3db7b33

Thanks, Ihor.
Leo

Re: org-cite: how to force a reparsing of the .bib file

[Ihor Radchenko]

Leo Butler  writes:

>> Does the attached patch fix the problem?
>
> ...
> To avoid an unneeded setq, I applied the patch:
>
>   (dolist (file (mapcar #'file-truename 
> (org-cite-list-bibliography-files)))

This would create an extra list and increase GC pressure. So, I prefer setq.

> This caused the bibtex file to be re-parsed when I changed it.

Thanks for testing!
Applied.
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3c3db7b33

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: org-cite: how to force a reparsing of the .bib file

[Leo Butler]

On Wed, Aug 23 2023, Ihor Radchenko  wrote:

> Leo Butler  writes:
>
>> Does org-cite monitor contents or the timestamp?
>> I am using a symlink to the bib file.
>
> Timestamp.
>
> Does the attached patch fix the problem?

Thanks, Ihor.

To avoid an unneeded setq, I applied the patch:

  (dolist (file (mapcar #'file-truename (org-cite-list-bibliography-files)))

This caused the bibtex file to be re-parsed when I changed it.

Best,
Leo

>
> From 39b503301fc7a3ea68733dfd9e4391e3f84efec8 Mon Sep 17 00:00:00 2001
> Message-ID: 
> <39b503301fc7a3ea68733dfd9e4391e3f84efec8.1692781998.git.yanta...@posteo.net>
> From: Ihor Radchenko 
> Date: Wed, 23 Aug 2023 12:12:13 +0300
> Subject: [PATCH] oc-basic: Fix detecting changes in symlinked bibliography
>
> * lisp/oc-basic.el (org-cite-basic--parse-bibliography): Use
> `file-truename' to follow symlinks first before checking bibliography
> file change times.
>
> Reported-by: Leo Butler 
> Link: https://orgmode.org/list/877cpmkds1@t14.reltub.ca
> ---
>  lisp/oc-basic.el | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el
> index 84d9492ea..c4468e5a8 100644
> --- a/lisp/oc-basic.el
> +++ b/lisp/oc-basic.el
> @@ -272,6 +272,9 @@ (defun org-cite-basic--parse-bibliography ( info)
>(plist-get info :cite-basic/bibliography)
>  (let ((results nil))
>(dolist (file (org-cite-list-bibliography-files))
> +;; Follow symlinks, to look into modification time of the
> +;; actual file, not its symlink.
> +(setq file (file-truename file))
>  (when (file-readable-p file)
>(with-temp-buffer
>  (when (or (org-file-has-changed-p file)
> -- 
> 2.41.0

Re: org-cite: how to force a reparsing of the .bib file

[Ihor Radchenko]

Leo Butler  writes:

> Does org-cite monitor contents or the timestamp?
> I am using a symlink to the bib file.

Timestamp.

Does the attached patch fix the problem?

>From 39b503301fc7a3ea68733dfd9e4391e3f84efec8 Mon Sep 17 00:00:00 2001
Message-ID: <39b503301fc7a3ea68733dfd9e4391e3f84efec8.1692781998.git.yanta...@posteo.net>
From: Ihor Radchenko 
Date: Wed, 23 Aug 2023 12:12:13 +0300
Subject: [PATCH] oc-basic: Fix detecting changes in symlinked bibliography

* lisp/oc-basic.el (org-cite-basic--parse-bibliography): Use
`file-truename' to follow symlinks first before checking bibliography
file change times.

Reported-by: Leo Butler 
Link: https://orgmode.org/list/877cpmkds1@t14.reltub.ca
---
 lisp/oc-basic.el | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el
index 84d9492ea..c4468e5a8 100644
--- a/lisp/oc-basic.el
+++ b/lisp/oc-basic.el
@@ -272,6 +272,9 @@ (defun org-cite-basic--parse-bibliography ( info)
   (plist-get info :cite-basic/bibliography)
 (let ((results nil))
   (dolist (file (org-cite-list-bibliography-files))
+;; Follow symlinks, to look into modification time of the
+;; actual file, not its symlink.
+(setq file (file-truename file))
 (when (file-readable-p file)
   (with-temp-buffer
 (when (or (org-file-has-changed-p file)
-- 
2.41.0



-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: org-cite: how to force a reparsing of the .bib file

[Leo Butler]

On Tue, Aug 22 2023, Ihor Radchenko  wrote:

> Leo Butler  writes:
>
>> I am struggling with org-cite at the moment. One problem: it is not
>> re-parsing my .bib file, so it is not picking up changes. How can I
>> force it to pick up changes?
>
> Please, provide more details.
> org-cite should already monitor .bib file contents and re-parse it as
> necessary.

Does org-cite monitor contents or the timestamp?
I am using a symlink to the bib file.

Leo

Re: org-cite: how to force a reparsing of the .bib file

[Ihor Radchenko]

Leo Butler  writes:

> I am struggling with org-cite at the moment. One problem: it is not
> re-parsing my .bib file, so it is not picking up changes. How can I
> force it to pick up changes?

Please, provide more details.
org-cite should already monitor .bib file contents and re-parse it as
necessary.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

org-cite: how to force a reparsing of the .bib file

[Leo Butler]

Hello,

I am struggling with org-cite at the moment. One problem: it is not
re-parsing my .bib file, so it is not picking up changes. How can I
force it to pick up changes?

TIA,
Leo

ps: (insert (format "\n%s\nOrg: %s" (emacs-version) (org-version)))
GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo 
version 1.16.0)
 of 2023-05-13, modified by Debian
Org: 9.6.7