Re: Skipping a generic comment backwards

2006-05-01 Thread martin rudalics

 BTW, your tiny contributions are beginning to accumulate, so you should
 seriously consider signing some paperwork, otherwise we soon won't be able
 to accept your patches any more.

Thanks for asking.  I signed them a couple of months ago.

There's yet another bug in forward-comment: When a generic comment is at
the beginning of a buffer I can't skip it backwards as `forward_comment'
checks whether `from' equals `stop' _before_ investigating whether the
character at `from' is a comment fence.

The attached patch should fix this by inverting the order of these
tests.

martin, who regrets the inconvenience
2006-05-01  Martin Rudalics  [EMAIL PROTECTED]

* syntax.c (Fforward_comment): Detect generic comment at beginning of
buffer when moving backwards.


*** syntax.cMon May  1 10:08:58 2006
--- syntax.cMon May  1 10:13:46 2006
***
*** 2123,2130 
  while (1)
{
  DEC_BOTH (from, from_byte);
- if (from == stop)
-   break;
  UPDATE_SYNTAX_TABLE_BACKWARD (from);
  c = FETCH_CHAR (from_byte);
  if (SYNTAX (c) == Scomment_fence
--- 2123,2128 
***
*** 2133,2138 
--- 2131,2138 
  found = 1;
  break;
}
+ else if (from == stop)
+   break;
}
  if (found == 0)
{
___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Skipping a generic comment backwards

2006-05-01 Thread Stefan Monnier
 The attached patch should fix this by inverting the order of these tests.

Thanks installed,


Stefan who's gone through the same kind of thing a few years back,
but obviously didn't test the generic-comment part of the
code


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


More safe local variables

2006-05-01 Thread Bill Wohler
Emacs complained about these local variables after a fresh update (it's
been a couple of weeks):

;; no-byte-compile: t
;; indent-tabs-mode: nil

I thought these had been made safe.

-- 
Bill Wohler [EMAIL PROTECTED]  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


doc string for next-history-element is incorrect

2006-05-01 Thread Drew Adams
The Emacs-Lisp manual doc for next-history-element and
previous-history-element is correct:

  This command replaces the minibuffer contents with the value of the
 Nth more recent history element.

The doc string is, however, incorrect:

  Insert the next element of the minibuffer history into the minibuffer.

Two things are wrong: 1) replaces vs insert, 2) Nth recent vs
next. Wrt #2, the prefix argument should be mentioned.


In GNU Emacs 22.0.50.1 (i386-mingw-nt5.1.2600)
 of 2006-03-20 on W2ONE
X server distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --cflags -Id:/g/include'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Info

Minor modes in effect:
  encoded-kbd-mode: t
  tooltip-mode: t
  auto-compression-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  line-number-mode: t

Recent input:
down-mouse-1 mouse-1 C-h i help-echo help-echo 
help-echo help-echo help-echo help-echo down-mouse-1 
mouse-2 help-echo s n e x t - h i s t o r y - e 
l e m e n t return s return s return left left 
C-h f return help-echo help-echo help-echo 
help-echo help-echo help-echo help-echo help-echo 
help-echo help-echo menu-bar help-menu re
port-emacs-bug

Recent messages:
Loading dired...done
Loading info...
Loading easymenu...done
Loading info...done
Composing main Info directory...done
Searching subfile elisp-2...
Searching subfile elisp-3...
Loading help-fns...done
Type C-x 1 to remove help window.  
Loading emacsbug...done



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug