Re: Can't put cursor after wrapped overlay string with `cursor' property

2006-06-02 Thread YAMAMOTO Mitsuharu
 On Mon, 29 May 2006 09:54:24 +0900, YAMAMOTO Mitsuharu [EMAIL 
 PROTECTED] said:

 But now I see some strange behavior if the overlay is placed at the
 end of line.

 emacs -Q -D
 (setq overlay (make-overlay 1 1))
 (setq str (make-string 100 ?a))
 (overlay-put overlay 'before-string str)
 M-
 RET
 C-p  -- The cursor at the previous position doesn't get erased.
 C-l  -- The cursor is displayed at the vertical center position.

The following change seems to work for me.  Could someone check if
this is correct?

 YAMAMOTO Mitsuharu
[EMAIL PROTECTED]

Index: src/xdisp.c
===
RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
retrieving revision 1.1101
diff -c -r1.1101 xdisp.c
*** src/xdisp.c 28 May 2006 20:19:07 -  1.1101
--- src/xdisp.c 2 Jun 2006 08:00:17 -
***
*** 11777,11783 
  
/* If we reached the end of the line, and end was from a string,
 cursor is not on this line.  */
!   if (glyph == end)
return 0;
  }
  
--- 11779,11785 
  
/* If we reached the end of the line, and end was from a string,
 cursor is not on this line.  */
!   if (glyph == end  row-continued_p)
return 0;
  }
  


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Can't display help-echo in overlay string with composition.

2006-06-02 Thread YAMAMOTO Mitsuharu
 On Wed, 31 May 2006 12:13:52 +0900 (JST), YAMAMOTO Mitsuharu [EMAIL 
 PROTECTED] said:

 Arg out of range 0,0 repeatedly occurs when trying to display
 help-echo string in an overlay string with composition.

  1. emacs -Q -D
  2. (overlay-put (make-overlay 1 1) 'before-string
  (propertize (compose-string ab) 'help-echo ab))
  3. Move the mouse pointer to the beginning of buffer.

The following change seems to work for me.  Could someone check if
this is correct?

 YAMAMOTO Mitsuharu
[EMAIL PROTECTED]

Index: src/xdisp.c
===
RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
retrieving revision 1.1101
diff -c -r1.1101 xdisp.c
*** src/xdisp.c 28 May 2006 20:19:07 -  1.1101
--- src/xdisp.c 2 Jun 2006 08:00:17 -
***
*** 6238,6243 
--- 6238,6245 
it-position = (STRINGP (it-string)
  ? it-current.string_pos
  : it-current.pos);
+   if (STRINGP (it-string))
+ it-object = it-string;
return 1;
  }
  


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Can't display help-echo in overlay string with composition.

2006-06-02 Thread Kim F. Storm
YAMAMOTO Mitsuharu [EMAIL PROTECTED] writes:

 On Wed, 31 May 2006 12:13:52 +0900 (JST), YAMAMOTO Mitsuharu [EMAIL 
 PROTECTED] said:

 Arg out of range 0,0 repeatedly occurs when trying to display
 help-echo string in an overlay string with composition.

  1. emacs -Q -D
  2. (overlay-put (make-overlay 1 1) 'before-string
  (propertize (compose-string ab) 'help-echo ab))
  3. Move the mouse pointer to the beginning of buffer.

 The following change seems to work for me.  Could someone check if
 this is correct?

Looks like the right thing to do.  Pls. install.

Thanks for debugging this.



YAMAMOTO Mitsuharu
   [EMAIL PROTECTED]

 Index: src/xdisp.c
 ===
 RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
 retrieving revision 1.1101
 diff -c -r1.1101 xdisp.c
 *** src/xdisp.c   28 May 2006 20:19:07 -  1.1101
 --- src/xdisp.c   2 Jun 2006 08:00:17 -
 ***
 *** 6238,6243 
 --- 6238,6245 
 it-position = (STRINGP (it-string)
 ? it-current.string_pos
 : it-current.pos);
 +   if (STRINGP (it-string))
 + it-object = it-string;
 return 1;
   }

-- 
Kim F. Storm [EMAIL PROTECTED] http://www.cua.dk



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Can't put cursor after wrapped overlay string with `cursor' property

2006-06-02 Thread Kim F. Storm
YAMAMOTO Mitsuharu [EMAIL PROTECTED] writes:

 On Mon, 29 May 2006 09:54:24 +0900, YAMAMOTO Mitsuharu [EMAIL 
 PROTECTED] said:

 But now I see some strange behavior if the overlay is placed at the
 end of line.

 emacs -Q -D
 (setq overlay (make-overlay 1 1))
 (setq str (make-string 100 ?a))
 (overlay-put overlay 'before-string str)
 M-
 RET
 C-p  -- The cursor at the previous position doesn't get erased.
 C-l  -- The cursor is displayed at the vertical center position.

 The following change seems to work for me.  Could someone check if
 this is correct?

Yes, this is a good change.  Please install.

Thanks for debugging this.



YAMAMOTO Mitsuharu
   [EMAIL PROTECTED]

 Index: src/xdisp.c
 ===
 RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
 retrieving revision 1.1101
 diff -c -r1.1101 xdisp.c
 *** src/xdisp.c   28 May 2006 20:19:07 -  1.1101
 --- src/xdisp.c   2 Jun 2006 08:00:17 -
 ***
 *** 11777,11783 
   
 /* If we reached the end of the line, and end was from a string,
cursor is not on this line.  */
 !   if (glyph == end)
   return 0;
   }
   
 --- 11779,11785 
   
 /* If we reached the end of the line, and end was from a string,
cursor is not on this line.  */
 !   if (glyph == end  row-continued_p)
   return 0;
   }

-- 
Kim F. Storm [EMAIL PROTECTED] http://www.cua.dk



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: bug in dired-do-query-replace-regexp (fix included)

2006-06-02 Thread David Wallin
Hi Juri,

The problem was in highlight-completion mode
(http://www.math.washington.edu/~palmieri/Emacs/hlc.html), and not in emacs.

I sent a fix to the author.

thanks,

--david.


At Fri, 02 Jun 2006 02:32:27 +0300,
Juri Linkov [EMAIL PROTECTED] wrote:
 
  Please describe exactly what actions triggered the bug
  and the precise symptoms of the bug:
 
  'Q' in dired doesn't work.
 
 Could you describe exactly what a problem do you have.  I don't see any.
 
  It seems like the culprit is that `query-replace-read-args' is called
  with too many args.
 
 After removing the arg `noerror' from `query-replace-read-args'
 typing `Q' in dired immediately fails with the error
 Buffer is read-only.
 
 -- 
 Juri Linkov
 http://www.jurta.org/emacs/
 


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Scrollbars ?

2006-06-02 Thread Stephan Hennig
Stephan Hennig schrieb:

 Symptoms:
 (i) While dragging the scrollbar and scrolling down slowly the window
 content wobbles vertically. This can be best seen when reaching the end
 of the file.

This bug could be related to item (iii) since when clicking (and
holding) the scrollbar handle the window contents already moves one line
down. This could be the reason for wrong calculations during dragging
the handle. However, when not moving the handle at all -- just clicking
it and releasing -- the handle only moves up after releasing. That is,

(a) clicking (and holding) the handle moves the window contents one line
down,

(b) optional: when dragging the handle there are display quirks,

(c) releasing the handle moves the handle up.

Maybe item (i) from my original bug report disappears when items (iii)
and (iv) are solved?

Regards,
Stephan Hennig

 (iii) Then clicking on the scrollbar causes the bar to shift up every
 time you click.



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Elisp manual node Future Local Variables

2006-06-02 Thread Richard Stallman
Why is this node in the manual? What is the point of mentioning
possible future anythings? I really don't understand this.

To ask people if they want these features.

I don't think anyone has said he wants them.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Scrollbars ?

2006-06-02 Thread Richard Stallman
 I clicked the scrollbar handle on the right of Emacs' frame.
 
 What button did you click?  And where?

Sorry, I do not seem to get your question. But I made some screen shots
to illustrate my original bug report.

Which mouse button did you click?  They have different effects.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Scrollbars ?

2006-06-02 Thread Richard Stallman
(a) clicking (and holding) the handle moves the window contents one line
down,

(b) optional: when dragging the handle there are display quirks,

(c) releasing the handle moves the handle up.

Are you using a mouse button which ought to drag the handle?  If so, I
think we see two bugs here.  (a) is a bug and (c) is a bug.

If you can develop a precise test case, and report it in a single
self-contained message to emacs-devel, someone will debug it.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


RE: Elisp manual node Future Local Variables

2006-06-02 Thread Drew Adams
Why is this node in the manual? What is the point of mentioning
possible future anythings? I really don't understand this.

To ask people if they want these features.
I don't think anyone has said he wants them.

I'm not for or against these particular features. I think it's inappropriate
to place this kind of thing in the user manual. There are other ways to ask
for input from users, and there is no reason to single out this or that
particular potential feature for mention in the doc (or is there?).
Technical doc usually tries to avoid mentioning what might or might not be
done in the future.

Apparently, this has been in the manual for almost a decade. Adding stuff
like this to the doc tends to pollute it with wannabe and hasbeen info that
can be confusing to users of the latest version. It seldom gets weeded out
because people lose track of what it was for.

It's better to put this kind of thing on a Web site (e.g. a wiki) or in a
list of stuff to be discussed by a mailing list. Or, a list of such
possibilities could be delivered _as such_ to users, along with Emacs (e.g.
in directory etc or made available via a Help menu). If we want to solicit
user input on particular questions, let's do so explicitly, not via stuff
that's buried in the manual.



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Regexp compiler, problem with character classes

2006-06-02 Thread Johan Bockgård

Character classes are translated to character alternatives during the
regexp compile phase. This is wrong, since the syntax table should be
taken into account during the actual matching. This may be non-trivial
to fix.


(with-temp-buffer
  (list
   (progn (modify-syntax-entry ?a  )
  (string-match x[[:space:]] xa))
   (progn (modify-syntax-entry ?a w)
  (string-match x[[:space:]] xa
= (0 0)



0:  /exactn/1/x
3:  /charset [\t\f a\302\200-\303\277]
37: /succeed
38: end of pattern.

Compiling pattern: x[[:space:]]

Compiled pattern: 
38 bytes used/174 bytes allocated.
fastmap: x
re_nsub: 0  regs_alloc: 0   can_be_null: 0  no_sub: 0   not_bol: 0  
not_eol: 0  syntax: 340204
0:  /exactn/1/x
3:  /charset [\t\f a\302\200-\303\277]
37: /succeed
38: end of pattern.
0:  /exactn/1/x
3:  /charset [\t\f a\302\200-\303\277]
37: /succeed
38: end of pattern.



As an effect you get the behavior below, since the compiler takes
no care to setup the syntax in the first place:


1)

emacs -Q

(with-temp-buffer
  (string-match x[[:space:]] x\n))
= nil

(exit Emacs)

2)
emacs -Q

(with-temp-buffer
  (char-syntax ?\n)
  (string-match x[[:space:]] x\n))
= 0

(Fchar_syntax does
gl_state.current_syntax_table = current_buffer-syntax_table;)


-- 
Johan Bockgård


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug