Re: emacs-lisp/cl.el (pushnew): void-variable x

2006-09-12 Thread Miles Bader
BTW, the previous patch is against my personal branch, which predates
Richard's changes to pushnew (so to see the effect you'll have to revert
those changes too).

-miles

-- 
`Suppose Korea goes to the World Cup final against Japan and wins,' Moon said.
`All the past could be forgiven.'   [NYT]


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: missing sit-for

2006-09-12 Thread Andreas Roehler

Richard Stallman schrieb:

However, as I had a calendar.el in my path, from here
resorts an error now:

Symbol's value as variable is void: facemenu-unlisted-faces

Are you saying this was caused by a spurious file?
That would mean that we don't have a bug in Emacs, right?

  

 `calendar.el' from cvs-source seems ok.

Kept an old variant, because I changed something in
order to have german names:

(defvar calendar-day-name-array
 [Sonntag Montag Dienstag Mittwoch Donnerstag Freitag 
Samstag]

   Array of capitalized strings giving, in order, the day names.)

instead of

;;(defvar calendar-day-name-array
;;  [Sunday Monday Tuesday Wednesday Thursday Friday Saturday]
;;  Array of capitalized strings giving, in order, the day names.)

and

(defvar calendar-month-name-array
 [Januar Februar März April Mai Juni Juli August
  September Oktober November Dezember]
 Array of capitalized strings giving, in order, the month names.)


instead of

;;(defvar calendar-month-name-array
;;  [January February March April   May  June
;;   JulyAugust   September October November December]
;;  Array of capitalized strings giving, in order, the month names.)



Probably there are better ways to do that.

Thanks!

__
Andreas Roehler


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: emacs-lisp/cl.el (pushnew): void-variable x

2006-09-12 Thread Kim F. Storm
Miles Bader [EMAIL PROTECTED] writes:

 How about adding a new primitive `memql', a variant of memq that uses
 eql -- which should be very efficient in C -- and then make the slight
 tweak to cl's `member*' expander to produce that in the default case?

You got my YES vote!  Much cleaner than the current add-to-list mess.

-- 
Kim F. Storm [EMAIL PROTECTED] http://www.cua.dk



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Flickering of mode line buttons

2006-09-12 Thread Marshall, Simon
src/emacs -Q
C-x 2   ; split windows makes flickering more obvious

In the selected window, move the mouse across the *scratch* or Lisp
Interaction mode-line buttons.  I see the other buttons, particularly the
buttons on the left (coding, read-only, modified) flickering as they are
repeatedly redrawn.  (It's possible that the whole mode-line is being
repeatedly redrawn - it's more obvious with the buttons.)  I also see
redrawing continue intermittently for a few seconds after I stop moving the
mouse (though still within a button).

In GNU Emacs 22.0.50.1 (sparc-sun-solaris2.8, X toolkit)
 of 2006-09-11 on perth
X server distributor `Hummingbird Ltd.', version 11.0.100015
configured using `configure 'CFLAGS=-g''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: en_GB.ISO8859-1
  value of $LC_CTYPE: en_GB.ISO8859-1
  value of $LC_MESSAGES: C
  value of $LC_MONETARY: en_GB.ISO8859-1
  value of $LC_NUMERIC: en_GB.ISO8859-1
  value of $LC_TIME: en_GB.ISO8859-1
  value of $LANG: en_GB.ISO8859-1
  locale-coding-system: iso-8859-1
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: focus-follows-mouse should be nil by default on MS Windows

2006-09-12 Thread YAMAMOTO Mitsuharu
 On Sat, 15 Jul 2006 11:47:15 +0300, Eli Zaretskii [EMAIL PROTECTED] 
 said:

  The default value should still reflect what's appropriate for the platform,
  even if for most purposes it's ignored by the OS. The OS might not DTRT, 
  but
  the behavior of Emacs code depends on the value of Emacs variables. For
  instance, doesn't it make a difference here? I think it does.
  
(defun select-frame-set-input-focus (frame)
  Select FRAME, raise it, and set input focus, if possible.
  (select-frame frame)
  (raise-frame frame)
  ;; Ensure, if possible, that frame gets input focus.
  (cond ((eq window-system 'x) (x-focus-frame frame))
((eq window-system 'w32) (w32-focus-frame frame)))
  (cond (focus-follows-mouse
 (set-mouse-position (selected-frame)
 (1- (frame-width)) 0)

 If so, I must ask you: did you actually tried this code?  (C-x 5 o
 calls this function, so it would suffice to try that command.)  I did
 try it, with both nil and t as values of focus-follows-mouse, and I
 don't see _any_ change in behavior whatsoever.

Let me confirm one thing.  The value doesn't affect the behavior with
respect to the mouse position on W32, either?  I'm asking because I'm
thinking about setting its default to nil on Mac Carbon, because if
the value is t, C-x 5 o moves the mouse pointer to the upper-right
corner of the focused frame.

 YAMAMOTO Mitsuharu
[EMAIL PROTECTED]


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: focus-follows-mouse should be nil by default on MS Windows

2006-09-12 Thread Jason Rumney

YAMAMOTO Mitsuharu wrote:

Let me confirm one thing.  The value doesn't affect the behavior with
respect to the mouse position on W32, either?  I'm asking because I'm
thinking about setting its default to nil on Mac Carbon, because if
the value is t, C-x 5 o moves the mouse pointer to the upper-right
corner of the focused frame.
  

The same happens on W32.



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


mouse-autoselect-window with menu pane

2006-09-12 Thread Marshall, Simon
Hi Martin, thanks again for the implementation, but a small buggette...

src/emacs -Q
(setq mouse-autoselect-window 3) C-x C-e C-x 2

And select the lower window.  Move quickly from the lower window up to the
menu bar and select the Help menu.  While holding down mouse-1, move quickly
to the upper window (ie, but off the Help menu pane).  Wait until the
autoselect timeout has occurred and release mouse-1.  Selection of the upper
window occurs (presumably it occurred while mouse-1 was down but there was
no redisplay at that time), rather than selection remaining in the lower
window.  Selection only seems to happen if the mouse is outside the menu
pane when the autoselect timeout occurs.

While this might seem fairly innocuous, it bites in the more frequent
situation where you momentarily leave the menu pane before returning to
select an entry.  So, instead of releasing mouse-1 after the autoselect
timeout, move back into the Help menu pane and select About Emacs.  The
action occurs in the upper window, not the lower window which was selected
when you opened the Help menu.

So, it seems that by being outside the menu pane when the autoselect timeout
occurs, autoselection is performed.  I think it is sensible to suppress
autoselection in this case (ie, reschedule the delay).

Occurs with Lucid/Motif toolkit, Solaris 2.8, displayed on PC via Exceed
server.  Also occurs if you open the Help menu with a single mouse-1 click,
rather than holding down mouse-1.

Simon.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: emacs-lisp/cl.el (pushnew): void-variable x

2006-09-12 Thread Stefan Monnier
 Honestly, I think using `add-to-list' here makes no sense.
 Since we have the variable as a symbol and we're macro-expanding, we can
 just use `(unless (member ,element ,var) (setq ,var (cons ,element ,var)))
 That'll be a lot more efficient than going through a function call to
 add-to-list, using an aux-var accessed via symbol-value and set and checking
 `append' arg etc...

 Yup, and it even looks like cl-macs.el has the machinery in place to do
 that, it's just very hard to follow (lots of levels of compiler-macros).

 However I think it normally doesn't take because the default
 comparison function for pushnew is `eql', not eq, so there's no non-cl
 way to express the result; that's why it uses member*.

[...]

 The following patche seems to implement this:

Looks good to me,


Stefan


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: missing sit-for

2006-09-12 Thread Kevin Rodgers

Andreas Roehler wrote:

Richard Stallman schrieb:

However, as I had a calendar.el in my path, from here
resorts an error now:

Symbol's value as variable is void: facemenu-unlisted-faces

Are you saying this was caused by a spurious file?
That would mean that we don't have a bug in Emacs, right?

  

 `calendar.el' from cvs-source seems ok.

Kept an old variant, because I changed something in
order to have german names:

(defvar calendar-day-name-array
 [Sonntag Montag Dienstag Mittwoch Donnerstag Freitag 
Samstag]

   Array of capitalized strings giving, in order, the day names.)

instead of

;;(defvar calendar-day-name-array
;;  [Sunday Monday Tuesday Wednesday Thursday Friday 
Saturday]

;;  Array of capitalized strings giving, in order, the day names.)

and

(defvar calendar-month-name-array
 [Januar Februar März April Mai Juni Juli August
  September Oktober November Dezember]
 Array of capitalized strings giving, in order, the month names.)


instead of

;;(defvar calendar-month-name-array
;;  [January February March April   May  June
;;   JulyAugust   September October November December]
;;  Array of capitalized strings giving, in order, the month names.)



Probably there are better ways to do that.


Why not use setq in your ~/.emacs file (instead of defvar in
calendar.el)?

--
Kevin



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: emacs-lisp/cl.el (pushnew): void-variable x

2006-09-12 Thread Richard Stallman
Honestly, I think using `add-to-list' here makes no sense.
Since we have the variable as a symbol and we're macro-expanding, we can
just use `(unless (member ,element ,var) (setq ,var (cons ,element ,var)))
That'll be a lot more efficient than going through a function call to
add-to-list, using an aux-var accessed via symbol-value and set and checking
`append' arg etc...

Maybe you're right, but note that it can't actually be `member' in
this case, not by default, since the default comparison function for
pushnew is `eql'.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: emacs-lisp/cl.el (pushnew): void-variable x

2006-09-12 Thread Richard Stallman
How about adding a new primitive `memql', a variant of memq that uses
eql -- which should be very efficient in C -- and then make the slight
tweak to cl's `member*' expander to produce that in the default case?

This would be ok, after the release.  But right now we should focus on
fixing the bugs listed in FOR-RELEASE.  Could you fix on of them?


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Error on gnus-group-make-rss-group

2006-09-12 Thread Andrew M. Scott
I get errors when I try to add new RSS feeds within GNUS on
the 12 Sept 2006 build of CVS Emacs. 

I first noticed this problem *months* ago, so it's unlikely a recent
code change.

emacs -Q 
M-x toggle-debug-on-error
M-x gnus
G R http://www.michaelhyatt.com/ Return
Debugger entered--Lisp error: (error No feeds found for 
http://www.michaelhyatt.com/;)
  signal(error (No feeds found for http://www.michaelhyatt.com/;))
  error(No feeds found for %s http://www.michaelhyatt.com/;)
  gnus-group-make-rss-group()
  call-interactively(gnus-group-make-rss-group)

*Messages* contains
nnrss: http://www.michaelhyatt.com/: Not valid XML (error XML: 
(Not Well-Formed) Invalid end tag (expecting p) at pos 49598) 
and w3-parse doesn't work (void-function w3-parse-buffer)

M-x locate-library w3 and w3-auto return:
No library w3 in search path
No library w3-auto in search path
(I tried these, because a long time ago I had the separate w3/url packages
in my Emacs-21.3 load-path).

and there is no mention of w3 in my ~/.gnus.el nor ~/.newsrc*

I have *existing* nnrss feeds in my *Group* buffer that are working properly,
but I've forgotten how I got them there.
   0: nnrss:gmane.emacs.pretest.bugs 
   2: nnrss:gmane.emacs.devel 
   0: nnrss:reddit: what's new online 

Mozilla Firefox with the Sage RSS extension had no problem discovering that
the RSS feed URL at http://www.michaelhyatt.com/; is at
http://www.michaelhyatt.com/workingsmarter/atom.xml;

Andy Scott

In GNU Emacs 22.0.50.1 (x86_64-unknown-linux-gnu, X toolkit)
 of 2006-09-12 on chlr6708
X server distributor `The XFree86 Project, Inc', version 11.0.40201000
configured using `configure '--prefix=/stor/garray/linux_2.6.5_x86-64' 
'--x-includes=/usr/intel/pkgs/X11/R6.7.0-64/include' 
'--x-libraries=/usr/intel/pkgs/X11/R6.7.0-64/lib' 'CC=gcc' 'CFLAGS=-O2 
-I/usr/intel/pkgs/X11/R6.7.0-64/include -L/usr/intel/pkgs/X11/R6.7.0-64/lib 
-I/usr/intel/pkgs/zlib/1.2.1-64/include -L/usr/intel/pkgs/zlib/1.2.1-64/lib  
-I/usr/intel/pkgs/ncurses/5.4/include -L/usr/intel/pkgs/ncurses/5.4/lib 
-I/usr/intel/pkgs/libungif/4.1.3/include -L/usr/intel/pkgs/libungif/4.1.3/lib 
-I/usr/intel/pkgs/libpng/1.0.16rc1-64/include 
-L/usr/intel/pkgs/libpng/1.0.16rc1-64/lib -I/usr/intel/pkgs/jpeg/6b-64/include 
-L/usr/intel/pkgs/jpeg/6b-64/lib' 'LDFLAGS=-L/usr/intel/pkgs/X11/R6.7.0-64/lib 
-L/usr/intel/pkgs/zlib/1.2.1-64/lib -L/usr/intel/pkgs/ncurses/5.4/lib 
-L/usr/intel/pkgs/libungif/4.1.3/lib -L/usr/intel/pkgs/libpng/1.0.16rc1-64/lib 
-L/usr/intel/pkgs/jpeg/6b-64/lib 
-Wl,-rpath=/usr/intel/pkgs/X11/R6.7.0-64/lib:/usr/intel/pkgs/zlib/1.2.1-64/lib:/usr/intel/pkgs/ncurses/5.!
 
4/lib:/usr/intel/pkgs/libungif/4.1.3/lib:/usr/intel/pkgs/libpng/1.0.16rc1-64/lib:/usr/intel/pkgs/jpeg/6b-64/lib''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Text

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Error on gnus-group-make-rss-group

2006-09-12 Thread Jason Rumney
Andrew M. Scott [EMAIL PROTECTED] writes:

 nnrss: http://www.michaelhyatt.com/: Not valid XML (error XML: 
 (Not Well-Formed) Invalid end tag (expecting p) at pos 49598) 
 and w3-parse doesn't work (void-function w3-parse-buffer)

You'd be better off asking for help on the gnus mailing lists, as the
only bugs I see here are with the webpage you are trying to subscribe
to. Since w3 is not part of Emacs, the second part of the above
message is not a bug, I guess Gnus is trying to fall back on the more
lenient w3 html parser when xml parsing fails so it can try to do rss
auto-discovery when you give it an html page.


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


describe-prefix-bindings uses let* but could use let

2006-09-12 Thread Drew Adams
Only one variable is bound - no need for let*.

In GNU Emacs 22.0.50.1 (i386-msvc-nt5.1.2600)
 of 2006-07-19 on BOS-CTHEWLAP2
X server distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-msvc (12.00)'



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: emacs-lisp/cl.el (pushnew): void-variable x

2006-09-12 Thread Stefan Monnier
 Honestly, I think using `add-to-list' here makes no sense.  Since we
 have the variable as a symbol and we're macro-expanding, we can just
 use `(unless (member ,element ,var) (setq ,var (cons ,element ,var)))
 That'll be a lot more efficient than going through a function call to
 add-to-list, using an aux-var accessed via symbol-value and set and
 checking `append' arg etc...

 Maybe you're right, but note that it can't actually be `member' in
 this case, not by default, since the default comparison function for
 pushnew is `eql'.

So you agree with me: it makes no sense to use add-to-list since add-to-list
uses `equal'.


Stefan ;-)


___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug


Re: Error on gnus-group-make-rss-group

2006-09-12 Thread David Hansen
On Tue, 12 Sep 2006 16:19:14 -0700 Andrew M. Scott wrote:

 I get errors when I try to add new RSS feeds within GNUS on
 the 12 Sept 2006 build of CVS Emacs. 

 I first noticed this problem *months* ago, so it's unlikely a recent
 code change.

 emacs -Q 
 M-x toggle-debug-on-error
 M-x gnus
 G R http://www.michaelhyatt.com/ Return
 Debugger entered--Lisp error: (error No feeds found for 
 http://www.michaelhyatt.com/;)
   signal(error (No feeds found for http://www.michaelhyatt.com/;))
   error(No feeds found for %s http://www.michaelhyatt.com/;)
   gnus-group-make-rss-group()
   call-interactively(gnus-group-make-rss-group)

 *Messages* contains
 nnrss: http://www.michaelhyatt.com/: Not valid XML (error XML: 
 (Not Well-Formed) Invalid end tag (expecting p) at pos 49598) 
 and w3-parse doesn't work (void-function w3-parse-buffer)

 M-x locate-library w3 and w3-auto return:
 No library w3 in search path
 No library w3-auto in search path
 (I tried these, because a long time ago I had the separate w3/url packages
 in my Emacs-21.3 load-path).

 and there is no mention of w3 in my ~/.gnus.el nor ~/.newsrc*

 I have *existing* nnrss feeds in my *Group* buffer that are working properly,
 but I've forgotten how I got them there.
0: nnrss:gmane.emacs.pretest.bugs 
2: nnrss:gmane.emacs.devel 

Ugh, why don't you use gmane directly?

0: nnrss:reddit: what's new online 

 Mozilla Firefox with the Sage RSS extension had no problem discovering that
 the RSS feed URL at http://www.michaelhyatt.com/; is at
 http://www.michaelhyatt.com/workingsmarter/atom.xml;

Use http://www.michaelhyatt.com/workingsmart/index.rdf (AFAIK
Gnus doesn't support atom feeds).

I think it should work w/o w3 but for reading RSS feeds i
would suggest to install some html renderer (emacs-w3m is
doing a very good job and it's useful as a normal web browser
too).

I'm not sure but i don't think Gnus looks at the meta tags of
the html page so you have to give it the direct link to the
feed.

David



___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug