Re: menu events get ignored when multi-line echo area message is displayed
> On Thu, 15 Mar 2007 18:22:13 +, David Reitter <[EMAIL PROTECTED]>
> said:
> A message should appear in the echo area. Then, select "Help" ->
> "Copying Conditions" (with the mouse). Result for me is that the
> license file is NOT displayed.
> Note that it works if the message displayed has only one line.
> This is a test case of a more general bug where the first selection
> of any (?) menu item is ignored after a multi-line message has been
> displayed. It has been reported by several Aquamacs users, but the
> above code reproduces the bug with an unpatched GNU Emacs (Carbon).
Thanks for minimizing the problematic case. This is because
show_help_echo called from menu_target_item_handler (in macmenu.c)
indirectly calls redisplay_internal in the above case, and then
set_frame_menubar (in macmenu.c) clears f->menu_bar_items_used.
YAMAMOTO Mitsuharu
[EMAIL PROTECTED]
*** src/xdisp.c.~1.1142.~ Sat Mar 10 10:46:41 2007
--- src/xdisp.c Fri Mar 16 17:02:48 2007
*** redisplay_internal (preserve_echo_area)
*** 10872,10878
return;
}
! #if defined (USE_X_TOOLKIT) || defined (USE_GTK)
if (popup_activated ())
return;
#endif
--- 10872,10878
return;
}
! #if defined (USE_X_TOOLKIT) || defined (USE_GTK) || defined (MAC_OS)
if (popup_activated ())
return;
#endif
*** note_mouse_highlight (f, x, y)
*** 22672,22678
struct buffer *b;
/* When a menu is active, don't highlight because this looks odd. */
! #if defined (USE_X_TOOLKIT) || defined (USE_GTK)
if (popup_activated ())
return;
#endif
--- 22672,22678
struct buffer *b;
/* When a menu is active, don't highlight because this looks odd. */
! #if defined (USE_X_TOOLKIT) || defined (USE_GTK) || defined (MAC_OS)
if (popup_activated ())
return;
#endif
*** src/macmenu.c.~1.55.~ Fri Feb 23 17:26:43 2007
--- src/macmenu.c Fri Mar 16 17:03:12 2007
*** static int menu_items_n_panes;
*** 259,264
--- 259,267
/* Current depth within submenus. */
static int menu_items_submenu_depth;
+ /* Nonzero means a menu is currently active. */
+ static int popup_activated_flag;
+
/* This is set nonzero after the user activates the menu bar, and set
to zero again after the menu bars are redisplayed by prepare_menu_bar.
While it is nonzero, all calls to set_frame_menubar go deep.
*** x_activate_menubar (f)
*** 1141,1147
--- 1144,1152
set_frame_menubar (f, 0, 1);
BLOCK_INPUT;
+ popup_activated_flag = 1;
menu_choice = MenuSelect (saved_menu_event_location);
+ popup_activated_flag = 0;
menu_id = HiWord (menu_choice);
menu_item = LoWord (menu_choice);
*** mac_menu_show (f, x, y, for_click, keyma
*** 2237,2243
--- 2242,2250
install_menu_quit_handler (MAC_MENU_POPUP_SUB, menu);
/* Display the menu. */
+ popup_activated_flag = 1;
menu_item_choice = PopUpMenuSelect (menu, pos.v, pos.h, 0);
+ popup_activated_flag = 0;
/* Get the refcon to find the correct item */
if (menu_item_choice)
*** dispose_menus (kind, id)
*** 3218,3223
--- 3225,3238
#endif /* HAVE_MENUS */
+ /* Detect if a menu is currently active. */
+
+ int
+ popup_activated ()
+ {
+ return popup_activated_flag;
+ }
+
/* The following is used by delayed window autoselection. */
DEFUN ("menu-or-popup-active-p", Fmenu_or_popup_active_p,
Smenu_or_popup_active_p, 0, 0, 0,
___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: scrolling up via mouse drag doesn't work
> On Thu, 15 Mar 2007 19:43:07 +, David Reitter <[EMAIL PROTECTED]> > said: > Thank you, your patch works fine. Thanks for testing. > Scrolling this way isn't as smooth as it is when you push an arrow > button - I wonder if something could be done about this. You can customize mouse-scroll-delay (in mouse.el). YAMAMOTO Mitsuharu [EMAIL PROTECTED] ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Strange emacsclient behaviour during use of isearch
Richard Stallman <[EMAIL PROTECTED]> writes: > So can we install the patch to server.el to terminate > isearch-mode and get on with the release. PLEASE!!! > > Your shouting does not convince me. But it should not keep you from considering the arguments Kim and others (who actually use emacsserver) brought forth. -- David Kastrup ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
incremental search and input method
When incrementally searching with no input method, everything works well. As soon as I turn on the default input method by C-\ isearch no longer works, with the following error message in the echo area: isearch-process-search-multibyte-characters: Text is read-only In GNU Emacs 22.0.95.1 (i686-pc-linux-gnu, GTK+ Version 2.8.20) of 2007-03-02 on pierredelune X server distributor `AT&T Laboratories Cambridge', version 11.0.3332 configured using `configure '--with-gtk' '--with-gif'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: fr_FR locale-coding-system: iso-latin-1 default-enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t tool-bar-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t unify-8859-on-encoding-mode: t utf-translate-cjk-mode: t auto-compression-mode: t line-number-mode: t Recent input: C-s e n t e C-g C-\ C-s e n C-g C-x b * M e s s Recent messages: Loading regexp-opt...done Loading tex-mode...done For information about the GNU Project and its goals, type C-h C-p. Quit Loading quail...done Loading quail/latin-pre...done Loading isearch-x...done isearch-process-search-multibyte-characters: Text is read-only [2 times] Quit Loading emacsbug...done ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: incremental search and input method
Olivier Lecarme <[EMAIL PROTECTED]> writes: > When incrementally searching with no input method, everything works > well. As soon as I turn on the default input method by C-\ isearch no > longer works, with the following error message in the echo area: > isearch-process-search-multibyte-characters: Text is read-only You need to update your Emacs to the latest CVS. Unfortunately, "latest CVS" != "current CVS", but for this specific problem, "current CVS" is sufficient. -- Kim F. Storm <[EMAIL PROTECTED]> http://www.cua.dk ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: menu events get ignored when multi-line echo area message is displayed
On 16 Mar 2007, at 08:17, YAMAMOTO Mitsuharu wrote: Thanks for minimizing the problematic case. This is because show_help_echo called from menu_target_item_handler (in macmenu.c) indirectly calls redisplay_internal in the above case, and then set_frame_menubar (in macmenu.c) clears f->menu_bar_items_used. Nice, that was quick. I tried your patch: it works. Thanks - D smime.p7s Description: S/MIME cryptographic signature ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
x_error_quitter
GNU Emacs 22.0.95.2 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2007-03-12 on quant8 again, emacs dies in x_error_quitter: Breakpoint 3, x_error_quitter (display=0x8591e38, error=0xbfe939a8) at xterm.c:7859 7859 if (error->error_code == BadName) (gdb) (gdb) (gdb) where #0 x_error_quitter (display=0x8591e38, error=0xbfe939a8) at xterm.c:7859 #1 0x080c97cd in x_error_handler (display=0x8591e38, error=0xbfe939a8) at xterm.c:7824 #2 0xb7d1c9ea in _XError () from /usr/lib/libX11.so.6 #3 0xb7d1f141 in _XEventsQueued () from /usr/lib/libX11.so.6 #4 0xb7cf387e in XCheckIfEvent () from /usr/lib/libX11.so.6 #5 0xb7f2e78c in XtSetWMColormapWindows () from /usr/lib/libXt.so.6 #6 0xb7f1915a in _XtMakeGeometryRequest () from /usr/lib/libXt.so.6 #7 0xb7f2d175 in XtSetValues () from /usr/lib/libXt.so.6 #8 0xb7f3fff2 in XtVaSetValues () from /usr/lib/libXt.so.6 #9 0x0819976b in EmacsFrameSetCharSize (widget=0xaf8a390, columns=3, rows=1) at widget.c:975 #10 0x080c9dce in x_set_window_size (f=0xa903758, change_gravity=1, cols=2, rows=1) at xterm.c:8731 #11 0x0805c8a5 in Fset_frame_size (frame=177223516, cols=16, rows=8) at frame.c:2500 #12 0x0805f656 in x_set_frame_parameters (f=0xa903758, alist=184507717) at frame.c:2862 #13 0x0805fc37 in x_default_parameter (f=0xa903758, alist=184509813, prop=137623537, deflt=137468153, xprop=0x81a67de "bitmapIcon", xclass=0x81a67d3 "BitmapIcon", type=RES_TYPE_SYMBOL) at frame.c:3683 #14 0x080d6c46 in Fx_create_frame (parms=184510005) at xfns.c:3347 #15 0x08153a71 in Ffuncall (nargs=2, args=0xbfe95478) at eval.c:2997 #16 0x0817e2dd in Fbyte_code (bytestr=136231163, vector=136231180, maxdepth=40) at bytecode.c:679 #17 0x0815351a in funcall_lambda (fun=136231116, nargs=1, arg_vector=0xbfe955a4) at eval.c:3184 #18 0x08153921 in Ffuncall (nargs=2, args=0xbfe955a0) at eval.c:3054 #19 0x0817e2dd in Fbyte_code (bytestr=136473963, vector=136473980, maxdepth=24) at bytecode.c:679 #20 0x0815351a in funcall_lambda (fun=136473916, nargs=1, arg_vector=0xbfe956c4) at eval.c:3184 #21 0x08153921 in Ffuncall (nargs=2, args=0xbfe956c0) at eval.c:3054 #22 0x0817e2dd in Fbyte_code (bytestr=143786411, vector=145684708, maxdepth=88) at bytecode.c:679 #23 0x0815351a in funcall_lambda (fun=144160660, nargs=2, arg_vector=0xbfe95804) at eval.c:3184 #24 0x08153921 in Ffuncall (nargs=3, args=0xbfe95800) at eval.c:3054 #25 0x0817e2dd in Fbyte_code (bytestr=143816491, vector=145683108, maxdepth=32) at bytecode.c:679 #26 0x0815351a in funcall_lambda (fun=143315508, nargs=4, arg_vector=0xbfe95924) at eval.c:3184 #27 0x08153921 in Ffuncall (nargs=5, args=0xbfe95920) at eval.c:3054 #28 0x0817e2dd in Fbyte_code (bytestr=143865707, vector=145622764, maxdepth=40) at bytecode.c:679 #29 0x0815351a in funcall_lambda (fun=145608828, nargs=4, arg_vector=0xbfe95a54) at eval.c:3184 #30 0x08153921 in Ffuncall (nargs=5, args=0xbfe95a50) at eval.c:3054 #31 0x0817e2dd in Fbyte_code (bytestr=143933843, vector=145676596, maxdepth=40) at bytecode.c:679 #32 0x0815351a in funcall_lambda (fun=145326692, nargs=4, arg_vector=0xbfe95b84) at eval.c:3184 #33 0x08153921 in Ffuncall (nargs=5, args=0xbfe95b80) at eval.c:3054 #34 0x0817e2dd in Fbyte_code (bytestr=146060859, vector=145660628, maxdepth=56) at bytecode.c:679 #35 0x0815351a in funcall_lambda (fun=145672812, nargs=9, arg_vector=0xbfe95cb4) at eval.c:3184 #36 0x08153921 in Ffuncall (nargs=10, args=0xbfe95cb0) at eval.c:3054 #37 0x0817e2dd in Fbyte_code (bytestr=146018163, vector=146027980, maxdepth=128) at bytecode.c:679 #38 0x0815351a in funcall_lambda (fun=146028204, nargs=5, arg_vector=0xbfe95e04) at eval.c:3184 #39 0x08153921 in Ffuncall (nargs=6, args=0xbfe95e00) at eval.c:3054 #40 0x0817e2dd in Fbyte_code (bytestr=146017955, vector=146019324, maxdepth=48) at bytecode.c:679 #41 0x0815351a in funcall_lambda (fun=146027660, nargs=2, ---Type to continue, or q to quit--- arg_vector=0xbfe95ed0) at eval.c:3184 #42 0x0815371b in apply_lambda (fun=146027660, args=186821165, eval_flag=1) at eval.c:3108 #43 0x08152df2 in Feval (form=186821173) at eval.c:2370 #44 0x08153a71 in Ffuncall (nargs=2, args=0xbfe96000) at eval.c:2997 #45 0x0817e2dd in Fbyte_code (bytestr=136316403, vector=136316420, maxdepth=64) at bytecode.c:679 #46 0x0815351a in funcall_lambda (fun=136316364, nargs=1, arg_vector=0xbfe96184) at eval.c:3184 #47 0x08153921 in Ffuncall (nargs=2, args=0xbfe96180) at eval.c:3054 #48 0x08150d7d in Fcall_interactively (function=137850697, record_flag=137468105, keys=154557276) at callint.c:860 #49 0x080f0fd3 in Fcommand_execute (cmd=137850697, record_flag=137468105, keys=137468105, special=137468105) at keyboard.c:10034 #50 0x080fc81b in command_loop_1 () at keyboard.c:1873 #51 0x08152562 in internal_condition_case (bfun=0x80fc4a0 , handlers=137512761, hfun=0x80f6f90 ) at eval.c:1481 #52 0x080f6343 in command_loop_2 () at keyboard.c:1329
(switch-to-completions) when completion-show-help is nil fails
M-: (setq completion-show-help nil)
M-x ab TAB M-v
Debugger entered--Lisp error: (search-failed "
")
search-forward("\n\n")
(progn (select-window window) (goto-char (point-min)) (search-forward "\n\n")
(forward-line 1))
(if window (progn (select-window window) (goto-char ...) (search-forward
"\n\n") (forward-line 1)))
(when window (select-window window) (goto-char (point-min)) (search-forward
"\n\n") (forward-line 1))
(let ((window ...)) (when window (select-window window) (goto-char ...)
(search-forward "\n\n") (forward-line 1)))
switch-to-completions()
call-interactively(switch-to-completions)
execute-extended-command(nil)
call-interactively(execute-extended-command)
Since the "\n\n" is part of the help text. The one line change to
simple.el works around the problem:
*** simple.el 02 Mar 2007 16:00:28 -0800 1.846
--- simple.el 14 Mar 2007 19:06:55 -0800
***
*** 5160,5166
(when window
(select-window window)
(goto-char (point-min))
! (search-forward "\n\n")
(forward-line 1
;;; Support keyboard commands to turn on various modifiers.
--- 5160,5166
(when window
(select-window window)
(goto-char (point-min))
! (search-forward "\n\n" nil t)
(forward-line 1
;;; Support keyboard commands to turn on various modifiers.
In GNU Emacs 22.0.95.2 (i386-unknown-openbsd4.0, X toolkit)
of 2007-03-06 on owie.yeske.ca
X server distributor `The X.Org Foundation', version 11.0.6090
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: nil
locale-coding-system: nil
default-enable-multibyte-characters: t
Major mode: Diff
Minor modes in effect:
shell-dirtrack-mode: t
display-battery-mode: t
auto-insert-mode: t
display-time-mode: t
iswitchb-mode: t
auto-image-file-mode: t
show-paren-mode: t
rcirc-track-minor-mode: t
tooltip-mode: t
mouse-wheel-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
unify-8859-on-encoding-mode: t
utf-translate-cjk-mode: t
auto-compression-mode: t
size-indication-mode: t
line-number-mode: t
Recent input:
C-n C-n C-n C-n C-n C-n C-n C-e C-b C-h f
SPC n i l SPC t C-a C-M-x C-x C-s M-x p a r M-v
C-n C-p C-n C-p q C-x 0 C-x o C-g C-x 1 C-p C-p
C-p C-p C-l M-x r m a i l h q C-x v = C-x
1 C-SPC C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n
C-n C-n C-n C-n C-n C-n C-n C-n C-n M-w M-x r e p o
r t - e m a c s - b u g
Recent messages:
Quit
(No new mail has arrived)
Computing summary lines...done
Expunging deleted messages...done
(No changes need to be saved)
Loading vc...done
Mark set
Loading emacsbug...done
Undo!
Quit [2 times]
--
http://www.yeske.ca
___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
missing prompts in testcover.el commands
The testcover.el package is missing prompts in interactive specs. The following patch supplies them. *** testcover.el02 Mar 2007 16:00:42 -0800 1.15 --- testcover.el14 Mar 2007 23:20:28 -0800 *** *** 190,196 changes the instrumentation from edebug to testcover--much faster, no problems with type-ahead or post-command-hook, etc. If BYTE-COMPILE is non-nil, byte-compiles each function after instrumenting." ! (interactive "f") (let ((buf(find-file filename)) (load-read-function 'testcover-read) (edebug-all-defs t)) --- 190,196 changes the instrumentation from edebug to testcover--much faster, no problems with type-ahead or post-command-hook, etc. If BYTE-COMPILE is non-nil, byte-compiles each function after instrumenting." ! (interactive "fStart covering file: ") (let ((buf(find-file filename)) (load-read-function 'testcover-read) (edebug-all-defs t)) *** *** 428,437 list) result)) ! (defun testcover-end (buffer) "Turn off instrumentation of all macros and functions in FILENAME." ! (interactive "b") ! (let ((buf (find-file-noselect buffer))) (eval-buffer buf t))) --- 428,437 list) result)) ! (defun testcover-end (filename) "Turn off instrumentation of all macros and functions in FILENAME." ! (interactive "fStop covering file: ") ! (let ((buf (find-file-noselect filename))) (eval-buffer buf t))) *** *** 513,519 (defun testcover-mark-all (&optional buffer) "Mark all forms in BUFFER that did not get completley tested during coverage tests. This function creates many overlays." ! (interactive "b") (if buffer (switch-to-buffer buffer)) (goto-char 1) --- 513,519 (defun testcover-mark-all (&optional buffer) "Mark all forms in BUFFER that did not get completley tested during coverage tests. This function creates many overlays." ! (interactive "bMark forms in buffer: ") (if buffer (switch-to-buffer buffer)) (goto-char 1) *** *** 523,529 (defun testcover-unmark-all (buffer) "Remove all overlays from FILENAME." ! (interactive "b") (condition-case nil (progn (set-buffer buffer) --- 523,529 (defun testcover-unmark-all (buffer) "Remove all overlays from FILENAME." ! (interactive "bUnmark forms in buffer: ") (condition-case nil (progn (set-buffer buffer) In GNU Emacs 22.0.95.2 (i386-unknown-openbsd4.0, X toolkit) of 2007-03-06 on owie.yeske.ca X server distributor `The X.Org Foundation', version 11.0.6090 Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Diff Minor modes in effect: vc-parent-buffer: testcover.el shell-dirtrack-mode: t display-battery-mode: t auto-insert-mode: t display-time-mode: t iswitchb-mode: t show-paren-mode: t rcirc-track-minor-mode: t auto-image-file-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t unify-8859-on-encoding-mode: t utf-translate-cjk-mode: t auto-compression-mode: t size-indication-mode: t line-number-mode: t Recent input: C-u C-b C-b C-b M-d C-d M-c SPC f i l e C-x o C-x o M-b C-b C-b C-b C-b C-b C-b S t a r t SPC M-l i n g C-x o M-f M-f SPC f i l e : SPC C-a C-n C-p C-p C-p C-s f i l e C-w C-s C-a C-n C-n C-e M-b M-d f i l e n a m e C-a C-x C-s C-x v / C-g C-x v = C-x 1 M-x r e p o r t - e m a c s - b u g Recent messages: Searched 1 buffer; 6 matches for `interactive' Auto-saving...done Type C-x 1 to remove help window. mouse-2, RET: find function's definition Quit Mark set Mark saved where search started Wrote /home/rcyeske/emacs/lisp/emacs-lisp/testcover.el Quit Loading emacsbug...done -- http://www.yeske.ca ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
