Re: [bug] Gnus weird behavior
Richard Stallman <[EMAIL PROTECTED]> writes: > No. But it has been installed in the stable (v5-10) branch of Gnus. > It will be synched to Emacs with Miles (Cc-ed) next sync. > > Miles, would you please tell me when this is done, so I can remove > that item from FOR-RELEASE? OK, it's done. -miles -- "Suppose we've chosen the wrong god. Every time we go to church we're just making him madder and madder." -- Homer Simpson ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: [bug] Gnus weird behavior
No. But it has been installed in the stable (v5-10) branch of Gnus. It will be synched to Emacs with Miles (Cc-ed) next sync. Miles, would you please tell me when this is done, so I can remove that item from FOR-RELEASE? ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: [bug] Gnus weird behavior
On Fri, Dec 29 2006, Richard Stallman wrote: > > Would you please install your patch in the v5-10 branch? Or do you or > > anyone else see a problem with it or a better fix? > > Done. > > Is this patch installed in Emacs yet? No. But it has been installed in the stable (v5-10) branch of Gnus. It will be synched to Emacs with Miles (Cc-ed) next sync. [ There have been some other fixed (mostly documentation issues) since the last sync, so it's better to wait for Miles than to only apply this patch. ] > Does it fix the problem that Leo reported? Yes. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: [bug] Gnus weird behavior
> Would you please install your patch in the v5-10 branch? Or do you or > anyone else see a problem with it or a better fix? Done. Is this patch installed in Emacs yet? Does it fix the problem that Leo reported? ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: [bug] Gnus weird behavior
> In <[EMAIL PROTECTED]> > Reiner Steib <[EMAIL PROTECTED]> wrote: > > The cause of the problem seems that gnus-article-mode uses > > gnus-summary-mode's tool-bar-map and a few commands in it expect to be > > called from the summary buffers. > [...] > > Here is a patch. > Would you please install your patch in the v5-10 branch? Or do you or > anyone else see a problem with it or a better fix? Done. Though it might be better to provide a new tool-bar-map for gnus-article-mode, such a change should be first introduced to the development branch of Gnus, I think. Regards, -- Daiki Ueno ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: [bug] Gnus weird behavior
On Tue, Dec 26 2006, Daiki Ueno wrote: >> In <[EMAIL PROTECTED]> >> Leo <[EMAIL PROTECTED]> wrote: >> To reproduce: > >>- go to the article buffer >>- click the right arrow in the toolbar > >> Backtrace: >> , >> | Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) >> | gnus-summary-next-article(nil) >> | call-interactively(gnus-summary-next-article) >> ` > > The cause of the problem seems that gnus-article-mode uses > gnus-summary-mode's tool-bar-map and a few commands in it expect to be > called from the summary buffers. [...] > Here is a patch. Would you please install your patch in the v5-10 branch? Or do you or anyone else see a problem with it or a better fix? > Index: lisp/gnus/gnus-sum.el > === > RCS file: /sources/emacs/emacs/lisp/gnus/gnus-sum.el,v > retrieving revision 1.96 > diff -c -r1.96 gnus-sum.el > --- lisp/gnus/gnus-sum.el 12 Dec 2006 16:12:12 - 1.96 > +++ lisp/gnus/gnus-sum.el 26 Dec 2006 01:12:40 - > @@ -7333,6 +7333,9 @@ > If SUBJECT, only articles with SUBJECT are selected. > If BACKWARD, the previous article is selected instead of the next." >(interactive "P") > + ;; Make sure we are in the summary buffer. > + (unless (eq major-mode 'gnus-summary-mode) > +(set-buffer gnus-summary-buffer)) >(cond > ;; Is there such an article? > ((and (gnus-summary-search-forward unread subject backward) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: [bug] Gnus weird behavior
Can you install your patch in the Emacs sources? If so, please do. ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: [bug] Gnus weird behavior
* Daiki Ueno (2006-12-26 10:16 +0900) said: ^^ >> In <[EMAIL PROTECTED]> >> Leo <[EMAIL PROTECTED]> wrote: >> To reproduce: > >>- go to the article buffer >>- click the right arrow in the toolbar > >> Backtrace: >> , >> | Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) >> | gnus-summary-next-article(nil) >> | call-interactively(gnus-summary-next-article) >> ` > > The cause of the problem seems that gnus-article-mode uses > gnus-summary-mode's tool-bar-map and a few commands in it expect to be > called from the summary buffers. > >> BTW, left arrow does not have this problem. > > However, it doesn't select the previous article, does it? No it does not. > > Here is a patch. With this patch both arrows work as expected. Thank you. > > Index: lisp/gnus/gnus-sum.el >=== >RCS file: /sources/emacs/emacs/lisp/gnus/gnus-sum.el,v retrieving >revision 1.96 diff -c -r1.96 gnus-sum.el *** lisp/gnus/gnus-sum.el 12 >Dec 2006 16:12:12 - 1.96 --- lisp/gnus/gnus-sum.el 26 Dec 2006 >01:12:40 - *** *** 7333,7338 --- 7333,7341 >If SUBJECT, only articles with SUBJECT are selected. If BACKWARD, >the previous article is selected instead of the next." (interactive >"P") > + ;; Make sure we are in the summary buffer. > + (unless (eq major-mode 'gnus-summary-mode) > + (set-buffer gnus-summary-buffer)) > (cond > ;; Is there such an article? > ((and (gnus-summary-search-forward unread subject backward) -- Leo (GPG Key: 9283AA3F) ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: [bug] Gnus weird behavior
> In <[EMAIL PROTECTED]> > Leo <[EMAIL PROTECTED]> wrote: > To reproduce: >- go to the article buffer >- click the right arrow in the toolbar > Backtrace: > , > | Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) > | gnus-summary-next-article(nil) > | call-interactively(gnus-summary-next-article) > ` The cause of the problem seems that gnus-article-mode uses gnus-summary-mode's tool-bar-map and a few commands in it expect to be called from the summary buffers. > BTW, left arrow does not have this problem. However, it doesn't select the previous article, does it? Here is a patch. Index: lisp/gnus/gnus-sum.el === RCS file: /sources/emacs/emacs/lisp/gnus/gnus-sum.el,v retrieving revision 1.96 diff -c -r1.96 gnus-sum.el *** lisp/gnus/gnus-sum.el 12 Dec 2006 16:12:12 - 1.96 --- lisp/gnus/gnus-sum.el 26 Dec 2006 01:12:40 - *** *** 7333,7338 --- 7333,7341 If SUBJECT, only articles with SUBJECT are selected. If BACKWARD, the previous article is selected instead of the next." (interactive "P") + ;; Make sure we are in the summary buffer. + (unless (eq major-mode 'gnus-summary-mode) + (set-buffer gnus-summary-buffer)) (cond ;; Is there such an article? ((and (gnus-summary-search-forward unread subject backward) -- Daiki Ueno ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
[bug] Gnus weird behavior
Hi all, To reproduce: - go to the article buffer - click the right arrow in the toolbar Backtrace: , | Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) | gnus-summary-next-article(nil) | call-interactively(gnus-summary-next-article) ` BTW, left arrow does not have this problem. -- Leo (GPG Key: 9283AA3F) ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
