Re: Can't put cursor after wrapped overlay string with `cursor' property
On Mon, 29 May 2006 09:54:24 +0900, YAMAMOTO Mitsuharu [EMAIL PROTECTED] said: But now I see some strange behavior if the overlay is placed at the end of line. emacs -Q -D (setq overlay (make-overlay 1 1)) (setq str (make-string 100 ?a)) (overlay-put overlay 'before-string str) M- RET C-p -- The cursor at the previous position doesn't get erased. C-l -- The cursor is displayed at the vertical center position. The following change seems to work for me. Could someone check if this is correct? YAMAMOTO Mitsuharu [EMAIL PROTECTED] Index: src/xdisp.c === RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v retrieving revision 1.1101 diff -c -r1.1101 xdisp.c *** src/xdisp.c 28 May 2006 20:19:07 - 1.1101 --- src/xdisp.c 2 Jun 2006 08:00:17 - *** *** 11777,11783 /* If we reached the end of the line, and end was from a string, cursor is not on this line. */ ! if (glyph == end) return 0; } --- 11779,11785 /* If we reached the end of the line, and end was from a string, cursor is not on this line. */ ! if (glyph == end row-continued_p) return 0; } ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Can't put cursor after wrapped overlay string with `cursor' property
YAMAMOTO Mitsuharu [EMAIL PROTECTED] writes: On Mon, 29 May 2006 09:54:24 +0900, YAMAMOTO Mitsuharu [EMAIL PROTECTED] said: But now I see some strange behavior if the overlay is placed at the end of line. emacs -Q -D (setq overlay (make-overlay 1 1)) (setq str (make-string 100 ?a)) (overlay-put overlay 'before-string str) M- RET C-p -- The cursor at the previous position doesn't get erased. C-l -- The cursor is displayed at the vertical center position. The following change seems to work for me. Could someone check if this is correct? Yes, this is a good change. Please install. Thanks for debugging this. YAMAMOTO Mitsuharu [EMAIL PROTECTED] Index: src/xdisp.c === RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v retrieving revision 1.1101 diff -c -r1.1101 xdisp.c *** src/xdisp.c 28 May 2006 20:19:07 - 1.1101 --- src/xdisp.c 2 Jun 2006 08:00:17 - *** *** 11777,11783 /* If we reached the end of the line, and end was from a string, cursor is not on this line. */ ! if (glyph == end) return 0; } --- 11779,11785 /* If we reached the end of the line, and end was from a string, cursor is not on this line. */ ! if (glyph == end row-continued_p) return 0; } -- Kim F. Storm [EMAIL PROTECTED] http://www.cua.dk ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
Re: Can't put cursor after wrapped overlay string with `cursor' property
YAMAMOTO Mitsuharu [EMAIL PROTECTED] writes: In some cases, we can't place the cursor at the middle of overlay string with the 'cursor' text property. Actually, if I repeat your example without the cursor property, the cursor also disappears. emacs -Q -D (setq overlay (make-overlay 1 1)) (setq str (make-string 100 ?a)) (overlay-put overlay 'before-string str) M- I have installed a change to fix the problem. Pls. retest. -- Kim F. Storm [EMAIL PROTECTED] http://www.cua.dk ___ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
