[Engine-devel] Proposing Kiril nesenko as power user for ovirt engine tools
Hi, I would like to propose kiril nesenko as 'jenkins power user' for ovirt engine tools. These tools indlude iso uploader, log collector, image uploader and others. Kiril is very involved in building and running Jenkins jobs on the rhevm product, and maintains package the ovirt tools currently. As part of being power user on jenkins.ovirt.org, he will create new jobs to build and release tools for the various OS supported. I vote +1 as i personally know kiril and he's experience. Thansk, Eyal. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Instance Types Feature
I have completed the User Interface part (e.g. where the Images, Instance Types and Templates main tabs will be). http://www.ovirt.org/Features/Instance_Types#User_Interface Your comments are welcome, Tomas - Original Message - From: Tomas Jelinek tjeli...@redhat.com To: Oved Ourfalli ov...@redhat.com Cc: engine-devel@ovirt.org Sent: Tuesday, February 5, 2013 5:14:00 PM Subject: Re: [Engine-devel] Instance Types Feature 1. Why do we need a new set of permissions for Create Instance and Instance Owner? Aren't the VmCreator role and the UserVmManager role enough in these use-cases? so checked this with Andy: - Create Instance: it is a permission to actually see the instance types in the list of instance types when creating the VM and to be able to create a VM from that instance type - Instance Owner: if the user has this permission, he can edit the fields marked as Basic User in the table in the wiki (but not the others) - Original Message - From: Oved Ourfalli ov...@redhat.com To: Tomas Jelinek tjeli...@redhat.com Cc: engine-devel@ovirt.org Sent: Tuesday, January 29, 2013 2:54:13 PM Subject: Re: [Engine-devel] Instance Types Feature Some questions: 1. Why do we need a new set of permissions for Create Instance and Instance Owner? Aren't the VmCreator role and the UserVmManager role enough in these use-cases? 2. iiuc, the internal implementation of instance types and images will be done using templates. However, I guess we plan to expose instance types and images as REST resources, right? Thank you, Oved - Original Message - From: Tomas Jelinek tjeli...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, January 22, 2013 3:09:51 PM Subject: [Engine-devel] Instance Types Feature Hi All, this is the proposed new feature called instance types: http://www.ovirt.org/Features/Instance_Types Long story short - it should basically split the VM template into: - hardware profile called instance types - software profile called image This should enable to do something like: Create a new small VM and attach a disk with RHEL + Postgres installed. Any comments are more than welcome! Tomas ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Instance Types Feature
- Original Message - From: Tomas Jelinek tjeli...@redhat.com To: Oved Ourfalli ov...@redhat.com Cc: engine-devel@ovirt.org Sent: Tuesday, February 5, 2013 6:14:00 PM Subject: Re: [Engine-devel] Instance Types Feature 1. Why do we need a new set of permissions for Create Instance and Instance Owner? Aren't the VmCreator role and the UserVmManager role enough in these use-cases? so checked this with Andy: - Create Instance: it is a permission to actually see the instance types in the list of instance types when creating the VM and to be able to create a VM from that instance type Wouldn't we want the instance types to be public, limiting the user on resources according to his Quota? What worries me is that you currently need VmCreator role on a DC in order to be able to create VMs there, add disks, and etc. So, now you would also need to have a CreateInstance permission. And, in addition, you also need the right Quota. Why not simplifying things, saying all instance types are public, and you only need VmCreator role, and the Quota for your new resources? - Instance Owner: if the user has this permission, he can edit the fields marked as Basic User in the table in the wiki (but not the others) - Original Message - From: Oved Ourfalli ov...@redhat.com To: Tomas Jelinek tjeli...@redhat.com Cc: engine-devel@ovirt.org Sent: Tuesday, January 29, 2013 2:54:13 PM Subject: Re: [Engine-devel] Instance Types Feature Some questions: 1. Why do we need a new set of permissions for Create Instance and Instance Owner? Aren't the VmCreator role and the UserVmManager role enough in these use-cases? 2. iiuc, the internal implementation of instance types and images will be done using templates. However, I guess we plan to expose instance types and images as REST resources, right? Thank you, Oved - Original Message - From: Tomas Jelinek tjeli...@redhat.com To: engine-devel@ovirt.org Sent: Tuesday, January 22, 2013 3:09:51 PM Subject: [Engine-devel] Instance Types Feature Hi All, this is the proposed new feature called instance types: http://www.ovirt.org/Features/Instance_Types Long story short - it should basically split the VM template into: - hardware profile called instance types - software profile called image This should enable to do something like: Create a new small VM and attach a disk with RHEL + Postgres installed. Any comments are more than welcome! Tomas ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Proposing Kiril nesenko as power user for ovirt engine tools
definitely +1 - Original Message - From: Eyal Edri ee...@redhat.com To: infra in...@ovirt.org Cc: knesenko knese...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Thursday, February 7, 2013 10:39:47 AM Subject: [Engine-devel] Proposing Kiril nesenko as power user for ovirt engine tools Hi, I would like to propose kiril nesenko as 'jenkins power user' for ovirt engine tools. These tools indlude iso uploader, log collector, image uploader and others. Kiril is very involved in building and running Jenkins jobs on the rhevm product, and maintains package the ovirt tools currently. As part of being power user on jenkins.ovirt.org, he will create new jobs to build and release tools for the various OS supported. I vote +1 as i personally know kiril and he's experience. Thansk, Eyal. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Proposing Kiril nesenko as power user for ovirt engine tools
+1 - Original Message - From: Eyal Edri ee...@redhat.com To: infra in...@ovirt.org Cc: knesenko knese...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Thursday, February 7, 2013 10:39:47 AM Subject: [Engine-devel] Proposing Kiril nesenko as power user for ovirt engine tools Hi, I would like to propose kiril nesenko as 'jenkins power user' for ovirt engine tools. These tools indlude iso uploader, log collector, image uploader and others. Kiril is very involved in building and running Jenkins jobs on the rhevm product, and maintains package the ovirt tools currently. As part of being power user on jenkins.ovirt.org, he will create new jobs to build and release tools for the various OS supported. I vote +1 as i personally know kiril and he's experience. Thansk, Eyal. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Import/snapshots duplicate MAC support
- Original Message - From: Mike Kolesnik mkole...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Wednesday, 6 February, 2013 8:13:11 AM Subject: [Engine-devel] Import/snapshots duplicate MAC support Hi, The current situation dictates that if the configuration value AllowDuplicateMacAddresses is set to false (this is the default setting), then we block import or switching snapshots where a MAC address in one or more of the snapshot/ovf's virtual NICs is already used. Given that we don't currently give the admin any option to select otherwise, I'm not sure that's a very robust behaviour.. First of all the MAC address should be unique per network and not in the whole system (like it is currently). Furthermore, as long as in the same network there are no two virtual NICs running with the same address, it is not such a bad situation. Therefore, I would like to propose a couple of solutions (from backend perspective): 1. Keep blocking. 2. Keep blocking but fix the mac pools to be per network basis. 3. Don't block, and allow duplicate MACs in these scenarios, but block on activating a NIC with duplicate MAC address. Warn the user that the NIC is with duplicate MAC, and perhaps even unplug or unwire it so that it would be obvious that it's using someone else's MAC. 4. Don't block, and give the problematic NIC a new MAC from the pool. Solution 1 is obviously not the greatest (hence this email). In my opinion, 4 is sort of a cat in a bag, since I'm not sure changing the HWADDR for the guest OS is really a good idea. Solution 2 would be nice going forward, but it just reduces the chances of an admin to come across this situation and doesn't solve it entirely. Hence, I would favour solution 3 which seems to solve the problem and allow the admin to choose what to do. Please voice your opinion, or propose an alternate solution. Another solution would be to perform the action without adding the problematic vNic, and notify the user about it. Overall, I am in favor of solution 3 as well. Regards, Mike ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] engine-config behaviour on -g by alternateKey
On 07/02/2013 14:59, Martin Betak wrote: - Original Message - From: Itamar Heim ih...@redhat.com To: Martin Betak mbe...@redhat.com Cc: engine-devel@ovirt.org Sent: Thursday, February 7, 2013 1:12:03 PM Subject: Re: [Engine-devel] engine-config behaviour on -g by alternateKey On 07/02/2013 12:08, Martin Betak wrote: Hi All, I've been working on the ability to set keyboard layout for VNC server as per each individual VM. Currently the only option is to use engine-config to set the value globally, e.g. engine-config -s VncKeyboardLayout=en-us. After adding this option to database and respective entities there were raised valid concerns about why is this option called VncKeyboardLayout and not just KeyboardLayout as it applies to SPICE equally (note that also VDSM calls this config value as 'keyboardLayout'). So to achieve consistency I also renamed it in engine-config.properties and set KeyboardLayout.alternateKey=VncKeyboardLayout. This indeed works for setting (engine-config -s VncKeyboardLayout=en-us sets KeyboardLayout and engine-config -g KeyboardLayout works but it is unable to read the value by the alternateKey) engine-config -g VncKeyboardLayout fails with no such entry with default version in the method EngineConfigLogic.printAllValuesForKey as it is passing the user given key name directly to database which returns zero results. Setter methods such as EngineConfigLogic.persistValue use the entity ConfigKey constructed from the user given key-name which correctly constructs appropriate ConfigKey even when given alternateKey name. So I wanted to ask whether this is the desired behaviour (set by alternateKey name but get only by the primary) or is this a bug? I have also simple patch that fixes this and enables also getting the config value by alternateKey. Thank you ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel Make sense that if we allow alternate names for backward compatibility/etc., -g will work for them as well, so my view is worth fixing in the config tool. but, are you sure it affects spice? i thought spice has its own handling for this. I traced the appropriate setting to VDSM code which builds the libvirt xml configuration and it seems that the option VNC/spice is orthogonal to the keyboard layout - i.e. you chooose your connection type VNC/spice and then you choose your keyboard layout independently - you can see this exact behaviour in virt-manager for example in the Display Spice panel. Also the only place where ConfigValues.VncKeyboardLayout is used is in VmInfoBuilderBase to set a config property called VdsProperties.KeyboardLayout :-) So should I include the patch for engine-config (very small local change - only 3 lines) in my current patch http://gerrit.ovirt.org/#/c/11314/ ? Thanks please indent your replies to be easier to see what your reply is. please check with spice developers, i remember something about in spice the keyboard layout is handled by spice based on client keyboard layout, regardless of the qemu parameter. btw, iirc, qemu now supports enabling both spice an vnc. i think we should consider enabling both. and yes, seems like a reasonable patch, but should be a separate one to yours (yours should depend on it i guess) ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Proposing Kiril nesenko as power user for ovirt engine tools
On 02/07/2013 10:39 AM, Eyal Edri wrote: Hi, I would like to propose kiril nesenko as 'jenkins power user' for ovirt engine tools. These tools indlude iso uploader, log collector, image uploader and others. Kiril is very involved in building and running Jenkins jobs on the rhevm product, and maintains package the ovirt tools currently. As part of being power user on jenkins.ovirt.org, he will create new jobs to build and release tools for the various OS supported. I vote +1 as i personally know kiril and he's experience. +1 as well. Thansk, Eyal. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] Proposing Kiril nesenko as power user for ovirt engine tools
Seems like enough +1 and not objections, Kiril, i will send you credentials in private. thanks, eyal. - Original Message - From: Moti Asayag masa...@redhat.com To: Eyal Edri ee...@redhat.com Cc: infra in...@ovirt.org, knesenko knese...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Thursday, February 7, 2013 7:00:39 PM Subject: Re: [Engine-devel] Proposing Kiril nesenko as power user for ovirt engine tools On 02/07/2013 10:39 AM, Eyal Edri wrote: Hi, I would like to propose kiril nesenko as 'jenkins power user' for ovirt engine tools. These tools indlude iso uploader, log collector, image uploader and others. Kiril is very involved in building and running Jenkins jobs on the rhevm product, and maintains package the ovirt tools currently. As part of being power user on jenkins.ovirt.org, he will create new jobs to build and release tools for the various OS supported. I vote +1 as i personally know kiril and he's experience. +1 as well. Thansk, Eyal. ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
