Re: [Engine-devel] Feedback/ input needed on Host power management

2013-08-20 Thread Eli Mesika


- Original Message -
> From: "Malini Rao" 
> To: "engine-devel" 
> Cc: us...@ovirt.org, "Itamar Heim" , "Eli Mesika" 
> , "Einav Cohen"
> , "Eldan Hildesheim" 
> Sent: Tuesday, August 20, 2013 10:50:43 PM
> Subject: Re: Feedback/ input needed on Host power management
> 
> Hello everyone,
> 
> We received a few responses to the email below that were very helpful and it
> seemed like while some people preferred one over the other concept, there
> was a general need to see the power management card details in a handy
> manner. Taking all the feedback into account, we have made an iteration to
> the concept and want to present it back to you for your feedback. Please see
> attached. In this version, the dialog presents the following flow from top
> to bottom -
> 
> 1. enable power management
> 2. Then Select which cards to use
> 3. Then indicate to the system whether those cards should be used
> concurrently or sequentially.
> 
> Within Step 2 in the flow, the details for each card are collapsed by default
> but can easily be expanded.

Well , few comments :

1) The Proxy Preference field is per Host not per card , it seems in your 
suggestion that it is per card.
   Therefor , it should be moved to the top of the screen below the Enable 
Power Management checkbox 
2) The + for adding card is redundant, currently we are not supporting that , 
only 2 cards are permitted , when we will support that we will have to 
re-factor this design anyway since the concurrent or sequential can be treated 
differently. for example , you may have 2 concurrent APC cards along with a 
sequential IPMI 

> 
> Besides feedback on the attached mockup, we also have some questions that we
> would like some clarifications on -
> 
> 1. When power management is enabled on a host, will at least one card NEED to
> be enabled? If yes, is that always the Primary card ( in other words, should
> the primary card ever be disabled?)

Yes , and it is always teh primary card
> 
> 2. Currently, in the mockup, we have checkboxes to enable and disable certain
> cards and also the ability to add cards. Should there be an ability to
> remove cards too in addition to turning them on/ off or is it ok to just
> add/ remove and take out the checkboxes all together?

Currently only a static design with places for primary/secondary definitions , 
no add/remove is required for 3.3 

> 
> Thanks
> Malini
> 
> 
> 
> 
> - Original Message -
> From: "Malini Rao" 
> To: "engine-devel" 
> Cc: us...@ovirt.org, "Itamar Heim" , "Eli Mesika"
> , "Einav Cohen" , "Eldan Hildesheham"
> 
> Sent: Wednesday, August 14, 2013 2:50:46 PM
> Subject: Feedback/ input needed on Host power management
> 
> Hello all,
> 
> In taking a look at the current implementation of Hosts> Power management, we
> have come up with a couple of approaches on improving this from a UX
> perspective
> -http://www.ovirt.org/Talk:Community#UXD_Proposals_for_Host_Power_management.
> We want your thoughts and input on what approach makes more sense from a
> user's perspective before fine tuning the UI.
> 
> Thanks
> Malini
> User Experience designer
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Gluster Volume asynchronous tasks

2013-08-20 Thread Sahina Bose


On 08/20/2013 04:00 AM, Itamar Heim wrote:

On 08/12/2013 06:09 AM, Sahina Bose wrote:


On 08/12/2013 03:28 PM, Yair Zaslavsky wrote:


- Original Message -

From: "Sahina Bose" 
To: "Eli Mesika" 
Cc: "engine-devel" , a...@ovirt.org
Sent: Monday, August 12, 2013 11:51:15 AM
Subject: Re: [Engine-devel] Gluster Volume asynchronous tasks


On 08/12/2013 01:21 PM, Eli Mesika wrote:

- Original Message -

From: "Sahina Bose" 
To: "engine-devel" , a...@ovirt.org, 
"Michael

Pasternak" 
Sent: Monday, August 12, 2013 8:41:55 AM
Subject: [Engine-devel] Gluster Volume asynchronous tasks

Hi all,

We are working on a feature to add support to start and monitor
gluster
volume asynchronous tasks (like rebalancing a gluster volume, 
removing

brick from volume ) from the oVirt engine.

The operations can be started from the Volumes tab or the Bricks
sub-tab
using the Rebalance, Remove options.
These are long running operations which can be monitored using a
task id
returned from Gluster. We are planning to add the monitoring in the
existing Task sub tab

The feature description and User flows are at
http://www.ovirt.org/Features/Gluster_Volume_Asynchronous_Tasks_Management 




The detailed design (including REST API design) is at
http://www.ovirt.org/Features/Detailed_Gluster_Volume_Asynchronous_Tasks_Management. 




I would really appreciate if you could review and provide your
valuable
feedback.

I Sahina
Why not using 6the External Tasks feature introduced for 3.3 for 
those

Gluster tasks ???
http://www.ovirt.org/Features/Design/DetailedExternalTasks

Hi Eli,

We still want to be able to start and stop these operations from the
engine.
So, when a user wants to say, rebalance a volume, they would go select
the volume and click on Rebalance Start.
This would then call the BLL command to start rebalance which will
invoke the corresponding vdsm verb to start the rebalance on the 
volume.

This is the same as existing flow for other commands. The only
difference is the vdsm verb will return the task id from gluster, for
the rebalance operation that was started. And we will monitor the
progress of the task using the gluster task id (by calling a gluster
command)

I'm not sure how ExternalTasks would fit in here? I was thinking of
using ExternalTask support for adding Job/Steps to engine when the
operation is started outside of engine, that is, from Gluster CLI.
Please correct me if I'm missing something.

Does this mean that from Gluster CLI you will not try and invoke the
rebalance command ?
(I mean, I should either use Gluster CLI or Engine's REST API?)

Rebalance volume command could be invoked in any of the following ways:
1. From the console UI (clicking on Rebalance as shown in
http://www.ovirt.org/Features/Gluster_Volume_Asynchronous_Tasks_Management#Rebalance_Volume) 



2. Using REST API
3. Outside of engine, from Gluster CLI - In such cases, the engine
should detect that a user has triggered rebalance operation outside the
engine, and allow the user to monitor progress of this from the engine.
This is where, we need support to add a Job for an operation that was
started externally, so that it can be seen in the Tasks tab.


and still, it should be considered an internal task, since the engine 
is managing it / detected it.




Itamar, yes, you are right. This would need to be treated as an internal 
task as the engine needs to be able to stop it and also monitor it. We 
would probably need a similar mechanism as external task injection, to 
add a Job for the task started from gluster CLI.



___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] Rebuild ovirt 3.2.1 success, but lost i18n support

2013-08-20 Thread An Yang
Hi all,

I just rebuild ovirt-engine 3.2.1 aaccording to
http://www.ovirt.org/Building_oVirt_engine , it work fine, but I could
not choose the language, it always display U.S. English UI.
Could you give me a hand, how can I enable GWT's i18n support, or
something is wrong in my building ENV? 

Thanks in advance.
An Yang


signature.asc
Description: This is a digitally signed message part
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Issues with IBM POWER support in oVirt engine

2013-08-20 Thread Michal Skrivanek

On Aug 16, 2013, at 22:02 , Vitor de Lima  wrote:

> Hi everyone,
>  
> I wrote some code to run a VM on a IBM POWER host, but I stumbled in some 
> issues that will need a little bit of refactoring in the current code and I 
> would like some feedback.
>  
> The first issue is that KVM on POWER requires a special SCSI interface 
> (called SPAPR), which is not available in x86-64. Currently I’m solving this 
> problem by using (in the VmInfoBuilder class):
>  
> if (vm.getArchitecture().equals(ArchitectureType.ppc64)) {
>Map struct = new HashMap();
> struct.put(VdsProperties.Type, VmDeviceType.CONTROLLER.getName());
> struct.put(VdsProperties.Device, VdsProperties.Scsi);
>  
>// Create a controller in the index 1, the VirtIO_SCSI interface 
> is in index 0
> struct.put(VdsProperties.Index, "1");
>  
> Map spaprAddress = new HashMap();
>  
> spaprAddress.put("type", "spapr-vio");
>  
> struct.put(VdsProperties.Address, spaprAddress);
>  devices.add(struct);
> }
>  
> But this is a poor solution, because this class would be polluted by 
> architectural differences. Another thing to notice is that since in IBM POWER 
> there are two SCSI controllers, all the SCSI devices must have their SCSI 
> address explicitly defined (it was not needed before, since there was just 
> one controller before). It was proposed that a “strategy” class could solve 
> the problem, but I would like to have some feedback on which package it 
> should be, since it will also be used in the bll package to validate other 
> stuff.
>  
> The second issue is that the CD-ROM interface is SCSI on POWER guests (and 
> must be attached to the SPAPR interface) and IDE on the x86_64, this 
> information could be retrieved from the osinfo (by creating a property there) 
> or It could be hard-coded in the strategy class.
> Which would be the best way to handle this difference?

the strategy class might be sufficient for now, if it's not difficult/ugly

>  
> The third and final issue is that when the VNC protocol is used in a VM, by 
> default a Cirrus Logic VGA device is created. This device is not supported on 
> POWER guests, but the standard VGA device is. I made a workaround, but the 
> issue is where to put this association between the device type and the 
> display protocol.
> Should it also be a property in the osinfo? Or it should be handled in the 
> strategy class?

we have a sort of mapping today that qxl means SPICE and cirrus means VNC, 
going forward we'd like to give a bit more flexibility, so elsewhere it was 
suggested to put into osinfo the list of supported devices/cards to pick from. 
I think it's still fine to use the simple "mapping", just add standard vga.
The meaning would be qxl means SPICE or VNC(user can pick - this is to allow 
both spice and vnc console access as you can use both on qxl in fact.), cirrus 
means VNC, vga would also mean VNC
osinfo would contain the list of devices and we just need to make sure cirrus 
and vga is exclusive as they both mean the same value in Edit VM protocol drop 
down box 

Thanks,
michal


>  
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel

___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Rebuild ovirt 3.2.1 success, but lost i18n support

2013-08-20 Thread An Yang
> - Original Message -
> > From: "An Yang" 
> > To: "engine-devel" 
> > Sent: Tuesday, August 20, 2013 10:22:36 AM
> > Subject: [Engine-devel] Rebuild ovirt 3.2.1 success, but lost i18n support
> > 
> > Hi all,
> > 
> > I just rebuild ovirt-engine 3.2.1 according to
> > http://www.ovirt.org/Building_oVirt_engine , it work fine, but I could not
> > choose the language, it always display U.S. English UI.
> > Could you give me a hand, how can I enable GWT's i18n support, or something
> > is wrong in my building ENV?
> 
> No. Something wrong with the approach that was taken to write the spec file 
> with developers in mind and not production.
> 
> This has been resolved in 3.3.
> 
> For 3.2 you can try:
> 
> # git clone ...
> # cd ...
> # make dist
> # rpmbuild -D"EXTRA_BUILD_FLAGS -P all-langs" -tb 

It works, thanks Alon. 

> 
> Regards,
> Alon


-- 
Bests,

An Yang
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] [vdsm] Jenkins job to run networking functional tests

2013-08-20 Thread Eyal Edri
OK,

Since i see now -1 and enough +1, i'll add giuseppe as power user for network 
tests on ovirt.
congrats.

I will send you the details in private.
please contact infra team if you need assistance with setting up the jobs.

Eyal.

- Original Message -
> From: "Assaf Muller" 
> To: "Sandro Bonazzola" 
> Cc: "Eyal Edri" , "engine-devel" , 
> "vdsm-devel"
> , "infra" 
> Sent: Monday, August 19, 2013 5:50:16 PM
> Subject: Re: [vdsm] Jenkins job to run networking functional tests
> 
> +1
> 
> Giuseppe is our go to guy as far as networking tests go!
> 
> - Original Message -
> From: "Sandro Bonazzola" 
> To: "Eyal Edri" 
> Cc: "engine-devel" , "vdsm-devel"
> , "infra" 
> Sent: Monday, August 19, 2013 2:20:36 PM
> Subject: Re: [vdsm] Jenkins job to run networking functional tests
> 
> Il 19/08/2013 11:26, Eyal Edri ha scritto:
> > [adding devel lists]
> > 
> > Usually to get power user privileges you need get +1 community (mostly
> > relevant people in your team/project).
> > saying you're familiar with jenkins and the project and is cabaple of
> > adding jobs to the project.
> > 
> > I personally give +1 since i know you're contribution and experience.
> > 
> > Eyal.
> 
> +1 from me too.
> 
> Sandro
> 
> 
> 
> 
> 
> > 
> > - Original Message -
> >> From: "Giuseppe Vallarelli" 
> >> To: "infra" 
> >> Sent: Monday, August 19, 2013 10:19:46 AM
> >> Subject: Jenkins job to run networking functional tests
> >>
> >> Hello everybody, following the previous discussion with Eyal,
> >> I need to get rights in order to create a jenkins job to
> >> achieve what stated in the subject.
> >>
> >> Is it the right place for such request?
> >>
> >> Cheers, Giuseppe
> >>
> >> - Forwarded Message -
> >> | From: "Eyal Edri" 
> >> | To: "Giuseppe Vallarelli" 
> >> | Cc: "infra" 
> >> | Sent: Sunday, August 18, 2013 2:06:22 PM
> >> | Subject: Re: running network functional tests
> >> | 
> >> | Hi,
> >> | 
> >> | Usually in these cases when a new job is requested to a specific
> >> | project/component,
> >> | A 'power user' for the relevant team (in your case network), is given
> >> | privileges on the Jenkins machine
> >> | to add any job required.
> >> | 
> >> | I would propose the following:
> >> |  1. request power user access to jenkins.ovirt.org (if you don't already
> >> |  have)
> >> |  2. add a new job with your functional test per commit (not per patch
> >> |  for
> >> |  starts)
> >> | any infra member can assist you with the labels for slaves / os
> >> | /etc...
> >> |  3. once that job is running properly, you can contact infra to assist
> >> |  in
> >> |  converting it to a per-patch job
> >> | with the topic / field verification logic done.
> >> |  4. not sure if this is relevant to your tests, but all existing jenkins
> >> |  slaves are VMs and not bare-metal.
> >> | 
> >> | i hope this helps.
> >> | 
> >> | Eyal.
> >> | 
> >> | - Original Message -
> >> | > From: "Giuseppe Vallarelli" 
> >> | > To: "infra" 
> >> | > Sent: Friday, August 16, 2013 12:28:43 PM
> >> | > Subject: Fwd: running network functional tests
> >> | > 
> >> | > - Forwarded Message -
> >> | > | From: "Giuseppe Vallarelli" 
> >> | > | To: "infra" 
> >> | > | Cc: "David Caro Estevez" 
> >> | > | Sent: Monday, August 12, 2013 10:58:04 AM
> >> | > | Subject: running network functional tests
> >> | > | 
> >> | > | Hello everbody!
> >> | > | Just recently we added networking functional tests and we would like
> >> | > | to have them running when we submit patches network related, i.e.
> >> | > | going to affect network modules. Displaying success or failure
> >> | > | as it happens with the current unittests.
> >> | > | 
> >> | > | Requirements/ideas:
> >> | > | 
> >> | > | - OS Fedora 19/RHEL6.4 should not matter.
> >> | > | 
> >> | > | - Kernel module used: bonding, dummy.
> >> | > | 
> >> | > | - No more than one 'instance' of networkTests should run
> >> | > |   on a specific host, simply because we use some global
> >> | > |   constants to identify network name vlan id and so on.
> >> | > | 
> >> | > | - Ideally we can use a previously proposed idea of commit tag
> >> | > |   where for example @networking is provided in the commit msg
> >> | > |   title to identify the need of running also the network
> >> | > |   functional tests.
> >> | > | 
> >> | > | - We should be able to run at the same time functional networking
> >> | > |   tests and unit tests - I don't expect any conflicts.
> >> | > | 
> >> | > | Would be cool to have a test run before -1s all networking patches
> >> | > | in case of problems :-)
> >> | > | 
> >> | > | Let me know if more information are needed.
> >> | > | 
> >> | > | 
> >> | > | Cheers, Giuseppe
> >> | > 
> >> | > Is there any update on the subject?
> >> | > 
> >> | > Any estimate to have functional network tests running?
> >> | > I mind that we can run network functional tests upstream
> >> | > that will speed up our workflow and possibly decrease the
> >> | > 

Re: [Engine-devel] Rebuild ovirt 3.2.1 success, but lost i18n support

2013-08-20 Thread Alon Bar-Lev


- Original Message -
> From: "An Yang" 
> To: "engine-devel" 
> Sent: Tuesday, August 20, 2013 10:22:36 AM
> Subject: [Engine-devel] Rebuild ovirt 3.2.1 success, but lost i18n support
> 
> Hi all,
> 
> I just rebuild ovirt-engine 3.2.1 according to
> http://www.ovirt.org/Building_oVirt_engine , it work fine, but I could not
> choose the language, it always display U.S. English UI.
> Could you give me a hand, how can I enable GWT's i18n support, or something
> is wrong in my building ENV?

No. Something wrong with the approach that was taken to write the spec file 
with developers in mind and not production.

This has been resolved in 3.3.

For 3.2 you can try:

# git clone ...
# cd ...
# make dist
# rpmbuild -D"EXTRA_BUILD_FLAGS -P all-langs" -tb 

Regards,
Alon
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


[Engine-devel] Rebuild ovirt 3.2.1 success, but lost i18n support

2013-08-20 Thread An Yang
Hi all,

I just rebuild ovirt-engine 3.2.1 according to
http://www.ovirt.org/Building_oVirt_engine , it work fine, but I could
not choose the language, it always display U.S. English UI.
Could you give me a hand, how can I enable GWT's i18n support, or
something is wrong in my building ENV? 

Thanks in advance.
-- 
Bests,

An Yang
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel