Re: [Engine-devel] Tweaking backup/restore of engine and the table 'audit_log'

2014-03-05 Thread Eli Mesika


- Original Message -
> From: "Sven Kieske" 
> To: engine-devel@ovirt.org
> Sent: Tuesday, March 4, 2014 10:10:31 AM
> Subject: Re: [Engine-devel] Tweaking backup/restore of engine and the table 
> 'audit_log'
> 
> Thanks for your answer so far.
> 
> Is there anyone around who knows
> if the audit_log data is needed for a successful restore?
> I'd rather not try this out myself.

only the table is needed, the data may be truncated and this not affect the way 
the engine will work, you will just loose the events/alerts history.


> 
> The reasoning behind this all is of course to keep backup
> space as small as possible.
> 
> Am 03.03.2014 21:41, schrieb Yedidyah Bar David:
> > I have no idea - I guess the data is not necessary.
> 
> --
> Mit freundlichen Grüßen / Regards
> 
> Sven Kieske
> 
> Systemadministrator
> Mittwald CM Service GmbH & Co. KG
> Königsberger Straße 6
> 32339 Espelkamp
> T: +49-5772-293-100
> F: +49-5772-293-333
> https://www.mittwald.de
> Geschäftsführer: Robert Meyer
> St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
> Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
> ___
> Engine-devel mailing list
> Engine-devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
> 
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Tweaking backup/restore of engine and the table 'audit_log'

2014-03-04 Thread Sven Kieske
Thanks for your answer so far.

Is there anyone around who knows
if the audit_log data is needed for a successful restore?
I'd rather not try this out myself.

The reasoning behind this all is of course to keep backup
space as small as possible.

Am 03.03.2014 21:41, schrieb Yedidyah Bar David:
> I have no idea - I guess the data is not necessary.

-- 
Mit freundlichen Grüßen / Regards

Sven Kieske

Systemadministrator
Mittwald CM Service GmbH & Co. KG
Königsberger Straße 6
32339 Espelkamp
T: +49-5772-293-100
F: +49-5772-293-333
https://www.mittwald.de
Geschäftsführer: Robert Meyer
St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel


Re: [Engine-devel] Tweaking backup/restore of engine and the table 'audit_log'

2014-03-03 Thread Yedidyah Bar David
- Original Message -
> From: "Sven Kieske" 
> To: engine-devel@ovirt.org
> Sent: Monday, March 3, 2014 6:25:39 PM
> Subject: [Engine-devel] Tweaking backup/restore of engine
> 
> Hi,
> 
> currently all events are stored in the table audit_log
> which all gets saved when you use the engine-backup
> shell script.
> 
> 
> the event log is full of these login lines (engine 3.3.2):
> 
> 25652 fdfc627c-d875-11e0-90f0-83df133b58ccadmin@internal
> ----  \N  \N  \N  \N  \N  
> 2014-01-20
> 06:39:17.222+01   USER_VDC_LOGIN  30  0   User admin@internal
> logged in.f   \N  \N  
> ----\N  \N  \N
> \N----\N  oVirt   -1  30  
> f   \N
> 
> this makes the log and db grow very large when you use the REST-API
> to query ovirt for various data.
> 
> Is this necessary for a working restore?

I have no idea - I guess the data is not necessary.

I also guess that the schema is.

> It would be cool if we could tweak the engine-backup
> tool to just dump necessary tables so you don't have
> to restore events from the past no one is interested
> in.
> 
> How does ovirt react, if I do not restore the content of the audit_log
> table?
> 
> If this works (restore without audit_log) I would prefer to have
> this code upstream in ovirt git so I don't have to maintain
> my own backupscript.
> 
> Would it be possible to extend the existing backupscript
> with a switch to not backup logs?
> Currently it's just "all" or "just db".

It would be easy to let you pass an "extra options" argument for pg_dump.
This will allow adding '-T audit_log'. As I said, I am pretty certain
that you do need the table itself, so this will not help you much.

I personally think that this isn't the right way to go. If you do not need
the data, create a cron job that will periodically truncate it - say, keep
the last X days and delete the rest. Perhaps also archive before deleting
if you want. If you want, open a bug to provide a script to do that for you.
Or make the engine itself do that, etc.

Of course, after verifying that this does not have a significant impact on
the engine :-)

> 
> I also recall that there shouldn't occur multiple login events any
> more since ovirt 3.3. but it still seems to be the case.
> 
> I also do not understand how you would manage a stored authentication
> via REST as REST is stateless.
> 
> I would appreciate any feedback or thoughts on this topic.

Best regards,
-- 
Didi
___
Engine-devel mailing list
Engine-devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel