Re: [Engine-devel] find-bugs errors
- Original Message - From: Vojtech Szocs vsz...@redhat.com Sent: Wednesday, January 22, 2014 8:47:21 AM - Original Message - From: Einav Cohen eco...@redhat.com To: Moti Asayag masa...@redhat.com, Vojtech Szocs vsz...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Tuesday, January 21, 2014 10:41:24 PM Subject: find-bugs errors (1) @Moti: see [1] and [2]. it seems that they were caused by http://gerrit.ovirt.org/#/c/23507/ (2) @Vojtech[/UI Maintainers/others]: see [3] - it seems that the UI's AppErrors.java file became too large for find-bugs to handle. Any ideas on how to handle this (add to ignore list/ divide to several files/...)? As far as I can tell, FindBugs has hard-coded limit of class size (1M) method count (1K). Any class exceeding these limits will be skipped with SKIPPED_CLASS_TOO_BIG warning. See [a] for details. In WebAdmin we already exclude ApplicationConstants from SKIPPED_CLASS_TOO_BIG warning [b]. I suggest to do the same for AppErrors. Dividing AppErrors into smaller files doesn't make sense as this is GWT i18n interface that only contains i18n constant keys with default values, no logic whatsoever. Thanks, Vojtech - it looks like AppErrors was added to the relevant exclude-filters.xml file [http://gerrit.ovirt.org/#/c/23547/] earlier today - thanks Arik/Tomas/Omer for the prompt handling! find-bugs is now green again. [a] http://sourceforge.net/p/findbugs/feature-requests/260/ [b] frontend/webadmin/modules/webadmin/exclude-filters.xml Vojtech [1] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1158699741/source.27/#386 [2] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1158699741/source.28/#387 [3] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1188557915/ - Forwarded Message - From: Jenkins ci oVirt Server jenk...@ovirt.org To: engine-patc...@ovirt.org, fsimo...@redhat.com Sent: Tuesday, January 21, 2014 4:11:24 PM Subject: [Engine-patches] [oVirt Jenkins] ovirt_engine_master_find_bugs - Build # 6308 - Still Unstable! Project: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/ Build Number: 6308 Build Status: Still Unstable Triggered By: Started by an SCM change - Changes Since Last Success: - Changes for Build #6301 [Moti Asayag] engine: Extract AddNetworksByLabelParametersBuilder [Moti Asayag] engine: Support attaching two labeled networks to a cluster [Moti Asayag] engine: Extract RemoveNetworksByLabelParametersBuilder [Moti Asayag] engine: Support detaching two labeled networks from a cluster [Lior Vernia] webadmin: Replaced Profiles by vNIC Profiles Changes for Build #6302 [Sergey Gotliv] engine, dao: Introduce ISCSI Bond entity, tables and dao [Sergey Gotliv] engine: Introduce commands to manage iscsi bonds entities [Sergey Gotliv] engine: Setup multiple iscsi sessions with the iscsi target Changes for Build #6303 [Sergey Gotliv] webadmin: Allow to configure ISCSI multipathing in the dc context [Martin Perina] tools: Adds more validations to MAIL_PORT in notifier [Moti Asayag] engine: Fix findbugs warnings about Map values iteration [Lior Vernia] webadmin: Hide content widget of boot protocol label Changes for Build #6304 [Lior Vernia] webadmin: Integrate VM icon into Add/Edit Network dialog Changes for Build #6305 [Alexander Wels] webadmin: Double click collapse system tree Changes for Build #6306 [Daniel Erez] restapi: del storage conn if domain creation fails Changes for Build #6307 [Moti Asayag] restapi: Preserve labels when setup networks is sent Changes for Build #6308 [Federico Simoncelli] core: set local storage domain format - Failed Tests: - No tests ran. ___ Engine-patches mailing list engine-patc...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] find-bugs errors
(1) @Moti: see [1] and [2]. it seems that they were caused by http://gerrit.ovirt.org/#/c/23507/ (2) @Vojtech[/UI Maintainers/others]: see [3] - it seems that the UI's AppErrors.java file became too large for find-bugs to handle. Any ideas on how to handle this (add to ignore list/ divide to several files/...)? [1] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1158699741/source.27/#386 [2] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1158699741/source.28/#387 [3] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1188557915/ - Forwarded Message - From: Jenkins ci oVirt Server jenk...@ovirt.org To: engine-patc...@ovirt.org, fsimo...@redhat.com Sent: Tuesday, January 21, 2014 4:11:24 PM Subject: [Engine-patches] [oVirt Jenkins] ovirt_engine_master_find_bugs - Build # 6308 - Still Unstable! Project: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/ Build Number: 6308 Build Status: Still Unstable Triggered By: Started by an SCM change - Changes Since Last Success: - Changes for Build #6301 [Moti Asayag] engine: Extract AddNetworksByLabelParametersBuilder [Moti Asayag] engine: Support attaching two labeled networks to a cluster [Moti Asayag] engine: Extract RemoveNetworksByLabelParametersBuilder [Moti Asayag] engine: Support detaching two labeled networks from a cluster [Lior Vernia] webadmin: Replaced Profiles by vNIC Profiles Changes for Build #6302 [Sergey Gotliv] engine, dao: Introduce ISCSI Bond entity, tables and dao [Sergey Gotliv] engine: Introduce commands to manage iscsi bonds entities [Sergey Gotliv] engine: Setup multiple iscsi sessions with the iscsi target Changes for Build #6303 [Sergey Gotliv] webadmin: Allow to configure ISCSI multipathing in the dc context [Martin Perina] tools: Adds more validations to MAIL_PORT in notifier [Moti Asayag] engine: Fix findbugs warnings about Map values iteration [Lior Vernia] webadmin: Hide content widget of boot protocol label Changes for Build #6304 [Lior Vernia] webadmin: Integrate VM icon into Add/Edit Network dialog Changes for Build #6305 [Alexander Wels] webadmin: Double click collapse system tree Changes for Build #6306 [Daniel Erez] restapi: del storage conn if domain creation fails Changes for Build #6307 [Moti Asayag] restapi: Preserve labels when setup networks is sent Changes for Build #6308 [Federico Simoncelli] core: set local storage domain format - Failed Tests: - No tests ran. ___ Engine-patches mailing list engine-patc...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors
- Original Message - From: Einav Cohen eco...@redhat.com To: Moti Asayag masa...@redhat.com, Vojtech Szocs vsz...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Tuesday, January 21, 2014 11:41:24 PM Subject: find-bugs errors (1) @Moti: see [1] and [2]. it seems that they were caused by http://gerrit.ovirt.org/#/c/23507/ A fix is pending review: http://gerrit.ovirt.org/23525 (2) @Vojtech[/UI Maintainers/others]: see [3] - it seems that the UI's AppErrors.java file became too large for find-bugs to handle. Any ideas on how to handle this (add to ignore list/ divide to several files/...)? [1] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1158699741/source.27/#386 [2] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1158699741/source.28/#387 [3] http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/findbugsResult/module.-1188557915/ - Forwarded Message - From: Jenkins ci oVirt Server jenk...@ovirt.org To: engine-patc...@ovirt.org, fsimo...@redhat.com Sent: Tuesday, January 21, 2014 4:11:24 PM Subject: [Engine-patches] [oVirt Jenkins] ovirt_engine_master_find_bugs - Build # 6308 - Still Unstable! Project: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6308/ Build Number: 6308 Build Status: Still Unstable Triggered By: Started by an SCM change - Changes Since Last Success: - Changes for Build #6301 [Moti Asayag] engine: Extract AddNetworksByLabelParametersBuilder [Moti Asayag] engine: Support attaching two labeled networks to a cluster [Moti Asayag] engine: Extract RemoveNetworksByLabelParametersBuilder [Moti Asayag] engine: Support detaching two labeled networks from a cluster [Lior Vernia] webadmin: Replaced Profiles by vNIC Profiles Changes for Build #6302 [Sergey Gotliv] engine, dao: Introduce ISCSI Bond entity, tables and dao [Sergey Gotliv] engine: Introduce commands to manage iscsi bonds entities [Sergey Gotliv] engine: Setup multiple iscsi sessions with the iscsi target Changes for Build #6303 [Sergey Gotliv] webadmin: Allow to configure ISCSI multipathing in the dc context [Martin Perina] tools: Adds more validations to MAIL_PORT in notifier [Moti Asayag] engine: Fix findbugs warnings about Map values iteration [Lior Vernia] webadmin: Hide content widget of boot protocol label Changes for Build #6304 [Lior Vernia] webadmin: Integrate VM icon into Add/Edit Network dialog Changes for Build #6305 [Alexander Wels] webadmin: Double click collapse system tree Changes for Build #6306 [Daniel Erez] restapi: del storage conn if domain creation fails Changes for Build #6307 [Moti Asayag] restapi: Preserve labels when setup networks is sent Changes for Build #6308 [Federico Simoncelli] core: set local storage domain format - Failed Tests: - No tests ran. ___ Engine-patches mailing list engine-patc...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors - please investigate/fix
On Apr 24, 2013, at 07:49 , Sahina Bose sab...@redhat.com wrote: On 04/24/2013 07:47 AM, Einav Cohen wrote: ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks! @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an unreachable OnSuccess method within an anonymous class or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 [again - not sure when introduced - seems old, hence I suspect it is a false positive] Doesn't really seem to work correctly. Tooltip is talking about OnSuccess method for all mine above and it really doesn't seem to correspond with reality. Looks like findbugs is broken or confused Thanks, Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors - please investigate/fix
On 04/24/2013 07:47 AM, Einav Cohen wrote: ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks! @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an unreachable OnSuccess method within an anonymous class or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 [again - not sure when introduced - seems old, hence I suspect it is a false positive] Thanks, Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors - please investigate/fix
Seems that the cleanup worked, now the actual results after the frontend cleanup pathces are shown without the false positives http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4069/ On 04/24/2013 10:11 AM, Michal Skrivanek wrote: On Apr 24, 2013, at 07:49 , Sahina Bosesab...@redhat.com wrote: On 04/24/2013 07:47 AM, Einav Cohen wrote: ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks! @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an unreachable OnSuccess method within an anonymous class or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 [again - not sure when introduced - seems old, hence I suspect it is a false positive] Doesn't really seem to work correctly. Tooltip is talking about OnSuccess method for all mine above and it really doesn't seem to correspond with reality. Looks like findbugs is broken or confused Thanks, Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors - please investigate/fix
I've seen it too, it's after a series of patches I pushed to solve some findbugs issue that we got this false positive, I've asked Eyal to clean the target, it seems that findbugs is referring to old code that doesn't exist anymore. On 04/24/2013 10:11 AM, Michal Skrivanek wrote: On Apr 24, 2013, at 07:49 , Sahina Bosesab...@redhat.com wrote: On 04/24/2013 07:47 AM, Einav Cohen wrote: ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 caused by: http://gerrit.ovirt.org/#/c/13831/ Have submitted a patch (http://gerrit.ovirt.org/#/c/14187/) fixing this. Thanks! @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an unreachable OnSuccess method within an anonymous class or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 [again - not sure when introduced - seems old, hence I suspect it is a false positive] Doesn't really seem to work correctly. Tooltip is talking about OnSuccess method for all mine above and it really doesn't seem to correspond with reality. Looks like findbugs is broken or confused Thanks, Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
[Engine-devel] find-bugs errors - please investigate/fix
ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 caused by: http://gerrit.ovirt.org/#/c/13831/ @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an unreachable OnSuccess method within an anonymous class or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 [again - not sure when introduced - seems old, hence I suspect it is a false positive] Thanks, Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors - please investigate/fix
it seems that after the fixes and clean-up, find-bugs is now back to normal: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4073/ all - many thanks for your prompt response! Regards, Einav - Original Message - From: Einav Cohen eco...@redhat.com To: Sahina Bose sab...@redhat.com, Michael Kublin mkub...@redhat.com, Michal Skrivanek michal.skriva...@redhat.com, Eyal Edri ee...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Tuesday, April 23, 2013 10:17:20 PM Subject: [Engine-devel] find-bugs errors - please investigate/fix ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 caused by: http://gerrit.ovirt.org/#/c/13831/ @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an unreachable OnSuccess method within an anonymous class or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 [again - not sure when introduced - seems old, hence I suspect it is a false positive] Thanks, Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
Re: [Engine-devel] find-bugs errors - please investigate/fix
thanks for the fix. Also, finally we see some progress on the 'low' priority bugs, fixing 337, which now stands on ~1600 instead of ~1900... http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4073/findbugsResult/? Eyal. - Original Message - From: Einav Cohen eco...@redhat.com To: Sahina Bose sab...@redhat.com, Michal Skrivanek michal.skriva...@redhat.com, Tal Nisan tni...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Eyal Edri ee...@redhat.com Sent: Wednesday, April 24, 2013 3:48:34 PM Subject: Re: [Engine-devel] find-bugs errors - please investigate/fix it seems that after the fixes and clean-up, find-bugs is now back to normal: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4073/ all - many thanks for your prompt response! Regards, Einav - Original Message - From: Einav Cohen eco...@redhat.com To: Sahina Bose sab...@redhat.com, Michael Kublin mkub...@redhat.com, Michal Skrivanek michal.skriva...@redhat.com, Eyal Edri ee...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Tuesday, April 23, 2013 10:17:20 PM Subject: [Engine-devel] find-bugs errors - please investigate/fix ovirt find-bugs errors in jenkins - please investigate/fix asap. [@Eyal - FYI: some of them seem really strange - see Michal's section below] @Sahina Bose: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-267688716/source.349621/#23 caused by: http://gerrit.ovirt.org/#/c/13831/ @Michael Kublin: find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.-609324659/source.347305/#346 caused by: http://gerrit.ovirt.org/#/c/13740/ @Michal Skrivanek: the following seem strange - can you please investigate? could be false positives. - find-bugs error details: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/source.350390/#1349 [not sure when introduced - seems old, hence I suspect it is a false positive] - Two additional errors in the same file as ^^^, you can see them at: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-2082646592/ when clicking on them, there aren't any details, however according to their tool-tips, it seems to be an unreachable OnSuccess method within an anonymous class or something similar. - another suspicious error is in VmListModel.java: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/4064/findbugsResult/NORMAL/module.935532853/package.-1516395789/source.350485/#2406 [again - not sure when introduced - seems old, hence I suspect it is a false positive] Thanks, Einav ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel
