Re: [Enigmail] [PATCH] Allow re-certifying keys that have expired certifications.

2017-05-16 Thread Patrick Brunschwig 
On 15.05.17 20:51, Daniel Kahn Gillmor wrote:
> Some people have made expiring certifications on other keys.  After
> such a certification expires, they might want to re-certify with the
> same key (e.g. if they've checked with the other person that they're
> still using the key).
> 
> If this happens, enigmail fails obscurely ("signing failed").
> 
> In the log is:
> 
> 2017-05-15 14:41:15.494 [DEBUG] keyManagmenent.jsm: 
> GpgEditorInterface.processLine: '[GNUPG:] GET_BOOL 
> sign_uid.replace_expired_okay'
> 2017-05-15 14:41:15.494 [ERROR] Unknown command prompt: [GNUPG:] GET_BOOL 
> sign_uid.replace_expired_okay
> 
> I believe this patch should resolve the problem.

Thanks, patch applied on master.

-Patrick




signature.asc
Description: OpenPGP digital signature
___
enigmail-users mailing list
enigmail-users@enigmail.net
To unsubscribe or make changes to your subscription click here:
https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net

[Enigmail] [PATCH] Allow re-certifying keys that have expired certifications.

2017-05-15 Thread Daniel Kahn Gillmor 
Some people have made expiring certifications on other keys.  After
such a certification expires, they might want to re-certify with the
same key (e.g. if they've checked with the other person that they're
still using the key).

If this happens, enigmail fails obscurely ("signing failed").

In the log is:

2017-05-15 14:41:15.494 [DEBUG] keyManagmenent.jsm: 
GpgEditorInterface.processLine: '[GNUPG:] GET_BOOL 
sign_uid.replace_expired_okay'
2017-05-15 14:41:15.494 [ERROR] Unknown command prompt: [GNUPG:] GET_BOOL 
sign_uid.replace_expired_okay

I believe this patch should resolve the problem.
---
 package/keyEditor.jsm | 4 
 1 file changed, 4 insertions(+)

diff --git a/package/keyEditor.jsm b/package/keyEditor.jsm
index f1750aca..615fea4d 100644
--- a/package/keyEditor.jsm
+++ b/package/keyEditor.jsm
@@ -616,6 +616,10 @@ function signKeyCallback(inputData, keyEdit, ret) {
   else if (keyEdit.doCheck(GET_BOOL, "sign_uid.local_promote_okay")) {
 ret.exitCode = 0;
 ret.writeTxt = "Y";
+  } 
+  else if (keyEdit.doCheck(GET_BOOL, "sign_uid.replace_expired_okay")) {
+ret.exitCode = 0;
+ret.writeTxt = "Y";
   }
   else if (keyEdit.doCheck(GET_LINE, "sign_uid.class")) {
 ret.exitCode = 0;
-- 
2.11.0


___
enigmail-users mailing list
enigmail-users@enigmail.net
To unsubscribe or make changes to your subscription click here:
https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net