E CVS: libs/ewl ningerso
Enlightenment CVS committal Author : ningerso Project : e17 Module : libs/ewl Dir : e17/libs/ewl/src/bin/tests/window Log Message: Directory /cvs/e/e17/libs/ewl/src/bin/tests/window added to the repository - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
E CVS: libs/ewl ningerso
Enlightenment CVS committal Author : ningerso Project : e17 Module : libs/ewl Dir : e17/libs/ewl/src/lib Modified Files: ewl_window.c ewl_window.h Log Message: Update window title, name and class accessors to avoid string duplication. Remove default title, name and class values. === RCS file: /cvs/e/e17/libs/ewl/src/lib/ewl_window.c,v retrieving revision 1.86 retrieving revision 1.87 diff -u -3 -r1.86 -r1.87 --- ewl_window.c6 Dec 2007 07:07:12 - 1.86 +++ ewl_window.c19 Dec 2007 16:15:31 - 1.87 @@ -53,9 +53,11 @@ ewl_widget_appearance_set(EWL_WIDGET(w), EWL_WINDOW_TYPE); ewl_widget_inherit(EWL_WIDGET(w), EWL_WINDOW_TYPE); ewl_object_fill_policy_set(EWL_OBJECT(w), EWL_FLAG_FILL_FILL); + /* w-title = strdup(EWL); w-name = strdup(EWL); w-classname = strdup(EWL); + */ ewl_callback_prepend(EWL_WIDGET(w), EWL_CALLBACK_REALIZE, ewl_window_cb_realize, NULL); @@ -120,7 +122,7 @@ DCHECK_PARAM_PTR(win); DCHECK_TYPE(win, EWL_WINDOW_TYPE); - if ((!title) || (strcmp(win-title, title))) { + if ((!title) || (!win-title) || (strcmp(win-title, title))) { IF_FREE(win-title); win-title = (title ? strdup(title) : strdup()); } @@ -135,16 +137,17 @@ * @return Returns a pointer to a new copy of the title, NULL on failure. * @brief Retrieve the title of the specified window * - * The returned title should be freed. + * The returned title should not be freed, and should be copied immediately if + * needed for extended use. */ -char * +const char * ewl_window_title_get(Ewl_Window *win) { DENTER_FUNCTION(DLEVEL_STABLE); DCHECK_PARAM_PTR_RET(win, NULL); DCHECK_TYPE_RET(win, EWL_WINDOW_TYPE, NULL); - DRETURN_PTR(strdup(win-title), DLEVEL_STABLE); + DRETURN_PTR(win-title, DLEVEL_STABLE); } /** @@ -163,7 +166,7 @@ DCHECK_PARAM_PTR(win); DCHECK_TYPE(win, EWL_WINDOW_TYPE); - if ((!name) || (strcmp(win-name, name))) { + if ((!name) || (!win-name) || (strcmp(win-name, name))) { IF_FREE(win-name); win-name = (name ? strdup(name) : strdup()); } @@ -178,16 +181,17 @@ * @return Returns a pointer to a new copy of the name, NULL on failure. * @brief Retrieve the name of the specified window * - * The returned name should be freed. + * The returned name should not be freed, and should be copied immediately if + * needed for extended use. */ -char * +const char * ewl_window_name_get(Ewl_Window *win) { DENTER_FUNCTION(DLEVEL_STABLE); DCHECK_PARAM_PTR_RET(win, NULL); DCHECK_TYPE_RET(win, EWL_WINDOW_TYPE, NULL); - DRETURN_PTR(strdup(win-name), DLEVEL_STABLE); + DRETURN_PTR(win-name, DLEVEL_STABLE); } /** @@ -223,16 +227,17 @@ * @return Returns a pointer to a new copy of the class, NULL on failure. * @brief Retrieve the class of the specified window * - * The returned class should be freed. + * The returned class should not be freed, and should be copied immediately if + * needed for extended use. */ -char * +const char * ewl_window_class_get(Ewl_Window *win) { DENTER_FUNCTION(DLEVEL_STABLE); DCHECK_PARAM_PTR_RET(win, NULL); DCHECK_TYPE_RET(win, EWL_WINDOW_TYPE, NULL); - DRETURN_PTR(strdup(win-classname), DLEVEL_STABLE); + DRETURN_PTR(win-classname, DLEVEL_STABLE); } /** === RCS file: /cvs/e/e17/libs/ewl/src/lib/ewl_window.h,v retrieving revision 1.40 retrieving revision 1.41 diff -u -3 -r1.40 -r1.41 --- ewl_window.h6 Dec 2007 07:07:12 - 1.40 +++ ewl_window.h19 Dec 2007 16:15:31 - 1.41 @@ -77,11 +77,11 @@ int ewl_window_init(Ewl_Window *win); Ewl_Window *ewl_window_window_find(void *window); voidewl_window_title_set(Ewl_Window *win, const char *title); -char *ewl_window_title_get(Ewl_Window *win); +const char *ewl_window_title_get(Ewl_Window *win); voidewl_window_name_set(Ewl_Window *win, const char *name); -char *ewl_window_name_get(Ewl_Window *win); +const char *ewl_window_name_get(Ewl_Window *win); voidewl_window_class_set(Ewl_Window *win, const char *classname); -char *ewl_window_class_get(Ewl_Window *win); +const char *ewl_window_class_get(Ewl_Window *win); voidewl_window_borderless_set(Ewl_Window *win); voidewl_window_dialog_set(Ewl_Window *win, int dialog); int ewl_window_dialog_get(Ewl_Window *win); - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just
E CVS: libs/ewl ningerso
Enlightenment CVS committal Author : ningerso Project : e17 Module : libs/ewl Dir : e17/libs/ewl/src/bin/tests/window Added Files: .cvsignore Makefile.am ewl_window_test.c Log Message: Add basic window unit tests. - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
E CVS: libs/ewl ningerso
Enlightenment CVS committal Author : ningerso Project : e17 Module : libs/ewl Dir : e17/libs/ewl Modified Files: configure.in Log Message: Add basic window unit tests. === RCS file: /cvs/e/e17/libs/ewl/configure.in,v retrieving revision 1.127 retrieving revision 1.128 diff -u -3 -r1.127 -r1.128 --- configure.in13 Dec 2007 00:03:09 - 1.127 +++ configure.in19 Dec 2007 16:17:16 - 1.128 @@ -320,6 +320,7 @@ src/bin/tests/tooltip/Makefile src/bin/tests/tree/Makefile src/bin/tests/widget/Makefile +src/bin/tests/window/Makefile src/lib/Makefile src/engines/Makefile src/plugins/Makefile - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
E CVS: libs/ewl ningerso
Enlightenment CVS committal Author : ningerso Project : e17 Module : libs/ewl Dir : e17/libs/ewl/src/bin/tests Modified Files: Makefile.am Log Message: Add basic window unit tests. === RCS file: /cvs/e/e17/libs/ewl/src/bin/tests/Makefile.am,v retrieving revision 1.56 retrieving revision 1.57 diff -u -3 -r1.56 -r1.57 --- Makefile.am 13 Dec 2007 00:03:09 - 1.56 +++ Makefile.am 19 Dec 2007 16:17:16 - 1.57 @@ -57,5 +57,6 @@ toolbar \ tooltip \ tree \ - widget + widget \ + window - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
E CVS: libs/ewl pfritz
Enlightenment CVS committal Author : pfritz Project : e17 Module : libs/ewl Dir : e17/libs/ewl/src/engines/x11 Modified Files: ewl_engine_x11.c Log Message: don't segfault on NULL titles (maybe this should actually be done by ecore_x) === RCS file: /cvs/e/e17/libs/ewl/src/engines/x11/ewl_engine_x11.c,v retrieving revision 1.56 retrieving revision 1.57 diff -u -3 -r1.56 -r1.57 --- ewl_engine_x11.c6 Dec 2007 07:07:12 - 1.56 +++ ewl_engine_x11.c19 Dec 2007 17:01:52 - 1.57 @@ -515,12 +515,15 @@ static void ee_window_title_set(Ewl_Window *win) { + const char *title; + DENTER_FUNCTION(DLEVEL_STABLE); DCHECK_PARAM_PTR(win); DCHECK_TYPE(win, EWL_WINDOW_TYPE); - ecore_x_icccm_title_set((Ecore_X_Window)win-window, win-title); - ecore_x_netwm_name_set((Ecore_X_Window)win-window, win-title); + title = win-title ? win-title : ; + ecore_x_icccm_title_set((Ecore_X_Window)win-window, title); + ecore_x_netwm_name_set((Ecore_X_Window)win-window, title); DLEAVE_FUNCTION(DLEVEL_STABLE); } - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
E CVS: apps/e devilhorns
Enlightenment CVS committal Author : devilhorns Project : e17 Module : apps/e Dir : e17/apps/e/src/modules/pager Modified Files: e_mod_config.c Log Message: Fix pager config dialog (thanks jeffdameth). (darn fat-finger copy/paste) :) === RCS file: /cvs/e/e17/apps/e/src/modules/pager/e_mod_config.c,v retrieving revision 1.34 retrieving revision 1.35 diff -u -3 -r1.34 -r1.35 --- e_mod_config.c 18 Dec 2007 00:46:46 - 1.34 +++ e_mod_config.c 19 Dec 2007 20:07:01 - 1.35 @@ -179,11 +179,11 @@ of = e_widget_frametable_add(evas, _(Popup Settings), 0); ow = e_widget_check_add(evas, _(Show popup on desktop change), - (cfdata-flip_desk)); + (cfdata-popup.show)); e_widget_frametable_object_append(of, ow, 0, 0, 2, 1, 1, 0, 1, 0); ow = e_widget_label_add(evas, _(Popup pager height)); e_widget_frametable_object_append(of, ow, 0, 1, 1, 1, 1, 0, 1, 0); - ow = e_widget_slider_add(evas, 1, 0, _(%.0f px), 0.0, 10.0, 1.0, 0, NULL, + ow = e_widget_slider_add(evas, 1, 0, _(%.0f px), 20.0, 200.0, 1.0, 0, NULL, (cfdata-popup.pager_height), 100); e_widget_frametable_object_append(of, ow, 1, 1, 1, 1, 1, 0, 1, 0); ow = e_widget_label_add(evas, _(Popup speed)); - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
E CVS: e kwo
Enlightenment CVS committal Author : kwo Project : e16 Module : e Dir : e16/e/src Modified Files: menus.c Log Message: Fix backward compatibility named menu hack. === RCS file: /cvs/e/e16/e/src/menus.c,v retrieving revision 1.290 retrieving revision 1.291 diff -u -3 -r1.290 -r1.291 --- menus.c 30 Sep 2007 12:56:31 - 1.290 +++ menus.c 19 Dec 2007 21:00:47 - 1.291 @@ -2106,7 +2106,10 @@ if (*p == '\0') p = NULL; if (p !strcmp(prm, named)) - Esnprintf(prm, sizeof(prm), %s, p); + { +Esnprintf(prm, sizeof(prm), %s, p); +p = NULL; + } SoundPlay(SOUND_MENU_SHOW); MenusShowNamed(prm, p); } - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
E CVS: libs/ewl ningerso
Enlightenment CVS committal Author : ningerso Project : e17 Module : libs/ewl Dir : e17/libs/ewl/src/lib Modified Files: ewl_window.c Log Message: Use NULL instead of duplicating for window properties. Update window unit tests to reflect this change. === RCS file: /cvs/e/e17/libs/ewl/src/lib/ewl_window.c,v retrieving revision 1.87 retrieving revision 1.88 diff -u -3 -r1.87 -r1.88 --- ewl_window.c19 Dec 2007 16:15:31 - 1.87 +++ ewl_window.c19 Dec 2007 21:53:57 - 1.88 @@ -53,11 +53,6 @@ ewl_widget_appearance_set(EWL_WIDGET(w), EWL_WINDOW_TYPE); ewl_widget_inherit(EWL_WIDGET(w), EWL_WINDOW_TYPE); ewl_object_fill_policy_set(EWL_OBJECT(w), EWL_FLAG_FILL_FILL); - /* - w-title = strdup(EWL); - w-name = strdup(EWL); - w-classname = strdup(EWL); - */ ewl_callback_prepend(EWL_WIDGET(w), EWL_CALLBACK_REALIZE, ewl_window_cb_realize, NULL); @@ -124,7 +119,7 @@ if ((!title) || (!win-title) || (strcmp(win-title, title))) { IF_FREE(win-title); - win-title = (title ? strdup(title) : strdup()); + win-title = ((title *title) ? strdup(title) : NULL); } ewl_engine_window_title_set(win); @@ -168,7 +163,7 @@ if ((!name) || (!win-name) || (strcmp(win-name, name))) { IF_FREE(win-name); - win-name = (name ? strdup(name) : strdup()); + win-name = ((name *name) ? strdup(name) : NULL); } ewl_engine_window_name_class_set(win); @@ -214,7 +209,8 @@ || (strcmp(win-classname, classname))) { IF_FREE(win-classname); - win-classname = (classname ? strdup(classname) : strdup()); + win-classname = ((classname *classname) ? + strdup(classname) : NULL); } ewl_engine_window_name_class_set(win); - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
E CVS: libs/ewl ningerso
Enlightenment CVS committal Author : ningerso Project : e17 Module : libs/ewl Dir : e17/libs/ewl/src/bin/tests/window Modified Files: ewl_window_test.c Log Message: Use NULL instead of duplicating for window properties. Update window unit tests to reflect this change. === RCS file: /cvs/e/e17/libs/ewl/src/bin/tests/window/ewl_window_test.c,v retrieving revision 1.1 retrieving revision 1.2 diff -u -3 -r1.1 -r1.2 --- ewl_window_test.c 19 Dec 2007 16:17:16 - 1.1 +++ ewl_window_test.c 19 Dec 2007 21:53:57 - 1.2 @@ -46,16 +46,22 @@ win = ewl_window_new(); title = ewl_window_title_get(EWL_WINDOW(win)); - if (title *title) - snprintf(buf, len, default title set to %s, title); + if (title) + snprintf(buf, len, default title set to '%s', title); else { ewl_window_title_set(EWL_WINDOW(win), A title); title = ewl_window_title_get(EWL_WINDOW(win)); if (strcmp(title, A title)) snprintf(buf, len, incorrect title set); - else - ret = 1; + else { + ewl_window_title_set(EWL_WINDOW(win), ); + title = ewl_window_title_get(EWL_WINDOW(win)); + if (title) + snprintf(buf, len, non-empty title set); + else + ret = 1; + } } ewl_widget_destroy(win); @@ -76,16 +82,22 @@ win = ewl_window_new(); name = ewl_window_name_get(EWL_WINDOW(win)); - if (name *name) - snprintf(buf, len, default name set to %s, name); + if (name) + snprintf(buf, len, default name set to '%s', name); else { ewl_window_name_set(EWL_WINDOW(win), A name); name = ewl_window_name_get(EWL_WINDOW(win)); if (strcmp(name, A name)) snprintf(buf, len, incorrect name set); - else - ret = 1; + else { + ewl_window_name_set(EWL_WINDOW(win), ); + name = ewl_window_name_get(EWL_WINDOW(win)); + if (name) + snprintf(buf, len, non-empty name set); + else + ret = 1; + } } ewl_widget_destroy(win); @@ -106,16 +118,22 @@ win = ewl_window_new(); class = ewl_window_class_get(EWL_WINDOW(win)); - if (class *class) - snprintf(buf, len, default class set to %s, class); + if (class) + snprintf(buf, len, default class set to '%s', class); else { ewl_window_class_set(EWL_WINDOW(win), A class); class = ewl_window_class_get(EWL_WINDOW(win)); if (strcmp(class, A class)) snprintf(buf, len, incorrect class set); - else - ret = 1; + else { + ewl_window_class_set(EWL_WINDOW(win), ); + class = ewl_window_class_get(EWL_WINDOW(win)); + if (class) + snprintf(buf, len, non-empty class set); + else + ret = 1; + } } ewl_widget_destroy(win); - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
E CVS: libs/eet davemds
Enlightenment CVS committal Author : davemds Project : e17 Module : libs/eet Dir : e17/libs/eet/src/lib Modified Files: Eet.h Log Message: Arghh !! I have lost one night of work for this doxy error. Please, please, please update doxy when you make changes. === RCS file: /cvs/e/e17/libs/eet/src/lib/Eet.h,v retrieving revision 1.40 retrieving revision 1.41 diff -u -3 -r1.40 -r1.41 --- Eet.h 31 Oct 2007 07:13:57 - 1.40 +++ Eet.h 20 Dec 2007 00:13:13 - 1.41 @@ -137,7 +137,7 @@ /** * Open an eet file on disk, and returns a handle to it. * @param file The file path to the eet file. eg: /tmp/file.eet. -* @param mode The mode for opening. Either EET_FILE_MODE_READ or EET_FILE_MODE_WRITE, but not both. +* @param mode The mode for opening. Either EET_FILE_MODE_READ, EET_FILE_MODE_WRITE or EET_FILE_MODE_READ_WRITE. * @return An opened eet file handle. * * This function will open an exiting eet file for reading, and build @@ -149,6 +149,10 @@ * delete the original file and replace it with a new empty file, till * the eet file handle is closed or flushed. If it cannot be opened for * writing or a memory error occurs, NULL is returned. +* +* You can also open the file for read/write. If you then write a key that +* not exist it will be created, if the key exist it will be replaced by +* the new data. * * Example: * @code - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
E CVS: libs/eet leviathan
Enlightenment CVS committal Author : leviathan Project : e17 Module : libs/eet Dir : e17/libs/eet/src/lib Modified Files: Eet.h Log Message: english === RCS file: /cvs/e/e17/libs/eet/src/lib/Eet.h,v retrieving revision 1.41 retrieving revision 1.42 diff -u -3 -r1.41 -r1.42 --- Eet.h 20 Dec 2007 00:13:13 - 1.41 +++ Eet.h 20 Dec 2007 07:22:52 - 1.42 @@ -151,8 +151,8 @@ * writing or a memory error occurs, NULL is returned. * * You can also open the file for read/write. If you then write a key that -* not exist it will be created, if the key exist it will be replaced by -* the new data. +* does not exist it will be created, if the key exists it will be replaced +* by the new data. * * Example: * @code - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs