[E-devel] RE: E CVS: libs/embryo raster
None of the changes in embryo_cc_sc1.c were correct.
They used sizeof on pointers rather than arrays...
All of the changes in embryo_cc_sc2.c were correct.
//Peter
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On
Behalf Of [EMAIL PROTECTED]
Sent: Tuesday, July 27, 2004 02:58
To: [EMAIL PROTECTED]
Subject: E CVS: libs/embryo raster
Enlightenment CVS committal
Author : raster
Project : e17
Module : libs/embryo
Dir : e17/libs/embryo/src/bin
Modified Files:
embryo_cc_sc1.c embryo_cc_sc2.c
Log Message:
back to previous. no snprintf's. one of these broke embryo_cc.
===
RCS file:
/cvsroot/enlightenment/e17/libs/embryo/src/bin/embryo_cc_sc1.c,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -3 -r1.14 -r1.15
--- embryo_cc_sc1.c 25 Jul 2004 14:52:24 - 1.14
+++ embryo_cc_sc1.c 27 Jul 2004 00:58:25 - 1.15
@@ -19,7 +19,7 @@
* must not be misrepresented as being the original software.
* 3. This notice may not be removed or altered from any source
* distribution.
- * Version: $Id: embryo_cc_sc1.c,v 1.14 2004/07/25 14:52:24
vacuum Exp $
+ * Version: $Id: embryo_cc_sc1.c,v 1.15 2004/07/27 00:58:25
raster Exp $
*/
#include assert.h
#include ctype.h
@@ -2151,7 +2151,7 @@
{
tag = TAGMASK;
assert(tag = 0);
- snprintf(dest, sizeof(dest), 0%x, tag);
+ sprintf(dest, 0%x, tag);
return isdigit(dest[1]) ? dest[1] : dest;
}
@@ -2165,12 +2165,12 @@
assert(numtags = 1 numtags = 2);
opertok = (opername[1] == '\0') ? opername[0] : 0;
if (opertok == '=')
- snprintf(symname, sizeof(symname), %s%s%s,
tag2str(tagstr1, resulttag), opername,
+ sprintf(symname, %s%s%s, tag2str(tagstr1,
resulttag), opername,
tag2str(tagstr2, tag1));
else if (numtags == 1 || opertok == '~')
- snprintf(symname, sizeof(symname), %s%s, opername,
tag2str(tagstr1, tag1));
+ sprintf(symname, %s%s, opername, tag2str(tagstr1, tag1));
else
- snprintf(symname, sizeof(symname), %s%s%s,
tag2str(tagstr1, tag1), opername,
+ sprintf(symname, %s%s%s, tag2str(tagstr1, tag1), opername,
tag2str(tagstr2, tag2));
return symname;
}
@@ -2226,7 +2226,7 @@
assert(tagsym[1] != NULL);
if (unary)
{
- snprintf(dest, sizeof(dest), operator%s(%s:), opname,
tagsym[1]-name);
+ sprintf(dest, operator%s(%s:), opname, tagsym[1]-name);
}
else
{
@@ -2234,11 +2234,11 @@
/* special case: the assignment operator has the return value
* as the 2nd tag */
if (opname[0] == '=' opname[1] == '\0')
-snprintf(dest, sizeof(dest), %s:operator%s(%s:),
tagsym[0]-name,
- opname, tagsym[1]-name);
+sprintf(dest, %s:operator%s(%s:), tagsym[0]-name, opname,
+tagsym[1]-name);
else
-snprintf(dest, sizeof(dest), operator%s(%s:,%s:), opname,
- tagsym[0]-name, tagsym[1]-name);
+sprintf(dest, operator%s(%s:,%s:), opname, tagsym[0]-name,
+tagsym[1]-name);
} /* if */
return dest;
}
===
RCS file:
/cvsroot/enlightenment/e17/libs/embryo/src/bin/embryo_cc_sc2.c,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -3 -r1.10 -r1.11
--- embryo_cc_sc2.c 25 Jul 2004 14:52:24 - 1.10
+++ embryo_cc_sc2.c 27 Jul 2004 00:58:25 - 1.11
@@ -18,7 +18,7 @@
* misrepresented as being the original software.
* 3. This notice may not be removed or altered from any
source distribution.
*
- * Version: $Id: embryo_cc_sc2.c,v 1.10 2004/07/25 14:52:24
vacuum Exp $
+ * Version: $Id: embryo_cc_sc2.c,v 1.11 2004/07/27 00:58:25
raster Exp $
*/
#include assert.h
#include stdio.h
@@ -1196,7 +1196,7 @@
extern char*sc_tokens[];
/* forward declaration */
if (tok 256)
-snprintf(s2, sizeof(s2), %c, (char)tok);
+sprintf(s2, %c, (char)tok);
else
strcpy(s2, sc_tokens[tok - tFIRST]);
error(1, sc_tokens[tSYMBOL - tFIRST], s2);
@@ -2139,13 +2139,13 @@
/* token already pushed back */
assert(_pushed);
if (token 256)
-snprintf(s1, sizeof(s1), %c, (char)token); /*
single character token */
+sprintf(s1, %c, (char)token); /* single
character token */
else
strcpy(s1, sc_tokens[token - tFIRST]); /*
multi-character symbol */
if (!freading)
strcpy(s2, -end of file-);
else if (_lextok 256)
-snprintf(s2, sizeof(s1), %c, (char)_lextok);
+sprintf(s2, %c, (char)_lextok);
else
[E-devel] SVG graphics?
Hi, did you ever thought to implement in E16 SVG (with libsvg) support? For example to use them native in the E-menu or iconbox? If not, I thought about implementing a on-the-fly converter to png in e16menuedit2. regards Andreas --- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=4721alloc_id=10040op=click ___ enlightenment-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] changing menu navigation key binding
Hi, I would like to use other keys to navigate the menus than the arrow keys. I have found were the behaviour is defined in menus.c, and I am thinking of making it a keybinding. Looking at the way keybindings are implemented, it seems a little too complex (I'm not sure I want to add actions in actions.c/ActionFunction and in E.h, it seems too generic). What I would rather do is have a way to store somewhere what keys are used to navigate menus, and use that in menus.c/MenuEventKeyPress. Is there already a place to store such things? Alan Schmitt -- The hacker: someone who figured things out and made something cool happen. .O. ..O OOO pgpsIB6rcZTl0.pgp Description: PGP signature
Re: [E-devel] SVG graphics?
Andreas Volz wrote: did you ever thought to implement in E16 SVG (with libsvg) support? For example to use them native in the E-menu or iconbox? If not, I thought about implementing a on-the-fly converter to png in e16menuedit2. I can't say I ever considered it :) What would be the benefits? Speaking against it I guess (please correct me if I'm wrong) would be a potential slow response first time opening a menu or showing an iconbox icon, dependency on a pile of additional libraries and additional memory usage? It seems to me that converting to png in e16menuedit2 would be a better solution. On second thought - I'm not familiar with the imlib2/loader architecture but if it is possible to make an imlib2 svg loader I believe there would only be an overhead if actually using svg's, right? No E16 code changes would be required either. /Kim --- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=4721alloc_id=10040op=click ___ enlightenment-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] changing menu navigation key binding
Alan Schmitt wrote:
I would like to use other keys to navigate the menus than the arrow
keys. I have found were the behaviour is defined in menus.c, and I am
thinking of making it a keybinding.
Looking at the way keybindings are implemented, it seems a little too
complex (I'm not sure I want to add actions in
actions.c/ActionFunction and in E.h, it seems too generic). What I
would rather do is have a way to store somewhere what keys are used
to navigate menus, and use that in menus.c/MenuEventKeyPress. Is
there already a place to store such things?
This isn't a keybinding thing, it's a question of somehow defining which
key does what in the menu navigation.
One fairly easy way to do this would be to add a struct, let's say
struct {
KeySym left, right, up, down;
} menukeys;
to the Conf struct, add the associated load and save statements (one
config line?) in config.c, and add a function call in menus.c after
XLookupKeysym() mapping the received key into the desired function.
There would have to be configured some defaults (setup.c). Finally, a
way to actually set the values would be nice. vi
~/.enlightenment/...e_session-XX could of course be considered a
way :)
I think this configuration thing is somewhat complicated and I'm
currently playing around a bit with a new configuration handler (using
edb), which would significantly simplify adding configuration items like
this.
/Kim
---
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=4721alloc_id=10040op=click
___
enlightenment-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
