Re: [E-devel] Evas Smart Object?
Hi, shouldn't the _icon_del() function in icon_smart1.c actually delete something? In the text you mention, evas_object_del(data-image); evas_object_del(data-text); free(data); but, this is missing in the example c code regards, chris On Thu, 24 Mar 2005 17:59:05 -0600 Brian Mattern [EMAIL PROTECTED] wrote: Here's a little tutorial I wrote about smart objects: http://rephorm.com/rephorm/code/smartobj -- rephorm Andreas Volz wrote: Hi, could someone say some words about Evas Smart Object? What is it for? Docs aren't complete here and I don't understand it. So please help me. regards Andreas --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Evas Smart Object?
Please ignore my previous babbling... everything is in the finished code, icon_smart2.c ... regards, chris On Fri, 25 Mar 2005 10:51:23 +0100 Christopher Campbell [EMAIL PROTECTED] wrote: Hi, shouldn't the _icon_del() function in icon_smart1.c actually delete something? In the text you mention, evas_object_del(data-image); evas_object_del(data-text); free(data); but, this is missing in the example c code regards, chris On Thu, 24 Mar 2005 17:59:05 -0600 Brian Mattern [EMAIL PROTECTED] wrote: Here's a little tutorial I wrote about smart objects: http://rephorm.com/rephorm/code/smartobj -- rephorm Andreas Volz wrote: Hi, could someone say some words about Evas Smart Object? What is it for? Docs aren't complete here and I don't understand it. So please help me. regards Andreas --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Fontset Append List Configurable
Hi, This _might_ be a valid for for a FIXME in e_main.c to get the fontset to be configurable. I tested it through enlightenment_remote and it seems to work nicely. One will need to put his/her mouse over the title to notice the update changes. This is pretty useful for testing out different asian fonts, it doesn't require a new build. Next I suppose I can make a configuration for changing the default Vera font. But as this is not a FIXME and we are in a Code Freeze I better not. Stafford Index: src/bin/e_config.c === RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_config.c,v retrieving revision 1.26 diff -u -r1.26 e_config.c --- src/bin/e_config.c 24 Mar 2005 08:30:44 - 1.26 +++ src/bin/e_config.c 25 Mar 2005 12:56:16 - @@ -55,6 +55,7 @@ #define T E_Config #define D _e_config_edd E_CONFIG_VAL(D, T, desktop_default_background, STR); + E_CONFIG_VAL(D, T, fontset, STR); E_CONFIG_VAL(D, T, menus_scroll_speed, DOUBLE); E_CONFIG_VAL(D, T, menus_fast_mouse_move_thresthold, DOUBLE); E_CONFIG_VAL(D, T, menus_click_drag_timeout, DOUBLE); @@ -75,6 +76,7 @@ /* DEFAULT CONFIG */ e_config = E_NEW(E_Config, 1); e_config-desktop_default_background = strdup(PACKAGE_DATA_DIR/data/themes/default.edj); + e_config-fontset = strdup(Kochi-Gothic,Baekmuk-Dotum); e_config-menus_scroll_speed = 1000.0; e_config-menus_fast_mouse_move_thresthold = 300.0; e_config-menus_click_drag_timeout = DEF_MENUCLICK; @@ -180,6 +182,7 @@ e_config-bindings = evas_list_remove_list(e_config-bindings, e_config-bindings); E_FREE(eb); } + E_FREE(e_config-fontset); E_FREE(e_config-desktop_default_background); E_FREE(e_config); } Index: src/bin/e_config.h === RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_config.h,v retrieving revision 1.11 diff -u -r1.11 e_config.h --- src/bin/e_config.h 11 Mar 2005 13:09:06 - 1.11 +++ src/bin/e_config.h 25 Mar 2005 12:56:16 - @@ -50,6 +50,7 @@ struct _E_Config { char *desktop_default_background; + char *fontset; double menus_scroll_speed; double menus_fast_mouse_move_thresthold; double menus_click_drag_timeout; Index: src/bin/e_ipc.c === RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_ipc.c,v retrieving revision 1.9 diff -u -r1.9 e_ipc.c --- src/bin/e_ipc.c 17 Mar 2005 01:30:50 - 1.9 +++ src/bin/e_ipc.c 25 Mar 2005 12:56:17 - @@ -213,6 +213,36 @@ bg, strlen(bg) + 1); } break; + case E_IPC_OP_FONTSET_SET: + { + char *fontset; + + fontset = malloc(e-size + 1); + fontset[e-size] = 0; + memcpy(fontset, e-data, e-size); + E_FREE(e_config-fontset); + e_config-fontset = fontset; + + edje_fontset_append_set(e_config-fontset); + e_canvas_recache(); + + e_config_save_queue(); + } + break; + case E_IPC_OP_FONTSET_GET: + { + char *fontset; + fontset = e_config-fontset; + if (!fontset) + fontset = ; + ecore_ipc_client_send(e-client, + E_IPC_DOMAIN_REPLY, + E_IPC_OP_FONTSET_GET_REPLY, + 0/*ref*/, 0/*ref_to*/, 0/*response*/, + fontset, strlen(fontset) + 1); + } + break; + case E_IPC_OP_RESTART: { restart = 1; Index: src/bin/e_ipc.h === RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_ipc.h,v retrieving revision 1.8 diff -u -r1.8 e_ipc.h --- src/bin/e_ipc.h 17 Mar 2005 01:30:50 - 1.8 +++ src/bin/e_ipc.h 25 Mar 2005 12:56:17 - @@ -23,6 +23,9 @@ E_IPC_OP_BG_SET, E_IPC_OP_BG_GET, E_IPC_OP_BG_GET_REPLY, + E_IPC_OP_FONTSET_SET, + E_IPC_OP_FONTSET_GET, + E_IPC_OP_FONTSET_GET_REPLY, E_IPC_OP_RESTART, E_IPC_OP_LAST } E_Ipc_Op; Index: src/bin/e_main.c === RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_main.c,v retrieving revision 1.57 diff -u -r1.57 e_main.c --- src/bin/e_main.c 22 Mar 2005 09:09:12 - 1.57 +++ src/bin/e_main.c 25 Mar 2005 12:56:17 - @@ -221,6 +221,9 @@ } _e_main_shutdown_push(ecore_evas_shutdown); + + /*** Finished loading subsystems, Loading WM Specifics ***/ + /* setup directories we will be using for configurations sotrage etc. */ if (!_e_main_dirs_init()) { @@ -247,9 +250,8 @@ /* setup edje to animate @ e_config-framerate frames per sec. */ edje_frametime_set(1.0 / e_config-framerate); - /* FIXME: this is just appending Kochi if Vera doesnt have it. We need -* a full config support subsystem for this */ - edje_fontset_append_set(Kochi-Gothic,Baekmuk-Dotum); + if(e_config-fontset) + edje_fontset_append_set(e_config-fontset); e_canvas_recache(); /* setup
Re: [E-devel] Evas Smart Object?
Hello! I'm trying to join #e on freenode, but appearently I'm banned. Does anyone of you know the ops? Or where I can reach them? Thanks Thijs Thiessens --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] access data from inside resize callback?
Hi, in GTK are two functions to get access to non global data from inside a callback. The problem is to give a pointer into the resize callback: ecore_evas_callback_resize_set ( Ecore_Evas * ee, void(*)(Ecore_Evas *ee) func) In GTK there are g_object_set_data to store a pointer and g_object_get_data to restore it. Is there something similar? Or should I do it another way? Global data? There should be a better solution. regards Andreas --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] access data from inside resize callback?
Andreas Volz [EMAIL PROTECTED] [2005-03-25 15:49]: in GTK are two functions to get access to non global data from inside a callback. The problem is to give a pointer into the resize callback: ecore_evas_callback_resize_set( Ecore_Evas * ee, void(*)(Ecore_Evas *ee) func) In GTK there are g_object_set_data to store a pointer and g_object_get_data to restore it. Is there something similar? Or should I do it another way? Global data? There should be a better solution. ecore_evas_data_set/get -- Regards, Tilman --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] small patch to e17
as in subject... Index: e17/apps/e/src/bin/e_int_menus.c === RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_int_menus.c,v retrieving revision 1.41 diff -u -r1.41 e_int_menus.c --- e17/apps/e/src/bin/e_int_menus.c22 Mar 2005 19:30:28 - 1.41 +++ e17/apps/e/src/bin/e_int_menus.c25 Mar 2005 17:23:04 - @@ -430,11 +430,12 @@ zone = root-zone; for (l = e_border_clients_get(); l; l = l-next) { - E_Border *border; + E_Border *bd; - border = l-data; - if ((border-zone == zone) || (border-iconic)) - borders = evas_list_append(borders, border); + bd = l-data; + if (((bd-zone == zone) || (bd-iconic)) !ecore_x_window_prop_state_isset(bd-win, + ECORE_X_WINDOW_STATE_SKIP_TASKBAR)) + borders = evas_list_append(borders, bd); } if (!borders)
[E-devel] e17/apps/e/data/themes/default.edj divide request
as in subject i know that this is connected with separately loading each of new file but this would be simpler to add layout changeabilyty to each module separately. now when i want only to change clock (to digital, as example) i need to change whole file. if this file would be divided theme change for any module would be done simply by putting some theme file to .e/e/themes/ and doing unload/load/enable (or maybe simpler by disable/enable) only this module. maybe, in future, someone will add menu position to select theme (as ex: from .e/e/themes/modulename-[themenames/*].edj) : --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Small embryo bug
There is a small bug in the embryo floating point support: native printf(format[], ...); main() { new Float:a; new i; a = 5.5; i = 3; if (a i) { printf(%f %i!\n, a, i); } else { printf(%f %i\n, a, i); } } fails to compile - the fix is attached. -- John Slaten [EMAIL PROTECTED] Index: include/default.inc --- include/default.inc 9 Dec 2004 02:46:32 - 1.4 +++ include/default.inc 25 Mar 2005 20:13:41 - @@ -193,7 +193,7 @@ stock bool:operator(Float:oper1, Float:oper2) return float_cmp(oper1, oper2) 0; stock bool:operator(Float:oper1, oper2) -return float_cmp(oper1, float_(oper2)) 0; +return float_cmp(oper1, float(oper2)) 0; stock bool:operator(oper1, Float:oper2) return float_cmp(float(oper1), oper2) 0; stock bool:operator=(Float:oper1, Float:oper2)
[E-devel] Elapse changes
Hi, I've done some minor changes in Elapse and added a new theme. I wrote the owner of Elapse (digitalfallout?), but I got no response. Do you think he has something against my changes? Should I simply commit my changes? regards Andreas --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
IRC (was Re: [E-devel] Evas Smart Object?)
On Friday, 25 March 2005, at 15:53:05 (+0100), Thijs Thiessens wrote: I'm trying to join #e on freenode, but appearently I'm banned. Does anyone of you know the ops? Or where I can reach them? Please start a new thread when you change topics. What is your nickname and your [EMAIL PROTECTED] mask? Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ [EMAIL PROTECTED] n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org) --- I remember the time I knew what happiness was. Let the memory live again. -- Memory, from /Cats/ --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] patch for eet
after bug report on #edevelop channel i done some investigation in code... eet_data_read calls eet_data_descriptor_decode (with some pointer) then with same pointer above function calls eet_data_chunk_get this function creates and sets Eet_Data_Chunk but incorrectly points to data which are later relased by upper calling function (eet_data_read) attached patch changes this a little... sorry about my poor english, but it isn't my everyday speeking language... Index: e17/libs/eet/src/lib/eet_data.c === RCS file: /cvsroot/enlightenment/e17/libs/eet/src/lib/eet_data.c,v retrieving revision 1.18 diff -u -r1.18 eet_data.c --- e17/libs/eet/src/lib/eet_data.c 28 Oct 2004 09:54:02 - 1.18 +++ e17/libs/eet/src/lib/eet_data.c 25 Mar 2005 20:41:33 - @@ -1183,8 +1183,14 @@ free(chnk); return NULL; } - chnk-data = (char *)src + 4 + ret1 + ret2; chnk-size -= ret2; + if (chnk-data = calloc(1, chnk-size)) + memcpy((void *)chnk-data, (const void *)src + 4 + ret1 + ret2, chnk-size); + else + { + free(chnk); + return NULL; + } return chnk; }
Re: IRC (was Re: [E-devel] Evas Smart Object?)
We apparently took this off-list inadvertently. He's a speed.planet.nl user. I recommended that he check out #edevelop. On Fri, 25 Mar 2005 16:13:46 -0500, Michael Jennings [EMAIL PROTECTED] wrote: On Friday, 25 March 2005, at 15:53:05 (+0100), Thijs Thiessens wrote: I'm trying to join #e on freenode, but appearently I'm banned. Does anyone of you know the ops? Or where I can reach them? Please start a new thread when you change topics. What is your nickname and your [EMAIL PROTECTED] mask? Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ [EMAIL PROTECTED] n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org) --- I remember the time I knew what happiness was. Let the memory live again. -- Memory, from /Cats/ --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] patch for eet
Piotr Skamruk [EMAIL PROTECTED] [2005-03-25 22:12]: eet_data_read calls eet_data_descriptor_decode (with some pointer) then with same pointer above function calls eet_data_chunk_get this function creates and sets Eet_Data_Chunk but incorrectly points to data which are later relased by upper calling function (eet_data_read) attached patch changes this a little... Rejected. The current code isn't broken, so your patch adds a memleak. If this bug was real, it would have led to valgrind throwing up on your boots if you ran that code - which it doesn't. Also, valgrind reports a memory leak with that new code. Advice: Use valgrind next time to verify the code is buggy, and to verify your fix is correct :) sorry about my poor english, but it isn't my everyday speeking language... Not a problem :) -- Regards, Tilman --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small embryo bug
John Slaten [EMAIL PROTECTED] [2005-03-25 13:20]: There is a small bug in the embryo floating point support: [float int] Thanks, applied. -- Regards, Tilman --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: IRC (was Re: [E-devel] Evas Smart Object?)
Sorry for the topic. Host is speed.planet.nl, but I'm cool with edevelop. Thijs Nathan Ingersoll wrote: We apparently took this off-list inadvertently. He's a speed.planet.nl user. I recommended that he check out #edevelop. On Fri, 25 Mar 2005 16:13:46 -0500, Michael Jennings [EMAIL PROTECTED] wrote: On Friday, 25 March 2005, at 15:53:05 (+0100), Thijs Thiessens wrote: I'm trying to join #e on freenode, but appearently I'm banned. Does anyone of you know the ops? Or where I can reach them? Please start a new thread when you change topics. What is your nickname and your [EMAIL PROTECTED] mask? Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ [EMAIL PROTECTED] n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org) --- I remember the time I knew what happiness was. Let the memory live again. -- Memory, from /Cats/ --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] access data from inside resize callback?
Am Fri, 25 Mar 2005 09:57:46 -0500 schrieb dan sinclair: Something like void *ecore_evas_data_get(Ecore_Evas *ee, const char *key); void ecore_evas_data_set(Ecore_Evas *ee, const char *key, const void *data); Ok, this worked. But for what are evas_object_name_set() and evas_object_name_find()? regards Andreas --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] access data from inside resize callback?
Andreas Volz [EMAIL PROTECTED] [2005-03-25 23:35]: Am Fri, 25 Mar 2005 09:57:46 -0500 schrieb dan sinclair: Something like void *ecore_evas_data_get(Ecore_Evas *ee, const char *key); void ecore_evas_data_set(Ecore_Evas *ee, const char *key, const void *data); Ok, this worked. But for what are evas_object_name_set() and evas_object_name_find()? Evas_Object *foo; foo = evas_object_image_add (my_evas); evas_object_name_set (foo, my image); foo = NULL; /* do more stuff with foo */ foo = evas_object_name_find (my_evas, my_image); /* whee, we got our image again! */ -- Regards, Tilman --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] patch for eet
* Tilman Sauerbeck, ([EMAIL PROTECTED]) napisa: ... Rejected. The current code isn't broken, so your patch adds a memleak. it's hard to plead guilty, but this was trully my mistake... --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95alloc_id396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Imlib2: loader_bz2.c leaks file handles. [Patch included]
Problem: Each time that imlib_load_image() is called, in turn, each loader library is called. The loader library for bz2 files opens a temporary file /tmp/imlib2_loader_bz2-XX and then almost immediately deletes it. But is never closes the tempfile so lsof will show: test-bin 28356 jwolf3u REG 3,2 0 213317 /tmp/imlib2_loader_bz2-55VbCn (deleted) If you are calling imlib_load_image() many times in a loop -- say to convert a bunch of images -- you will end up with a new open filehandle to a deleted file each iteration. After 1024 iterations you run out of filehandles. (at the default ulimit) Solution (maybe): --- src/modules/loaders/loader_bz2.c.orig 2005-03-24 15:54:50.541223640 -0800 +++ src/modules/loaders/loader_bz2.c2005-03-24 15:54:50.541223640 -0800 @@ -61,6 +61,7 @@ return 0; if (!(fp = fopen (im-real_file, rb))) { + close (dest); unlink (tmp); return 0; } I've tested this once and it seemed to fix the problem, but I'm not 100% certain that the new bz2.so was being called by imlib2. Licence: I hereby release the above patch into the Public Domain. You can even say you wrote it if you want. --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Imlib2: loader_bz2.c leaks file handles. [Patch included]
Hello, if (!(fp = fopen (im-real_file, rb))) { + close (dest); unlink (tmp); I guess the fopen might fail if the user hasn't got permission to read the file. The fix looks good, although for performance it may be useful to check the file starts with BZ before even trying to create a temporary file. --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Re: E CVS: libs/ewl rbdpngn
This fix has caused the stock buttons to be huge. Might need to back this one out or change how the stock buttons work. On Fri, 25 Mar 2005 21:54:33 -0800, enlightenment-cvs@lists.sourceforge.net enlightenment-cvs@lists.sourceforge.net wrote: Enlightenment CVS committal Author : rbdpngn Project : e17 Module : libs/ewl Dir : e17/libs/ewl/src/lib Modified Files: ewl_image.c Log Message: Use the inner size for calculating and setting the preferred size for the image widget. === RCS file: /cvsroot/enlightenment/e17/libs/ewl/src/lib/ewl_image.c,v retrieving revision 1.3 retrieving revision 1.4 diff -u -3 -r1.3 -r1.4 --- ewl_image.c 26 Mar 2005 05:25:20 - 1.3 +++ ewl_image.c 26 Mar 2005 05:54:33 - 1.4 @@ -322,14 +322,14 @@ if (!i-oh) i-oh = 256; - if (ewl_object_preferred_w_get(EWL_OBJECT(i)) == EWL_OBJECT_MIN_SIZE) { + if (!ewl_object_preferred_inner_w_get(EWL_OBJECT(i))) { ewl_object_preferred_inner_w_set(EWL_OBJECT(i), i-ow); ewl_object_preferred_inner_h_set(EWL_OBJECT(i), i-oh); ewl_image_scale(i, i-sw, i-sh); } else - ewl_image_scale_to(i, ewl_object_preferred_w_get(EWL_OBJECT(i)), - ewl_object_preferred_h_get(EWL_OBJECT(i))); + ewl_image_scale_to(i, ewl_object_preferred_inner_w_get(EWL_OBJECT(i)), + ewl_object_preferred_inner_h_get(EWL_OBJECT(i))); DLEAVE_FUNCTION(DLEVEL_STABLE); } --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Imlib2: loader_bz2.c leaks file handles. [Patch included]
On Fri, 25 Mar 2005 20:37:36 -0500 Julia Wolf [EMAIL PROTECTED] babbled: Problem: Each time that imlib_load_image() is called, in turn, each loader library is called. The loader library for bz2 files opens a temporary file "/tmp/imlib2_loader_bz2-XX" and then almost immediately deletes it. But is never closes the tempfile so lsof will show: test-bin 28356 jwolf 3u REG 3,2 0 213317 /tmp/imlib2_loader_bz2-55VbCn (deleted) If you are calling imlib_load_image() many times in a loop -- say to convert a bunch of images -- you will end up with a new open filehandle to a deleted file each iteration. After 1024 iterations you run out of filehandles. (at the default ulimit) ooh that is nasty! BAD bz2 loader. BAD!. thanks for pointing this out. i re-arranged things to only 1. use this loader IF it ends in .bz2 AND to try load the real file first before making the tmp file so if that fails you dont go and make a tmp file anyway. :) Solution (maybe): --- src/modules/loaders/loader_bz2.c.orig 2005-03-24 15:54:50.541223640 -0800 +++ src/modules/loaders/loader_bz2.c2005-03-24 15:54:50.541223640 -0800 @@ -61,6 +61,7 @@ return 0; if (!(fp = fopen (im-real_file, "rb"))) { + close (dest); unlink (tmp); return 0; } I've tested this once and it seemed to fix the problem, but I'm not 100% certain that the new bz2.so was being called by imlib2. Licence: I hereby release the above patch into the Public Domain. You can even say you wrote it if you want. --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 [EMAIL PROTECTED] Tokyo, Japan (東京 日本) --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] e17/apps/e/data/themes/default.edj divide request
On Fri, 25 Mar 2005 20:24:37 +0100 Piotr Skamruk [EMAIL PROTECTED] babbled: as in subject i know that this is connected with separately loading each of new file but this would be simpler to add layout changeabilyty to each module separately. now when i want only to change clock (to digital, as example) i need to change whole file. if this file would be divided theme change for any module would be done simply by putting some theme file to .e/e/themes/ and doing unload/load/enable (or maybe simpler by disable/enable) only this module. maybe, in future, someone will add menu position to select theme (as ex: from .e/e/themes/modulename-[themenames/*].edj) : yes - in future we will allow being able to use a different theme for different parts of e17 - u'll notice lots of FIXME's wherever we load/set a theme file to an object already. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 [EMAIL PROTECTED] Tokyo, Japan (東京 日本) --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Fontset Append List Configurable
On Fri, 25 Mar 2005 21:13:27 +0800 Stafford Horne [EMAIL PROTECTED] babbled: Hi, This _might_ be a valid for for a FIXME in e_main.c to get the fontset to be configurable. I tested it through enlightenment_remote and it seems to work nicely. One will need to put his/her mouse over the title to notice the update changes. This is pretty useful for testing out different asian fonts, it doesn't require a new build. Next I suppose I can make a configuration for changing the default "Vera" font. But as this is not a FIXME and we are in a Code Freeze I better not. i personally would lump this all together into the same code/api/subsystem. ie. e_fonts.c e_fonts.h - maybe a whole wrapper api that can accept a list of fallback fonts (not just set a string with X,Y,Z...) so u can append/prepend/remove items from the list of falback fonts, list available fonts, wet the default font (textclass) and size... etc. etc. etc. etc. etc. so right now i think this is good - but its the "quick and dirty" patch. i would suggest breaking it all out into an e_font.[ch] subsystem to set this up and centralise it. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 [EMAIL PROTECTED] Tokyo, Japan (東京 日本) --- SF email is sponsored by - The IT Product Guide Read honest candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel