Re: [E-devel] [Patch] Edge and corner bindings
On Sun, Feb 15, 2009 at 12:14 PM, Viktor Kojouharov wrote: > Hi guys, > > Since my computer burned to the ground, I will be out of one for at > least 2-3 weeks. But I have this nice looking patch, which adds edge and > corner binding possibilities to E. Since I won't be able to commit it if > raster approves it when he returns, I'd like to ask one of you to commit > it in my stead. > > Now for the patch itself. The edge.5.diff contains all the needed stuff > for this to work, besides the config dialog edj icon, which I hope toma > will create (I just copied the one from conf_keybindings and renamed it > so it would compile). > > It adds another dialog to the input section of the config panel. With > this dialog, one can bind actions to any edge or corner, and specify a > delay and modifiers for it. The default bindings (if you click restore > to default), is to make the desks flip in the direction of the > edge/corner with 0.3s delay. This is the same behaviour that was > previously set by default through the virtual desks config, and the > later was removed since it is not needed anymore. > > It also adds e_bindings_edge* set of functions to deal with the actual > bindings, the special flip_in_direction action, config bindings struct > and a major cleanup to the E_Zone struct and functions. A lot flags are > removed since they are not needed anymore, as well as some functions > that made use of these flags. The long-standing annoyance where dragging > something to a hidden shelf does not show it is also addressed. > > The second file is a patch for the configs that ship with E. It's a > separate file since I have NOT tested it (due to my laptop's unfortunate > meltdown). It should work though. Hi Viktor, I did review your patch and it looks good, I'd just say you should use EINA_LIST_FOREACH() whenever possible and that eina_stringshare is safe to operate with NULL, so no need to check for null before calling add or del. One issue is: +_modify_edge_binding_cb(void *data, void *data2) ... + int n; + + sscanf(cfdata->locals.cur, "e%d", &n); sscanf may fail, in this case it will return 0 and n will be undefined. Either init n=0 or check return and abort, that seems more reasonable. Also happens with _delete_edge_binding_cb and _update_action_list... search for sscanf() I have not studied the problem in depth, but I'd say that we should try to avoid lots of list lookups whenever possible. As I said, I don't really know if it is possible, but if we can add some extra points to avoid walking lists so many times, then let's do it. Patch is really big so maybe I missed something, if others could review it I'd appreciate. Regards, -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [E_Menu] recalculate the menu
On Sun, Feb 22, 2009 at 6:22 PM, Atton Jonathan wrote: > hey, > > I have a probleme with the E_Menu > I create one and add 1 item. > > A few time later I add a new item but it didn't appears in the menu, I > suppose the menu is not recalculate or something like that. is there a way > to display the new items ? Hey, please give us more information, is this a new menu or existing? If it is a new one, please provide a test case so we can debug it. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [E_Menu] recalculate the menu
hey, I have a probleme with the E_Menu I create one and add 1 item. A few time later I add a new item but it didn't appears in the menu, I suppose the menu is not recalculate or something like that. is there a way to display the new items ? -- Regards. -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] gstreamer v4l support for emotion
On Sun, Feb 22, 2009 at 1:25 PM, Lars Munch wrote: > On Sat, Feb 21, 2009 at 09:50:55PM -0300, Gustavo Sverzut Barbieri wrote: >> On Thu, Feb 19, 2009 at 3:09 PM, Lars Munch wrote: >> > This patch adds gstreamer v4l support to emotion. If you got a webcam it >> > can >> > be tested by doing: >> > >> > emotion_test -gstreamer v4l:// >> > >> > This will use the first video device /dev/video0. >> > >> > If you do not have a webcam, you can also try it using the Virtual Video >> > driver >> > (modprobe vivi). If you got more that one video device you can also use >> > >> > emotion_test -gstreamer v4l://0 v4l://1 >> > >> > to play from both /dev/video0 and /dev/video1. >> >> Lars, sorry taking so review it, but here it is: > > Thanks for the review! > > [snip] > >> >> so very minor stuff, send a new patch and I'll commit. >> > > Three new patches attached - please apply Done! -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] gstreamer v4l support for emotion
On Sat, Feb 21, 2009 at 09:50:55PM -0300, Gustavo Sverzut Barbieri wrote:
> On Thu, Feb 19, 2009 at 3:09 PM, Lars Munch wrote:
> > This patch adds gstreamer v4l support to emotion. If you got a webcam it can
> > be tested by doing:
> >
> > emotion_test -gstreamer v4l://
> >
> > This will use the first video device /dev/video0.
> >
> > If you do not have a webcam, you can also try it using the Virtual Video
> > driver
> > (modprobe vivi). If you got more that one video device you can also use
> >
> > emotion_test -gstreamer v4l://0 v4l://1
> >
> > to play from both /dev/video0 and /dev/video1.
>
> Lars, sorry taking so review it, but here it is:
Thanks for the review!
[snip]
>
> so very minor stuff, send a new patch and I'll commit.
>
Three new patches attached - please apply
Thanks
Lars Munch
Use calloc instead of malloc
Use calloc instead of malloc. This will ensure that length in set to zero if no
length is provided from gstreamer.
---
src/modules/gstreamer/emotion_gstreamer_pipeline.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/modules/gstreamer/emotion_gstreamer_pipeline.c b/src/modules/gstreamer/emotion_gstreamer_pipeline.c
index cf1e28b..5fcd742 100644
--- a/src/modules/gstreamer/emotion_gstreamer_pipeline.c
+++ b/src/modules/gstreamer/emotion_gstreamer_pipeline.c
@@ -93,7 +93,7 @@ file_new_decoded_pad_cb(GstElement *decodebin,
GstElement *queue;
GstPad *videopad;
- vsink = (Emotion_Video_Sink *)malloc(sizeof(Emotion_Video_Sink));
+ vsink = (Emotion_Video_Sink *)calloc(1, sizeof(Emotion_Video_Sink));
if (!vsink) return;
if (!ecore_list_append(ev->video_sinks, vsink))
{
@@ -121,7 +121,7 @@ file_new_decoded_pad_cb(GstElement *decodebin,
Emotion_Audio_Sink *asink;
GstPad *audiopad;
- asink = (Emotion_Audio_Sink *)malloc(sizeof(Emotion_Audio_Sink));
+ asink = (Emotion_Audio_Sink *)calloc(1, sizeof(Emotion_Audio_Sink));
if (!asink) return;
if (!ecore_list_append(ev->audio_sinks, asink))
{
@@ -146,7 +146,7 @@ emotion_video_sink_new(Emotion_Gstreamer_Video *ev)
if (!ev) return NULL;
- vsink = (Emotion_Video_Sink *)malloc(sizeof(Emotion_Video_Sink));
+ vsink = (Emotion_Video_Sink *)calloc(1, sizeof(Emotion_Video_Sink));
if (!vsink) return NULL;
if (!ecore_list_append(ev->video_sinks, vsink))
--
1.6.1.3
Do not spam the user if no length available
Do not spam the user if no length available from gstreamer. This is the case
for webcams, streaming audio and video etc.
---
src/modules/gstreamer/emotion_gstreamer.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/src/modules/gstreamer/emotion_gstreamer.c b/src/modules/gstreamer/emotion_gstreamer.c
index d528dea..b76eb25 100644
--- a/src/modules/gstreamer/emotion_gstreamer.c
+++ b/src/modules/gstreamer/emotion_gstreamer.c
@@ -605,8 +605,6 @@ em_len_get(void *video)
return val / 10.0;
fallback:
- fputs("Gstreamer reported no length, try existing sinks...\n", stderr);
-
ecore_list_first_goto(ev->audio_sinks);
while ((asink = ecore_list_next(ev->audio_sinks)) != NULL)
if (asink->length_time >= 0)
--
1.6.1.3
gstreamer v4l support to emotion
This patch adds gstreamer v4l support to emotion. If you got a webcam it can
be tested by doing:
emotion_test -gstreamer v4l://
This will use the first video device /dev/video0.
If you do not have a webcam, you can also try it using the Virtual Video driver
(modprobe vivi). If you got more that one video device you can also use
emotion_test -gstreamer v4l://0 v4l://1
to play from /dev/video0 and /dev/video1
---
src/modules/gstreamer/Makefile.am |5 +-
src/modules/gstreamer/emotion_gstreamer.c | 11 +++
src/modules/gstreamer/emotion_gstreamer_pipeline.h |1 +
.../gstreamer/emotion_gstreamer_pipeline_v4l.c | 87
4 files changed, 102 insertions(+), 2 deletions(-)
create mode 100644 src/modules/gstreamer/emotion_gstreamer_pipeline_v4l.c
diff --git a/src/modules/gstreamer/Makefile.am b/src/modules/gstreamer/Makefile.am
index f3519af..6aee2e3 100644
--- a/src/modules/gstreamer/Makefile.am
+++ b/src/modules/gstreamer/Makefile.am
@@ -24,10 +24,11 @@ emotion_gstreamer_pipeline.h \
emotion_gstreamer_pipeline_cdda.c \
emotion_gstreamer_pipeline_dvd.c \
emotion_gstreamer_pipeline_file.c \
-emotion_gstreamer_pipeline_uri.c
+emotion_gstreamer_pipeline_uri.c \
+emotion_gstreamer_pipeline_v4l.c
gstreamer_la_LIBADD = @EVAS_LIBS@ @ECORE_LIBS@ @GST_LIBS@ $(top_builddir)/src/lib/libemotion.la
gstreamer_la_LDFLAGS = -module -avoid-version
gstreamer_la_LIBTOOLFLAGS = --tag=disable-static
gstreamer_la_DEPENDENCIES = $(top_builddir)/config.h
-endif
\ No newline at end of file
+endif
diff --git a/src/modules/gstreamer/emotion_gstreamer.c b/src/modules/gstreamer/emotion_gstreamer.c
index b76eb25..1516bd3 100644
--- a/src/modules/gstreamer/emotion_gstreamer.c
+++ b/src/modules/gstreamer/
Re: [E-devel] E SVN: toma trunk/PROTO/keys
On Sun, Feb 22, 2009 at 10:54 AM, Enlightenment SVN wrote: > Log: ... > -ee.callback_delete_request_set(v.unlock_mod(1)) ouch, this was actually wrong, unless v.unlock_mod(1) returns a *function*, you were giving the callback_delete_request_set() the wrong object. I don't remember if I did check if the given object is a callable or not, but I should check for it or None. Summary: - v.unlock_mod: the "pointer" to function - v.unlock_mod(1): call the function v.unlock_mod() with parameter 1, receives a return value (which will be None if no explicit return statement is given). Regards, -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] Edge and corner bindings
ok, tested, the patch works really well and I really like the feature. If none has something against it I will commit the patch in the next days. Dave - "Viktor Kojouharov" ha scritto: > Hi guys, > > Since my computer burned to the ground, I will be out of one for at > least 2-3 weeks. But I have this nice looking patch, which adds edge > and > corner binding possibilities to E. Since I won't be able to commit it > if > raster approves it when he returns, I'd like to ask one of you to > commit > it in my stead. > > Now for the patch itself. The edge.5.diff contains all the needed > stuff > for this to work, besides the config dialog edj icon, which I hope > toma > will create (I just copied the one from conf_keybindings and renamed > it > so it would compile). > > It adds another dialog to the input section of the config panel. With > this dialog, one can bind actions to any edge or corner, and specify > a > delay and modifiers for it. The default bindings (if you click > restore > to default), is to make the desks flip in the direction of the > edge/corner with 0.3s delay. This is the same behaviour that was > previously set by default through the virtual desks config, and the > later was removed since it is not needed anymore. > > It also adds e_bindings_edge* set of functions to deal with the > actual > bindings, the special flip_in_direction action, config bindings > struct > and a major cleanup to the E_Zone struct and functions. A lot flags > are > removed since they are not needed anymore, as well as some functions > that made use of these flags. The long-standing annoyance where > dragging > something to a hidden shelf does not show it is also addressed. > > The second file is a patch for the configs that ship with E. It's a > separate file since I have NOT tested it (due to my laptop's > unfortunate > meltdown). It should work though. > > -- > Open Source Business Conference (OSBC), March 24-25, 2009, San > Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the > Enterprise > -Strategies to boost innovation and cut costs with open source > participation > -Receive a $600 discount off the registration fee with the source > code: SFAD > http://p.sf.net/sfu/XcvMzF8H > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: caro IN trunk/MISC/enthrall: . src
On Sun, 22 Feb 2009, Peter Wehrfritz wrote:
> Enlightenment SVN schrieb:
>> +if (ecore_str_has_suffix (output_file, ".ogg")) {
>>
> Better use ecore_str_has_extension(), it does a case-insensitive compare.
thanks, in svn
Vincent
--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: caro IN trunk/MISC/enthrall: . src
Enlightenment SVN schrieb:
> + if (ecore_str_has_suffix (output_file, ".ogg")) {
>
Better use ecore_str_has_extension(), it does a case-insensitive compare.
Peter
--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
