Re: [E-devel] E SVN: devilhorns trunk/e/src/bin
After a quick read-through, the patches look good :) I won't have time to actually do a build test until later tonight tho (and if ok, then I'll commmit them). If someone else gets to these before me, great...if not I will attend to them later tonightbut for the most part, if you have more like this, feel free to send them in :) Much appreciated :) Thanks, devilhorns Peter van de Werken wrote: On Sun, Jul 26, 2009 at 05:30:07PM -0700, Enlightenment SVN wrote: Log: Remove whitespace. Use E_FREE for things created with E_NEW. Add new function to clear the toolbar. Add new function to return the number of the selected item. got two patches: #1: hide eina_list internals by using the eina macros and methods instead #2: cleanup some duplicate code If appreciated I can provide more patches like #1 for the other parts of E. regards, Peter -- With a rubber duck, one's never alone. -- The Hitchhiker's Guide to the Galaxy -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] edje weirdness
On Sun, Jul 26, 2009 at 07:23:12PM -0300, Gustavo Sverzut Barbieri wrote: On Sun, Jul 26, 2009 at 5:46 PM, t...@hiddenrock.com wrote: The following is a group from a .edc file I'm using that is exhibiting behavior confusing to me. I have a SWALLOW object with an image in it, and when I call the selected_on program, I want the selector part shown on top, which will obscure the image a bit. This works, initially. However, if I move the object, it appears as if the selector part is no longer on top of the card part, because the former doesn't show up when the appropriate program is called. If I add card as a target for the program, the card disappears and the selector alpha rect shows up, which implies to me that it's underneath the card. I thought parts within a group were ordered such that lower parts were on top. What am I missing? I have not tried it myself, but I'd say don't trust SWALLOW parts events as it will depend on the swallowed part. Instead just add a part on top that catch events, it can be transparent (color: 0 0 0 0;) and if you want events to be repeated to parts below, just use repeat_events:1; I don't follow. The problem does not appear to be related to catching events, but rather to the Z-ordering of the parts within the group. That is, the card_click program always does its thing when I expect it to, but running program selected_on does not result in the selector part appearing above the card part. Am I misunderstanding your hypothesis? BTW, comma notation is deprecated, use : instead. Cool, thanks. pete -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] edje weirdness
On Mon, Jul 27, 2009 at 03:36:10PM -0400, t...@hiddenrock.com wrote: On Sun, Jul 26, 2009 at 07:23:12PM -0300, Gustavo Sverzut Barbieri wrote: On Sun, Jul 26, 2009 at 5:46 PM, t...@hiddenrock.com wrote: The following is a group from a .edc file I'm using that is exhibiting behavior confusing to me. I have a SWALLOW object with an image in it, and when I call the selected_on program, I want the selector part shown on top, which will obscure the image a bit. This works, initially. However, if I move the object, it appears as if the selector part is no longer on top of the card part, because the former doesn't show up when the appropriate program is called. If I add card as a target for the program, the card disappears and the selector alpha rect shows up, which implies to me that it's underneath the card. I thought parts within a group were ordered such that lower parts were on top. What am I missing? I have not tried it myself, but I'd say don't trust SWALLOW parts events as it will depend on the swallowed part. Instead just add a part on top that catch events, it can be transparent (color: 0 0 0 0;) and if you want events to be repeated to parts below, just use repeat_events:1; I don't follow. The problem does not appear to be related to catching events, but rather to the Z-ordering of the parts within the group. That is, the card_click program always does its thing when I expect it to, but running program selected_on does not result in the selector part appearing above the card part. Am I misunderstanding your hypothesis? Aha. I found I was doing other evas_object_raise()s elsewhere that were causing problems. Sorry for the confusion! pete -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: devilhorns trunk/e/src/bin
Thanks, Committed :) I slightly modified the patches a little to account for formatting whitespace. I also replaced a couple of missed while/for loops with eina_list macros. Cheers, devilhorns Peter van de Werken wrote: On Sun, Jul 26, 2009 at 05:30:07PM -0700, Enlightenment SVN wrote: Log: Remove whitespace. Use E_FREE for things created with E_NEW. Add new function to clear the toolbar. Add new function to return the number of the selected item. got two patches: #1: hide eina_list internals by using the eina macros and methods instead #2: cleanup some duplicate code If appreciated I can provide more patches like #1 for the other parts of E. regards, Peter -- With a rubber duck, one's never alone. -- The Hitchhiker's Guide to the Galaxy -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
