[E-devel] [elementary] _expand already exists on Windows
Hey in elc_fileselector.c, _expand is defined, but it is a symbol that is already defined in mingw gcc. Can someone rename it ? (btw, all the functions in elm should have a namespace to avoid that kind of problem) Vincent -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: devilhorns trunk/e/src/bin
On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: Formatting. Whitespace Removal. Fetch the windows evas once instead of multiple calls to e_win_evas_get. Use E_FREE to free the config dialog structure. Make sure the window is centered when switching between Basic Advanced. This last bit is up to discussion. I personally dislike it as all your reference is lost when you change the window. For example, the title bar will change completely. Most people (at least languages supported by E) read from top-left to bottom-right and loosing the reference point is not good. BUT I know the dialog can overflow visible area, even more if screen is small (try at 640x480), so I'd say we should not center if we not overflow, center or clamp otherwise. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: devilhorns trunk/e/src/bin
Gustavo Sverzut Barbieri wrote: On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: Formatting. Whitespace Removal. Fetch the windows evas once instead of multiple calls to e_win_evas_get. Use E_FREE to free the config dialog structure. Make sure the window is centered when switching between Basic Advanced. This last bit is up to discussion. I personally dislike it as all your reference is lost when you change the window. I'm lost a little here by this statement...I didn't change the window at all...just added one line to ensure that it's centered when changing modes (basic/advanced) For example, the title bar will change completely. Just by centering a window ? I don't think so... Most people (at least languages supported by E) read from top-left to bottom-right and loosing the reference point is not good. BUT I know the dialog can overflow visible area, even more if screen is small (try at 640x480), so I'd say we should not center if we not overflow, center or clamp otherwise. dh -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: devilhorns trunk/e/src/bin
On Sat, Aug 22, 2009 at 11:27 PM, Christopher Michaelcpmicha...@comcast.net wrote: Gustavo Sverzut Barbieri wrote: On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: Formatting. Whitespace Removal. Fetch the windows evas once instead of multiple calls to e_win_evas_get. Use E_FREE to free the config dialog structure. Make sure the window is centered when switching between Basic Advanced. This last bit is up to discussion. I personally dislike it as all your reference is lost when you change the window. I'm lost a little here by this statement...I didn't change the window at all...just added one line to ensure that it's centered when changing modes (basic/advanced) exactly, window was at (x,y) + wxh. I prefer it to just change wxh and not the 4 values. For example, the title bar will change completely. Just by centering a window ? I don't think so... Most people (at least languages supported by E) read from top-left to bottom-right and loosing the reference point is not good. BUT I know the dialog can overflow visible area, even more if screen is small (try at 640x480), so I'd say we should not center if we not overflow, center or clamp otherwise. dh -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: devilhorns trunk/e/src/bin
Gustavo Sverzut Barbieri wrote: On Sat, Aug 22, 2009 at 11:27 PM, Christopher Michaelcpmicha...@comcast.net wrote: Gustavo Sverzut Barbieri wrote: On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: Formatting. Whitespace Removal. Fetch the windows evas once instead of multiple calls to e_win_evas_get. Use E_FREE to free the config dialog structure. Make sure the window is centered when switching between Basic Advanced. This last bit is up to discussion. I personally dislike it as all your reference is lost when you change the window. I'm lost a little here by this statement...I didn't change the window at all...just added one line to ensure that it's centered when changing modes (basic/advanced) exactly, window was at (x,y) + wxh. I prefer it to just change wxh and not the 4 values. Well, if it ends up bothering people too much, then we can just remove it. Seemed silly to me tho to not have the window centered when chaning modes (since it was centered at the start)...but maybe that's just me... dh For example, the title bar will change completely. Just by centering a window ? I don't think so... Most people (at least languages supported by E) read from top-left to bottom-right and loosing the reference point is not good. BUT I know the dialog can overflow visible area, even more if screen is small (try at 640x480), so I'd say we should not center if we not overflow, center or clamp otherwise. dh -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: devilhorns trunk/e/src/bin
On Sat, 22 Aug 2009 23:00:22 -0400 Christopher Michael cpmicha...@comcast.net wrote: Gustavo Sverzut Barbieri wrote: On Sat, Aug 22, 2009 at 11:27 PM, Christopher Michaelcpmicha...@comcast.net wrote: Gustavo Sverzut Barbieri wrote: On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: Formatting. Whitespace Removal. Fetch the windows evas once instead of multiple calls to e_win_evas_get. Use E_FREE to free the config dialog structure. Make sure the window is centered when switching between Basic Advanced. This last bit is up to discussion. I personally dislike it as all your reference is lost when you change the window. I'm lost a little here by this statement...I didn't change the window at all...just added one line to ensure that it's centered when changing modes (basic/advanced) exactly, window was at (x,y) + wxh. I prefer it to just change wxh and not the 4 values. Well, if it ends up bothering people too much, then we can just remove it. Seemed silly to me tho to not have the window centered when chaning modes (since it was centered at the start)...but maybe that's just me... And if the window had been moved to somewhere else by the user? I say without looking at the code. lol signature.asc Description: PGP signature -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: devilhorns trunk/e/src/bin
David Seikel wrote: On Sat, 22 Aug 2009 23:00:22 -0400 Christopher Michael cpmicha...@comcast.net wrote: Gustavo Sverzut Barbieri wrote: On Sat, Aug 22, 2009 at 11:27 PM, Christopher Michaelcpmicha...@comcast.net wrote: Gustavo Sverzut Barbieri wrote: On Sat, Aug 22, 2009 at 11:03 PM, Enlightenment SVNno-re...@enlightenment.org wrote: Log: Formatting. Whitespace Removal. Fetch the windows evas once instead of multiple calls to e_win_evas_get. Use E_FREE to free the config dialog structure. Make sure the window is centered when switching between Basic Advanced. This last bit is up to discussion. I personally dislike it as all your reference is lost when you change the window. I'm lost a little here by this statement...I didn't change the window at all...just added one line to ensure that it's centered when changing modes (basic/advanced) exactly, window was at (x,y) + wxh. I prefer it to just change wxh and not the 4 values. Well, if it ends up bothering people too much, then we can just remove it. Seemed silly to me tho to not have the window centered when chaning modes (since it was centered at the start)...but maybe that's just me... And if the window had been moved to somewhere else by the user? I say without looking at the code. lol That's true...I hadn't considered that angle. I'll revert. dh -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
