[E-devel] Using -Wall -Wextra -Wno-unused-parameter
Hey all, Wall and Wextra are great compilation flags they help finding a lot of coding mistakes. Warnings about unused parameters is a bit annoying in a library that has a lot of callbacks, so disabling that makes sense, but other than that, all warnings are welcomed. What do you guys say about making -Wall -Wextra -Wno-unused-parameter our new compilation flags default? -- Tom. -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter
On Wed, Aug 18, 2010 at 4:35 PM, Christopher Michael cpmicha...@comcast.net wrote: Personally I like the idea. It would certainly help spot errors in code and could help enforce cleaner code from others. WRT unused paramaters tho, I would lean toward the side of not disabling those tho because there are some situations where those warnings are legitimate. Yes, don't put every where __UNUSED__, understand the code, see FIXME or #ifdef and act accordingly. But anyway, I am all for enforcing that all new commit to our svn should not trigger new warning with this flags. -- Cedric BAIL -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] efl broken on Gentoo
On Wed, 18 Aug 2010, Matthew Robbetts wrote: On 08/18/10 19:34, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: Those new errors are fixed now, but it has just reverted to the original breakage. I don't suppose anyone knows Gentoo well enough to event hint at something I could check into? It's driving me nuts. I'm having to use KDE while enlightenment is broken, so I really hope someone can help me soon! that one: `/var/tmp/portage/x11-wm/enlightenment-/work/trunk/e': configure: error: The pkg-config script could not be found or is too old. Make sure it ? If so, did you read my answer i sent you some day ago ? Vincent You mean: 'I don't know how gentoo manages the pkg-config binary. It's strange anyway' I did get that, but can't think what to do about it. The pkg-config folder seems to contain valid .pc files for everything. The error message sounds a bit like the .pc file is missing from the source or something. Either way, if the error listed exactly which file it was missing it would be helpful! the problem is not the .pc files. The problem is the binary named 'pkg-config'. The error does not say that a package is missing. The error is : The pkg-config script could not be found or is too old as you used that binary for the EFL, that is why I said that it is strange. paste in pastebin.com the content of config.log The directory that's mentioned has no .pc files in it, though it does have `everything.pc.in` and `enlightenment.pc.in` in there. Do you know if that's correct? it is not related. It's just strange because I haven't changed anything. I'm using layman to manage the overlay, which I sync regularly, and I rebuild the packages listed in that order. I presume nobody else on Gentoo is seeing this problem? I don't use gentoo, sorry. Vincent -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] efl broken on Gentoo
On 08/18/10 20:04, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: On 08/18/10 19:34, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: Those new errors are fixed now, but it has just reverted to the original breakage. I don't suppose anyone knows Gentoo well enough to event hint at something I could check into? It's driving me nuts. I'm having to use KDE while enlightenment is broken, so I really hope someone can help me soon! that one: `/var/tmp/portage/x11-wm/enlightenment-/work/trunk/e': configure: error: The pkg-config script could not be found or is too old. Make sure it ? If so, did you read my answer i sent you some day ago ? Vincent You mean: 'I don't know how gentoo manages the pkg-config binary. It's strange anyway' I did get that, but can't think what to do about it. The pkg-config folder seems to contain valid .pc files for everything. The error message sounds a bit like the .pc file is missing from the source or something. Either way, if the error listed exactly which file it was missing it would be helpful! the problem is not the .pc files. The problem is the binary named 'pkg-config'. The error does not say that a package is missing. The error is : The pkg-config script could not be found or is too old as you used that binary for the EFL, that is why I said that it is strange. paste in pastebin.com the content of config.log Hi Vincent, Hope this is the right one: http://pastebin.com/BwaR9jH4 Thanks a lot :) -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] efl broken on Gentoo
On Wed, 18 Aug 2010, Matthew Robbetts wrote: On 08/18/10 20:04, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: On 08/18/10 19:34, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: Those new errors are fixed now, but it has just reverted to the original breakage. I don't suppose anyone knows Gentoo well enough to event hint at something I could check into? It's driving me nuts. I'm having to use KDE while enlightenment is broken, so I really hope someone can help me soon! that one: `/var/tmp/portage/x11-wm/enlightenment-/work/trunk/e': configure: error: The pkg-config script could not be found or is too old. Make sure it ? If so, did you read my answer i sent you some day ago ? Vincent You mean: 'I don't know how gentoo manages the pkg-config binary. It's strange anyway' I did get that, but can't think what to do about it. The pkg-config folder seems to contain valid .pc files for everything. The error message sounds a bit like the .pc file is missing from the source or something. Either way, if the error listed exactly which file it was missing it would be helpful! the problem is not the .pc files. The problem is the binary named 'pkg-config'. The error does not say that a package is missing. The error is : The pkg-config script could not be found or is too old as you used that binary for the EFL, that is why I said that it is strange. paste in pastebin.com the content of config.log Hi Vincent, Hope this is the right one: http://pastebin.com/BwaR9jH4 add PKG_PROG_PKG_CONFIG line 292 of the configure.ac file, that is, just before : if test x$e_cv_want_device_udev = xyes;then Vincent -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter
On Wed, Aug 18, 2010 at 7:06 PM, Vincent Torri vto...@univ-evry.fr wrote: See how I did in eina's configure.ac. It's just a macro to add. This? m4_ifdef([v_mic], [ EFL_COMPILER_FLAG([-Wall]) EFL_COMPILER_FLAG([-W]) ]) What does it do exactly? (I'm not an m4 expert). -- Tom. -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter
On Wed, 18 Aug 2010, Tom Hacohen wrote: On Wed, Aug 18, 2010 at 7:06 PM, Vincent Torri vto...@univ-evry.fr wrote: See how I did in eina's configure.ac. It's just a macro to add. This? m4_ifdef([v_mic], [ EFL_COMPILER_FLAG([-Wall]) EFL_COMPILER_FLAG([-W]) ]) EFL_COMPILER_FLAG([-Wall]) adds -Wall to CFLAGS m4_ifdef([v_mic] ***) checks if v_mic is used (that is if the micro version of eina is defined. I did that in order to add these flags only when in developper mode (not in release mode) But you can use EFL_COMPILER_FLAG without m4_ifdef. Just like that: EFL_COMPILER_FLAG([-Wall]) Vincent -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter
On Wed, Aug 18, 2010 at 10:27 PM, Vincent Torri vto...@univ-evry.fr wrote: EFL_COMPILER_FLAG([-Wall]) adds -Wall to CFLAGS m4_ifdef([v_mic] ***) checks if v_mic is used (that is if the micro version of eina is defined. I did that in order to add these flags only when in developper mode (not in release mode) But you can use EFL_COMPILER_FLAG without m4_ifdef. Just like that: EFL_COMPILER_FLAG([-Wall]) Cool. Is there a standard way to choose between developer mode to release mode in autotools? (except for what you did with the versions) Maybe we should consider adding that as well. -- Tom. -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter
On Wed, 18 Aug 2010, Tom Hacohen wrote: On Wed, Aug 18, 2010 at 10:27 PM, Vincent Torri vto...@univ-evry.fr wrote: EFL_COMPILER_FLAG([-Wall]) adds -Wall to CFLAGS m4_ifdef([v_mic] ***) checks if v_mic is used (that is if the micro version of eina is defined. I did that in order to add these flags only when in developper mode (not in release mode) But you can use EFL_COMPILER_FLAG without m4_ifdef. Just like that: EFL_COMPILER_FLAG([-Wall]) Cool. Is there a standard way to choose between developer mode to release mode in autotools? (except for what you did with the versions) Maybe we should consider adding that as well. better ask raster, as i'm not sure exactly which part of the version is not used for the release mode IIRC, v_mic is always used. The development part is v_rev - the current SVN revision, which is m4_undefine'd for releases. Cheers, -- Albin Tonnerre -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] efl broken on Gentoo
On 08/18/10 20:20, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: On 08/18/10 20:04, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: On 08/18/10 19:34, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: Those new errors are fixed now, but it has just reverted to the original breakage. I don't suppose anyone knows Gentoo well enough to event hint at something I could check into? It's driving me nuts. I'm having to use KDE while enlightenment is broken, so I really hope someone can help me soon! that one: `/var/tmp/portage/x11-wm/enlightenment-/work/trunk/e': configure: error: The pkg-config script could not be found or is too old. Make sure it ? If so, did you read my answer i sent you some day ago ? Vincent You mean: 'I don't know how gentoo manages the pkg-config binary. It's strange anyway' I did get that, but can't think what to do about it. The pkg-config folder seems to contain valid .pc files for everything. The error message sounds a bit like the .pc file is missing from the source or something. Either way, if the error listed exactly which file it was missing it would be helpful! the problem is not the .pc files. The problem is the binary named 'pkg-config'. The error does not say that a package is missing. The error is : The pkg-config script could not be found or is too old as you used that binary for the EFL, that is why I said that it is strange. paste in pastebin.com the content of config.log Hi Vincent, Hope this is the right one: http://pastebin.com/BwaR9jH4 add PKG_PROG_PKG_CONFIG line 292 of the configure.ac file, that is, just before : if test x$e_cv_want_device_udev = xyes;then Vincent That sounds awfully simple :) I'll try it when I can work out how to make Gentoo not overwrite the modified file with the repo version every time I try to emerge! Anyhow, in case this does actually fix my problem - is this something that should be committed to svn, or an indication that something's not right with my system? Ta, Matt -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] efl broken on Gentoo
On Wed, 18 Aug 2010, Matthew Robbetts wrote: Hope this is the right one: http://pastebin.com/BwaR9jH4 add PKG_PROG_PKG_CONFIG line 292 of the configure.ac file, that is, just before : if test x$e_cv_want_device_udev = xyes;then Vincent That sounds awfully simple :) I'll try it when I can work out how to make Gentoo not overwrite the modified file with the repo version every time I try to emerge! Anyhow, in case this does actually fix my problem - is this something that should be committed to svn, or an indication that something's not right with my system? First, try that. According to config.log, the second use of pkg-config is when defining E_REMOTE (a few lines after, it's where the error is), but just before, PKG_CHECK_EXISTS (the first use of pkg-config) is used conditionnally. I know that I had some problems when PKG_CHECK_EXISTS or PKG_CHECK_MODULES is used conditionnally. And I fixed the problem by checking first if pkg-config exists with PKG_PROG_PKG_CONFIG. Vincent -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter
On Wed, 18 Aug 2010 21:42:12 +0200 Albin Tonnerre albin.tonne...@gmail.com said: On Wed, 18 Aug 2010, Tom Hacohen wrote: On Wed, Aug 18, 2010 at 10:27 PM, Vincent Torri vto...@univ-evry.fr wrote: EFL_COMPILER_FLAG([-Wall]) adds -Wall to CFLAGS m4_ifdef([v_mic] ***) checks if v_mic is used (that is if the micro version of eina is defined. I did that in order to add these flags only when in developper mode (not in release mode) But you can use EFL_COMPILER_FLAG without m4_ifdef. Just like that: EFL_COMPILER_FLAG([-Wall]) Cool. Is there a standard way to choose between developer mode to release mode in autotools? (except for what you did with the versions) Maybe we should consider adding that as well. better ask raster, as i'm not sure exactly which part of the version is not used for the release mode IIRC, v_mic is always used. The development part is v_rev - the current SVN revision, which is m4_undefine'd for releases. from efl 1.0.0 on (well eet 1.4.0 too - eet is a stupid exception here, but maybe over time it will come into line). v_rev is indeed off for release. it's off now in svn. v_rev is on otheriwse when back in normal dev mode. v_mic is for bugfix releases. ie after 1.0.0, 1.0.1 will simply be a patchlevel fixing bugs, maybe optimising some internals, cleaning something up. no features are added. nothing new. just stuff fixed/improved silently as far as any app/lib is concerned that uses EFL. when v_mic goes up - we did a new release with fixes. v_min is for major major bugfix(es) but mostly for hey - we added new features. new api calls. new enums. new struct members, new code-path options that were not meant to work before, but now do etc. etc. - when this goes up, v_mic goes back to 0 and we have improved that lib with new stuff or very significant fixes. the lib will not break for existing apps/libs, BUT new libs/apps cannot work with an older minor versioned lib - eg an app built for 1.2 cannot 100% be guaranteed to work with 1.1 - but 1.2.3 will work with 1.2.1, so its backwards-compat for older built apps and libs only. v_maj is major release version. as of now it's. if this goes up - we broke api or abi. we'd damned well never break this unless we ABSOLUTELY HAVE TO. i'd like to have at least a few years between now and any break. every break pisses developers who use api's off. as for forcing -W's into builds. no. this is compiler dependent AND it's the task of CFLAGS. you can make this happen for you NOW. export CFLAGS=-W -Wall -Wextra -Werror etc. done. nothing to be changed anywhere in any svn in any source tree. by putting it on there you force error output for those that simply dont want it OR don't care and wont read it anyway, or it simply confuses them. we have enough gentoo users who are unable to read as it is. (sorry - have to say that, but it's true - there are enough who simply paste compiler output just so we can become reading services. SIMPLE errors like blah.h not found and having to tell them well blah.h is not found. maybe you need blah?). haven't you seen enough pasts of but when e starts, it logs errors about this hash being null,. that must be the bug why it segv's without ever using gdb. because something prints out warning to people who have no idea what the waninng actually means, it sends them off on a vector wasting their and our time. other than that, -W's are the job of your CFLAGS and you can, if you want them and to fix wanrings, set it up in your bashrc or have an alias that changes your cflags to add them in etc. etc. eg: alias cflagwarn='export CFLAGS=$CFLAGS -W -Wall -Wextra -Werror' then just: cflagswarn before doing efl compiles. setting warning flags simply does not belong in the makefiles, configure scripts etc. of a project. if you say well lets make it a --enable-warnings then just SET YOUR CFLAGS instead! there is no point in involving configure. this does not mean i hate the warnings and discourage them in general - it just is not the place for them to be set on by default in configure scripts. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] efl broken on Gentoo
On 08/18/10 21:08, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: Hope this is the right one: http://pastebin.com/BwaR9jH4 add PKG_PROG_PKG_CONFIG line 292 of the configure.ac file, that is, just before : if test x$e_cv_want_device_udev = xyes;then Vincent That sounds awfully simple :) I'll try it when I can work out how to make Gentoo not overwrite the modified file with the repo version every time I try to emerge! Anyhow, in case this does actually fix my problem - is this something that should be committed to svn, or an indication that something's not right with my system? First, try that. According to config.log, the second use of pkg-config is when defining E_REMOTE (a few lines after, it's where the error is), but just before, PKG_CHECK_EXISTS (the first use of pkg-config) is used conditionnally. I know that I had some problems when PKG_CHECK_EXISTS or PKG_CHECK_MODULES is used conditionnally. And I fixed the problem by checking first if pkg-config exists with PKG_PROG_PKG_CONFIG. Vincent Well, I couldn't work out how to trick gentoo into playing nice with it, but I just went into the source and ran ./autogen and the configure stage does indeed complete now. Excellent. I'm continuing with the build to see what happens... Sounds like one of those annoying fiddly script problems that seem to crop up sometimes. Does the modification you gave me break it for other people? -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] efl broken on Gentoo
On Thu, 19 Aug 2010, Matthew Robbetts wrote: On 08/18/10 21:08, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: Hope this is the right one: http://pastebin.com/BwaR9jH4 add PKG_PROG_PKG_CONFIG line 292 of the configure.ac file, that is, just before : if test x$e_cv_want_device_udev = xyes;then Vincent That sounds awfully simple :) I'll try it when I can work out how to make Gentoo not overwrite the modified file with the repo version every time I try to emerge! Anyhow, in case this does actually fix my problem - is this something that should be committed to svn, or an indication that something's not right with my system? First, try that. According to config.log, the second use of pkg-config is when defining E_REMOTE (a few lines after, it's where the error is), but just before, PKG_CHECK_EXISTS (the first use of pkg-config) is used conditionnally. I know that I had some problems when PKG_CHECK_EXISTS or PKG_CHECK_MODULES is used conditionnally. And I fixed the problem by checking first if pkg-config exists with PKG_PROG_PKG_CONFIG. Vincent Well, I couldn't work out how to trick gentoo into playing nice with it, but I just went into the source and ran ./autogen and the configure stage does indeed complete now. Excellent. I'm continuing with the build to see what happens... Sounds like one of those annoying fiddly script problems that seem to crop up sometimes. Does the modification you gave me break it for other people? I've patched the configure.ac file in svn. Try to compile again Vincent -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] efl broken on Gentoo
On 08/19/2010 12:08 AM, Vincent Torri wrote: On Thu, 19 Aug 2010, Matthew Robbetts wrote: On 08/18/10 21:08, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: Hope this is the right one: http://pastebin.com/BwaR9jH4 add PKG_PROG_PKG_CONFIG line 292 of the configure.ac file, that is, just before : if test x$e_cv_want_device_udev = xyes;then Vincent That sounds awfully simple :) I'll try it when I can work out how to make Gentoo not overwrite the modified file with the repo version every time I try to emerge! Anyhow, in case this does actually fix my problem - is this something that should be committed to svn, or an indication that something's not right with my system? First, try that. According to config.log, the second use of pkg-config is when defining E_REMOTE (a few lines after, it's where the error is), but just before, PKG_CHECK_EXISTS (the first use of pkg-config) is used conditionnally. I know that I had some problems when PKG_CHECK_EXISTS or PKG_CHECK_MODULES is used conditionnally. And I fixed the problem by checking first if pkg-config exists with PKG_PROG_PKG_CONFIG. Vincent Well, I couldn't work out how to trick gentoo into playing nice with it, but I just went into the source and ran ./autogen and the configure stage does indeed complete now. Excellent. I'm continuing with the build to see what happens... Sounds like one of those annoying fiddly script problems that seem to crop up sometimes. Does the modification you gave me break it for other people? I've patched the configure.ac file in svn. Try to compile again Vincent Vincent, You are an absolute legend - it's worked perfectly. I am enlightened once more. Thanks ever so much! -- This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
