[E-devel] [PATCH] elm_transit
Hi,
Here is a very small patch for elm_transit
Removed an unnecessary parameter.
Please consider then apply it.
Thanks.
Index: lib/elm_transit.c
===
--- lib/elm_transit.c (revision 55979)
+++ lib/elm_transit.c (working copy)
@@ -2362,7 +2362,6 @@
struct _Elm_Transit_Effect_Rotation
{
- Eina_Bool cw;
float from, to;
};
@@ -2395,8 +2394,6 @@
evas_map_util_points_populate_from_object_full(map, obj, 0);
degree = rotation->from + (float)(progress * rotation->to);
-if (!rotation->cw) degree *= -1;
-
evas_object_geometry_get(obj, &x, &y, &w, &h);
half_w = (float)w * 0.5;
@@ -2411,7 +2408,7 @@
}
static void *
-_transit_effect_rotation_context_new(float from_degree, float to_degree,
Eina_Bool cw)
+_transit_effect_rotation_context_new(float from_degree, float to_degree)
{
Elm_Transit_Effect_Rotation *rotation;
@@ -2420,7 +2417,6 @@
rotation->from = from_degree;
rotation->to = to_degree - from_degree;
- rotation->cw = cw;
return rotation;
}
Index: lib/Elementary.h.in
===
--- lib/Elementary.h.in (revision 55979)
+++ lib/Elementary.h.in (working copy)
@@ -2501,7 +2501,7 @@
EAPI void *elm_transit_effect_color_add(Elm_Transit
*transit, unsigned int from_r, unsigned int from_g, unsigned int from_b,
unsigned int from_a, unsigned int to_r, unsigned int to_g, unsigned int to_b,
unsigned int to_a);
EAPI void *elm_transit_effect_fade_add(Elm_Transit
*transit);
EAPI void *elm_transit_effect_blend_add(Elm_Transit
*transit);
- EAPI void *elm_transit_effect_rotation_add(Elm_Transit
*transit, float from_degree, float to_degree, Eina_Bool cw);
+ EAPI void *elm_transit_effect_rotation_add(Elm_Transit
*transit, float from_degree);
EAPI void
*elm_transit_effect_image_animation_add(Elm_Transit *transit, Eina_List
*images);
typedef struct _Elm_Store Elm_Store;
Index: bin/test_transit.c
===
--- bin/test_transit.c (revision 55979)
+++ bin/test_transit.c (working copy)
@@ -81,7 +81,7 @@
elm_transit_effect_color_add(trans, 100, 255, 100, 255, 200, 50, 200, 50);
/* Rotation Effect */
- elm_transit_effect_rotation_add(trans, 0.0, 135.0, EINA_FALSE);
+ elm_transit_effect_rotation_add(trans, 0.0, 135.0);
elm_transit_duration_set(trans, 5.0);
elm_transit_go(trans);
--
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web. Learn how to
best implement a security strategy that keeps consumers' information secure
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl ___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] elm_transit
Really sorry.
Attached file is something wrong.
Here it again.
Thanks.
-Original Message-
From: ChunEon Park [mailto:chuneon.p...@samsung.com]
Sent: Friday, January 07, 2011 8:48 PM
To: 'enlightenment-devel@lists.sourceforge.net'
Subject: [PATCH] elm_transit
Hi,
Here is a very small patch for elm_transit
Removed an unnecessary parameter.
Please consider then apply it.
Thanks.
Index: lib/elm_transit.c
===
--- lib/elm_transit.c (revision 55979)
+++ lib/elm_transit.c (working copy)
@@ -2362,7 +2362,6 @@
struct _Elm_Transit_Effect_Rotation
{
- Eina_Bool cw;
float from, to;
};
@@ -2395,8 +2394,6 @@
evas_map_util_points_populate_from_object_full(map, obj, 0);
degree = rotation->from + (float)(progress * rotation->to);
-if (!rotation->cw) degree *= -1;
-
evas_object_geometry_get(obj, &x, &y, &w, &h);
half_w = (float)w * 0.5;
@@ -2411,7 +2408,7 @@
}
static void *
-_transit_effect_rotation_context_new(float from_degree, float to_degree,
Eina_Bool cw)
+_transit_effect_rotation_context_new(float from_degree, float to_degree)
{
Elm_Transit_Effect_Rotation *rotation;
@@ -2420,7 +2417,6 @@
rotation->from = from_degree;
rotation->to = to_degree - from_degree;
- rotation->cw = cw;
return rotation;
}
@@ -2440,7 +2436,6 @@
* @param transit Transit object.
* @param from_degree Degree when effect begins.
* @param to_degree Degree when effect is ends.
- * @param cw Rotation direction. EINA_TRUE is clock wise.
* @return Rotation effect context data.
*
* @ingroup Transit
@@ -2452,10 +2447,10 @@
* to run, because the order of the objects will be affected.
*/
EAPI void *
-elm_transit_effect_rotation_add(Elm_Transit *transit, float from_degree, float
to_degree, Eina_Bool cw)
+elm_transit_effect_rotation_add(Elm_Transit *transit, float from_degree, float
to_degree)
{
ELM_TRANSIT_CHECK_OR_RETURN(transit, NULL);
- void *effect_context = _transit_effect_rotation_context_new(from_degree,
to_degree, cw);
+ void *effect_context = _transit_effect_rotation_context_new(from_degree,
to_degree);
if (!effect_context) return NULL;
elm_transit_effect_add(transit,
Index: lib/Elementary.h.in
===
--- lib/Elementary.h.in (revision 55979)
+++ lib/Elementary.h.in (working copy)
@@ -2501,7 +2501,7 @@
EAPI void *elm_transit_effect_color_add(Elm_Transit
*transit, unsigned int from_r, unsigned int from_g, unsigned int from_b,
unsigned int from_a, unsigned int to_r, unsigned int to_g, unsigned int to_b,
unsigned int to_a);
EAPI void *elm_transit_effect_fade_add(Elm_Transit
*transit);
EAPI void *elm_transit_effect_blend_add(Elm_Transit
*transit);
- EAPI void *elm_transit_effect_rotation_add(Elm_Transit
*transit, float from_degree, float to_degree, Eina_Bool cw);
+ EAPI void *elm_transit_effect_rotation_add(Elm_Transit
*transit, float from_degree, float to_degree);
EAPI void
*elm_transit_effect_image_animation_add(Elm_Transit *transit, Eina_List
*images);
typedef struct _Elm_Store Elm_Store;
Index: bin/test_transit.c
===
--- bin/test_transit.c (revision 55979)
+++ bin/test_transit.c (working copy)
@@ -81,7 +81,7 @@
elm_transit_effect_color_add(trans, 100, 255, 100, 255, 200, 50, 200, 50);
/* Rotation Effect */
- elm_transit_effect_rotation_add(trans, 0.0, 135.0, EINA_FALSE);
+ elm_transit_effect_rotation_add(trans, 0.0, 135.0);
elm_transit_duration_set(trans, 5.0);
elm_transit_go(trans);
--
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web. Learn how to
best implement a security strategy that keeps consumers' information secure
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl ___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: caro trunk/TMP/st/elementary
On Thu, 6 Jan 2011 11:01:34 -0800 "Enlightenment SVN" said: > Log: > add guards in config.h to avoid multiple inclusions > > raster: may I rename elementary_config.h to config.h ? If I > add macros for all the init stuff, it would be nice to have > consistent name for that file yes you may :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Gaining the trust of online customers is vital for the success of any company that requires sensitive data to be transmitted over the Web. Learn how to best implement a security strategy that keeps consumers' information secure and instills the confidence they need to proceed with transactions. http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk: ecore ecore/src/lib/ecore ecore/src/lib/ecore_file eet eet/src/lib eina eina/src/lib evas/src/lib/canvas evas/src/lib/file evas/src/lib/include
On Fri, 7 Jan 2011, Enlightenment SVN wrote:
> Log:
> hve to revert these commits. they hve created a whole chunk of 64bit
> crashes on linux. this is REALLY bad. so remove these changes now.
I have tested them on my 64 bits ubuntu.
You can't seriously say that these commits can crash the EFL. It's just a
matter of macro defined in config.h ! Look at the patches !
Vincent
>
>
>
> Author: raster
> Date: 2011-01-07 07:56:54 -0800 (Fri, 07 Jan 2011)
> New Revision: 55981
> Trac: http://trac.enlightenment.org/e/changeset/55981
>
> Modified:
> trunk/ecore/configure.ac trunk/ecore/src/lib/ecore/ecore.c
> trunk/ecore/src/lib/ecore/ecore_app.c trunk/ecore/src/lib/ecore/ecore_main.c
> trunk/ecore/src/lib/ecore_file/ecore_file.c trunk/eet/configure.ac
> trunk/eet/src/lib/eet_cipher.c trunk/eet/src/lib/eet_lib.c
> trunk/eina/configure.ac trunk/eina/src/lib/eina_hash.c
> trunk/eina/src/lib/eina_log.c trunk/eina/src/lib/eina_module.c
> trunk/evas/src/lib/canvas/evas_async_events.c
> trunk/evas/src/lib/file/evas_path.c trunk/evas/src/lib/include/evas_common.h
>
> Modified: trunk/ecore/configure.ac
> ===
> --- trunk/ecore/configure.ac 2011-01-07 12:57:06 UTC (rev 55980)
> +++ trunk/ecore/configure.ac 2011-01-07 15:56:54 UTC (rev 55981)
> @@ -889,7 +889,7 @@
> have_addrinfo="yes"
> ;;
>*)
> - AC_CHECK_HEADERS([dlfcn.h features.h langinfo.h locale.h sys/time.h
> sys/mman.h signal.h sys/resource.h sys/param.h unistd.h libgen])
> + AC_CHECK_HEADERS([dlfcn.h features.h langinfo.h locale.h sys/time.h
> sys/mman.h signal.h sys/resource.h])
> ;;
> esac
>
>
> Modified: trunk/ecore/src/lib/ecore/ecore.c
> ===
> --- trunk/ecore/src/lib/ecore/ecore.c 2011-01-07 12:57:06 UTC (rev 55980)
> +++ trunk/ecore/src/lib/ecore/ecore.c 2011-01-07 15:56:54 UTC (rev 55981)
> @@ -8,7 +8,7 @@
> #include
> #include
>
> -#ifdef HAVE_UNISTD_H
> +#ifndef _MSC_VER
> # include
> #endif
>
> @@ -27,7 +27,6 @@
> #ifdef HAVE_EVIL
> # include
> #endif
> -
> #include
>
> #include "Ecore.h"
>
> Modified: trunk/ecore/src/lib/ecore/ecore_app.c
> ===
> --- trunk/ecore/src/lib/ecore/ecore_app.c 2011-01-07 12:57:06 UTC (rev
> 55980)
> +++ trunk/ecore/src/lib/ecore/ecore_app.c 2011-01-07 15:56:54 UTC (rev
> 55981)
> @@ -4,11 +4,9 @@
>
> #include
>
> -#ifdef HAVE_UNISTD_H
> +#ifndef _MSC_VER
> # include
> -#endif
> -
> -#ifdef _MSC_VER
> +#else
> # include
> #endif
>
>
> Modified: trunk/ecore/src/lib/ecore/ecore_main.c
> ===
> --- trunk/ecore/src/lib/ecore/ecore_main.c2011-01-07 12:57:06 UTC (rev
> 55980)
> +++ trunk/ecore/src/lib/ecore/ecore_main.c2011-01-07 15:56:54 UTC (rev
> 55981)
> @@ -23,22 +23,17 @@
> #include
> #include
>
> -#ifdef HAVE_SYS_TIME_H
> +#ifndef _MSC_VER
> # include
> -#endif
> -
> -#ifdef HAVE_UNISTD_H
> # include
> -#endif
> -
> -#ifdef _MSC_VER
> +#else
> # include
> #endif
>
> #define FIX_HZ 1
>
> #ifdef FIX_HZ
> -# ifdef HAVE_SYS_PARAM_H
> +# ifndef _MSC_VER
> # include
> # endif
> # ifndef HZ
> @@ -50,6 +45,9 @@
> # include
> #endif
>
> +#include "Ecore.h"
> +#include "ecore_private.h"
> +
> #ifdef HAVE_SYS_EPOLL_H
> # define HAVE_EPOLL
> # include
> @@ -59,9 +57,6 @@
> # include
> #endif
>
> -#include "Ecore.h"
> -#include "ecore_private.h"
> -
> struct _Ecore_Fd_Handler
> {
>EINA_INLIST;
>
> Modified: trunk/ecore/src/lib/ecore_file/ecore_file.c
> ===
> --- trunk/ecore/src/lib/ecore_file/ecore_file.c 2011-01-07 12:57:06 UTC
> (rev 55980)
> +++ trunk/ecore/src/lib/ecore_file/ecore_file.c 2011-01-07 15:56:54 UTC
> (rev 55981)
> @@ -5,18 +5,14 @@
> #include
> #include
>
> -#ifdef HAVE_UNISTD_H
> +#ifndef _MSC_VER
> # include
> -#endif
> -
> -#ifdef HAVE_LIBGEN_H
> # include
> #endif
>
> #ifdef HAVE_FEATURES_H
> # include
> #endif
> -
> #include
> #include
>
>
> Modified: trunk/eet/configure.ac
> ===
> --- trunk/eet/configure.ac2011-01-07 12:57:06 UTC (rev 55980)
> +++ trunk/eet/configure.ac2011-01-07 15:56:54 UTC (rev 55981)
> @@ -352,7 +352,7 @@
>[dummy="yes"],
>[AC_MSG_ERROR("Cannot find jpeglib.h. Make sure your CFLAGS environment
> variable contains include lines for the location of this file")])
>
> -AC_CHECK_HEADERS([netinet/in.h unistd.h])
> +AC_CHECK_HEADERS(netinet/in.h)
> EFL_CHECK_PATH_MAX
>
> ### Checks for types
>
> Modified: trunk/eet/src/lib/eet_cipher.c
> ===
> --- trunk/eet/src/lib/eet_cipher.c2011-01-07 12:57:06 UTC (rev 55980)
> +++ trunk/eet/src/lib/eet_cipher.c2011-01-07 15:56:54 UTC (rev 55981)
> @@ -25,9 +25,9 @@
> #inc
Re: [E-devel] E SVN: raster IN trunk: ecore ecore/src/lib/ecore ecore/src/lib/ecore_file eet eet/src/lib eina eina/src/lib evas/src/lib/canvas evas/src/lib/file evas/src/lib/include
On Fri, 7 Jan 2011, Vincent Torri wrote:
>
>
> On Fri, 7 Jan 2011, Enlightenment SVN wrote:
>
>> Log:
>> hve to revert these commits. they hve created a whole chunk of 64bit
>> crashes on linux. this is REALLY bad. so remove these changes now.
>
> I have tested them on my 64 bits ubuntu.
>
> You can't seriously say that these commits can crash the EFL. It's just a
> matter of macro defined in config.h ! Look at the patches !
the only thing i can think of is:
* use of LARGEFILE for ecore_file
* i have inverted the order of glib/epoll includes in ecore_main.c
the other parts of the patch are just correct
>
> Vincent
>
>>
>>
>>
>> Author: raster
>> Date: 2011-01-07 07:56:54 -0800 (Fri, 07 Jan 2011)
>> New Revision: 55981
>> Trac: http://trac.enlightenment.org/e/changeset/55981
>>
>> Modified:
>> trunk/ecore/configure.ac trunk/ecore/src/lib/ecore/ecore.c
>> trunk/ecore/src/lib/ecore/ecore_app.c trunk/ecore/src/lib/ecore/ecore_main.c
>> trunk/ecore/src/lib/ecore_file/ecore_file.c trunk/eet/configure.ac
>> trunk/eet/src/lib/eet_cipher.c trunk/eet/src/lib/eet_lib.c
>> trunk/eina/configure.ac trunk/eina/src/lib/eina_hash.c
>> trunk/eina/src/lib/eina_log.c trunk/eina/src/lib/eina_module.c
>> trunk/evas/src/lib/canvas/evas_async_events.c
>> trunk/evas/src/lib/file/evas_path.c trunk/evas/src/lib/include/evas_common.h
>>
>> Modified: trunk/ecore/configure.ac
>> ===
>> --- trunk/ecore/configure.ac 2011-01-07 12:57:06 UTC (rev 55980)
>> +++ trunk/ecore/configure.ac 2011-01-07 15:56:54 UTC (rev 55981)
>> @@ -889,7 +889,7 @@
>> have_addrinfo="yes"
>> ;;
>>*)
>> - AC_CHECK_HEADERS([dlfcn.h features.h langinfo.h locale.h sys/time.h
>> sys/mman.h signal.h sys/resource.h sys/param.h unistd.h libgen])
>> + AC_CHECK_HEADERS([dlfcn.h features.h langinfo.h locale.h sys/time.h
>> sys/mman.h signal.h sys/resource.h])
>> ;;
>> esac
>>
>>
>> Modified: trunk/ecore/src/lib/ecore/ecore.c
>> ===
>> --- trunk/ecore/src/lib/ecore/ecore.c2011-01-07 12:57:06 UTC (rev
>> 55980)
>> +++ trunk/ecore/src/lib/ecore/ecore.c2011-01-07 15:56:54 UTC (rev
>> 55981)
>> @@ -8,7 +8,7 @@
>> #include
>> #include
>>
>> -#ifdef HAVE_UNISTD_H
>> +#ifndef _MSC_VER
>> # include
>> #endif
>>
>> @@ -27,7 +27,6 @@
>> #ifdef HAVE_EVIL
>> # include
>> #endif
>> -
>> #include
>>
>> #include "Ecore.h"
>>
>> Modified: trunk/ecore/src/lib/ecore/ecore_app.c
>> ===
>> --- trunk/ecore/src/lib/ecore/ecore_app.c2011-01-07 12:57:06 UTC (rev
>> 55980)
>> +++ trunk/ecore/src/lib/ecore/ecore_app.c2011-01-07 15:56:54 UTC (rev
>> 55981)
>> @@ -4,11 +4,9 @@
>>
>> #include
>>
>> -#ifdef HAVE_UNISTD_H
>> +#ifndef _MSC_VER
>> # include
>> -#endif
>> -
>> -#ifdef _MSC_VER
>> +#else
>> # include
>> #endif
>>
>>
>> Modified: trunk/ecore/src/lib/ecore/ecore_main.c
>> ===
>> --- trunk/ecore/src/lib/ecore/ecore_main.c 2011-01-07 12:57:06 UTC (rev
>> 55980)
>> +++ trunk/ecore/src/lib/ecore/ecore_main.c 2011-01-07 15:56:54 UTC (rev
>> 55981)
>> @@ -23,22 +23,17 @@
>> #include
>> #include
>>
>> -#ifdef HAVE_SYS_TIME_H
>> +#ifndef _MSC_VER
>> # include
>> -#endif
>> -
>> -#ifdef HAVE_UNISTD_H
>> # include
>> -#endif
>> -
>> -#ifdef _MSC_VER
>> +#else
>> # include
>> #endif
>>
>> #define FIX_HZ 1
>>
>> #ifdef FIX_HZ
>> -# ifdef HAVE_SYS_PARAM_H
>> +# ifndef _MSC_VER
>> # include
>> # endif
>> # ifndef HZ
>> @@ -50,6 +45,9 @@
>> # include
>> #endif
>>
>> +#include "Ecore.h"
>> +#include "ecore_private.h"
>> +
>> #ifdef HAVE_SYS_EPOLL_H
>> # define HAVE_EPOLL
>> # include
>> @@ -59,9 +57,6 @@
>> # include
>> #endif
>>
>> -#include "Ecore.h"
>> -#include "ecore_private.h"
>> -
>> struct _Ecore_Fd_Handler
>> {
>>EINA_INLIST;
>>
>> Modified: trunk/ecore/src/lib/ecore_file/ecore_file.c
>> ===
>> --- trunk/ecore/src/lib/ecore_file/ecore_file.c 2011-01-07 12:57:06 UTC
>> (rev 55980)
>> +++ trunk/ecore/src/lib/ecore_file/ecore_file.c 2011-01-07 15:56:54 UTC
>> (rev 55981)
>> @@ -5,18 +5,14 @@
>> #include
>> #include
>>
>> -#ifdef HAVE_UNISTD_H
>> +#ifndef _MSC_VER
>> # include
>> -#endif
>> -
>> -#ifdef HAVE_LIBGEN_H
>> # include
>> #endif
>>
>> #ifdef HAVE_FEATURES_H
>> # include
>> #endif
>> -
>> #include
>> #include
>>
>>
>> Modified: trunk/eet/configure.ac
>> ===
>> --- trunk/eet/configure.ac 2011-01-07 12:57:06 UTC (rev 55980)
>> +++ trunk/eet/configure.ac 2011-01-07 15:56:54 UTC (rev 55981)
>> @@ -352,7 +352,7 @@
>>[dummy="yes"],
>>[AC_MSG_ERROR("Cannot find jpeglib.h. Make sure your CFLAGS environment
>> variable contains include lines for the location of this
Re: [E-devel] E SVN: raster IN trunk: ecore ecore/src/lib/ecore ecore/src/lib/ecore_file eet eet/src/lib eina eina/src/lib evas/src/lib/canvas evas/src/lib/file evas/src/lib/include
On Fri, 7 Jan 2011 17:01:21 +0100 (CET) Vincent Torri
said:
>
>
> On Fri, 7 Jan 2011, Enlightenment SVN wrote:
>
> > Log:
> > hve to revert these commits. they hve created a whole chunk of 64bit
> > crashes on linux. this is REALLY bad. so remove these changes now.
>
> I have tested them on my 64 bits ubuntu.
>
> You can't seriously say that these commits can crash the EFL. It's just a
> matter of macro defined in config.h ! Look at the patches !
i can. they do. e17 literally ceased to begin - crash in ecore_file_dir_get()
revert and presto - works again. i suspect its one or more of the headers not
being detected and included and thus prototypes not being defined properly -
the only thing that would make sense, but i'm not kidding - it really does
cause e to crash instantly on start - it doesnt even get past some first few
inits. revert your changes and it works again - i reverted all the similar
changes too just for safety.
> Vincent
>
> >
> >
> >
> > Author: raster
> > Date: 2011-01-07 07:56:54 -0800 (Fri, 07 Jan 2011)
> > New Revision: 55981
> > Trac: http://trac.enlightenment.org/e/changeset/55981
> >
> > Modified:
> > trunk/ecore/configure.ac trunk/ecore/src/lib/ecore/ecore.c
> > trunk/ecore/src/lib/ecore/ecore_app.c
> > trunk/ecore/src/lib/ecore/ecore_main.c
> > trunk/ecore/src/lib/ecore_file/ecore_file.c trunk/eet/configure.ac
> > trunk/eet/src/lib/eet_cipher.c trunk/eet/src/lib/eet_lib.c
> > trunk/eina/configure.ac trunk/eina/src/lib/eina_hash.c
> > trunk/eina/src/lib/eina_log.c trunk/eina/src/lib/eina_module.c
> > trunk/evas/src/lib/canvas/evas_async_events.c
> > trunk/evas/src/lib/file/evas_path.c trunk/evas/src/lib/include/evas_common.h
> >
> > Modified: trunk/ecore/configure.ac
> > ===
> > --- trunk/ecore/configure.ac2011-01-07 12:57:06 UTC (rev 55980)
> > +++ trunk/ecore/configure.ac2011-01-07 15:56:54 UTC (rev 55981)
> > @@ -889,7 +889,7 @@
> > have_addrinfo="yes"
> > ;;
> >*)
> > - AC_CHECK_HEADERS([dlfcn.h features.h langinfo.h locale.h sys/time.h
> > sys/mman.h signal.h sys/resource.h sys/param.h unistd.h libgen])
> > + AC_CHECK_HEADERS([dlfcn.h features.h langinfo.h locale.h sys/time.h
> > sys/mman.h signal.h sys/resource.h]) ;;
> > esac
> >
> >
> > Modified: trunk/ecore/src/lib/ecore/ecore.c
> > ===
> > --- trunk/ecore/src/lib/ecore/ecore.c 2011-01-07 12:57:06 UTC (rev
> > 55980) +++ trunk/ecore/src/lib/ecore/ecore.c2011-01-07 15:56:54 UTC
> > (rev 55981) @@ -8,7 +8,7 @@
> > #include
> > #include
> >
> > -#ifdef HAVE_UNISTD_H
> > +#ifndef _MSC_VER
> > # include
> > #endif
> >
> > @@ -27,7 +27,6 @@
> > #ifdef HAVE_EVIL
> > # include
> > #endif
> > -
> > #include
> >
> > #include "Ecore.h"
> >
> > Modified: trunk/ecore/src/lib/ecore/ecore_app.c
> > ===
> > --- trunk/ecore/src/lib/ecore/ecore_app.c 2011-01-07 12:57:06 UTC
> > (rev 55980) +++ trunk/ecore/src/lib/ecore/ecore_app.c 2011-01-07
> > 15:56:54 UTC (rev 55981) @@ -4,11 +4,9 @@
> >
> > #include
> >
> > -#ifdef HAVE_UNISTD_H
> > +#ifndef _MSC_VER
> > # include
> > -#endif
> > -
> > -#ifdef _MSC_VER
> > +#else
> > # include
> > #endif
> >
> >
> > Modified: trunk/ecore/src/lib/ecore/ecore_main.c
> > ===
> > --- trunk/ecore/src/lib/ecore/ecore_main.c 2011-01-07 12:57:06 UTC
> > (rev 55980) +++ trunk/ecore/src/lib/ecore/ecore_main.c 2011-01-07
> > 15:56:54 UTC (rev 55981) @@ -23,22 +23,17 @@
> > #include
> > #include
> >
> > -#ifdef HAVE_SYS_TIME_H
> > +#ifndef _MSC_VER
> > # include
> > -#endif
> > -
> > -#ifdef HAVE_UNISTD_H
> > # include
> > -#endif
> > -
> > -#ifdef _MSC_VER
> > +#else
> > # include
> > #endif
> >
> > #define FIX_HZ 1
> >
> > #ifdef FIX_HZ
> > -# ifdef HAVE_SYS_PARAM_H
> > +# ifndef _MSC_VER
> > # include
> > # endif
> > # ifndef HZ
> > @@ -50,6 +45,9 @@
> > # include
> > #endif
> >
> > +#include "Ecore.h"
> > +#include "ecore_private.h"
> > +
> > #ifdef HAVE_SYS_EPOLL_H
> > # define HAVE_EPOLL
> > # include
> > @@ -59,9 +57,6 @@
> > # include
> > #endif
> >
> > -#include "Ecore.h"
> > -#include "ecore_private.h"
> > -
> > struct _Ecore_Fd_Handler
> > {
> >EINA_INLIST;
> >
> > Modified: trunk/ecore/src/lib/ecore_file/ecore_file.c
> > ===
> > --- trunk/ecore/src/lib/ecore_file/ecore_file.c 2011-01-07 12:57:06
> > UTC (rev 55980) +++ trunk/ecore/src/lib/ecore_file/ecore_file.c
> > 2011-01-07 15:56:54 UTC (rev 55981) @@ -5,18 +5,14 @@
> > #include
> > #include
> >
> > -#ifdef HAVE_UNISTD_H
> > +#ifndef _MSC_VER
> > # include
> > -#endif
> > -
> > -#ifdef HAVE_LIBGEN_H
> > # include
> > #endif
> >
> > #ifdef HAVE_FEATURES_H
> > # include
> > #endif
> > -
> > #include
> > #
Re: [E-devel] E SVN: raster IN trunk: ecore ecore/src/lib/ecore ecore/src/lib/ecore_file eet eet/src/lib eina eina/src/lib evas/src/lib/canvas evas/src/lib/file evas/src/lib/include
On 01/08/2011 12:09 AM, Carsten Haitzler (The Rasterman) wrote: > On Fri, 7 Jan 2011 17:01:21 +0100 (CET) Vincent Torri > said: > >> >> >> On Fri, 7 Jan 2011, Enlightenment SVN wrote: >> >>> Log: >>> hve to revert these commits. they hve created a whole chunk of 64bit >>> crashes on linux. this is REALLY bad. so remove these changes now. >> >> I have tested them on my 64 bits ubuntu. >> >> You can't seriously say that these commits can crash the EFL. It's just a >> matter of macro defined in config.h ! Look at the patches ! > > i can. they do. e17 literally ceased to begin - crash in ecore_file_dir_get() > revert and presto - works again. i suspect its one or more of the headers not > being detected and included and thus prototypes not being defined properly - > the only thing that would make sense, but i'm not kidding - it really does > cause e to crash instantly on start - it doesnt even get past some first few > inits. revert your changes and it works again - i reverted all the similar > changes too just for safety. If it helps, I can confirm. I was just one revision behind this commit by raster. And I couldn't restart e or login. On amd64, linux here too. Updating to this commit fixed e. -- Gaining the trust of online customers is vital for the success of any company that requires sensitive data to be transmitted over the Web. Learn how to best implement a security strategy that keeps consumers' information secure and instills the confidence they need to proceed with transactions. http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [Patch] elm_genlist doxygen fix and addition.
Hello, I fixed some typos of Genlist doxygen and added more explanations. Please review this and apply this to upstream. Thanks. Daniel Juyung Seo (SeoZ) Index: src/lib/elm_genlist.c === --- src/lib/elm_genlist.c (revision 55980) +++ src/lib/elm_genlist.c (working copy) @@ -9,11 +9,11 @@ /** * @defgroup Genlist Genlist * - * The Aim was to have more expansive list that the simple list in + * The aim was to have more expansive list than the simple list in * Elementary that could have more flexible items and allow many more entries * while still being fast and low on memory usage. At the same time it was * also made to be able to do tree structures. But the price to pay is more - * complexity when it comes to usage. If all you want is a simple list with + * complex when it comes to usage. If all you want is a simple list with * icons and a single label, use the normal List object. * * Signals that you can add callbacks for are: @@ -27,7 +27,7 @@ * unselected - This is called when a user has made an item unselected. The * event_info parameter is the genlist item that was unselected. * - * expanded - This is called when elm_genlist_item_expanded_set() is called + * expanded - This is called when elm_genlist_item_expanded_set() is called * and the item is now meant to be expanded. The event_info parameter is the * genlist item that was indicated to expand. It is the job of this callback * to then fill in the child items. @@ -35,7 +35,7 @@ * contracted - This is called when elm_genlist_item_expanded_set() is called * and the item is now meant to be contracted. The event_info parameter is * the genlist item that was indicated to contract. It is the job of this - * callback to then delete the child items + * callback to then delete the child items. * * expand,request - This is called when a user has indicated they want to * expand a tree branch item. The callback should decide if the item can @@ -56,7 +56,7 @@ * where it may point to freed objects. * * unrealized - This is called just before an item is unrealized. After - * this call icon objects provideed will be deleted and the item object + * this call icon objects provided will be deleted and the item object * itself delete or be put into a floating cache. * * drag,start,up - This is called when the item in the list has been dragged @@ -111,7 +111,7 @@ * * Genlist has a fairly large API, mostly because it's relatively complex, * trying to be both expansive, powerful and efficient. First we will begin - * an overview o the theory behind genlist. + * an overview on the theory behind genlist. * * Evas tracks every object you create. Every time it processes an event * (mouse move, down, up etc.) it needs to walk through objects and find out @@ -146,8 +146,9 @@ * more icons (which are simply objects swallowed into the genlist item) and * 0 or more boolean states that can be used for check, radio or other * indicators by the edje theme style. An item may be one of several styles - * (Elementary provides 2 by default - “default” and “double_label”, but this - * can be extended by system or application custom themes/overlays/extensions). + * (Elementary provides 4 by default - “default”, “double_label”, "group_index" + * and "icon_top_text_bottom", but this can be extended by system or + * application custom themes/overlays/extensions). * * In order to implement the ability to add and delete items on the fly, * Genlist implements a class/callback system where the application provides @@ -176,7 +177,7 @@ * of the icon part in the edje design that is listed as one of the possible * icons that can be set. This must return NULL for no object or a valid * object. The object will be deleted by genlist on shutdown or when the item - * its unrealized. + * is unrealized. * * func.state_get - This function is called when an actual item object is * created. The data parameter is the data parameter passed to @@ -198,14 +199,16 @@ * handle that is an internal member inside the genlist. They all take a data * parameter that is meant to be used for a handle to the applications * internal data (eg the struct with the original item data). The parent - * parameter is the parent genlist item this belongs to if it is a tree, and - * NULL if there is no parent. The flags can be a bitmask of - * ELM_GENLIST_ITEM_NONE and ELM_GENLIST_ITEM_SUBITEMS. If - * ELM_GENLIST_ITEM_SUBITEMS is set then this item is displayed as a item - * that is able to expand and have child items. The func parameter is a + * parameter is the parent genlist item this belongs to if it is a tree or + * an indexed group, and NULL if there is no parent. The flags can be a bitmask + * of ELM_GENLIST_ITEM_NONE, ELM_GENLIST_ITEM_SUBITEMS and + * ELM_GENLIST_ITEM_GROUP. If ELM_GENLIST_ITEM_SUBITEMS is set then this item + * is displayed as an item tha
Re: [E-devel] E SVN: discomfitor IN trunk: . DEBUG
Hey, maybe it's worth noting that gdb itself is capable of intercepting syscalls. Thus a gdb script that includes the used conditions could be sufficient. http://sourceware.org/gdb/onlinedocs/gdb/Set-Catchpoints.html BR, Leif Middelschulte 2011/1/7 Enlightenment SVN : > Log: > new directory for useful debugging scripts/code/etc > fd_catcher.c is a close() wrapper which can be used to detect certain fds > being closed when used with LD_PRELOAD > it was used to catch the epoll_fd bug (ticket #637), so I figured it would > probably be useful again to someone > > > Author: discomfitor > Date: 2011-01-07 10:51:42 -0800 (Fri, 07 Jan 2011) > New Revision: 55983 > Trac: http://trac.enlightenment.org/e/changeset/55983 > > Added: > trunk/DEBUG/ trunk/DEBUG/fd_catcher.c > > > -- > Gaining the trust of online customers is vital for the success of any company > that requires sensitive data to be transmitted over the Web. Learn how to > best implement a security strategy that keeps consumers' information secure > and instills the confidence they need to proceed with transactions. > http://p.sf.net/sfu/oracle-sfdevnl > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > -- Gaining the trust of online customers is vital for the success of any company that requires sensitive data to be transmitted over the Web. Learn how to best implement a security strategy that keeps consumers' information secure and instills the confidence they need to proceed with transactions. http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor IN trunk: . DEBUG
On Fri, 7 Jan 2011 21:53:39 +0100 Leif Middelschulte wrote: > Hey, > > maybe it's worth noting that gdb itself is capable of intercepting > syscalls. Thus a gdb script that includes the used conditions could be > sufficient. > > http://sourceware.org/gdb/onlinedocs/gdb/Set-Catchpoints.html > > BR, > > Leif Middelschulte > > > > 2011/1/7 Enlightenment SVN : > > Log: > > new directory for useful debugging scripts/code/etc > > fd_catcher.c is a close() wrapper which can be used to detect certain fds > > being closed when used with LD_PRELOAD it was used to catch the epoll_fd > > bug (ticket #637), so I figured it would probably be useful again to someone > > > > > > Author: discomfitor > > Date: 2011-01-07 10:51:42 -0800 (Fri, 07 Jan 2011) > > New Revision: 55983 > > Trac: http://trac.enlightenment.org/e/changeset/55983 > > > > Added: > > trunk/DEBUG/ trunk/DEBUG/fd_catcher.c > > > > if you can create a gdb script that can catch the close() of a specific fd from a variable in a stack frame I'd like to see it for other debugging uses I have :) -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! -- Gaining the trust of online customers is vital for the success of any company that requires sensitive data to be transmitted over the Web. Learn how to best implement a security strategy that keeps consumers' information secure and instills the confidence they need to proceed with transactions. http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor IN trunk: . DEBUG
2011/1/7 Mike Blumenkrantz : > On Fri, 7 Jan 2011 21:53:39 +0100 > Leif Middelschulte wrote: > >> Hey, >> >> maybe it's worth noting that gdb itself is capable of intercepting >> syscalls. Thus a gdb script that includes the used conditions could be >> sufficient. >> >> http://sourceware.org/gdb/onlinedocs/gdb/Set-Catchpoints.html >> >> BR, >> >> Leif Middelschulte >> >> >> >> 2011/1/7 Enlightenment SVN : >> > Log: >> > new directory for useful debugging scripts/code/etc >> > fd_catcher.c is a close() wrapper which can be used to detect certain fds >> > being closed when used with LD_PRELOAD it was used to catch the epoll_fd >> > bug (ticket #637), so I figured it would probably be useful again to >> > someone >> > >> > >> > Author: discomfitor >> > Date: 2011-01-07 10:51:42 -0800 (Fri, 07 Jan 2011) >> > New Revision: 55983 >> > Trac: http://trac.enlightenment.org/e/changeset/55983 >> > >> > Added: >> > trunk/DEBUG/ trunk/DEBUG/fd_catcher.c >> > >> > > if you can create a gdb script that can catch the close() of a specific fd > from > a variable in a stack frame I'd like to see it for other debugging uses I > have :) Afaik you can use variables from the stack within conditions you set as a trigger/guard for (enabling) the catch. BR, Leif > > -- > Mike Blumenkrantz > Zentific: NULL pointer dereferences now 50% off! > -- Gaining the trust of online customers is vital for the success of any company that requires sensitive data to be transmitted over the Web. Learn how to best implement a security strategy that keeps consumers' information secure and instills the confidence they need to proceed with transactions. http://p.sf.net/sfu/oracle-sfdevnl ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
