Re: [E-devel] E SVN: discomfitor IN trunk/edje: . src/bin src/bin/epp
Vtorri, Isn't edje_cc needed for things like changing the background in e? IIRC edje_cc is widely used on all devices just because of this. -- Tom. On Wed, 2011-02-23 at 07:34 +0100, Vincent Torri wrote: > > On Wed, 23 Feb 2011, unixti...@gmail.com wrote: > > > Why revert the Windows CE stuff? What if someone is using Windows CE? > > Should be fine to leave as a just in case. > > because no one, absolutely no one, will use edje_cc ON a Windows CE > embedded devices to create a theme (Will people use edje_cc on openmoko > or any other embedded devices to create theme ? One doesn't developper on > embedded devices). > > Vincent > > Sent from my Cellular South HTC Desire > > - Reply message - > From: "Vincent Torri" > Date: Tue, Feb 22, 2011 11:56 pm > Subject: [E-devel] E SVN: discomfitor IN trunk/edje: . src/bin src/bin/epp > To: > > > > On Tue, 22 Feb 2011, Enlightenment SVN wrote: > > > Log: > > edje: change epp installdir > > > > > > Author: discomfitor > > Date: 2011-02-22 18:51:32 -0800 (Tue, 22 Feb 2011) > > New Revision: 57252 > > Trac: http://trac.enlightenment.org/e/changeset/57252 > > > > Modified: > > trunk/edje/configure.ac trunk/edje/src/bin/edje_cc_parse.c.in > > trunk/edje/src/bin/epp/Makefile.am > > > > Modified: trunk/edje/configure.ac > > === > > --- trunk/edje/configure.ac 2011-02-23 00:45:53 UTC (rev 57251) > > +++ trunk/edje/configure.ac 2011-02-23 02:51:32 UTC (rev 57252) > > @@ -294,12 +294,9 @@ > >PKG_CHECK_MODULES([EDJE_CC], [ecore-file >= 1.0.0 ecore-evas >= 1.0.0 > > ecore >= 1.0.0 evas >= 1.0.0 eet >= 1.0.0 eina >= 1.0.0]) > >EDJE_CC_LIBS="${EDJE_CC_LIBS} ${LUA_LIBS} ${lua_libs}" > > fi > > -AC_PATH_PROG([EPP], [epp]) > > -AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes" -a -z "$EPP"]) > > -if test -z "$EPP" ; then > > - EPP=${prefix}/bin/epp > > - AC_SUBST(EPP) > > -fi > > +AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes"]) > > +EPPDIR=${prefix}/lib/edje/utils > > do not do that. The value of prefix is not known at configure time. In > addition, do not use $prefix/lib/edje in configure.ac but $libdir/$PACKAGE > in Makefile.am with a macro. Use that macro in edje_cc_parse (so no need > to have a edje_cc_parse.c.in > > and don't forget to revert your changes about Windows CE > > > +AC_SUBST(EPPDIR) > > > > if test "x$have_edje_decc" = "xyes"; then > >PKG_CHECK_MODULES([EDJE_DECC], [ecore-file >= 1.0.0 ecore-evas >= 1.0.0 > > ecore >= 1.0.0 evas >= 1.0.0 eet >= 1.0.0 eina >= 1.0.0]) > > > > Modified: trunk/edje/src/bin/edje_cc_parse.c.in > > === > > --- trunk/edje/src/bin/edje_cc_parse.c.in 2011-02-23 00:45:53 UTC (rev > > 57251) > > +++ trunk/edje/src/bin/edje_cc_parse.c.in 2011-02-23 02:51:32 UTC (rev > > 57252) > > @@ -693,9 +693,9 @@ > > * Run the input through the C pre-processor. > > */ > > ret = -1; > > - if (ecore_file_exists("@EPP@")) > > + if (ecore_file_exists("@EPPDIR@/epp")) > > { > > -snprintf(buf, sizeof(buf), "@EPP@ -I%s %s -P -o %s - < %s", > > +snprintf(buf, sizeof(buf), "@EPPDIR@/epp -I%s %s -P -o %s - < %s", > > inc, def, tmpn, file_in); > > ret = system(buf); > > } > > > > Modified: trunk/edje/src/bin/epp/Makefile.am > > === > > --- trunk/edje/src/bin/epp/Makefile.am 2011-02-23 00:45:53 UTC (rev > > 57251) > > +++ trunk/edje/src/bin/epp/Makefile.am 2011-02-23 02:51:32 UTC (rev > > 57252) > > @@ -18,7 +18,8 @@ > > #the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. > > > > MAINTAINERCLEANFILES = Makefile.in > > -bin_PROGRAMS = epp > > +eppdir = @EPPDIR@ > > +epp_PROGRAMS = epp > > > > epp_SOURCES = \ > > cpplib.h \ > > > > > > -- > > Free Software Download: Index, Search & Analyze Logs and other IT data in > > Real-Time with Splunk. Collect, index and harness all the fast moving IT > > data > > generated by your applications, servers and devices whether physical, > > virtual > > or in the cloud. Deliver compliance at lower cost and gain new business > > insights. http://p.sf.net/sfu/splunk-dev2dev > > ___ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > > > -- > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business
Re: [E-devel] E SVN: discomfitor IN trunk/edje: . src/bin src/bin/epp
On Wed, 23 Feb 2011, Mike Blumenkrantz wrote: > On Wed, 23 Feb 2011 06:56:21 +0100 (CET) > Vincent Torri wrote: > >> >> >> On Tue, 22 Feb 2011, Enlightenment SVN wrote: >> >>> Log: >>> edje: change epp installdir >>> >>> >>> Author: discomfitor >>> Date: 2011-02-22 18:51:32 -0800 (Tue, 22 Feb 2011) >>> New Revision: 57252 >>> Trac: http://trac.enlightenment.org/e/changeset/57252 >>> >>> Modified: >>> trunk/edje/configure.ac trunk/edje/src/bin/edje_cc_parse.c.in >>> trunk/edje/src/bin/epp/Makefile.am >>> >>> Modified: trunk/edje/configure.ac >>> === >>> --- trunk/edje/configure.ac 2011-02-23 00:45:53 UTC (rev 57251) >>> +++ trunk/edje/configure.ac 2011-02-23 02:51:32 UTC (rev 57252) >>> @@ -294,12 +294,9 @@ >>>PKG_CHECK_MODULES([EDJE_CC], [ecore-file >= 1.0.0 ecore-evas >= 1.0.0 >>> ecore >= 1.0.0 evas >= 1.0.0 eet >= 1.0.0 eina >= 1.0.0]) >>> EDJE_CC_LIBS="${EDJE_CC_LIBS} ${LUA_LIBS} ${lua_libs}" fi >>> -AC_PATH_PROG([EPP], [epp]) >>> -AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes" -a -z "$EPP"]) >>> -if test -z "$EPP" ; then >>> - EPP=${prefix}/bin/epp >>> - AC_SUBST(EPP) >>> -fi >>> +AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes"]) >>> +EPPDIR=${prefix}/lib/edje/utils >> >> do not do that. The value of prefix is not known at configure time. In >> addition, do not use $prefix/lib/edje in configure.ac but $libdir/$PACKAGE >> in Makefile.am with a macro. Use that macro in edje_cc_parse (so no need >> to have a edje_cc_parse.c.in > no clue what you mean about a macro, but it sounds like a good idea so I'll > let > you do that while I finish preparing for cebit > >> and don't forget to revert your changes about Windows CE > I didn't make any changes for windows of any kind ? edje_cc compiled for mingw32ce, that is Windows CE... -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor IN trunk/edje: . src/bin src/bin/epp
On Wed, 23 Feb 2011, unixti...@gmail.com wrote: > Why revert the Windows CE stuff? What if someone is using Windows CE? Should > be fine to leave as a just in case. because no one, absolutely no one, will use edje_cc ON a Windows CE embedded devices to create a theme (Will people use edje_cc on openmoko or any other embedded devices to create theme ? One doesn't developper on embedded devices). Vincent Sent from my Cellular South HTC Desire - Reply message - From: "Vincent Torri" Date: Tue, Feb 22, 2011 11:56 pm Subject: [E-devel] E SVN: discomfitor IN trunk/edje: . src/bin src/bin/epp To: On Tue, 22 Feb 2011, Enlightenment SVN wrote: > Log: > edje: change epp installdir > > > Author: discomfitor > Date: 2011-02-22 18:51:32 -0800 (Tue, 22 Feb 2011) > New Revision: 57252 > Trac: http://trac.enlightenment.org/e/changeset/57252 > > Modified: > trunk/edje/configure.ac trunk/edje/src/bin/edje_cc_parse.c.in > trunk/edje/src/bin/epp/Makefile.am > > Modified: trunk/edje/configure.ac > === > --- trunk/edje/configure.ac 2011-02-23 00:45:53 UTC (rev 57251) > +++ trunk/edje/configure.ac 2011-02-23 02:51:32 UTC (rev 57252) > @@ -294,12 +294,9 @@ >PKG_CHECK_MODULES([EDJE_CC], [ecore-file >= 1.0.0 ecore-evas >= 1.0.0 > ecore >= 1.0.0 evas >= 1.0.0 eet >= 1.0.0 eina >= 1.0.0]) >EDJE_CC_LIBS="${EDJE_CC_LIBS} ${LUA_LIBS} ${lua_libs}" > fi > -AC_PATH_PROG([EPP], [epp]) > -AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes" -a -z "$EPP"]) > -if test -z "$EPP" ; then > - EPP=${prefix}/bin/epp > - AC_SUBST(EPP) > -fi > +AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes"]) > +EPPDIR=${prefix}/lib/edje/utils do not do that. The value of prefix is not known at configure time. In addition, do not use $prefix/lib/edje in configure.ac but $libdir/$PACKAGE in Makefile.am with a macro. Use that macro in edje_cc_parse (so no need to have a edje_cc_parse.c.in and don't forget to revert your changes about Windows CE > +AC_SUBST(EPPDIR) > > if test "x$have_edje_decc" = "xyes"; then >PKG_CHECK_MODULES([EDJE_DECC], [ecore-file >= 1.0.0 ecore-evas >= 1.0.0 > ecore >= 1.0.0 evas >= 1.0.0 eet >= 1.0.0 eina >= 1.0.0]) > > Modified: trunk/edje/src/bin/edje_cc_parse.c.in > === > --- trunk/edje/src/bin/edje_cc_parse.c.in 2011-02-23 00:45:53 UTC (rev > 57251) > +++ trunk/edje/src/bin/edje_cc_parse.c.in 2011-02-23 02:51:32 UTC (rev > 57252) > @@ -693,9 +693,9 @@ >* Run the input through the C pre-processor. >*/ > ret = -1; > - if (ecore_file_exists("@EPP@")) > + if (ecore_file_exists("@EPPDIR@/epp")) > { > -snprintf(buf, sizeof(buf), "@EPP@ -I%s %s -P -o %s - < %s", > +snprintf(buf, sizeof(buf), "@EPPDIR@/epp -I%s %s -P -o %s - < %s", > inc, def, tmpn, file_in); > ret = system(buf); > } > > Modified: trunk/edje/src/bin/epp/Makefile.am > === > --- trunk/edje/src/bin/epp/Makefile.am2011-02-23 00:45:53 UTC (rev > 57251) > +++ trunk/edje/src/bin/epp/Makefile.am2011-02-23 02:51:32 UTC (rev > 57252) > @@ -18,7 +18,8 @@ > #the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. > > MAINTAINERCLEANFILES = Makefile.in > -bin_PROGRAMS = epp > +eppdir = @EPPDIR@ > +epp_PROGRAMS = epp > > epp_SOURCES = \ > cpplib.h \ > > > -- > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the
Re: [E-devel] E SVN: discomfitor IN trunk/edje: . src/bin src/bin/epp
On Wed, 23 Feb 2011 06:56:21 +0100 (CET) Vincent Torri wrote: > > > On Tue, 22 Feb 2011, Enlightenment SVN wrote: > > > Log: > > edje: change epp installdir > > > > > > Author: discomfitor > > Date: 2011-02-22 18:51:32 -0800 (Tue, 22 Feb 2011) > > New Revision: 57252 > > Trac: http://trac.enlightenment.org/e/changeset/57252 > > > > Modified: > > trunk/edje/configure.ac trunk/edje/src/bin/edje_cc_parse.c.in > > trunk/edje/src/bin/epp/Makefile.am > > > > Modified: trunk/edje/configure.ac > > === > > --- trunk/edje/configure.ac 2011-02-23 00:45:53 UTC (rev 57251) > > +++ trunk/edje/configure.ac 2011-02-23 02:51:32 UTC (rev 57252) > > @@ -294,12 +294,9 @@ > >PKG_CHECK_MODULES([EDJE_CC], [ecore-file >= 1.0.0 ecore-evas >= 1.0.0 > > ecore >= 1.0.0 evas >= 1.0.0 eet >= 1.0.0 eina >= 1.0.0]) > > EDJE_CC_LIBS="${EDJE_CC_LIBS} ${LUA_LIBS} ${lua_libs}" fi > > -AC_PATH_PROG([EPP], [epp]) > > -AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes" -a -z "$EPP"]) > > -if test -z "$EPP" ; then > > - EPP=${prefix}/bin/epp > > - AC_SUBST(EPP) > > -fi > > +AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes"]) > > +EPPDIR=${prefix}/lib/edje/utils > > do not do that. The value of prefix is not known at configure time. In > addition, do not use $prefix/lib/edje in configure.ac but $libdir/$PACKAGE > in Makefile.am with a macro. Use that macro in edje_cc_parse (so no need > to have a edje_cc_parse.c.in no clue what you mean about a macro, but it sounds like a good idea so I'll let you do that while I finish preparing for cebit > and don't forget to revert your changes about Windows CE I didn't make any changes for windows of any kind ? -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor IN trunk/edje: . src/bin src/bin/epp
Why revert the Windows CE stuff? What if someone is using Windows CE? Should be fine to leave as a just in case. Sent from my Cellular South HTC Desire - Reply message - From: "Vincent Torri" Date: Tue, Feb 22, 2011 11:56 pm Subject: [E-devel] E SVN: discomfitor IN trunk/edje: . src/bin src/bin/epp To: On Tue, 22 Feb 2011, Enlightenment SVN wrote: > Log: > edje: change epp installdir > > > Author: discomfitor > Date: 2011-02-22 18:51:32 -0800 (Tue, 22 Feb 2011) > New Revision: 57252 > Trac: http://trac.enlightenment.org/e/changeset/57252 > > Modified: > trunk/edje/configure.ac trunk/edje/src/bin/edje_cc_parse.c.in > trunk/edje/src/bin/epp/Makefile.am > > Modified: trunk/edje/configure.ac > === > --- trunk/edje/configure.ac 2011-02-23 00:45:53 UTC (rev 57251) > +++ trunk/edje/configure.ac 2011-02-23 02:51:32 UTC (rev 57252) > @@ -294,12 +294,9 @@ >PKG_CHECK_MODULES([EDJE_CC], [ecore-file >= 1.0.0 ecore-evas >= 1.0.0 > ecore >= 1.0.0 evas >= 1.0.0 eet >= 1.0.0 eina >= 1.0.0]) >EDJE_CC_LIBS="${EDJE_CC_LIBS} ${LUA_LIBS} ${lua_libs}" > fi > -AC_PATH_PROG([EPP], [epp]) > -AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes" -a -z "$EPP"]) > -if test -z "$EPP" ; then > - EPP=${prefix}/bin/epp > - AC_SUBST(EPP) > -fi > +AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes"]) > +EPPDIR=${prefix}/lib/edje/utils do not do that. The value of prefix is not known at configure time. In addition, do not use $prefix/lib/edje in configure.ac but $libdir/$PACKAGE in Makefile.am with a macro. Use that macro in edje_cc_parse (so no need to have a edje_cc_parse.c.in and don't forget to revert your changes about Windows CE > +AC_SUBST(EPPDIR) > > if test "x$have_edje_decc" = "xyes"; then >PKG_CHECK_MODULES([EDJE_DECC], [ecore-file >= 1.0.0 ecore-evas >= 1.0.0 > ecore >= 1.0.0 evas >= 1.0.0 eet >= 1.0.0 eina >= 1.0.0]) > > Modified: trunk/edje/src/bin/edje_cc_parse.c.in > === > --- trunk/edje/src/bin/edje_cc_parse.c.in 2011-02-23 00:45:53 UTC (rev > 57251) > +++ trunk/edje/src/bin/edje_cc_parse.c.in 2011-02-23 02:51:32 UTC (rev > 57252) > @@ -693,9 +693,9 @@ >* Run the input through the C pre-processor. >*/ > ret = -1; > - if (ecore_file_exists("@EPP@")) > + if (ecore_file_exists("@EPPDIR@/epp")) > { > -snprintf(buf, sizeof(buf), "@EPP@ -I%s %s -P -o %s - < %s", > +snprintf(buf, sizeof(buf), "@EPPDIR@/epp -I%s %s -P -o %s - < %s", > inc, def, tmpn, file_in); > ret = system(buf); > } > > Modified: trunk/edje/src/bin/epp/Makefile.am > === > --- trunk/edje/src/bin/epp/Makefile.am2011-02-23 00:45:53 UTC (rev > 57251) > +++ trunk/edje/src/bin/epp/Makefile.am2011-02-23 02:51:32 UTC (rev > 57252) > @@ -18,7 +18,8 @@ > #the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. > > MAINTAINERCLEANFILES = Makefile.in > -bin_PROGRAMS = epp > +eppdir = @EPPDIR@ > +epp_PROGRAMS = epp > > epp_SOURCES = \ > cpplib.h \ > > > -- > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list en
Re: [E-devel] Elfe : Enlightenment Launcher for Embedded
Wow cool!!! How's the performance? Did you test that on devices? I'd love to see that. I'll be good to be shown in CeBIT 2011. Thanks. Daniel Juyung Seo (SeoZ) On Wed, Feb 23, 2011 at 6:59 AM, Jeff Hoogland wrote: > Wow how stable is this? If it doesn't get added to SVN can I get source code > so I can include this module into Bodhi Linux? > > ~Jeff Hoogland > > - Original message - >> Hi, >> >> Let me introduce Elfe. A new project on which i'm currently working. >> Elfe is the acronym for Enlightenment Launcher For Embedded (world, >> devices, whatever). It can be used as a replacement of the current >> illume-home module. >> It's a E module itself, and uses Elementary for containers and widgets. >> >> Currently it's a just a simple launcher. You can add Applications and >> E modules on several "virtual desktops". >> >> If you agree, i will be glad to add it in the E-EXTRA-MODULES >> directory of the SVN. >> >> you can find a presentation of Elfe on this video : >> http://www.youtube.com/watch?v=mKlDgl-Tquw >> >> Regards, >> Nico >> >> -- >> Nicolas Aguirre >> Mail: aguirre.nico...@gmail.com >> Web: http://enna.geexbox.org >> Blog: http://dev.enlightenment.fr/~captainigloo/ >> >> -- >> Free Software Download: Index, Search & Analyze Logs and other IT data >> in Real-Time with Splunk. Collect, index and harness all the fast >> moving IT data generated by your applications, servers and devices >> whether physical, virtual or in the cloud. Deliver compliance at lower >> cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor IN trunk/edje: . src/bin src/bin/epp
On Tue, 22 Feb 2011, Enlightenment SVN wrote: > Log: > edje: change epp installdir > > > Author: discomfitor > Date: 2011-02-22 18:51:32 -0800 (Tue, 22 Feb 2011) > New Revision: 57252 > Trac: http://trac.enlightenment.org/e/changeset/57252 > > Modified: > trunk/edje/configure.ac trunk/edje/src/bin/edje_cc_parse.c.in > trunk/edje/src/bin/epp/Makefile.am > > Modified: trunk/edje/configure.ac > === > --- trunk/edje/configure.ac 2011-02-23 00:45:53 UTC (rev 57251) > +++ trunk/edje/configure.ac 2011-02-23 02:51:32 UTC (rev 57252) > @@ -294,12 +294,9 @@ >PKG_CHECK_MODULES([EDJE_CC], [ecore-file >= 1.0.0 ecore-evas >= 1.0.0 > ecore >= 1.0.0 evas >= 1.0.0 eet >= 1.0.0 eina >= 1.0.0]) >EDJE_CC_LIBS="${EDJE_CC_LIBS} ${LUA_LIBS} ${lua_libs}" > fi > -AC_PATH_PROG([EPP], [epp]) > -AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes" -a -z "$EPP"]) > -if test -z "$EPP" ; then > - EPP=${prefix}/bin/epp > - AC_SUBST(EPP) > -fi > +AM_CONDITIONAL([BUILD_EPP], [test "x$have_edje_cc" = "xyes"]) > +EPPDIR=${prefix}/lib/edje/utils do not do that. The value of prefix is not known at configure time. In addition, do not use $prefix/lib/edje in configure.ac but $libdir/$PACKAGE in Makefile.am with a macro. Use that macro in edje_cc_parse (so no need to have a edje_cc_parse.c.in and don't forget to revert your changes about Windows CE > +AC_SUBST(EPPDIR) > > if test "x$have_edje_decc" = "xyes"; then >PKG_CHECK_MODULES([EDJE_DECC], [ecore-file >= 1.0.0 ecore-evas >= 1.0.0 > ecore >= 1.0.0 evas >= 1.0.0 eet >= 1.0.0 eina >= 1.0.0]) > > Modified: trunk/edje/src/bin/edje_cc_parse.c.in > === > --- trunk/edje/src/bin/edje_cc_parse.c.in 2011-02-23 00:45:53 UTC (rev > 57251) > +++ trunk/edje/src/bin/edje_cc_parse.c.in 2011-02-23 02:51:32 UTC (rev > 57252) > @@ -693,9 +693,9 @@ >* Run the input through the C pre-processor. >*/ > ret = -1; > - if (ecore_file_exists("@EPP@")) > + if (ecore_file_exists("@EPPDIR@/epp")) > { > -snprintf(buf, sizeof(buf), "@EPP@ -I%s %s -P -o %s - < %s", > +snprintf(buf, sizeof(buf), "@EPPDIR@/epp -I%s %s -P -o %s - < %s", > inc, def, tmpn, file_in); > ret = system(buf); > } > > Modified: trunk/edje/src/bin/epp/Makefile.am > === > --- trunk/edje/src/bin/epp/Makefile.am2011-02-23 00:45:53 UTC (rev > 57251) > +++ trunk/edje/src/bin/epp/Makefile.am2011-02-23 02:51:32 UTC (rev > 57252) > @@ -18,7 +18,8 @@ > #the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. > > MAINTAINERCLEANFILES = Makefile.in > -bin_PROGRAMS = epp > +eppdir = @EPPDIR@ > +epp_PROGRAMS = epp > > epp_SOURCES = \ > cpplib.h \ > > > -- > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] Add ecore_imf_context_preedit_string_with_attributes_get API
Hello, This is patch for adding ecore_imf_context_preedit_string_with_attributes_get API. In ecore_imf, there is ecore_imf_context_preedit_string_get API, but the attribute info from input method engine cannot be got from it. After discussing rater, we decided to add new API. Attribute infomation can be got as Eina_List type containing Ecore_IMF_Preedit_Attr structure items. In this patch, ECORE_IMF_PREEDIT_TYPE_SUB1,2,3 means the depth of preedit style. Would you please review it? Index: AUTHORS === --- AUTHORS (revision 57251) +++ AUTHORS (working copy) @@ -37,3 +37,4 @@ Mike Blumenkrantz Leif Middelschulte Mike McCormack Sangho Park +Jihoon Kim Index: src/lib/ecore_imf/ecore_imf_context.c === --- src/lib/ecore_imf/ecore_imf_context.c (revision 57251) +++ src/lib/ecore_imf/ecore_imf_context.c (working copy) @@ -381,6 +381,38 @@ ecore_imf_context_preedit_string_get(Ecore_IMF_Con } /** + * Retrieve the current preedit string, atrributes and + * cursor position for the Input Method Context. + * + * @param ctx An #Ecore_IMF_Context. + * @param str Location to store the retrieved string. The + *string retrieved must be freed with free(). + * @param attrs an Eina_List of attributes + * @param cursor_pos Location to store position of cursor (in characters) + * within the preedit string. + * @ingroup Ecore_IMF_Context_Group + * @since 1.1.0 + */ +EAPI void +ecore_imf_context_preedit_string_with_attributes_get(Ecore_IMF_Context *ctx, char **str, Eina_List **attrs, int *cursor_pos) +{ + if (!ECORE_MAGIC_CHECK(ctx, ECORE_MAGIC_CONTEXT)) + { +ECORE_MAGIC_FAIL(ctx, ECORE_MAGIC_CONTEXT, + "ecore_imf_context_preedit_string_with_attributes_get"); +return; + } + if (ctx->klass->preedit_string_with_attributes_get) + ctx->klass->preedit_string_with_attributes_get(ctx, str, attrs, cursor_pos); + else + { +if (str) *str = strdup(""); +if (attrs) *attrs = NULL; +if (cursor_pos) *cursor_pos = 0; + } +} + +/** * Notify the Input Method Context that the widget to which its * correspond has gained focus. * Index: src/lib/ecore_imf/Ecore_IMF.h === --- src/lib/ecore_imf/Ecore_IMF.h (revision 57251) +++ src/lib/ecore_imf/Ecore_IMF.h (working copy) @@ -55,6 +55,9 @@ typedef struct _Ecore_IMF_Context typedef struct _Ecore_IMF_Context_ClassEcore_IMF_Context_Class; /**< An Input Method Context class */ typedef struct _Ecore_IMF_Context_Info Ecore_IMF_Context_Info; /**< An Input Method Context info */ +/* Preedit attribute info */ +typedef struct _Ecore_IMF_Preedit_Attr Ecore_IMF_Preedit_Attr; + EAPI extern int ECORE_IMF_EVENT_PREEDIT_START; EAPI extern int ECORE_IMF_EVENT_PREEDIT_END; EAPI extern int ECORE_IMF_EVENT_PREEDIT_CHANGED; @@ -109,6 +112,14 @@ typedef enum ECORE_IMF_INPUT_MODE_AUTOCAP = 1 << 30 } Ecore_IMF_Input_Mode; +typedef enum +{ + ECORE_IMF_PREEDIT_TYPE_NONE, + ECORE_IMF_PREEDIT_TYPE_SUB1, + ECORE_IMF_PREEDIT_TYPE_SUB2, + ECORE_IMF_PREEDIT_TYPE_SUB3 +} Ecore_IMF_Preedit_Type; + struct _Ecore_IMF_Event_Preedit_Start { Ecore_IMF_Context *ctx; @@ -260,6 +271,13 @@ union _Ecore_IMF_Event Ecore_IMF_Event_Key_Up key_up; }; +struct _Ecore_IMF_Preedit_Attr +{ + Ecore_IMF_Preedit_Type preedit_type; + unsigned int start_index; + unsigned int end_index; +}; + struct _Ecore_IMF_Context_Class { void (*add) (Ecore_IMF_Context *ctx); @@ -276,6 +294,7 @@ struct _Ecore_IMF_Context_Class void (*use_preedit_set) (Ecore_IMF_Context *ctx, Eina_Bool use_preedit); void (*input_mode_set) (Ecore_IMF_Context *ctx, Ecore_IMF_Input_Mode input_mode); Eina_Bool (*filter_event) (Ecore_IMF_Context *ctx, Ecore_IMF_Event_Type type, Ecore_IMF_Event *event); + void (*preedit_string_with_attributes_get) (Ecore_IMF_Context *ctx, char **str, Eina_List **attrs, int *cursor_pos); }; struct _Ecore_IMF_Context_Info @@ -308,6 +327,7 @@ EAPI void *ecore_imf_conte EAPI void ecore_imf_context_show(Ecore_IMF_Context *ctx); EAPI void ecore_imf_context_hide(Ecore_IMF_Context *ctx); EAPI void ecore_imf_context_preedit_string_get(Ecore_IMF_Context *ctx, char **str, int *cursor_pos); +EAPI void ecore_imf_context_preedit_string_with_attributes_get(Ecore_IMF_Context *ctx, char **str, Eina_List **attrs, int *cursor_pos); EAPI void ecore_imf_context_focus_in(Ecore_IMF_Context *ctx); EAPI void ecore_imf_context_focus_out(Ecore_IMF_Context *ctx); EAPI void
Re: [E-devel] Elfe : Enlightenment Launcher for Embedded
Wow how stable is this? If it doesn't get added to SVN can I get source code so I can include this module into Bodhi Linux? ~Jeff Hoogland - Original message - > Hi, > > Let me introduce Elfe. A new project on which i'm currently working. > Elfe is the acronym for Enlightenment Launcher For Embedded (world, > devices, whatever). It can be used as a replacement of the current > illume-home module. > It's a E module itself, and uses Elementary for containers and widgets. > > Currently it's a just a simple launcher. You can add Applications and > E modules on several "virtual desktops". > > If you agree, i will be glad to add it in the E-EXTRA-MODULES > directory of the SVN. > > you can find a presentation of Elfe on this video : > http://www.youtube.com/watch?v=mKlDgl-Tquw > > Regards, > Nico > > -- > Nicolas Aguirre > Mail: aguirre.nico...@gmail.com > Web: http://enna.geexbox.org > Blog: http://dev.enlightenment.fr/~captainigloo/ > > -- > Free Software Download: Index, Search & Analyze Logs and other IT data > in Real-Time with Splunk. Collect, index and harness all the fast > moving IT data generated by your applications, servers and devices > whether physical, virtual or in the cloud. Deliver compliance at lower > cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Elfe : Enlightenment Launcher for Embedded
Amazing, gj. On Tue, Feb 22, 2011 at 11:29 PM, Nicolas Aguirre wrote: > Hi, > > Let me introduce Elfe. A new project on which i'm currently working. > Elfe is the acronym for Enlightenment Launcher For Embedded (world, > devices, whatever). It can be used as a replacement of the current > illume-home module. > It's a E module itself, and uses Elementary for containers and widgets. > > Currently it's a just a simple launcher. You can add Applications and > E modules on several "virtual desktops". > > If you agree, i will be glad to add it in the E-EXTRA-MODULES > directory of the SVN. > > you can find a presentation of Elfe on this video : > http://www.youtube.com/watch?v=mKlDgl-Tquw > > Regards, > Nico > > -- > Nicolas Aguirre > Mail: aguirre.nico...@gmail.com > Web: http://enna.geexbox.org > Blog: http://dev.enlightenment.fr/~captainigloo/ > > > -- > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT > data > generated by your applications, servers and devices whether physical, > virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Tom. -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Elfe : Enlightenment Launcher for Embedded
Hi, Let me introduce Elfe. A new project on which i'm currently working. Elfe is the acronym for Enlightenment Launcher For Embedded (world, devices, whatever). It can be used as a replacement of the current illume-home module. It's a E module itself, and uses Elementary for containers and widgets. Currently it's a just a simple launcher. You can add Applications and E modules on several "virtual desktops". If you agree, i will be glad to add it in the E-EXTRA-MODULES directory of the SVN. you can find a presentation of Elfe on this video : http://www.youtube.com/watch?v=mKlDgl-Tquw Regards, Nico -- Nicolas Aguirre Mail: aguirre.nico...@gmail.com Web: http://enna.geexbox.org Blog: http://dev.enlightenment.fr/~captainigloo/ -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: englebass trunk/efreet/src/bin
On 02/22/2011 08:45 PM, Sebastian Dransfeld wrote: > On 02/22/2011 04:22 PM, Atton Jonathan wrote: >> If the problem is in e why you don't fix e instead of revert a fix in efreet >> ? > > E always wants to wait for desktop cache to be updated. So we always > need to wait there. What we need to do is to differentiate between > "cache build done and change", and "cache build done and no change". > Needs a bit more work. > > So it is better to let things work as it is now, instead of breaking E. > > S. What a crappy reply. E hasn't a problem, it works as it should. Efreet needs a better fix. S. > >> >> >> 2011/2/22 Enlightenment SVN >> >>> Log: >>> Efreet: Reset changed before scanning fallback >>> >>>Changed must be EINA_FALSE before scanning fallback to not create false >>>positive. >>> >>> Author: englebass >>> Date: 2011-02-22 04:52:58 -0800 (Tue, 22 Feb 2011) >>> New Revision: 57240 >>> Trac: http://trac.enlightenment.org/e/changeset/57240 >>> >>> Modified: >>>trunk/efreet/src/bin/efreet_icon_cache_create.c >>> >>> Modified: trunk/efreet/src/bin/efreet_icon_cache_create.c >>> === >>> --- trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:46 >>> UTC (rev 57239) >>> +++ trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:58 >>> UTC (rev 57240) >>> @@ -897,6 +897,8 @@ >>> } >>> eina_iterator_free(it); >>> >>> +changed = EINA_FALSE; >>> + >>> /* open icon file */ >>> icon_ef = eet_open(efreet_icon_cache_file(EFREET_CACHE_ICON_FALLBACK), >>> EET_FILE_MODE_READ_WRITE); >>> if (!icon_ef) goto on_error_efreet; >>> >>> >>> >>> -- >>> Index, Search& Analyze Logs and other IT data in Real-Time with Splunk >>> Collect, index and harness all the fast moving IT data generated by your >>> applications, servers and devices whether physical, virtual or in the >>> cloud. >>> Deliver compliance at lower cost and gain new business insights. >>> Free Software Download: http://p.sf.net/sfu/splunk-dev2dev >>> ___ >>> enlightenment-svn mailing list >>> enlightenment-...@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >>> >> >> >> > > > -- > Free Software Download: Index, Search& Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: englebass trunk/efreet/src/bin
On 02/22/2011 04:22 PM, Atton Jonathan wrote: > If the problem is in e why you don't fix e instead of revert a fix in efreet > ? E always wants to wait for desktop cache to be updated. So we always need to wait there. What we need to do is to differentiate between "cache build done and change", and "cache build done and no change". Needs a bit more work. So it is better to let things work as it is now, instead of breaking E. S. > > > 2011/2/22 Enlightenment SVN > >> Log: >> Efreet: Reset changed before scanning fallback >> >> Changed must be EINA_FALSE before scanning fallback to not create false >> positive. >> >> Author: englebass >> Date: 2011-02-22 04:52:58 -0800 (Tue, 22 Feb 2011) >> New Revision: 57240 >> Trac: http://trac.enlightenment.org/e/changeset/57240 >> >> Modified: >> trunk/efreet/src/bin/efreet_icon_cache_create.c >> >> Modified: trunk/efreet/src/bin/efreet_icon_cache_create.c >> === >> --- trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:46 >> UTC (rev 57239) >> +++ trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:58 >> UTC (rev 57240) >> @@ -897,6 +897,8 @@ >> } >> eina_iterator_free(it); >> >> +changed = EINA_FALSE; >> + >> /* open icon file */ >> icon_ef = eet_open(efreet_icon_cache_file(EFREET_CACHE_ICON_FALLBACK), >> EET_FILE_MODE_READ_WRITE); >> if (!icon_ef) goto on_error_efreet; >> >> >> >> -- >> Index, Search& Analyze Logs and other IT data in Real-Time with Splunk >> Collect, index and harness all the fast moving IT data generated by your >> applications, servers and devices whether physical, virtual or in the >> cloud. >> Deliver compliance at lower cost and gain new business insights. >> Free Software Download: http://p.sf.net/sfu/splunk-dev2dev >> ___ >> enlightenment-svn mailing list >> enlightenment-...@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >> > > > -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Proposed new EFL Manual (and some wiki updates)
Hello, what about this manual,please? On 17/12/2010 18:11, Kim Lester wrote: > All, > > A few notes and two requests (marked *** ) > > 1) > Attached is a 0th order draft of a proposed EFL manual to replace all the > other "manuals". > Or more accurately here is a half written manual to replace the other half > written manuals :-) > > I've cannibalised all the other sources of info that I could find. Once > complete and if everyone is happy I suggest the old docs be moved into an > ARCHIVE directory (or similar) so they are not accidentally used to provide > incorrect info (not that I'm claiming this manual is 100% accurate yet) > > I have deliberately take some additional info from the doxygen "main page". I > don't see doxygen as a suitable "user guide documentation tool" so if there > is overview stuff in doxygen IMHO it is better in a proper document and leave > doxygen for source code docs and maybe the odd code example. > > *** I would appreciate feedback on this document. > > Incidentally I wrote this in OO simply because writing either doxygen or xml > is not a good way to evolve a large complex document. I've written large docs > in TeX with vi before and whilst it is good for producing consistent output > it sucks from the point of view of massive cut/pastes and "creative flow". > Eventually this doc _could_ be converted to xml or tex or something but not > just now. > > > 2) > My suggestion is we create 3 sources of reference documentation (excluding > the "casual" wiki for ad-hoc info) > > 1) The EFL Manual > 2) The Edje User Guide (not yet written) > 3) The API source. > > > 3) > IMHO there are far too many sources and types of info for E at the moment and > too many enlightenment subdomains (confusing to me anyway). > Info sources > 1) web site > 2) wiki > 3) misc docs in SVN (trunk/DOCS) > 4) doxygenated source (auto) > 5) doxygentated source (out of date - late 2009) > > I've stated cleaning up the wiki (done about 20 pages) - see RecentChanges > page for last week. > I have a list of pages I think should be deleted but I'm not game to do that > yet. > I think the website (not wiki) needs a bit of tweaking too. > > *** I would appreciate some feedback on the wiki changes before I > contemplate doing any more work. > > > > > > 4) Passing comment. IMHO the guides for building EFL are poor enough that it > would put a lot of people off... More work needs to be done in this area IMHO > if you want uptake... > > it should be as simple as: > download source > optionally downloads non EFL source deps for you (as a convenience) > make > > run EFL demos > > Other projects manage this > > > cheers > Kim > > > -- > Lotusphere 2011 > Register now for Lotusphere 2011 and learn how > to connect the dots, take your collaborative environment > to the next level, and enter the era of Social Business. > http://p.sf.net/sfu/lotusphere-d2d > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] elementary widget theming
On Tue, Feb 22, 2011 at 2:05 PM, Benjamin Flanagin wrote: > Whats the proper way to change the theme on elementary widgets? I'm > converting a program from stright edje to elementary/edje to leverage the > great work that has been done there. But I would like to retain the original > button styles. the easiest way is to create a theme overlay or extension, check out "enjoy" or "eve" in SVN for examples. there is an undocumented (as in text documents) interface that must be respected. The edje group names must follow a pattern, and there must be text/swallow parts and some signals. So hardly you can reuse "as is", but it may be simple to adapt. NOTE: although it's not documented in a nice text, it's pretty simple to deduce it from default.edc as names follow a scheme. And edc is easy to read (although verbose). -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn trunk/elementary/data/themes
Yeah, weird, very weird, and it's terribly old, which makes things even weirder. But no doubt about it, reverting it fixed things for me. Furthermore, the commit wasn't really clean. I did keep the changes he did in the .c, so the signals are still sent to edje, but I reverted the theme so the broken changes won't run. -- Tom. On Wed, 2011-02-23 at 01:54 +0900, Daniel Juyung Seo wrote: > Hmmm. > This should be noticed before. > Sohyun will take a look. > Thanks. > > Daniel Juyung Seo (SeoZ) > > On Wed, Feb 23, 2011 at 1:33 AM, Enlightenment SVN > wrote: > > Log: > > Elementary theme-bubble: revert 55839 that introduced bugs with no-icon. > > > > The commit caused bugs when there was no icon, exactly what it claimed > > to have fixed. I took a look at the commit and it looked a bit messy, > > too messy for me to try to fix. A rewrite makes more sense. > > > > Previous commit message: > > From: Sohyun Kim > > Subject: [E-devel] [Patch] elm_bubble theme patch > > > > I'm Sohyun Kim. Nice to meet you. > > > > This is a patch for bubble theme. > > > > The bubble has a region for icon, label and info text. > > However, it has the region, if icon, label and info text are not set. > > I modified theme and added edje signals. > > > > 1. add edje signal for label and info text state > > 2. remove text size for label and info text default state > > -> set it on "visible" state > > 3. add base image state for info text only > > > > Author: tasn > > Date: 2011-02-22 08:33:38 -0800 (Tue, 22 Feb 2011) > > New Revision: 57244 > > Trac: http://trac.enlightenment.org/e/changeset/57244 > > > > Modified: > > trunk/elementary/data/themes/default.edc > > > > Modified: trunk/elementary/data/themes/default.edc > > === > > --- trunk/elementary/data/themes/default.edc2011-02-22 16:33:18 UTC > > (rev 57243) > > +++ trunk/elementary/data/themes/default.edc2011-02-22 16:33:38 UTC > > (rev 57244) > > @@ -9058,7 +9058,6 @@ > > description { state: "default" 0.0; > > align: 0.0 0.0; > > fixed: 0 1; > > - visible: 0; > > rel1 { > > to_x: "elm.swallow.icon"; > > relative: 1.0 0.0; > > @@ -9069,10 +9068,6 @@ > > relative: 0.0 0.0; > > offset: -5 4; > > } > > -} > > -description { state: "visible" 0.0; > > - inherit: "default" 0.0; > > - visible: 1; > > color: 0 0 0 255; > > text { > > font: "Sans:style=Bold,Edje-Vera-Bold"; > > @@ -9090,7 +9085,6 @@ > > description { state: "default" 0.0; > > align: 1.0 0.0; > > fixed: 1 1; > > - visible: 0; > > rel1 { > > relative: 1.0 0.0; > > offset: -5 4; > > @@ -9099,10 +9093,6 @@ > > relative: 1.0 0.0; > > offset: -5 4; > > } > > -} > > -description { state: "visible" 0.0; > > - inherit: "default" 0.0; > > - visible: 1; > > color: 0 0 0 64; > > text { > > font: "Sans:style=Bold,Edje-Vera-Bold"; > > @@ -9128,10 +9118,6 @@ > > image.middle: SOLID; > > fill.smooth: 0; > > } > > -description { state: "infobase" 0.0; > > - inherit: "default" 0.0; > > - rel1.to_y: "elm.info"; > > -} > > } > > part { name: "elm.swallow.content"; > > type: SWALLOW; > > @@ -9178,63 +9164,16 @@ > > name: "icon_show"; > > signal: "elm,state,icon,visible"; > > source: "elm"; > > -script { > > - new st[31]; > > - new Float:vl; > > - get_state(PART:"base0", st, 30, vl); > > - if (!strcmp(st, "infobase")) > > -set_state(PART:"base0", "default", 0.0); > > - set_state(PART:"elm.swallow.icon", "visible", 0.0); > > -} > > +action: STATE_SET "visible" 0.0; > > +target: "elm.swallow.icon"; > > } > > program { > > name: "icon_hide"; > > signal: "elm,state,icon,hidden"; > > source: "elm"; > > -script { > > - new st[31]; > > - new Float:vl; > > - get_state(PART:"elm.info", st, 30, vl); > > - if (!strcmp(st, "visible")) > > -set_state(PART:"base0", "infobase", 0.0); > > - set_state(PART:"elm.swallow.icon", "default", 0.0); > > -} > > - } > > - program { > > -name: "text_show"; > > -signal: "elm,state,text,visible"; > > -source: "elm"; > > -action: STATE_SET "visible" 0.0; > > -target: "elm.text"; > > - } > > - program { > > -name: "text_hide"; > > -signal: "elm,state,text,hidden"; > > -source: "elm"; > > action: STATE_SET "default" 0.0; > > -target: "elm.text"; > > +target: "elm.swa
[E-devel] elementary widget theming
Whats the proper way to change the theme on elementary widgets? I'm converting a program from stright edje to elementary/edje to leverage the great work that has been done there. But I would like to retain the original button styles. Thanks, Ben -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: tasn trunk/elementary/data/themes
Hmmm. This should be noticed before. Sohyun will take a look. Thanks. Daniel Juyung Seo (SeoZ) On Wed, Feb 23, 2011 at 1:33 AM, Enlightenment SVN wrote: > Log: > Elementary theme-bubble: revert 55839 that introduced bugs with no-icon. > > The commit caused bugs when there was no icon, exactly what it claimed > to have fixed. I took a look at the commit and it looked a bit messy, > too messy for me to try to fix. A rewrite makes more sense. > > Previous commit message: > From: Sohyun Kim > Subject: [E-devel] [Patch] elm_bubble theme patch > > I'm Sohyun Kim. Nice to meet you. > > This is a patch for bubble theme. > > The bubble has a region for icon, label and info text. > However, it has the region, if icon, label and info text are not set. > I modified theme and added edje signals. > > 1. add edje signal for label and info text state > 2. remove text size for label and info text default state > -> set it on "visible" state > 3. add base image state for info text only > > Author: tasn > Date: 2011-02-22 08:33:38 -0800 (Tue, 22 Feb 2011) > New Revision: 57244 > Trac: http://trac.enlightenment.org/e/changeset/57244 > > Modified: > trunk/elementary/data/themes/default.edc > > Modified: trunk/elementary/data/themes/default.edc > === > --- trunk/elementary/data/themes/default.edc 2011-02-22 16:33:18 UTC (rev > 57243) > +++ trunk/elementary/data/themes/default.edc 2011-02-22 16:33:38 UTC (rev > 57244) > @@ -9058,7 +9058,6 @@ > description { state: "default" 0.0; > align: 0.0 0.0; > fixed: 0 1; > - visible: 0; > rel1 { > to_x: "elm.swallow.icon"; > relative: 1.0 0.0; > @@ -9069,10 +9068,6 @@ > relative: 0.0 0.0; > offset: -5 4; > } > - } > - description { state: "visible" 0.0; > - inherit: "default" 0.0; > - visible: 1; > color: 0 0 0 255; > text { > font: "Sans:style=Bold,Edje-Vera-Bold"; > @@ -9090,7 +9085,6 @@ > description { state: "default" 0.0; > align: 1.0 0.0; > fixed: 1 1; > - visible: 0; > rel1 { > relative: 1.0 0.0; > offset: -5 4; > @@ -9099,10 +9093,6 @@ > relative: 1.0 0.0; > offset: -5 4; > } > - } > - description { state: "visible" 0.0; > - inherit: "default" 0.0; > - visible: 1; > color: 0 0 0 64; > text { > font: "Sans:style=Bold,Edje-Vera-Bold"; > @@ -9128,10 +9118,6 @@ > image.middle: SOLID; > fill.smooth: 0; > } > - description { state: "infobase" 0.0; > - inherit: "default" 0.0; > - rel1.to_y: "elm.info"; > - } > } > part { name: "elm.swallow.content"; > type: SWALLOW; > @@ -9178,63 +9164,16 @@ > name: "icon_show"; > signal: "elm,state,icon,visible"; > source: "elm"; > - script { > - new st[31]; > - new Float:vl; > - get_state(PART:"base0", st, 30, vl); > - if (!strcmp(st, "infobase")) > - set_state(PART:"base0", "default", 0.0); > - set_state(PART:"elm.swallow.icon", "visible", 0.0); > - } > + action: STATE_SET "visible" 0.0; > + target: "elm.swallow.icon"; > } > program { > name: "icon_hide"; > signal: "elm,state,icon,hidden"; > source: "elm"; > - script { > - new st[31]; > - new Float:vl; > - get_state(PART:"elm.info", st, 30, vl); > - if (!strcmp(st, "visible")) > - set_state(PART:"base0", "infobase", 0.0); > - set_state(PART:"elm.swallow.icon", "default", 0.0); > - } > - } > - program { > - name: "text_show"; > - signal: "elm,state,text,visible"; > - source: "elm"; > - action: STATE_SET "visible" 0.0; > - target: "elm.text"; > - } > - program { > - name: "text_hide"; > - signal: "elm,state,text,hidden"; > - source: "elm"; > action: STATE_SET "default" 0.0; > - target: "elm.text"; > + target: "elm.swallow.icon"; > } > - program { > - name: "info_show"; > - signal: "elm,state,info,visible"; > - source: "elm"; > - script { > - new st[31]; > - new Float:vl; > - get_state(PART:"elm.swallow.icon", st, 30, vl); > - if (!strcmp(st, "default")) > - set_state(PART:"base0", "infobase", 0.0); > - set_state(PART:"elm.info", "visible", 0.0); > - } > - } > - program { > - name: "info_hide"; > - signal: "elm,state,info,hidden"; > - source: "elm"; > - action: STATE_SET "default" 0.0; > - target: "elm.info"; > - target: "b
Re: [E-devel] E SVN: englebass trunk/efreet/src/bin
If the problem is in e why you don't fix e instead of revert a fix in efreet ? 2011/2/22 Enlightenment SVN > Log: > Efreet: Reset changed before scanning fallback > > Changed must be EINA_FALSE before scanning fallback to not create false > positive. > > Author: englebass > Date: 2011-02-22 04:52:58 -0800 (Tue, 22 Feb 2011) > New Revision: 57240 > Trac: http://trac.enlightenment.org/e/changeset/57240 > > Modified: > trunk/efreet/src/bin/efreet_icon_cache_create.c > > Modified: trunk/efreet/src/bin/efreet_icon_cache_create.c > === > --- trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:46 > UTC (rev 57239) > +++ trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-22 12:52:58 > UTC (rev 57240) > @@ -897,6 +897,8 @@ > } > eina_iterator_free(it); > > +changed = EINA_FALSE; > + > /* open icon file */ > icon_ef = eet_open(efreet_icon_cache_file(EFREET_CACHE_ICON_FALLBACK), > EET_FILE_MODE_READ_WRITE); > if (!icon_ef) goto on_error_efreet; > > > > -- > Index, Search & Analyze Logs and other IT data in Real-Time with Splunk > Collect, index and harness all the fast moving IT data generated by your > applications, servers and devices whether physical, virtual or in the > cloud. > Deliver compliance at lower cost and gain new business insights. > Free Software Download: http://p.sf.net/sfu/splunk-dev2dev > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > -- Regards. -- Index, Search & Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. Free Software Download: http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] ecore_imf_context_canvas_get, ecore_imf_context_window_get
Thank you, raster. Version information (@since 1.1.0) should be inserted, is it right? Attached patch file includes it. On Mon, Feb 21, 2011 at 3:22 PM, Carsten Haitzler wrote: > On Sun, 20 Feb 2011 18:05:56 +0900 Jihoon Kim said: > > happiness! in svn! thanks! > > > Hi, Mike. > > According to your comment, I revised this patch file. > > Would you please review again? > > > > On Sun, Feb 20, 2011 at 2:27 AM, Mike Blumenkrantz >wrote: > > > > > On Sat, 19 Feb 2011 10:13:27 +0900 > > > Jihoon Kim wrote: > > > > > > > Hi, > > > > > > > > This patch includes the code to add ecore_imf_context_canvas_get and > > > > ecore_imf_context_window_get. > > > > These APIs are coupled with the ecore_imf_context_canvas_set and > > > > ecore_imf_context_window_set. > > > > Would you please review it? > > > > > > > Looks good, but your formatting is a little off: > > > void* function_name(void); /* INCORRECT */ > > > void *function_name(void); /* CORRECT */ > > > > > > Please fix this and resend :) > > > > > > -- > > > Mike Blumenkrantz > > > Zentific: NULL pointer dereferences now 50% off! > > > > > > > > > > -- > > > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio > XE: > > > Pinpoint memory and threading errors before they happen. > > > Find and fix more than 250 security defects in the development cycle. > > > Locate bottlenecks in serial and parallel code that limit performance. > > > http://p.sf.net/sfu/intel-dev2devfeb > > > ___ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > -- > - Codito, ergo sum - "I code, therefore I am" -- > The Rasterman (Carsten Haitzler)ras...@rasterman.com > > Index: src/lib/ecore_imf/ecore_imf_context.c === --- src/lib/ecore_imf/ecore_imf_context.c (revision 57241) +++ src/lib/ecore_imf/ecore_imf_context.c (working copy) @@ -253,6 +253,7 @@ ecore_imf_context_client_window_set(Ecore_IMF_Cont * @param ctx An #Ecore_IMF_Context. * @return Return the client window. * @ingroup Ecore_IMF_Context_Group + * @since 1.1.0 */ EAPI void * ecore_imf_context_client_window_get(Ecore_IMF_Context *ctx) @@ -300,6 +301,7 @@ ecore_imf_context_client_canvas_set(Ecore_IMF_Cont * @param ctx An #Ecore_IMF_Context. * @return Return the client canvas. * @ingroup Ecore_IMF_Context_Group + * @since 1.1.0 */ EAPI void * ecore_imf_context_client_canvas_get(Ecore_IMF_Context *ctx) -- Index, Search & Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. Free Software Download: http://p.sf.net/sfu/splunk-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/ecore: . src/lib/ecore_file
On Tue, 22 Feb 2011 07:48:57 +0100 (CET) Vincent Torri said: i have a list of things to backport. i'll go thru changelog at some point and do that. not now though. got other things to do. > > backport in 1.0 ? > > Vincent > > On Mon, 21 Feb 2011, Enlightenment SVN wrote: > > > Log: > > Fix: ecore-file inotify fd would be duplicated in children > > on fork. Have it detecti this on next monitor add and re-init > > the inotify fd and fd handler. > > > > > > > > Author: raster > > Date: 2011-02-21 22:09:46 -0800 (Mon, 21 Feb 2011) > > New Revision: 57228 > > Trac: http://trac.enlightenment.org/e/changeset/57228 > > > > Modified: > > trunk/ecore/ChangeLog > > trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c > > > > Modified: trunk/ecore/ChangeLog > > === > > --- trunk/ecore/ChangeLog 2011-02-22 01:55:08 UTC (rev 57227) > > +++ trunk/ecore/ChangeLog 2011-02-22 06:09:46 UTC (rev 57228) > > @@ -58,3 +58,9 @@ > > > > * Remove 300 second timeout so large downloads work in ecore_con. > > > > +2011-02-22 Carsten Haitzler (The Rasterman) > > + > > +* Fix: ecore-file inotify fd would be duplicated in children > > +on fork. Have it detecti this on next monitor add and re-init the > > +inotify fd and fd handler. > > + > > > > Modified: trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c > > === > > --- trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c > > 2011-02-22 01:55:08 UTC (rev 57227) +++ > > trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c > > 2011-02-22 06:09:46 UTC (rev 57228) @@ -47,6 +47,7 @@ > > > > static Ecore_Fd_Handler *_fdh = NULL; > > static Ecore_File_Monitor*_monitors = NULL; > > +static pid_t _inotify_fd_pid = -1; > > > > static Eina_Bool _ecore_file_monitor_inotify_handler(void *data, > > Ecore_Fd_Handler *fdh); static Ecore_File_Monitor > > *_ecore_file_monitor_inotify_monitor_find(int wd); @@ -64,7 +65,7 @@ > >fd = inotify_init(); > >if (fd < 0) > > return 0; > > - > > + > >_fdh = ecore_main_fd_handler_add(fd, ECORE_FD_READ, > > _ecore_file_monitor_inotify_handler, NULL, NULL, NULL); > >if (!_fdh) > > @@ -73,6 +74,7 @@ > > return 0; > > } > > > > + _inotify_fd_pid = getpid(); > >return 1; > > } > > > > @@ -90,6 +92,7 @@ > > ecore_main_fd_handler_del(_fdh); > > close(fd); > > } > > + _inotify_fd_pid = -1; > >return 1; > > } > > > > @@ -103,6 +106,14 @@ > >Ecore_File_Monitor *em; > >int len; > > > > + if (_inotify_fd_pid == -1) return NULL; > > + > > + if (_inotify_fd_pid != getpid()) > > + { > > +ecore_file_monitor_inotify_shutdown(); > > +ecore_file_monitor_inotify_init(); > > + } > > + > >em = calloc(1, sizeof(Ecore_File_Monitor_Inotify)); > >if (!em) return NULL; > > > > > > > > -- > > Index, Search & Analyze Logs and other IT data in Real-Time with Splunk > > Collect, index and harness all the fast moving IT data generated by your > > applications, servers and devices whether physical, virtual or in the cloud. > > Deliver compliance at lower cost and gain new business insights. > > Free Software Download: http://p.sf.net/sfu/splunk-dev2dev > > ___ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > > > -- > Index, Search & Analyze Logs and other IT data in Real-Time with Splunk > Collect, index and harness all the fast moving IT data generated by your > applications, servers and devices whether physical, virtual or in the cloud. > Deliver compliance at lower cost and gain new business insights. > Free Software Download: http://p.sf.net/sfu/splunk-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Index, Search & Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. Free Software Download: http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lis
[E-devel] elm_genlist - bug fix about del callback
Hello. All. I found one bug in elm_genlist_clear. In case append lots of items in genlist, some items are still in genlist item queue before it is processed in _item_queue. At that time, if application calls elm_genlist_item_del api that has item in genlist queue and elm_genlist_clear is called at once, "func.del" callback is called twice. If application frees some memory in "func.del" callback, It occurs double free memory problem. For example, some application has many items. and all items are deleted. but all items are not proceed in queue. then application is terminated. In that case, double free problem is occured in application. So, I fixed elm_genlist_clear code and made a patch. Anybody can check about this? Thanks. Index: src/lib/elm_genlist.c === --- src/lib/elm_genlist.c (revision 57228) +++ src/lib/elm_genlist.c (working copy) @@ -3153,7 +3153,6 @@ elm_genlist_clear(Evas_Object *obj) } return; } - wd->clear_me = EINA_FALSE; while (wd->items) { Elm_Genlist_Item *it = ELM_GENLIST_ITEM_FROM_INLIST(wd->items); @@ -3170,12 +3169,13 @@ elm_genlist_clear(Evas_Object *obj) it->wd->group_items = eina_list_remove(it->wd->group_items, it); elm_widget_item_pre_notify_del(it); if (it->realized) _item_unrealize(it); -if (it->itc->func.del) +if (((wd->clear_me) || (!it->delete_me)) && (it->itc->func.del)) it->itc->func.del((void *)it->base.data, it->base.widget); if (it->long_timer) ecore_timer_del(it->long_timer); if (it->swipe_timer) ecore_timer_del(it->swipe_timer); elm_widget_item_del(it); } + wd->clear_me = EINA_FALSE; wd->anchor_item = NULL; while (wd->blocks) { -- Index, Search & Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. Free Software Download: http://p.sf.net/sfu/splunk-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small bug in evas_textblock.
OK, I fixed it in somewhere else. As I suspected this was just a symptom, there was a problem with paragraph_char_last that with empty paragraphs would have set the cursor to a wrong value. Anyhow, fixed. On Tue, 2011-02-22 at 11:12 +0900, WooHyun Jung wrote: > Oh. Right - return 0 is correct thing. > > But, why do you think - this solution will fix my issue ? > > I think - just returning 0 will be enough for this. > > > > From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom Hacohen > Sent: Tuesday, February 22, 2011 2:25 AM > To: WooHyun Jung > Cc: enlightenment-devel@lists.sourceforge.net > Subject: Re: [E-devel] Small bug in evas_textblock. > > > > Dear WooHyun, > > I can confirm the issue, but I don't think your solution is valid, probably > the more correct thing to do is set to 0 > and return, but I don't think this will fix your issue, but it's just a > correct thing to do :P > > Anyhow, will take a look tomorrow, I'm too tired atm. > > Thanks for the report, > Tom. > > On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung > wrote: > > Hello. All. > > I found one small bug in evas_textblock. > > For checking this bug ~ I recommend to do like following scenario. > > > > In Entry 3 of Elementary_test, > > 1. Push Clr Button for the bottom entry. > > 2. Input 'a' and input "Backspace" in the bottom entry. > > 3. Click the top entry. > > 4. Click the bottom entry. > > 5. Input some characters. > > 6. Result : char is input before the last character. > > > > So I made a patch and attached it. > > Anybody can check about this ? > > Thanks. > > > > -- > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- Index, Search & Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. Free Software Download: http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small bug in evas_textblock.
I've checked with ~ setting cursor to 0. And it worked fine :) I made a patch for it ~ -Original Message- From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com] Sent: Tuesday, February 22, 2011 5:25 PM To: WooHyun Jung Cc: 'Tom Hacohen'; enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] Small bug in evas_textblock. Yeah, setting the cursor to 0 may actually fix your issue (did you try it?), though I think there's another issue hiding there, I'll take a look :) Will add the set to 0 soon. -- Tom. On Tue, 2011-02-22 at 11:12 +0900, WooHyun Jung wrote: > Oh. Right - return 0 is correct thing. > > But, why do you think - this solution will fix my issue ? > > I think - just returning 0 will be enough for this. > > > > From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom > Hacohen > Sent: Tuesday, February 22, 2011 2:25 AM > To: WooHyun Jung > Cc: enlightenment-devel@lists.sourceforge.net > Subject: Re: [E-devel] Small bug in evas_textblock. > > > > Dear WooHyun, > > I can confirm the issue, but I don't think your solution is valid, > probably the more correct thing to do is set to 0 and return, but I > don't think this will fix your issue, but it's just a correct thing to > do :P > > Anyhow, will take a look tomorrow, I'm too tired atm. > > Thanks for the report, > Tom. > > On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung > > wrote: > > Hello. All. > > I found one small bug in evas_textblock. > > For checking this bug ~ I recommend to do like following scenario. > > > > In Entry 3 of Elementary_test, > > 1. Push Clr Button for the bottom entry. > > 2. Input 'a' and input "Backspace" in the bottom entry. > > 3. Click the top entry. > > 4. Click the bottom entry. > > 5. Input some characters. > > 6. Result : char is input before the last character. > > > > So I made a patch and attached it. > > Anybody can check about this ? > > Thanks. > > > -- > -- > -- > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > Index: src/lib/canvas/evas_object_textblock.c === --- src/lib/canvas/evas_object_textblock.c (revision 57228) +++ src/lib/canvas/evas_object_textblock.c (working copy) @@ -5465,7 +5465,11 @@ evas_textblock_cursor_line_char_last(Evas_Textbloc _find_layout_item_match(cur, &ln, &it); - if (!ln) return; + if (!ln) + { +cur->pos = 0; +return; + } if (ln->items) { Evas_Object_Textblock_Item *i; -- Index, Search & Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. Free Software Download: http://p.sf.net/sfu/splunk-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch] elm_gengrid calc_job patch
Can anybody check about this? -Original Message- From: Jeonghyun Yun [mailto:jh0506@samsung.com] Sent: Friday, February 11, 2011 11:15 AM To: 'enlightenment-devel@lists.sourceforge.net' Subject: [E-devel] [Patch] elm_gengrid calc_job patch Hello. When I tested gengrid, sometimes gengrid renderd two times in different shape in a moment. So I checked gengrid code, I found cause in calc_job function. calc_job added to ecore job after elm_gengrid_item_size_set and elm_gengrid_item_append(,prepend,insert_before,insert_after). Sometimes pan_smart's cvw and cvh is 0 at this time. For Example, If (item_width = 120, item_height = 120, horizontal = EINA_FALSE, item_count = 8, cvw = 0, cvh = 0) Then, nmax = 0 but nmax < 1 then nmax = 1 Then, minw = 120 (1*120), minh = 960 (8*120), and then pan_smart "changed" callback called. I don't know why this code is added. if (nmax < 1) nmax = 1; I attached patch file for this problem. Can anybody check about this ? Thanks. -- Index, Search & Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. Free Software Download: http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Small bug in evas_textblock.
Yeah, setting the cursor to 0 may actually fix your issue (did you try it?), though I think there's another issue hiding there, I'll take a look :) Will add the set to 0 soon. -- Tom. On Tue, 2011-02-22 at 11:12 +0900, WooHyun Jung wrote: > Oh. Right - return 0 is correct thing. > > But, why do you think - this solution will fix my issue ? > > I think - just returning 0 will be enough for this. > > > > From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom Hacohen > Sent: Tuesday, February 22, 2011 2:25 AM > To: WooHyun Jung > Cc: enlightenment-devel@lists.sourceforge.net > Subject: Re: [E-devel] Small bug in evas_textblock. > > > > Dear WooHyun, > > I can confirm the issue, but I don't think your solution is valid, probably > the more correct thing to do is set to 0 > and return, but I don't think this will fix your issue, but it's just a > correct thing to do :P > > Anyhow, will take a look tomorrow, I'm too tired atm. > > Thanks for the report, > Tom. > > On Mon, Feb 21, 2011 at 2:43 PM, WooHyun Jung > wrote: > > Hello. All. > > I found one small bug in evas_textblock. > > For checking this bug ~ I recommend to do like following scenario. > > > > In Entry 3 of Elementary_test, > > 1. Push Clr Button for the bottom entry. > > 2. Input 'a' and input "Backspace" in the bottom entry. > > 3. Click the top entry. > > 4. Click the bottom entry. > > 5. Input some characters. > > 6. Result : char is input before the last character. > > > > So I made a patch and attached it. > > Anybody can check about this ? > > Thanks. > > > > -- > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- Index, Search & Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. Free Software Download: http://p.sf.net/sfu/splunk-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel