Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
It is needed for 64 bits where sizeof(void*) sizeof(int)
Don't do these changes without asking anymore :-/
On Thursday, January 26, 2012, Enlightenment SVN no-re...@enlightenment.org
wrote:
Log:
elementary/genlist - deprecated elm_genlist_item_data_set/get
but please use elm_object_item_data_set/get instead.
and what was purpose of this double casting?
(int)(long) elm_genlist_item_data_get(gli);
these calls are used in some places.
I removed the (long) casting because it looks useless.
Author: hermet
Date: 2012-01-25 23:31:30 -0800 (Wed, 25 Jan 2012)
New Revision: 67546
Trac: http://trac.enlightenment.org/e/changeset/67546
Modified:
trunk/elementary/src/bin/test_cursor.c
trunk/elementary/src/bin/test_genlist.c
trunk/elementary/src/bin/test_tooltip.c
trunk/elementary/src/examples/genlist_example_05.c
trunk/elementary/src/lib/elc_fileselector.c
trunk/elementary/src/lib/elm_deprecated.h
trunk/elementary/src/lib/elm_genlist.h trunk/elementary/src/lib/elm_store.c
Modified: trunk/elementary/src/bin/test_cursor.c
===
--- trunk/elementary/src/bin/test_cursor.c 2012-01-26 07:21:27 UTC
(rev 67545)
+++ trunk/elementary/src/bin/test_cursor.c 2012-01-26 07:31:30 UTC
(rev 67546)
@@ -47,7 +47,7 @@
{
Elm_Object_Item *glit = event_info;
Evas_Object *gl = elm_genlist_item_genlist_get(glit);
- int val = (int)(long)elm_genlist_item_data_get(glit);
+ int val = (int) elm_object_item_data_get(glit);
Elm_Object_Item *glit1, *glit2, *glit3;
val *= 10;
Modified: trunk/elementary/src/bin/test_genlist.c
===
--- trunk/elementary/src/bin/test_genlist.c 2012-01-26 07:21:27 UTC
(rev 67545)
+++ trunk/elementary/src/bin/test_genlist.c 2012-01-26 07:31:30 UTC
(rev 67546)
@@ -63,7 +63,7 @@
Elm_Object_Item *gli;
gli = elm_genlist_at_xy_item_get(gl, ev-cur.canvas.x,
ev-cur.canvas.y, where);
if (gli)
- printf(over %p, where %i\n, elm_genlist_item_data_get(gli),
where);
+ printf(over %p, where %i\n, elm_object_item_data_get(gli), where);
else
printf(over none, where %i\n, where);
}
@@ -1051,7 +1051,7 @@
{
Elm_Object_Item *glit = event_info;
Evas_Object *gl = elm_genlist_item_genlist_get(glit);
- int val = (int)(long)elm_genlist_item_data_get(glit);
+ int val = (int) elm_object_item_data_get(glit);
val *= 10;
elm_genlist_item_append(gl, itc4,
(void *)(long)(val + 1)/* item data */,
@@ -1536,7 +1536,7 @@
{
Elm_Object_Item *glit = event_info;
Evas_Object *gl = elm_genlist_item_genlist_get(glit);
- int val = (int)(long)elm_genlist_item_data_get(glit);
+ int val = (int) elm_object_item_data_get(glit);
val *= 10;
elm_genlist_item_append(gl, itc1,
(void *)(long)(val + 1)/* item data */,
@@ -1953,8 +1953,8 @@
gl13_cmp(const void *pa, const void *pb)
{
const Elm_Object_Item *ia = pa, *ib = pb;
- int a = (int)(long)elm_genlist_item_data_get(ia);
- int b = (int)(long)elm_genlist_item_data_get(ib);
+ int a = (int) elm_object_item_data_get(ia);
+ int b = (int) elm_object_item_data_get(ib);
return a - b;
}
@@ -2172,7 +2172,7 @@
Elm_Object_Item *sub_glit[6];
int j;
-base = 1000 * (long)elm_genlist_item_data_get(pi[i]);
+base = 1000 * (long) elm_object_item_data_get(pi[i]);
sub_glit[0] = elm_genlist_item_append
(gl, itc4, (void *)(idx[0] + base)/* item data */, pi[i]/*
parent */,
@@ -2211,7 +2211,7 @@
Elm_Object_Item *sub_glit[6];
int j;
-base = 1000 * (long)elm_genlist_item_data_get(pi[i]);
+base = 1000 * (long) elm_object_item_data_get(pi[i]);
sub_glit[0] = elm_genlist_item_append
(gl, itc4, (void *)(idx[0] + base)/* item data */, pi[i]/*
parent */,
Modified: trunk/elementary/src/bin/test_tooltip.c
===
--- trunk/elementary/src/bin/test_tooltip.c 2012-01-26 07:21:27 UTC
(rev 67545)
+++ trunk/elementary/src/bin/test_tooltip.c 2012-01-26 07:31:30 UTC
(rev 67546)
@@ -53,7 +53,7 @@
{
Elm_Object_Item *glit = event_info;
Evas_Object *gl = elm_genlist_item_genlist_get(glit);
- int val = (int)(long)elm_genlist_item_data_get(glit);
+ int val = (int) elm_object_item_data_get(glit);
Elm_Object_Item *glit1, *glit2, *glit3;
val *= 10;
Modified: trunk/elementary/src/examples/genlist_example_05.c
===
--- trunk/elementary/src/examples/genlist_example_05.c 2012-01-26
07:21:27 UTC (rev 67545)
+++ trunk/elementary/src/examples/genlist_example_05.c 2012-01-26
07:31:30 UTC (rev 67546)
@@ -119,7 +119,7 @@
if (parent)
{
d-level = elm_genlist_item_expanded_depth_get(parent) + 1;
Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
On 26/01/12 13:10, Gustavo Sverzut Barbieri wrote: It is needed for 64 bits where sizeof(void*) sizeof(int) Don't do these changes without asking anymore :-/ On Thursday, January 26, 2012, Enlightenment SVNno-re...@enlightenment.org wrote: Log: elementary/genlist - deprecated elm_genlist_item_data_set/get but please use elm_object_item_data_set/get instead. and what was purpose of this double casting? (int)(long) elm_genlist_item_data_get(gli); these calls are used in some places. I removed the (long) casting because it looks useless. Gustavo, (int) (long) sounds bad, a better solution would be using intptr_t, don't you agree? So the code is indeed bad and it (int) (long) is just a hack that should have been removed anyway... -- Tom. -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
Dunno, raster is not too found of the _t variants, that's why we have almost no uint8_t et al On Thursday, January 26, 2012, Tom Hacohen tom.haco...@partner.samsung.com wrote: On 26/01/12 13:10, Gustavo Sverzut Barbieri wrote: It is needed for 64 bits where sizeof(void*) sizeof(int) Don't do these changes without asking anymore :-/ On Thursday, January 26, 2012, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elementary/genlist - deprecated elm_genlist_item_data_set/get but please use elm_object_item_data_set/get instead. and what was purpose of this double casting? (int)(long) elm_genlist_item_data_get(gli); these calls are used in some places. I removed the (long) casting because it looks useless. Gustavo, (int) (long) sounds bad, a better solution would be using intptr_t, don't you agree? So the code is indeed bad and it (int) (long) is just a hack that should have been removed anyway... -- Tom. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
But this case is just ridiculous. :) -- Tom. On 26/01/12 14:11, Gustavo Sverzut Barbieri wrote: Dunno, raster is not too found of the _t variants, that's why we have almost no uint8_t et al On Thursday, January 26, 2012, Tom Hacohen tom.haco...@partner.samsung.com mailto:tom.haco...@partner.samsung.com wrote: On 26/01/12 13:10, Gustavo Sverzut Barbieri wrote: It is needed for 64 bits where sizeof(void*) sizeof(int) Don't do these changes without asking anymore :-/ On Thursday, January 26, 2012, Enlightenment SVNno-re...@enlightenment.org mailto:no-re...@enlightenment.org wrote: Log: elementary/genlist - deprecated elm_genlist_item_data_set/get but please use elm_object_item_data_set/get instead. and what was purpose of this double casting? (int)(long) elm_genlist_item_data_get(gli); these calls are used in some places. I removed the (long) casting because it looks useless. Gustavo, (int) (long) sounds bad, a better solution would be using intptr_t, don't you agree? So the code is indeed bad and it (int) (long) is just a hack that should have been removed anyway... -- Tom. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com mailto:barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] elm_win_resize_object_add - better behavior?
Hello guys, I've been playing with the elm_win_resize_object_add() function to add a main layout to my program. I guess that is a common use-case. However, elm_layout adjusts its min size hints to the required edje size. And those size hints are used by the elm_win to determine its size. The problem here is: if I have mostly relative parts inside this theme, their size can imply on an edje min calc size bigger than the one of my window, and that would force my window to be resized. As fair as I understand, there's no way to make sure that the window has total control over the size of its subobjects. What I had to do for now was to use old-school evas resize callbacks. So, wouldn't it be nice if we could allow the current behavior to persist, but giving more control to the window itself, respecting its min/max size hints and it's actual size? Maybe with an additional call, or based on the weight size hints... Regards, -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] elm_win_resize_object_add - better behavior?
On Thu, 26 Jan 2012 17:29:28 -0200 Rafael Antognolli antogno...@profusion.mobi wrote: Hello guys, I've been playing with the elm_win_resize_object_add() function to add a main layout to my program. I guess that is a common use-case. However, elm_layout adjusts its min size hints to the required edje size. And those size hints are used by the elm_win to determine its size. The problem here is: if I have mostly relative parts inside this theme, their size can imply on an edje min calc size bigger than the one of my window, and that would force my window to be resized. As fair as I understand, there's no way to make sure that the window has total control over the size of its subobjects. What I had to do for now was to use old-school evas resize callbacks. So, wouldn't it be nice if we could allow the current behavior to persist, but giving more control to the window itself, respecting its min/max size hints and it's actual size? Maybe with an additional call, or based on the weight size hints... Regards, I've had this experience as well, and I agree that it would be nice if there were some way to set ratios/weights on subobjects here. -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
On Thu, Jan 26, 2012 at 13:11, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Dunno, raster is not too found of the _t variants, that's why we have almost no uint8_t et al I don't want to troll on that but I'd like to know why raster doesn't want the use the types in stdint.h specified in C99? I would also like to know why there is Eina_Bool that does the same thing as bool aka _Bool defined in stdbool.h. I'm almost sure there are no issues with compilation using visual studio. Is there something else or just that raster doesn't like them and never bothered to use them? I'm not asking for a change on those points. -- Boris Faure -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
On Thu, Jan 26, 2012 at 8:16 PM, Boris Faure bill...@gmail.com wrote: On Thu, Jan 26, 2012 at 13:11, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Dunno, raster is not too found of the _t variants, that's why we have almost no uint8_t et al I don't want to troll on that but I'd like to know why raster doesn't want the use the types in stdint.h specified in C99? I would also like to know why there is Eina_Bool that does the same thing as bool aka _Bool defined in stdbool.h. I'm almost sure there are no issues with compilation using visual studio. Is there something else or just that raster doesn't like them and never bothered to use them? I'm not asking for a change on those points. he has suffered from that in 83 :-) thats the default answer. I'm all for using it and when not defined, provide the stdint.h file ourselves... it is trivial. As for bool - Eina_Bool, the later is an unsigned char, the former is an integer... can't remember/check right now, but maybe it's even signed by default? What I am sure is that it is 4 bytes, not 1. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
On Thu, 26 Jan 2012 20:37:42 -0200 Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: On Thu, Jan 26, 2012 at 8:16 PM, Boris Faure bill...@gmail.com wrote: On Thu, Jan 26, 2012 at 13:11, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Dunno, raster is not too found of the _t variants, that's why we have almost no uint8_t et al I don't want to troll on that but I'd like to know why raster doesn't want the use the types in stdint.h specified in C99? I would also like to know why there is Eina_Bool that does the same thing as bool aka _Bool defined in stdbool.h. I'm almost sure there are no issues with compilation using visual studio. Is there something else or just that raster doesn't like them and never bothered to use them? I'm not asking for a change on those points. he has suffered from that in 83 :-) thats the default answer. Um, he had trouble in 1983 from a 1999 standard? Raster really is ahead of his time. B-) -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
Thank you for explaining.
So I leave the log messages for picking up any problems from there by someone
like you.
But It would be better if there were any comments to explain it why he/she
wrote those unusual code.
Anyway, once I will revert them but I hope to fix that code rightly because I
don't wanna keep those strange things in our svn.
-Regards, Hermet-
-Original Message-
From: Gustavo Sverzut Barbierilt;barbi...@profusion.mobigt;
To:
enlightenment-devel@lists.sourceforge.netlt;enlightenment-devel@lists.sourceforge.netgt;
Cc:
enlightenment-...@lists.sourceforge.netlt;enlightenment-...@lists.sourceforge.netgt;
Sent: 12-01-26(목) 20:10:06
Subject: Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
It is needed for 64 bits where sizeof(void*) sizeof(int)
Don't do these changes without asking anymore :-/
On Thursday, January 26, 2012, Enlightenment SVN
lt;no-re...@enlightenment.orggt;
wrote:
Log:
elementary/genlist - deprecated elm_genlist_item_data_set/get
but please use elm_object_item_data_set/get instead.
and what was purpose of this double casting?
(int)(long) elm_genlist_item_data_get(gli);
these calls are used in some places.
I removed the (long) casting because it looks useless.
Author: hermet
Date: 2012-01-25 23:31:30 -0800 (Wed, 25 Jan 2012)
New Revision: 67546
Trac: http://trac.enlightenment.org/e/changeset/67546
Modified:
trunk/elementary/src/bin/test_cursor.c
trunk/elementary/src/bin/test_genlist.c
trunk/elementary/src/bin/test_tooltip.c
trunk/elementary/src/examples/genlist_example_05.c
trunk/elementary/src/lib/elc_fileselector.c
trunk/elementary/src/lib/elm_deprecated.h
trunk/elementary/src/lib/elm_genlist.h trunk/elementary/src/lib/elm_store.c
Modified: trunk/elementary/src/bin/test_cursor.c
===
--- trunk/elementary/src/bin/test_cursor.c 2012-01-26 07:21:27 UTC
(rev 67545)
+++ trunk/elementary/src/bin/test_cursor.c 2012-01-26 07:31:30 UTC
(rev 67546)
@@ -47,7 +47,7 @@
{
Elm_Object_Item *glit = event_info;
Evas_Object *gl = elm_genlist_item_genlist_get(glit);
- int val = (int)(long)elm_genlist_item_data_get(glit);
+ int val = (int) elm_object_item_data_get(glit);
Elm_Object_Item *glit1, *glit2, *glit3;
val *= 10;
Modified: trunk/elementary/src/bin/test_genlist.c
===
--- trunk/elementary/src/bin/test_genlist.c 2012-01-26 07:21:27 UTC
(rev 67545)
+++ trunk/elementary/src/bin/test_genlist.c 2012-01-26 07:31:30 UTC
(rev 67546)
@@ -63,7 +63,7 @@
Elm_Object_Item *gli;
gli = elm_genlist_at_xy_item_get(gl, ev-cur.canvas.x,
ev-cur.canvas.y, where);
if (gli)
- printf(over %p, where %i\n, elm_genlist_item_data_get(gli),
where);
+ printf(over %p, where %i\n, elm_object_item_data_get(gli), where);
else
printf(over none, where %i\n, where);
}
@@ -1051,7 +1051,7 @@
{
Elm_Object_Item *glit = event_info;
Evas_Object *gl = elm_genlist_item_genlist_get(glit);
- int val = (int)(long)elm_genlist_item_data_get(glit);
+ int val = (int) elm_object_item_data_get(glit);
val *= 10;
elm_genlist_item_append(gl, itc4,
(void *)(long)(val + 1)/* item data */,
@@ -1536,7 +1536,7 @@
{
Elm_Object_Item *glit = event_info;
Evas_Object *gl = elm_genlist_item_genlist_get(glit);
- int val = (int)(long)elm_genlist_item_data_get(glit);
+ int val = (int) elm_object_item_data_get(glit);
val *= 10;
elm_genlist_item_append(gl, itc1,
(void *)(long)(val + 1)/* item data */,
@@ -1953,8 +1953,8 @@
gl13_cmp(const void *pa, const void *pb)
{
const Elm_Object_Item *ia = pa, *ib = pb;
- int a = (int)(long)elm_genlist_item_data_get(ia);
- int b = (int)(long)elm_genlist_item_data_get(ib);
+ int a = (int) elm_object_item_data_get(ia);
+ int b = (int) elm_object_item_data_get(ib);
return a - b;
}
@@ -2172,7 +2172,7 @@
Elm_Object_Item *sub_glit[6];
int j;
- base = 1000 * (long)elm_genlist_item_data_get(pi[i]);
+ base = 1000 * (long) elm_object_item_data_get(pi[i]);
sub_glit[0] = elm_genlist_item_append
(gl, itc4, (void *)(idx[0] + base)/* item data */, pi[i]/*
parent */,
@@ -2211,7 +2211,7 @@
Elm_Object_Item *sub_glit[6];
int j;
- base = 1000 * (long)elm_genlist_item_data_get(pi[i]);
+ base = 1000 * (long) elm_object_item_data_get(pi[i]);
sub_glit[0] = elm_genlist_item_append
(gl, itc4, (void *)(idx[0] + base)/* item data */, pi[i]/*
parent */,
Modified: trunk/elementary/src/bin/test_tooltip.c
===
--- trunk/elementary/src/bin/test_tooltip.c 2012-01-26 07:21:27 UTC
(rev 67545)
+++ trunk/elementary/src/bin/test_tooltip.c 2012-01-26 07:31:30 UTC
(rev 67546)
@@ -53,7 +53,7 @@
{
Elm_Object_Item *glit = event_info;
Evas_Object *gl = elm_genlist_item_genlist_get(glit);
- int val = (int)(long)elm_genlist_item_data_get(glit);
+ int val = (int) elm_object_item_data_get(glit);
Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
I changed to use ssize_t type for now,
Since I'm not sure that long type will be expanded to 64bit.
-Regards, Hermet-
-Original Message-
From: ChunEon Parklt;her...@naver.comgt;
To: Enlightenment develolt;enlightenment-devel@lists.sourceforge.netgt;
Cc: enlightenment-...@lists.sourceforge.net
Sent: 12-01-27(금) 11:52:52
Subject: Re: [E-devel]E SVN: hermet IN trunk/elementary/src: bin examples lib
Thank you for explaining.
So I leave the log messages for picking up any problems from there by someone
like you.
But It would be better if there were any comments to explain it why he/she
wrote those unusual code.
Anyway, once I will revert them but I hope to fix that code rightly because I
don't wanna keep those strange things in our svn.
-Regards, Hermet-
-Original Message-
From: Gustavo Sverzut Barbierilt;barbi...@profusion.mobigt;
To:
enlightenment-devel@lists.sourceforge.netlt;enlightenment-devel@lists.sourceforge.netgt;
Cc:
enlightenment-...@lists.sourceforge.netlt;enlightenment-...@lists.sourceforge.netgt;
Sent: 12-01-26(목) 20:10:06
Subject: Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
It is needed for 64 bits where sizeof(void*) sizeof(int)
Don't do these changes without asking anymore :-/
On Thursday, January 26, 2012, Enlightenment SVN
lt;no-re...@enlightenment.orggt;
wrote:
Log:
elementary/genlist - deprecated elm_genlist_item_data_set/get
but please use elm_object_item_data_set/get instead.
and what was purpose of this double casting?
(int)(long) elm_genlist_item_data_get(gli);
these calls are used in some places.
I removed the (long) casting because it looks useless.
Author: hermet
Date: 2012-01-25 23:31:30 -0800 (Wed, 25 Jan 2012)
New Revision: 67546
Trac: http://trac.enlightenment.org/e/changeset/67546
Modified:
trunk/elementary/src/bin/test_cursor.c
trunk/elementary/src/bin/test_genlist.c
trunk/elementary/src/bin/test_tooltip.c
trunk/elementary/src/examples/genlist_example_05.c
trunk/elementary/src/lib/elc_fileselector.c
trunk/elementary/src/lib/elm_deprecated.h
trunk/elementary/src/lib/elm_genlist.h trunk/elementary/src/lib/elm_store.c
Modified: trunk/elementary/src/bin/test_cursor.c
===
--- trunk/elementary/src/bin/test_cursor.c 2012-01-26 07:21:27 UTC
(rev 67545)
+++ trunk/elementary/src/bin/test_cursor.c 2012-01-26 07:31:30 UTC
(rev 67546)
@@ -47,7 +47,7 @@
{
Elm_Object_Item *glit = event_info;
Evas_Object *gl = elm_genlist_item_genlist_get(glit);
- int val = (int)(long)elm_genlist_item_data_get(glit);
+ int val = (int) elm_object_item_data_get(glit);
Elm_Object_Item *glit1, *glit2, *glit3;
val *= 10;
Modified: trunk/elementary/src/bin/test_genlist.c
===
--- trunk/elementary/src/bin/test_genlist.c 2012-01-26 07:21:27 UTC
(rev 67545)
+++ trunk/elementary/src/bin/test_genlist.c 2012-01-26 07:31:30 UTC
(rev 67546)
@@ -63,7 +63,7 @@
Elm_Object_Item *gli;
gli = elm_genlist_at_xy_item_get(gl, ev-cur.canvas.x,
ev-cur.canvas.y, where);
if (gli)
- printf(over %p, where %i\n, elm_genlist_item_data_get(gli),
where);
+ printf(over %p, where %i\n, elm_object_item_data_get(gli), where);
else
printf(over none, where %i\n, where);
}
@@ -1051,7 +1051,7 @@
{
Elm_Object_Item *glit = event_info;
Evas_Object *gl = elm_genlist_item_genlist_get(glit);
- int val = (int)(long)elm_genlist_item_data_get(glit);
+ int val = (int) elm_object_item_data_get(glit);
val *= 10;
elm_genlist_item_append(gl, itc4,
(void *)(long)(val + 1)/* item data */,
@@ -1536,7 +1536,7 @@
{
Elm_Object_Item *glit = event_info;
Evas_Object *gl = elm_genlist_item_genlist_get(glit);
- int val = (int)(long)elm_genlist_item_data_get(glit);
+ int val = (int) elm_object_item_data_get(glit);
val *= 10;
elm_genlist_item_append(gl, itc1,
(void *)(long)(val + 1)/* item data */,
@@ -1953,8 +1953,8 @@
gl13_cmp(const void *pa, const void *pb)
{
const Elm_Object_Item *ia = pa, *ib = pb;
- int a = (int)(long)elm_genlist_item_data_get(ia);
- int b = (int)(long)elm_genlist_item_data_get(ib);
+ int a = (int) elm_object_item_data_get(ia);
+ int b = (int) elm_object_item_data_get(ib);
return a - b;
}
@@ -2172,7 +2172,7 @@
Elm_Object_Item *sub_glit[6];
int j;
- base = 1000 * (long)elm_genlist_item_data_get(pi[i]);
+ base = 1000 * (long) elm_object_item_data_get(pi[i]);
sub_glit[0] = elm_genlist_item_append
(gl, itc4, (void *)(idx[0] + base)/* item data */, pi[i]/*
parent */,
@@ -2211,7 +2211,7 @@
Elm_Object_Item *sub_glit[6];
int j;
- base = 1000 * (long)elm_genlist_item_data_get(pi[i]);
+ base = 1000 * (long) elm_object_item_data_get(pi[i]);
sub_glit[0] = elm_genlist_item_append
(gl, itc4, (void *)(idx[0] + base)/* item data */, pi[i]/*
parent */,
Modified: trunk/elementary/src/bin/test_tooltip.c
Re: [E-devel] E SVN: hermet IN trunk/elementary/src: bin examples lib
On Fri, Jan 27, 2012 at 1:39 AM, David Seikel onef...@gmail.com wrote: On Thu, 26 Jan 2012 20:37:42 -0200 Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: On Thu, Jan 26, 2012 at 8:16 PM, Boris Faure bill...@gmail.com wrote: On Thu, Jan 26, 2012 at 13:11, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Dunno, raster is not too found of the _t variants, that's why we have almost no uint8_t et al I don't want to troll on that but I'd like to know why raster doesn't want the use the types in stdint.h specified in C99? I would also like to know why there is Eina_Bool that does the same thing as bool aka _Bool defined in stdbool.h. I'm almost sure there are no issues with compilation using visual studio. unfortunately, vc++ is not C99 compliant. But fortunately, defining them in Evil.h is doable (intN_t and uintN_t are already there). On the other hand, we know the size of char, short and int. Only long is problematic. so is it really necessary ? Vincent -- Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
