Re: [E-devel] icons in menu and everything
On 10/05/2012 10:30 PM, Tomas Cech wrote: Hi again, I have found that most of the problem was wrong installation. Now it passed most of test and two remaining failures seems to be more relevant. The tests hasn't been updated in a while, so it might be changes in efreet which triggers the errors. Will look into it. S. $ efreet_test Data Home: PASSED in 0.027 seconds Config Home:PASSED in 0.010 seconds Cache Home: PASSED in 0.020 seconds Data Directories: efreet_data_dirs_get() nodes is differnet from expected default efreet_data_dirs_get() returned incorrect value (/usr/local/share) when XDG_DATA_DIRS= is set /usr/share FAILED in 0.010 seconds Config Directories: PASSED in 0.018 seconds Icon Theme Basic: PASSED in 0.017 seconds Icon Theme List:ERR5110: efreet_ini.c:325 efreet_ini_section_set() safety check failed: ini-data == NULL ERR5110: efreet_ini.c:465 efreet_ini_localestring_get() safety check failed: ini-section == NULL PASSED in 0.007 seconds Icon Matching: Time: 0.000279 Time: 0.000785 PASSED in 0.002 seconds ERR5110:eet eet_lib.c:668 eet_shutdown() File '/home/tcech/.cache/efreet/icons___efreet_fallback_venom.suse.cz.eet' is still open ! INI Parsing:efreet_ini_localestring_get() Name parsed incorrectly FAILED in 0.000 seconds INI Long Line Parsing: PASSED in 0.000 seconds INI Garbage Parsing:PASSED in 0.000 seconds Desktop Parsing:PASSED in 0.001 seconds Desktop Type Parsing: PASSED in 0.001 seconds Desktop Save: save data: 0 save test: 1 PASSED in 0.003 seconds Desktop Command: EXE: 'app '/tmp/absolute_path' '/relative_path' '/tmp/absolute_uri' '/relative_uri'' EXE: 'app '/tmp/absolute_path' '/relative_path' '/tmp/absolute_uri' '/relative_uri'' EXE: 'app '/tmp/absolute_path' '/relative_path' '/tmp/absolute_uri' '/relative_uri'' EXE: 'app '/tmp/absolute_path' '/relative_path' '/tmp/absolute_uri' '/relative_uri'' EXE: 'app 'file:///tmp/absolute_path' 'file:///relative_path' 'file:///tmp/absolute_uri' 'file:///relative_uri'' EXE: 'app 'file:///tmp/absolute_path' 'file:///relative_path' 'file:///tmp/absolute_uri' 'file:///relative_uri'' EXE: 'app 'file:///tmp/absolute_path' 'file:///relative_path' 'file:///tmp/absolute_uri' 'file:///relative_uri'' EXE: 'app 'file:///tmp/absolute_path' 'file:///relative_path' 'file:///tmp/absolute_uri' 'file:///relative_uri'' PASSED in 0.000 seconds Menu Parsing: PASSED in 0.050 seconds Menu Incorrect Names: PASSED in 0.000 seconds Menu Save: PASSED in 0.040 seconds Utils: this-tmp-test.desktop kde-kresources.desktop: (nil) mplayer.desktop: 0x1aae140 nautilus-computer.desktop: (nil) PASSED in 0.001 seconds Mime: mime icon: application/x-desktop (null) 0.000223 mime icon: image/png (null) 0.20 mime icon: image/png (null) 0.16 mime icon: inode/directory (null) 0.17 PASSED in 0.008 seconds - Passed 18 of 20 tests. Total run: 0.316 seconds Any ideas? Tomas Cech Sleep_Walker -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] regarding notification
can somebody explain what the option Ignore replace ID of the notification module actually does? -- Massimo Maiurana GPG keyID #7044D601 La fede e' credere in cio' che sai non essere vero [Mark Twain] signature.asc Description: OpenPGP digital signature -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] regarding notification
On Sat, 06 Oct 2012 12:05:52 +0200 Massimo Maiurana maiur...@gmail.com wrote: can somebody explain what the option Ignore replace ID of the notification module actually does? notifications contain an identifier which allows the display system to replace notifications with the same ID. for example, if an application sends a notification which says 50% Complete and then wants to update it to 60% Complete, the app can set the same id for teh message to have it replaced instead of displaying both notifications. this option ignores replacements and always generates new notifications whenever a message is received -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [ecore] Recursive rm
Hi,
I looked at the ecore_file_recursive_rm() function
(in ecore/src/lib/ecore_file/), and I wonder why this
is so ugly/complicated.
We are doing a readlink() and two stat(). Why not simply
do a lstat() ?
It takes less memory and it's simplier. Here is a patch.
Am I wrong ?
(And readlink() is ssize_t)
--- ecore_file.c 2012-10-06 13:11:59.884889232 +0200
+++ ecore_file.c 2012-10-06 13:08:24.569905570 +0200
@@ -399,21 +399,16 @@
EAPI Eina_Bool
ecore_file_recursive_rm(const char *dir)
{
- Eina_Iterator *it;
- char buf[PATH_MAX];
struct stat st;
- int ret;
- if (readlink(dir, buf, sizeof(buf) - 1) 0)
- return ecore_file_unlink(dir);
+ if (lstat(dir, st) == -1)
+ return EINA_FALSE;
- ret = stat(dir, st);
- if ((ret == 0) (S_ISDIR(st.st_mode)))
+ if (S_ISDIR(st.st_mode))
{
Eina_File_Direct_Info *info;
-
-ret = 1;
-if (stat(dir, st) == -1) return EINA_FALSE; /* WOOT: WHY ARE WE CALLING STAT TWO TIMES ??? */
+Eina_Iterator *it;
+int ret = 1;
it = eina_file_direct_ls(dir);
EINA_ITERATOR_FOREACH(it, info)
@@ -429,11 +424,8 @@
else
return EINA_FALSE;
}
- else
- {
-if (ret == -1) return EINA_FALSE;
-return ecore_file_unlink(dir);
- }
+
+ return ecore_file_unlink(dir);
}
static inline Eina_Bool
@@ -790,7 +782,7 @@
ecore_file_readlink(const char *lnk)
{
char buf[PATH_MAX];
- int count;
+ ssize_t count;
if ((count = readlink(lnk, buf, sizeof(buf) - 1)) 0) return NULL;
buf[count] = 0;
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [ecore] Recursive rm
On Sat, Oct 6, 2012 at 1:21 PM, rustyBSD rusty...@gmx.fr wrote: Hi, I looked at the ecore_file_recursive_rm() function (in ecore/src/lib/ecore_file/), and I wonder why this is so ugly/complicated. We are doing a readlink() and two stat(). Why not simply do a lstat() ? note that lstat does not exist on Windows Vincent It takes less memory and it's simplier. Here is a patch. Am I wrong ? (And readlink() is ssize_t) -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [ecore] Recursive rm
Le 06/10/2012 14:03, Vincent Torri a écrit : Hi, I looked at the ecore_file_recursive_rm() function (in ecore/src/lib/ecore_file/), and I wonder why this is so ugly/complicated. We are doing a readlink() and two stat(). Why not simply do a lstat() ? note that lstat does not exist on Windows Vincent Ah ok, I didn't know. But the second stat() is still useless. -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck
Hi list.
There are several suspicious code snippets in E, that
look much like copypaste errors, but I don't know how
to properly fix those errors. Maybe someone experienced
could look into these.
#1: src/bin/e_backlight.c#n496
if ((e_config-backlight.sysdev)
(!strcmp(e_config-backlight.sysdev, f)))
bl_sysval = eina_stringshare_add(f);
else
bl_sysval = eina_stringshare_add(f);
#2: src/bin/e_gadcon.c#n2988
if (e_gadcon_layout_orientation_get(gc-o_container))
e_gadcon_layout_pack_request_set(o, gcc-config.pos,
gcc-config.size);
else
e_gadcon_layout_pack_request_set(o, gcc-config.pos,
gcc-config.size);
#3: src/bin/e_border.c#n5765
if (e-mode == ECORE_X_EVENT_MODE_GRAB)
{
if (e-detail == ECORE_X_EVENT_DETAIL_POINTER) return
ECORE_CALLBACK_PASS_ON;
}
else if (e-mode == ECORE_X_EVENT_MODE_UNGRAB)
{
if (e-detail == ECORE_X_EVENT_DETAIL_POINTER) return
ECORE_CALLBACK_PASS_ON;
}
-- Igor
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck
#3 is definitely correct.
S.
Den 6. okt. 2012 kl. 21:14 skrev Igor Murzov e-m...@date.by:
Hi list.
There are several suspicious code snippets in E, that
look much like copypaste errors, but I don't know how
to properly fix those errors. Maybe someone experienced
could look into these.
#1: src/bin/e_backlight.c#n496
if ((e_config-backlight.sysdev)
(!strcmp(e_config-backlight.sysdev, f)))
bl_sysval = eina_stringshare_add(f);
else
bl_sysval = eina_stringshare_add(f);
#2: src/bin/e_gadcon.c#n2988
if (e_gadcon_layout_orientation_get(gc-o_container))
e_gadcon_layout_pack_request_set(o, gcc-config.pos,
gcc-config.size);
else
e_gadcon_layout_pack_request_set(o, gcc-config.pos,
gcc-config.size);
#3: src/bin/e_border.c#n5765
if (e-mode == ECORE_X_EVENT_MODE_GRAB)
{
if (e-detail == ECORE_X_EVENT_DETAIL_POINTER) return
ECORE_CALLBACK_PASS_ON;
}
else if (e-mode == ECORE_X_EVENT_MODE_UNGRAB)
{
if (e-detail == ECORE_X_EVENT_DETAIL_POINTER) return
ECORE_CALLBACK_PASS_ON;
}
-- Igor
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: billiob trunk/terminology/src/bin
Please add parenthesis :)
2012/10/6 Enlightenment SVN no-re...@enlightenment.org
Log:
terminology: fix vim issue
Author: billiob
Date: 2012-10-06 13:23:20 -0700 (Sat, 06 Oct 2012)
New Revision: 77549
Trac: http://trac.enlightenment.org/e/changeset/77549
Modified:
trunk/terminology/src/bin/termptyops.c
Modified: trunk/terminology/src/bin/termptyops.c
===
--- trunk/terminology/src/bin/termptyops.c 2012-10-06 17:10:58 UTC
(rev 77548)
+++ trunk/terminology/src/bin/termptyops.c 2012-10-06 20:23:20 UTC
(rev 77549)
@@ -127,7 +127,7 @@
int e = ty-h;
if (ty-state.scroll_y2 != 0) e = ty-state.scroll_y2;
- if (ty-state.cy = e)
+ if (ty-state.cy = e ty-state.cy = ty-h)
{
_termpty_text_scroll(ty);
ty-state.cy = e - 1;
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
--
Michaël Bouchaud (yoz) y...@efl.so
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: billiob trunk/terminology/src/bin
On 12-10-06 22:46, Michaël Bouchaud wrote: Please add parenthesis :) done ;) sorry. -- Boris Faure Pointer Arithmetician -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck
#3 is definitely correct.
Then could you simplify this part, so that it doesn't look
like bad copypaste?
-- Igor
Den 6. okt. 2012 kl. 21:14 skrev Igor Murzov e-m...@date.by:
Hi list.
There are several suspicious code snippets in E, that
look much like copypaste errors, but I don't know how
to properly fix those errors. Maybe someone experienced
could look into these.
#1: src/bin/e_backlight.c#n496
if ((e_config-backlight.sysdev)
(!strcmp(e_config-backlight.sysdev, f)))
bl_sysval = eina_stringshare_add(f);
else
bl_sysval = eina_stringshare_add(f);
#2: src/bin/e_gadcon.c#n2988
if (e_gadcon_layout_orientation_get(gc-o_container))
e_gadcon_layout_pack_request_set(o, gcc-config.pos,
gcc-config.size);
else
e_gadcon_layout_pack_request_set(o, gcc-config.pos,
gcc-config.size);
#3: src/bin/e_border.c#n5765
if (e-mode == ECORE_X_EVENT_MODE_GRAB)
{
if (e-detail == ECORE_X_EVENT_DETAIL_POINTER) return
ECORE_CALLBACK_PASS_ON;
}
else if (e-mode == ECORE_X_EVENT_MODE_UNGRAB)
{
if (e-detail == ECORE_X_EVENT_DETAIL_POINTER) return
ECORE_CALLBACK_PASS_ON;
}
-- Igor
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
