Re: [E-devel] clang warnings -- please help

[Jihoon Kim]

Hi, Gustavo.

I've fixed warnings in edje_entry.c as rev 83033.
Thanks.

On Sunday, January 20, 2013, Gustavo Sverzut Barbieri wrote:

> Hi,
>
> Today compiling efl with clang some warnings shows. While there are
> some false alarms with EINA_INLINE macros (I'll try to check what to
> do about those), some are valid.
>
> == eet_chipher.c eet_decipher() ==
> lib/eet/eet_cipher.c:1096:8: warning: variable 'opened' is used
> uninitialized
>   whenever 'if' condition is true [-Wsometimes-uninitialized]
>if (!ret)
>^~~~
> lib/eet/eet_cipher.c:1180:8: note: uninitialized use occurs here
>if (opened)
>^~
> lib/eet/eet_cipher.c:1096:4: note: remove the 'if' if its condition is
> always
>   false
>if (!ret)
>^
> lib/eet/eet_cipher.c:1092:8: warning: variable 'opened' is used
> uninitialized
>   whenever 'if' condition is true [-Wsometimes-uninitialized]
>if ((tmp_len & 0x1F) != 0)
>^
> lib/eet/eet_cipher.c:1180:8: note: uninitialized use occurs here
>if (opened)
>^~
> lib/eet/eet_cipher.c:1092:4: note: remove the 'if' if its condition is
> always
>   false
>if ((tmp_len & 0x1F) != 0)
>^~
> lib/eet/eet_cipher.c:1130:4: note: variable 'opened' is declared here
>int opened = 0;
>^
> 2 warnings generated.
>
>
> this file is a horror story of using 2 systems. It's leaking the ssl
> and gnutls stuff with the goto on_error. The first 'if (!ret) goto
> error' happens BEFORE opened was declared... but goto uses that.
>
> Who wrote this file please rewrite this bit using 2 different
> functions, one for gnutls and another for openssl, handle memory and
> errors right. Then call them from eet_decipher().
>
>
> == evas_image_load_psd.c ==
> bin/evas/loaders/psd/evas_image_load_psd.c:374:70: warning: expression
> result
>   unused [-Wunused-value]
>for (x = 0; x < (unsigned int)bps2; x += bpp,
> shortptr)
>
>  ^~~~
> 1 warning generated.
>
> shortptr is in the for(), but not being changed. Later on in the code it
> does:
>
> newval = *shortptr * ((unsigned
> short*)data)[y + x + 3];
>
> using the same ptr. Likely shortptr needs to be incremented, but who
> wrote this code please check.
>
> This error is also present in
> modules/evas/loaders/psd/evas_image_load_psd.c
>
>
> == dns.c ==
>
> horror story, warnings everywhere, with gcc, clang... can't we have a
> sane dns implementation? I know we got this from someone else, but
> what's the difficulty in doing it with our tech?
>
> == ecore_x_randr_12.c ==
> lib/ecore_x/xlib/ecore_x_randr_12.c:1204:30: warning: comparison of
> constant
>   4294967295 with expression of type 'Ecore_X_Randr_Orientation' (aka
> 'enum
>   _Ecore_X_Randr_Orientation') is always false
>   [-Wtautological-constant-out-of-range-compare]
>  if (orientation == Ecore_X_Randr_Unset)
>
> unset is -1, while orientation is an enum without that value. Some
> compilers will just remove this check, as the value can't exist.
> Either convert orientation to 'int' (be warned of ABI break), or add
> Ecore_X_Randr_Unset to enum (also should break ABI).
>
>
> == edje_entry.c ==
> lots of conversion that are suspicious. We need to check if the enums
> match perfectly:
>
> lib/edje/edje_entry.c:2921:62: warning: implicit conversion from
> enumeration
>   type 'Edje_Text_Autocapital_Type' (aka 'enum
> _Edje_Text_Autocapital_Type')
>   to different enumeration type 'Ecore_IMF_Autocapital_Type'
>   [-Wenum-conversion]
>  ecore_imf_context_autocapital_type_set(en->imf_context,
> autocapital_type);
>  ~~
>  ^~~~
> lib/edje/edje_entry.c:2940:13: warning: implicit conversion from
> enumeration
>   type 'Ecore_IMF_Autocapital_Type' to different enumeration type
>   'Edje_Text_Autocapital_Type' (aka 'enum _Edje_Text_Autocapital_Type')
>   [-Wenum-conversion]
>  return ecore_imf_context_autocapital_type_get(en->imf_context);
>  ~~ ^~~
> lib/edje/edje_entry.c:3050:66: warning: implicit conversion from
> enumeration
>   type 'Edje_Input_Panel_Lang' (aka 'enum _Edje_Input_Panel_Lang') to
>   different enumeration type 'Ecore_IMF_Input_Panel_Lang'
>   [-Wenum-conversion]
>  ecore_imf_context_input_panel_language_set(en->imf_context, lang);
>  ~~  ^~~~
> lib/edje/edje_entry.c:3115:73: warning: implicit conversion from
> enumeration
>   type 'Edje_Input_Panel_Return_Key_Type' (aka 'enum
>   _Edje_Input_Panel_Return_Key_Type') to different enumeration type
>   'Ecore_IMF_Input_Panel_Return_Key_Type' [-Wenum-conversion]
>  ecore_imf_context_input_panel_return_key_type_set(en->imf_context,
> return_key_type);
>  ~
>  ^~

Re: [E-devel] [PATCH] evas: reuse evas gl context and surface if change to new rotation

[The Rasterman]

On Mon, 21 Jan 2013 02:34:13 + "Li, Peng"  said:

> Hi, Rasterman
> 
> Thanks for your review. My problem is that two gl accelerated evas window
> (one overlap on another and alpha channel enabled) doing rotation and the top
> window content turns black for some reason.
> 
> This evas change could fix the problem. but finally we found it turns out to
> be an application issue and came up with a fix in the app. So no need to
> change evas.

aha! basically i didn't see that this SHOULD fix any actual bug. re-creating
context is perfectly valid and should be all done right... if it wasn't we need
to hunt that other source issue down, but it seems your issue was somewhere
else entirely.

as such keeping the context should be a little more efficient (though that is
dwarfed by the inefficiency of allocating new sized backbuffers and pixmaps,
rendering etc. anyway, so i guess it's not even measurable).

> Thanks
> Peng
> 
> -Original Message-
> From: Carsten Haitzler [mailto:ras...@rasterman.com] 
> Sent: Friday, January 18, 2013 11:43 AM
> To: Enlightenment developer list
> Cc: Li, Peng
> Subject: Re: [E-devel] [PATCH] evas: reuse evas gl context and surface if
> change to new rotation
> 
> On Fri, 18 Jan 2013 02:37:07 + "Li, Peng"  said:
> 
> > Hi, enlightenment developers:
> > 
> > Please help review attached patch and provide your comments. Thanks
> > 
> > Peng
> 
> so curious... what problems did you actually have? i am sure the code in
> there was conservative... and i've never noticed this as a problem. to be
> honest resizes in gl are abysmal already on a tonne of gl driver
> implementations (like slow as all hell). :)
> 
> :)
> 
> --
> - Codito, ergo sum - "I code, therefore I am" --
> The Rasterman (Carsten Haitzler)ras...@rasterman.com
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH] [Elementary] Fix memory leak and callback function in ctxpopup

[ChunEon Park]

yes, I couldn't see the last patch that was for the backport :) 
I changed NEWs. thank you!  
  


-Regards, Hermet- 
-Original Message-
From: "thiep ha" 
To: "Enlightenment developer 
list"; 
Cc: 
Sent: 2013-01-21 (월) 09:39:43
Subject: Re: [E-devel] [PATCH] [Elementary] Fix memory leak and callback 
function in ctxpopup

Dear Hermet and Daniel,



Thank  you for your reviewing.



I provided the backport patch which is "elm_ctxpopup_memleak_callback_1.7.diff".

Could you please check it and correct NEWS change for me?



Thanks & Regards,

Thiep





--- Original Message ---

Sender : Daniel Juyung Seo@gmail.com> 

Date   : Jan 18, 2013 18:38 (GMT+09:00)

Title  : Re: [E-devel] [PATCH] [Elementary] Fix memory leak and callback

 function in ctxpopup



I think "elm_ctxpopup_memleak_callback_1.7.diff" is the backport.

But he made a mistake in NEWS.



Daniel Juyung Seo (SeoZ)



On Fri, Jan 18, 2013 at 6:12 PM, ChunEon Park @naver.com> 
wrote:

> and theip,  could you please make a backport patch also?

>

> 

>

> -Regards, Hermet-

> -Original Message-

> From: "ChunEon Park"

> To: "Enlightenment developer 
list";

> Cc:

> Sent: 2013-01-18 (금) 18:08:11

> Subject: Re: [E-devel][PATCH] [Elementary] Fix memory leak and callback 
function in ctxpopup

>

> Here is my review of the first patch elm_ctxpopup_memleak_callback.diff.

> I don't have much time to review both.

>

> 1. Reduce line as possible. We don't need to block the area if the 
conditional  has only one

>

>  32 +   EINA_LIST_FREE (sd->items, it)

>  33 + {

>  34 +elm_widget_item_free(it);

>  35 + }

>

> EINA_LIST_FREE (sd->items, it)

>   elm_widget_item_free(it);

>

> 2. Changelog/NEWS have lack of information. People may dont understand why 
does callback function fixed.

>

> 3. Don't mix the different changes in one path. This should be seprated to 
memory leak and callback function to be reviewed simple and fast.

>

> 4. Please make a backport patch also.

>

> I submitted your patch this time but please consider my reivew in next 
time.

> Next patch i will review soon

>

> Thank you.

>

> 

>

> -Regards, Hermet-

> -Original Message-

> From: "thiep ha"

> To: 
"enlightenment-devel@lists.sourceforge.net";

> Cc:

> Sent: 2013-01-15 (화) 15:06:45

> Subject: [E-devel] [PATCH] [Elementary] Fix memory leak and callback 
function in ctxpopup

>

> Hello everyone,

>

>

>

> There are two issues with ctxpopup:

>

> - Memory leak: Elm_Ctxpopup_Item is used but not deleted.

>

> - Incorrect callback function: returned object and event_info are list 
object and item

>

>   (should be ctxpopup object and item).

>

>

>

> I would like to send a patch to fix above issues.

>

> I also provide the patch for backporting.

>

> Please review them.

>

>

>

> Best Regards,

>

> Thiep

>

>

> 
--

> Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS

> and more. Get SQL Server skills now (including 2012) with LearnDevNow -

> 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.

> SALE $99.99 this month only - learn more at:

> http://p.sf.net/sfu/learnmore_122512

> ___

> enlightenment-devel mailing list

> enlightenment-devel@lists.sourceforge.net

> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

>

> 
--

> Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and

> much more. Get web development skills now with LearnDevNow -

> 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.

> SALE $99.99 this month only -- learn more at:

> http://p.sf.net/sfu/learnmore_122812

> ___

> enlightenment-devel mailing list

> enlightenment-devel@lists.sourceforge.net

> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

> 
--

> Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and

> much more. Get web development skills now with LearnDevNow -

> 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.

> SALE $99.99 this month only -- learn more at:

> http://p.sf.net/sfu/learnmore_122812

> ___

> enlightenment-devel mailing list

> enlightenment-devel@lists.sourceforge.net

> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] elemines 0.2

[ChunEon Park]

interesting! i didn't launch it yet but are the scores shared on online?  
 


-Regards, Hermet- 
-Original Message-
From: "Jérôme Pinot" 
To: "e-users"; 
Cc: "e-devel"; 
Sent: 2013-01-20 (일) 17:46:18
Subject: [E-devel] elemines 0.2

I would like to announce the availability of elemines 0.2, the EFL
minesweeper clone. This new version has some improvements, like:

- scores management (using etrophy library)
- in game configuration
- middle click support (thanks to Sebastian Dransfeld)
- french translation
- cosmetic changes (icons, background...)

Elemines 0.2 requires EFL 1.7 and etrophy 0.5.1.

I'm already packaging for Slackware, but if you like to see elemines
in your distributuin and you can provide the build script/spec/etc,
I'll be happy to add it in the source code, under packaging/

Moreover, any help for translation is welcome (po file is really small).

Website: http://elemines.sourceforge.net/ 
Download: http://sourceforge.net/projects/elemines/files/0.2/ 
Screenshot: http://elemines.sourceforge.net/shot2.jpg 

Regards,

-- 
Jérôme Pinot
http://ngc891.blogdns.net/

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH] evas: reuse evas gl context and surface if change to new rotation

[Li, Peng]

Hi, Rasterman

Thanks for your review. My problem is that two gl accelerated evas window (one 
overlap on another and alpha channel enabled) doing rotation and the top window 
content turns black for some reason.

This evas change could fix the problem. but finally we found it turns out to be 
an application issue and came up with a fix in the app. So no need to change 
evas.

Thanks
Peng

-Original Message-
From: Carsten Haitzler [mailto:ras...@rasterman.com] 
Sent: Friday, January 18, 2013 11:43 AM
To: Enlightenment developer list
Cc: Li, Peng
Subject: Re: [E-devel] [PATCH] evas: reuse evas gl context and surface if 
change to new rotation

On Fri, 18 Jan 2013 02:37:07 + "Li, Peng"  said:

> Hi, enlightenment developers:
> 
> Please help review attached patch and provide your comments. Thanks
> 
> Peng

so curious... what problems did you actually have? i am sure the code in there 
was conservative... and i've never noticed this as a problem. to be honest 
resizes in gl are abysmal already on a tonne of gl driver implementations (like 
slow as all hell). :)

:)

--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Heads Up: EFL single tree is ready for tests!

[Gustavo Sverzut Barbieri]

On Sun, Jan 20, 2013 at 12:51 PM, dieter roelants  wrote:
> On Sun, 13 Jan 2013 22:10:08 -0200
> Gustavo Sverzut Barbieri  wrote:
>
>> > - libedje.so is linked with libfontconfig but the rpath as specified by
>> >   the latter's pkg-config file is not used when linking it. Because
>> >   fontconfig is installed under the Xorg prefix (/usr/X11R7/) this
>> >   breaks e.g. edje_cc during build. (I worked around it by setting
>> >   LD_LIBRARY_PATH.)
>>
>> This is very weird. libedje.so doesn't use fontconfig directly, it's
>> just used by libevas.so and this uses whatever `pkg-config --libs
>> fontconfig`reports. Is it a broken fontconfig.pc?
>
> I don't think it's broken:
> simult:2:~/work/e/efl$ pkg-config --libs fontconfig
> -Wl,-rpath,/usr/X11R7/lib -L/usr/X11R7/lib -lfontconfig
>
> and libevas.so has /usr/X11R7/lib in its RPATH.
>
> I think libfontconfig gets linked in libedje by libtool because it's in
> its (.la) dependency_libs? I see that -Wl,--as-needed is passed to the
> command linking libedje, but it comes almost at the end, after all the
> libraries, while the ld man page says it only affects libraries
> mentioned after it. Maybe this is the problem?

i changed that, could you try again?


--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH] [Elementary] Fix memory leak and callback function in ctxpopup

[thiep ha]

Dear Hermet and Daniel,

Thank  you for your reviewing.

I provided the backport patch which is "elm_ctxpopup_memleak_callback_1.7.diff".
Could you please check it and correct NEWS change for me?

Thanks & Regards,
Thiep


--- Original Message ---
Sender : Daniel Juyung Seo 
Date   : Jan 18, 2013 18:38 (GMT+09:00)
Title  : Re: [E-devel] [PATCH] [Elementary] Fix memory leak and callback
 function in ctxpopup

I think "elm_ctxpopup_memleak_callback_1.7.diff" is the backport.
But he made a mistake in NEWS.

Daniel Juyung Seo (SeoZ)

On Fri, Jan 18, 2013 at 6:12 PM, ChunEon Park  wrote:
> and theip,  could you please make a backport patch also?
>
> 
>
> -Regards, Hermet-
> -Original Message-
> From: "ChunEon Park"
> To: "Enlightenment developer 
> list";
> Cc:
> Sent: 2013-01-18 (금) 18:08:11
> Subject: Re: [E-devel][PATCH] [Elementary] Fix memory leak and callback 
> function in ctxpopup
>
> Here is my review of the first patch elm_ctxpopup_memleak_callback.diff.
> I don't have much time to review both.
>
> 1. Reduce line as possible. We don't need to block the area if the 
> conditional  has only one
>
>  32 +   EINA_LIST_FREE (sd->items, it)
>  33 + {
>  34 +elm_widget_item_free(it);
>  35 + }
>
> EINA_LIST_FREE (sd->items, it)
>   elm_widget_item_free(it);
>
> 2. Changelog/NEWS have lack of information. People may dont understand why 
> does callback function fixed.
>
> 3. Don't mix the different changes in one path. This should be seprated to 
> memory leak and callback function to be reviewed simple and fast.
>
> 4. Please make a backport patch also.
>
> I submitted your patch this time but please consider my reivew in next time.
> Next patch i will review soon
>
> Thank you.
>
> 
>
> -Regards, Hermet-
> -Original Message-
> From: "thiep ha"
> To: 
> "enlightenment-devel@lists.sourceforge.net";
> Cc:
> Sent: 2013-01-15 (화) 15:06:45
> Subject: [E-devel] [PATCH] [Elementary] Fix memory leak and callback function 
> in ctxpopup
>
> Hello everyone,
>
>
>
> There are two issues with ctxpopup:
>
> - Memory leak: Elm_Ctxpopup_Item is used but not deleted.
>
> - Incorrect callback function: returned object and event_info are list object 
> and item
>
>   (should be ctxpopup object and item).
>
>
>
> I would like to send a patch to fix above issues.
>
> I also provide the patch for backporting.
>
> Please review them.
>
>
>
> Best Regards,
>
> Thiep
>
>
> --
> Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
> and more. Get SQL Server skills now (including 2012) with LearnDevNow -
> 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
> SALE $99.99 this month only - learn more at:
> http://p.sf.net/sfu/learnmore_122512
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
> --
> Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
> much more. Get web development skills now with LearnDevNow -
> 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
> SALE $99.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122812
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> --
> Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
> much more. Get web development skills now with LearnDevNow -
> 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
> SALE $99.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122812
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
much more. Get web development skills now with LearnDevNow -
350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122812
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
  
--
Master Visua

[E-devel] Added Python EFL epydocs to docs page

[Jeff Hoogland]

Would it be possible to get the html python documentation epydoc generates
for the different python EFL libraries added to the docs page on
Enlightenment.org?

For an example of what this looks like here are the VLC epydocs ->
http://liris.cnrs.fr/advene//download/python-ctypes/doc/

-- 
~Jeff Hoogland 
Thoughts on Technology , Tech Blog
Bodhi Linux , Enlightenment for your Desktop
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] elemines 0.2

[Igor Murzov]

On Sun, 20 Jan 2013 17:46:18 +0900
Jérôme Pinot  wrote:

> I would like to announce the availability of elemines 0.2, the EFL
> minesweeper clone. This new version has some improvements, like:
> 
> - scores management (using etrophy library)
> - in game configuration
> - middle click support (thanks to Sebastian Dransfeld)

It's broken. Player can mark any random squares around a digit and
then double click on that digit and all correct surrounding squares
would be cleared even if flags were not set to correct positions.


-- Igor

> - french translation
> - cosmetic changes (icons, background...)
> 
> Elemines 0.2 requires EFL 1.7 and etrophy 0.5.1.
> 
> I'm already packaging for Slackware, but if you like to see elemines
> in your distributuin and you can provide the build script/spec/etc,
> I'll be happy to add it in the source code, under packaging/
> 
> Moreover, any help for translation is welcome (po file is really small).
> 
> Website: http://elemines.sourceforge.net/ 
> Download: http://sourceforge.net/projects/elemines/files/0.2/ 
> Screenshot: http://elemines.sourceforge.net/shot2.jpg 
> 
> Regards,
> 
> -- 
> Jérôme Pinot
> http://ngc891.blogdns.net/

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Heads Up: EFL single tree is ready for tests!

[dieter roelants]

On Sun, 13 Jan 2013 22:10:08 -0200
Gustavo Sverzut Barbieri  wrote:

> > - libedje.so is linked with libfontconfig but the rpath as specified by
> >   the latter's pkg-config file is not used when linking it. Because
> >   fontconfig is installed under the Xorg prefix (/usr/X11R7/) this
> >   breaks e.g. edje_cc during build. (I worked around it by setting
> >   LD_LIBRARY_PATH.)
> 
> This is very weird. libedje.so doesn't use fontconfig directly, it's
> just used by libevas.so and this uses whatever `pkg-config --libs
> fontconfig`reports. Is it a broken fontconfig.pc?

I don't think it's broken:
simult:2:~/work/e/efl$ pkg-config --libs fontconfig
-Wl,-rpath,/usr/X11R7/lib -L/usr/X11R7/lib -lfontconfig

and libevas.so has /usr/X11R7/lib in its RPATH.

I think libfontconfig gets linked in libedje by libtool because it's in
its (.la) dependency_libs? I see that -Wl,--as-needed is passed to the
command linking libedje, but it comes almost at the end, after all the
libraries, while the ld man page says it only affects libraries
mentioned after it. Maybe this is the problem?

kind regards
dieter

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] clang warnings -- please help

[Gustavo Sverzut Barbieri]

Hi,

Today compiling efl with clang some warnings shows. While there are
some false alarms with EINA_INLINE macros (I'll try to check what to
do about those), some are valid.

== eet_chipher.c eet_decipher() ==
lib/eet/eet_cipher.c:1096:8: warning: variable 'opened' is used uninitialized
  whenever 'if' condition is true [-Wsometimes-uninitialized]
   if (!ret)
   ^~~~
lib/eet/eet_cipher.c:1180:8: note: uninitialized use occurs here
   if (opened)
   ^~
lib/eet/eet_cipher.c:1096:4: note: remove the 'if' if its condition is always
  false
   if (!ret)
   ^
lib/eet/eet_cipher.c:1092:8: warning: variable 'opened' is used uninitialized
  whenever 'if' condition is true [-Wsometimes-uninitialized]
   if ((tmp_len & 0x1F) != 0)
   ^
lib/eet/eet_cipher.c:1180:8: note: uninitialized use occurs here
   if (opened)
   ^~
lib/eet/eet_cipher.c:1092:4: note: remove the 'if' if its condition is always
  false
   if ((tmp_len & 0x1F) != 0)
   ^~
lib/eet/eet_cipher.c:1130:4: note: variable 'opened' is declared here
   int opened = 0;
   ^
2 warnings generated.


this file is a horror story of using 2 systems. It's leaking the ssl
and gnutls stuff with the goto on_error. The first 'if (!ret) goto
error' happens BEFORE opened was declared... but goto uses that.

Who wrote this file please rewrite this bit using 2 different
functions, one for gnutls and another for openssl, handle memory and
errors right. Then call them from eet_decipher().


== evas_image_load_psd.c ==
bin/evas/loaders/psd/evas_image_load_psd.c:374:70: warning: expression result
  unused [-Wunused-value]
   for (x = 0; x < (unsigned int)bps2; x += bpp, shortptr)
 ^~~~
1 warning generated.

shortptr is in the for(), but not being changed. Later on in the code it does:

newval = *shortptr * ((unsigned
short*)data)[y + x + 3];

using the same ptr. Likely shortptr needs to be incremented, but who
wrote this code please check.

This error is also present in modules/evas/loaders/psd/evas_image_load_psd.c


== dns.c ==

horror story, warnings everywhere, with gcc, clang... can't we have a
sane dns implementation? I know we got this from someone else, but
what's the difficulty in doing it with our tech?

== ecore_x_randr_12.c ==
lib/ecore_x/xlib/ecore_x_randr_12.c:1204:30: warning: comparison of constant
  4294967295 with expression of type 'Ecore_X_Randr_Orientation' (aka 'enum
  _Ecore_X_Randr_Orientation') is always false
  [-Wtautological-constant-out-of-range-compare]
 if (orientation == Ecore_X_Randr_Unset)

unset is -1, while orientation is an enum without that value. Some
compilers will just remove this check, as the value can't exist.
Either convert orientation to 'int' (be warned of ABI break), or add
Ecore_X_Randr_Unset to enum (also should break ABI).


== edje_entry.c ==
lots of conversion that are suspicious. We need to check if the enums
match perfectly:

lib/edje/edje_entry.c:2921:62: warning: implicit conversion from enumeration
  type 'Edje_Text_Autocapital_Type' (aka 'enum _Edje_Text_Autocapital_Type')
  to different enumeration type 'Ecore_IMF_Autocapital_Type'
  [-Wenum-conversion]
 ecore_imf_context_autocapital_type_set(en->imf_context, autocapital_type);
 ~~  ^~~~
lib/edje/edje_entry.c:2940:13: warning: implicit conversion from enumeration
  type 'Ecore_IMF_Autocapital_Type' to different enumeration type
  'Edje_Text_Autocapital_Type' (aka 'enum _Edje_Text_Autocapital_Type')
  [-Wenum-conversion]
 return ecore_imf_context_autocapital_type_get(en->imf_context);
 ~~ ^~~
lib/edje/edje_entry.c:3050:66: warning: implicit conversion from enumeration
  type 'Edje_Input_Panel_Lang' (aka 'enum _Edje_Input_Panel_Lang') to
  different enumeration type 'Ecore_IMF_Input_Panel_Lang'
  [-Wenum-conversion]
 ecore_imf_context_input_panel_language_set(en->imf_context, lang);
 ~~  ^~~~
lib/edje/edje_entry.c:3115:73: warning: implicit conversion from enumeration
  type 'Edje_Input_Panel_Return_Key_Type' (aka 'enum
  _Edje_Input_Panel_Return_Key_Type') to different enumeration type
  'Ecore_IMF_Input_Panel_Return_Key_Type' [-Wenum-conversion]
 ecore_imf_context_input_panel_return_key_type_set(en->imf_context,
return_key_type);
 ~
 ^~~
lib/edje/edje_entry.c:3133:13: warning: implicit conversion from enumeration
  type 'Ecore_IMF_Input_Panel_Return_Key_Type' to different enumeration type
  'Edje_Input_Panel_Return_Key_Type' (aka 'enum
  _Edje_Input_Panel_Return_Key_Type') [-Wenum-conversion]
 return ecor

Re: [E-devel] Git and Phabricator

[David Seikel]

On Sun, 20 Jan 2013 11:54:28 +0100 Cedric BAIL 
wrote:

> On Sun, Jan 20, 2013 at 11:23 AM, David Seikel 
> wrote:
> > On Sun, 20 Jan 2013 11:17:33 +0100 Jérémy Zurcher 
> > wrote:
> >
> >> On Sunday 20 January 2013  01:36, Tom Hacohen wrote :
> >> > The current plan is to use phabricator, not cgit. As Alex has
> >> > mentioned.
> >>
> >> ;) I understood well, and I don't challenge phabricator, it seems
> >> to be a nice tool for code review, comments, info exchange, etc.
> >>
> >> I don't know why you install trac besides phabricator,
> >> the latest has a bug tracking tool, but I don't challenge that
> >> either.
> >
> > Trac is the old system, it's not being installed beside
> > phabricator.  I think the plan is to get rid of trac, but I might
> > be wrong.  Trac had problems.
> 
> You are nice, I would have said, Trac is a problem !

Personally Trac's biggest problem is that I was never able to actually
use it due to a corrupted account.  So that's the only problem I
actually experienced, I was never able to experience the other
problems.  Thus I err on the side of niceness.  B-)

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.


signature.asc
Description: PGP signature
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH] Fix memory leak in Eina cow

[Cedric BAIL]

On Fri, Jan 18, 2013 at 10:12 PM, Paulo Alcantara  wrote:
> Is this the correct fix ?

Thanks, in svn.
--
Cedric BAIL

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Git and Phabricator

[Cedric BAIL]

On Sun, Jan 20, 2013 at 11:23 AM, David Seikel  wrote:
> On Sun, 20 Jan 2013 11:17:33 +0100 Jérémy Zurcher 
> wrote:
>
>> On Sunday 20 January 2013  01:36, Tom Hacohen wrote :
>> > The current plan is to use phabricator, not cgit. As Alex has
>> > mentioned.
>>
>> ;) I understood well, and I don't challenge phabricator, it seems to
>> be a nice tool for code review, comments, info exchange, etc.
>>
>> I don't know why you install trac besides phabricator,
>> the latest has a bug tracking tool, but I don't challenge that either.
>
> Trac is the old system, it's not being installed beside phabricator.  I
> think the plan is to get rid of trac, but I might be wrong.  Trac had
> problems.

You are nice, I would have said, Trac is a problem !
--
Cedric BAIL

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Git and Phabricator

[David Seikel]

On Sun, 20 Jan 2013 11:17:33 +0100 Jérémy Zurcher 
wrote:

> On Sunday 20 January 2013  01:36, Tom Hacohen wrote :
> > The current plan is to use phabricator, not cgit. As Alex has
> > mentioned.
> 
> ;) I understood well, and I don't challenge phabricator, it seems to
> be a nice tool for code review, comments, info exchange, etc.
> 
> I don't know why you install trac besides phabricator,
> the latest has a bug tracking tool, but I don't challenge that either.

Trac is the old system, it's not being installed beside phabricator.  I
think the plan is to get rid of trac, but I might be wrong.  Trac had
problems.

-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.


signature.asc
Description: PGP signature
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Git and Phabricator

[Jérémy Zurcher]

On Sunday 20 January 2013  01:36, Tom Hacohen wrote :
> The current plan is to use phabricator, not cgit. As Alex has mentioned.

;) I understood well, and I don't challenge phabricator, it seems to be
a nice tool for code review, comments, info exchange, etc.

I don't know why you install trac besides phabricator,
the latest has a bug tracking tool, but I don't challenge that either.

my point is, as you use gitolite, having cgit.enlightenment.org would be a
very nice addon at 0 installation and maintenance cost,
gitolite will automatically generate cgit's repolist.

can we access phabricator's builtin browser without beeing logged in ?
cgit would provide a efficient way to quickly review the latest commits.
it's a specialised tool not an alternative.

Jérémy
 
> 
> On Sat, Jan 19, 2013 at 6:26 PM, Jérémy Zurcher  wrote:
> 
> > On Saturday 19 January 2013  19:32, Alex-P. Natsios wrote :
> > > I don't really think there is much point to adding one more repo browser.
> > >
> > > Phabricator has an integrated repo browser which should be pretty much
> > > adequate for the current state of the project (and possible repo
> > > splittings).
> > >
> > I've tested it on https://secure.phabricator.com, it's a facebook like,
> > so slow and bloated, for those who are used to read diffs and want a clean
> > and fast browser, cgit is by far the winner
> >
> >
> > --
> > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> > MVPs and experts. SALE $99.99 this month only -- learn more at:
> > http://p.sf.net/sfu/learnmore_122912
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> 
> 
> 
> -- 
> Tom.
> --
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_123012
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

-- 
Jérémy Zurcher
av General Guisan 49
1400 Yverdon-les-bains
+41 (0) 79 599 84 27

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] elemines 0.2

[Jérôme Pinot]

I would like to announce the availability of elemines 0.2, the EFL
minesweeper clone. This new version has some improvements, like:

- scores management (using etrophy library)
- in game configuration
- middle click support (thanks to Sebastian Dransfeld)
- french translation
- cosmetic changes (icons, background...)

Elemines 0.2 requires EFL 1.7 and etrophy 0.5.1.

I'm already packaging for Slackware, but if you like to see elemines
in your distributuin and you can provide the build script/spec/etc,
I'll be happy to add it in the source code, under packaging/

Moreover, any help for translation is welcome (po file is really small).

Website: http://elemines.sourceforge.net/ 
Download: http://sourceforge.net/projects/elemines/files/0.2/ 
Screenshot: http://elemines.sourceforge.net/shot2.jpg 

Regards,

-- 
Jérôme Pinot
http://ngc891.blogdns.net/


signature.asc
Description: Digital signature
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel