Re: [E-devel] [EGIT] [apps/terminology] master 04/04: fix crash when closing top-level split. Closes T256.
Am Mittwoch, 28. August 2013 um 17:14 schrieb Boris Faure - Enlightenment Git:
billiob pushed a commit to branch master.
commit 441f2ef39e7f9912cfa1002e84e7d809368c5a0c
Author: Boris Faure bill...@gmail.com (mailto:bill...@gmail.com)
Date: Wed Aug 28 17:11:48 2013 +0200
fix crash when closing top-level split. Closes T256.
---
src/bin/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/bin/main.c b/src/bin/main.c
index c0e11d1..92d6910 100644
--- a/src/bin/main.c
+++ b/src/bin/main.c
@@ -493,6 +493,8 @@ _split_merge(Split *spp, Split *sp, const char *slot)
spp-s2-parent = spp;
spp-horizontal = sp-horizontal;
o = sp-panes;
+ elm_object_part_content_unset(sp-parent-panes,
+ (strcmp(slot, PANES_TOP)) ? PANES_TOP : PANES_BOTTOM);
sure that it shouldn't be !strcmp or (stcmp(..) == 0)?
--
Leif
if (spp-parent)
{
elm_object_part_content_unset(spp-parent-panes, slot);
--
--
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk
--
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [apps/terminology] master 04/04: fix crash when closing top-level split. Closes T256.
On 13-08-28 17:23, Leif Middelschulte wrote: Am Mittwoch, 28. August 2013 um 17:14 schrieb Boris Faure - Enlightenment Git: billiob pushed a commit to branch master. commit 441f2ef39e7f9912cfa1002e84e7d809368c5a0c Author: Boris Faure bill...@gmail.com (mailto:bill...@gmail.com) Date: Wed Aug 28 17:11:48 2013 +0200 fix crash when closing top-level split. Closes T256. --- src/bin/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/bin/main.c b/src/bin/main.c index c0e11d1..92d6910 100644 --- a/src/bin/main.c +++ b/src/bin/main.c @@ -493,6 +493,8 @@ _split_merge(Split *spp, Split *sp, const char *slot) spp-s2-parent = spp; spp-horizontal = sp-horizontal; o = sp-panes; + elm_object_part_content_unset(sp-parent-panes, + (strcmp(slot, PANES_TOP)) ? PANES_TOP : PANES_BOTTOM); sure that it shouldn't be !strcmp or (stcmp(..) == 0)? It's the correct way. slot is the empty part, so the part that should be unset is the other one. I'll rewrite it with a !strcmp that we usually see. -- Boris Faure Pointer Arithmetician -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [apps/terminology] master 04/04: fix crash when closing top-level split. Closes T256.
On Wed, 28 Aug 2013 17:23:25 +0200
Leif Middelschulte leif.middelschu...@gmail.com wrote:
Am Mittwoch, 28. August 2013 um 17:14 schrieb Boris Faure - Enlightenment Git:
billiob pushed a commit to branch master.
commit 441f2ef39e7f9912cfa1002e84e7d809368c5a0c
Author: Boris Faure bill...@gmail.com (mailto:bill...@gmail.com)
Date: Wed Aug 28 17:11:48 2013 +0200
fix crash when closing top-level split. Closes T256.
---
src/bin/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/bin/main.c b/src/bin/main.c
index c0e11d1..92d6910 100644
--- a/src/bin/main.c
+++ b/src/bin/main.c
@@ -493,6 +493,8 @@ _split_merge(Split *spp, Split *sp, const char *slot)
spp-s2-parent = spp;
spp-horizontal = sp-horizontal;
o = sp-panes;
+ elm_object_part_content_unset(sp-parent-panes,
+ (strcmp(slot, PANES_TOP)) ? PANES_TOP : PANES_BOTTOM);
sure that it shouldn't be !strcmp or (stcmp(..) == 0)?
--
Leif
if (spp-parent)
{
elm_object_part_content_unset(spp-parent-panes, slot);
--
leave ternary operators alone!
--
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_bg: added a color reset feature.
On Wed, Aug 28, 2013 at 7:35 AM, Daniel Juyung Seo - Enlightenment Git no-re...@enlightenment.org wrote: seoz pushed a commit to branch master. commit 1286b98c1f52a070c09c2541ce8ab86fa90325dc Author: Daniel Juyung Seo seojuyu...@gmail.com Date: Wed Aug 28 19:31:40 2013 +0900 elm_bg: added a color reset feature. This can be achieved by calling elm_bg_color_set(bg, -1, -1, -1); you could also delete the obj if color == 0, 0, 0, 0 as that would be transparent... so = 0 should work in your code. -- Gustavo Sverzut Barbieri -- Mobile: +55 (19) 9225-2202 Contact: http://www.gustavobarbieri.com.br/contact -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_bg: added a color reset feature.
On Thu, Aug 29, 2013 at 1:26 AM, Gustavo Sverzut Barbieri barbi...@gmail.com wrote: On Wed, Aug 28, 2013 at 7:35 AM, Daniel Juyung Seo - Enlightenment Git no-re...@enlightenment.org wrote: seoz pushed a commit to branch master. commit 1286b98c1f52a070c09c2541ce8ab86fa90325dc Author: Daniel Juyung Seo seojuyu...@gmail.com Date: Wed Aug 28 19:31:40 2013 +0900 elm_bg: added a color reset feature. This can be achieved by calling elm_bg_color_set(bg, -1, -1, -1); you could also delete the obj if color == 0, 0, 0, 0 as that would be transparent... so = 0 should work in your code. There is no alpha value for the bg color set... -- Cedric BAIL -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_bg: added a color reset feature.
People can use simple rectangle if they wanna single bg color if they really need, we don't need to support this kind of unnecessary functions. -Regards, Hermet- -Original Message- From: Cedric BAILcedric.b...@free.fr To: Enlightenment developer listenlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-08-29 (목) 09:20:27 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_bg: added a color reset feature. On Thu, Aug 29, 2013 at 1:26 AM, Gustavo Sverzut Barbieri barbieri@gmail.com wrote: On Wed, Aug 28, 2013 at 7:35 AM, Daniel Juyung Seo - Enlightenment Git no-reply@enlightenment.org wrote: seoz pushed a commit to branch master. commit 1286b98c1f52a070c09c2541ce8ab86fa90325dc Author: Daniel Juyung Seo seojuyung2@gmail.com Date: Wed Aug 28 19:31:40 2013 +0900 elm_bg: added a color reset feature. This can be achieved by calling elm_bg_color_set(bg, -1, -1, -1); you could also delete the obj if color == 0, 0, 0, 0 as that would be transparent... so = 0 should work in your code. There is no alpha value for the bg color set... -- Cedric BAIL -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_bg: added a color reset feature.
On Thu, Aug 29, 2013 at 9:20 AM, Cedric BAIL cedric.b...@free.fr wrote: On Thu, Aug 29, 2013 at 1:26 AM, Gustavo Sverzut Barbieri barbi...@gmail.com wrote: On Wed, Aug 28, 2013 at 7:35 AM, Daniel Juyung Seo - Enlightenment Git no-re...@enlightenment.org wrote: seoz pushed a commit to branch master. commit 1286b98c1f52a070c09c2541ce8ab86fa90325dc Author: Daniel Juyung Seo seojuyu...@gmail.com Date: Wed Aug 28 19:31:40 2013 +0900 elm_bg: added a color reset feature. This can be achieved by calling elm_bg_color_set(bg, -1, -1, -1); you could also delete the obj if color == 0, 0, 0, 0 as that would be transparent... so = 0 should work in your code. There is no alpha value for the bg color set... Yes there is no alpha parameter in elm_bg_color_set(). That is why I used -1 as a reset value. Long time ago I asked why there is no alpha in bg to raster, and got a reply like no alpha is needed for bg. If we need alpha, we should use evas_object_rectangle. It would be good if we have alpha in elm_bg_color_set() but can't break API. We should deal with it. Thanks. Daniel Juyung Seo (SeoZ) -- Cedric BAIL -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_bg: added a color reset feature.
On Thu, Aug 29, 2013 at 5:06 AM, Daniel Juyung Seo seojuyu...@gmail.com wrote: On Thu, Aug 29, 2013 at 9:20 AM, Cedric BAIL cedric.b...@free.fr wrote: On Thu, Aug 29, 2013 at 1:26 AM, Gustavo Sverzut Barbieri barbi...@gmail.com wrote: On Wed, Aug 28, 2013 at 7:35 AM, Daniel Juyung Seo - Enlightenment Git no-re...@enlightenment.org wrote: seoz pushed a commit to branch master. commit 1286b98c1f52a070c09c2541ce8ab86fa90325dc Author: Daniel Juyung Seo seojuyu...@gmail.com Date: Wed Aug 28 19:31:40 2013 +0900 elm_bg: added a color reset feature. This can be achieved by calling elm_bg_color_set(bg, -1, -1, -1); you could also delete the obj if color == 0, 0, 0, 0 as that would be transparent... so = 0 should work in your code. There is no alpha value for the bg color set... Yes there is no alpha parameter in elm_bg_color_set(). That is why I used -1 as a reset value. Long time ago I asked why there is no alpha in bg to raster, and got a reply like no alpha is needed for bg. If we need alpha, we should use evas_object_rectangle. It would be good if we have alpha in elm_bg_color_set() but can't break API. We should deal with it. You can change it for the Eo API of elm if you want. -- Cedric BAIL -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_bg: added a color reset feature.
On Thu, Aug 29, 2013 at 12:13 PM, Cedric BAIL cedric.b...@free.fr wrote: On Thu, Aug 29, 2013 at 5:06 AM, Daniel Juyung Seo seojuyu...@gmail.com wrote: On Thu, Aug 29, 2013 at 9:20 AM, Cedric BAIL cedric.b...@free.fr wrote: On Thu, Aug 29, 2013 at 1:26 AM, Gustavo Sverzut Barbieri barbi...@gmail.com wrote: On Wed, Aug 28, 2013 at 7:35 AM, Daniel Juyung Seo - Enlightenment Git no-re...@enlightenment.org wrote: seoz pushed a commit to branch master. commit 1286b98c1f52a070c09c2541ce8ab86fa90325dc Author: Daniel Juyung Seo seojuyu...@gmail.com Date: Wed Aug 28 19:31:40 2013 +0900 elm_bg: added a color reset feature. This can be achieved by calling elm_bg_color_set(bg, -1, -1, -1); you could also delete the obj if color == 0, 0, 0, 0 as that would be transparent... so = 0 should work in your code. There is no alpha value for the bg color set... Yes there is no alpha parameter in elm_bg_color_set(). That is why I used -1 as a reset value. Long time ago I asked why there is no alpha in bg to raster, and got a reply like no alpha is needed for bg. If we need alpha, we should use evas_object_rectangle. It would be good if we have alpha in elm_bg_color_set() but can't break API. We should deal with it. You can change it for the Eo API of elm if you want. That's a good idea! In git. Thanks. Daniel Juyung Seo (SeoZ) -- Cedric BAIL -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
