[EGIT] [core/elementary] master 01/01: elm_widget: Fixed some codes about focus custom chain.

[WooHyun Jung]

woohyun pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=922aae2394959d20831fa07104f9265ca8a89946

commit 922aae2394959d20831fa07104f9265ca8a89946
Author: WooHyun Jung 
Date:   Wed Jan 22 16:24:25 2014 +0900

elm_widget: Fixed some codes about focus custom chain.

- When appending an object to the focus custom chain,
  event callback about deletion should be added.
- When a widget is deleted, its focus custom chain should be
  managed correctly.
---
 src/lib/elm_widget.c | 11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/lib/elm_widget.c b/src/lib/elm_widget.c
index 37859ae..80676f5 100644
--- a/src/lib/elm_widget.c
+++ b/src/lib/elm_widget.c
@@ -326,11 +326,12 @@ _elm_widget_smart_del(Eo *obj, void *_pd, va_list *list 
EINA_UNUSED)
  }
 
EINA_LIST_FREE(sd->event_cb, ecb)
- free(ecb);
+  free(ecb);
 
eina_stringshare_del(sd->style);
if (sd->theme) elm_theme_free(sd->theme);
_if_focused_revert(obj, EINA_TRUE);
+   elm_widget_focus_custom_chain_unset(obj);
eina_stringshare_del(sd->access_info);
evas_object_smart_data_set(obj, NULL);
 }
@@ -1983,8 +1984,8 @@ _elm_widget_focus_custom_chain_append(Eo *obj, void *_pd, 
va_list *list)
 
if (!_elm_widget_focus_chain_manager_is(obj)) return;
 
-   evas_object_event_callback_del_full(child, EVAS_CALLBACK_DEL,
-   _elm_object_focus_chain_del_cb, obj);
+   evas_object_event_callback_add(child, EVAS_CALLBACK_DEL,
+  _elm_object_focus_chain_del_cb, obj);
 
if (!relative_child)
  sd->focus_chain = eina_list_append(sd->focus_chain, child);
@@ -2029,8 +2030,8 @@ _elm_widget_focus_custom_chain_prepend(Eo *obj, void 
*_pd, va_list *list)
 
if (!_elm_widget_focus_chain_manager_is(obj)) return;
 
-   evas_object_event_callback_del_full(child, EVAS_CALLBACK_DEL,
-   _elm_object_focus_chain_del_cb, obj);
+   evas_object_event_callback_add(child, EVAS_CALLBACK_DEL,
+  _elm_object_focus_chain_del_cb, obj);
 
if (!relative_child)
  sd->focus_chain = eina_list_prepend(sd->focus_chain, child);

-- 

[EGIT] [apps/terminology] master 01/01: fix escaping of file in helper run in 1 missed case

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/apps/terminology.git/commit/?id=4891932c741726206fe8b4f89bd13bcbe5f2

commit 4891932c741726206fe8b4f89bd13bcbe5f2
Author: Carsten Haitzler (Rasterman) 
Date:   Wed Jan 22 15:44:57 2014 +0900

fix escaping of file in helper run in 1 missed case

this fixes T814
---
 src/bin/termio.c | 11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/bin/termio.c b/src/bin/termio.c
index 72b5b2b..dbd686e 100644
--- a/src/bin/termio.c
+++ b/src/bin/termio.c
@@ -740,10 +740,15 @@ _smart_media_clicked(void *data, Evas_Object *obj, void 
*info EINA_UNUSED)
  cmd = config->helper.local.general;
if (cmd)
  {
-char buf[PATH_MAX];
+char buf[PATH_MAX], *escaped;
 
-snprintf(buf, sizeof(buf), "%s %s", cmd, file);
-ecore_exe_run(buf, NULL);
+escaped = ecore_file_escape_name(file);
+if (escaped)
+  {
+ snprintf(buf, sizeof(buf), "%s %s", cmd, 
escaped);
+ ecore_exe_run(buf, NULL);
+ free(escaped);
+  }
 return;
  }
 }

-- 

[EGIT] [core/elementary] master 01/01: ctxpopup: Fixed typo and flourished comment.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=10caf2eb249cae35c10a7e5c94d738eba78c06cc

commit 10caf2eb249cae35c10a7e5c94d738eba78c06cc
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 15:17:45 2014 +0900

ctxpopup: Fixed typo and flourished comment.
---
 src/lib/elc_ctxpopup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/elc_ctxpopup.c b/src/lib/elc_ctxpopup.c
index 8a953c5..06ec1fb 100644
--- a/src/lib/elc_ctxpopup.c
+++ b/src/lib/elc_ctxpopup.c
@@ -257,8 +257,8 @@ _base_geometry_calc(Evas_Object *obj,
if ((min_size.x > 0) && (base_size.x < min_size.x))
  base_size.x = min_size.x;
 
-   //Check the Which direction is available.
-   //If find a available direction, it adjusts position and size.
+   //Check available directions. If there is one, it adjusts ctxpopup's 
position
+   // and size.
for (idx = 0; idx < 4; idx++)
  {
 switch (sd->dir_priority[idx])

-- 

[EGIT] [core/elementary] master 02/02: elm filesel - scale button in filesel button.

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=0c5633c3e3bc551c7f7873dc165b076ea919faab

commit 0c5633c3e3bc551c7f7873dc165b076ea919faab
Author: Carsten Haitzler (Rasterman) 
Date:   Wed Jan 22 15:19:17 2014 +0900

elm filesel - scale button in filesel button.
---
 data/themes/edc/elm/fileselector.edc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/data/themes/edc/elm/fileselector.edc 
b/data/themes/edc/elm/fileselector.edc
index cc21bee..78a06b5 100644
--- a/data/themes/edc/elm/fileselector.edc
+++ b/data/themes/edc/elm/fileselector.edc
@@ -191,12 +191,14 @@ group { name: "elm/fileselector_entry/base/default";
  }
   }
   part { name: "elm.swallow.button"; type: SWALLOW;
+ scale: 1;
  description { state: "default" 0.0;
 align: 1.0 0.0;
 fixed: 1 0;
+min: 40 4;
 rel1 {
relative: 1.0 0.0;
-   offset: -41 0;
+   offset: -1 0;
 }
  }
   }

-- 

[EGIT] [core/elementary] master 01/02: elm filesel - fix theme layout for button+entry

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=3766f8386d795bdee9f1986a7b97c29c98ef17ad

commit 3766f8386d795bdee9f1986a7b97c29c98ef17ad
Author: Carsten Haitzler (Rasterman) 
Date:   Wed Jan 22 15:17:47 2014 +0900

elm filesel - fix theme layout for button+entry
---
 data/themes/edc/elm/fileselector.edc | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/data/themes/edc/elm/fileselector.edc 
b/data/themes/edc/elm/fileselector.edc
index abd91b0..cc21bee 100644
--- a/data/themes/edc/elm/fileselector.edc
+++ b/data/themes/edc/elm/fileselector.edc
@@ -180,9 +180,10 @@ group { name: "elm/fileselector/base/default";
 group { name: "elm/fileselector_entry/base/default";
parts {
   part { name: "elm.swallow.entry"; type: SWALLOW;
+ scale: 1;
  description { state: "default" 0.0;
-align: 0.0 0.0;
-min: 50 10;
+align: 0.0 0.5;
+min: 50 4;
 rel2 { to_x: "elm.swallow.button";
relative: 0.0 1.0;
offset: -1 -1;
@@ -192,11 +193,10 @@ group { name: "elm/fileselector_entry/base/default";
   part { name: "elm.swallow.button"; type: SWALLOW;
  description { state: "default" 0.0;
 align: 1.0 0.0;
-min: 10 10;
 fixed: 1 0;
 rel1 {
relative: 1.0 0.0;
-   offset: -21 0;
+   offset: -41 0;
 }
  }
   }

-- 

[EGIT] [core/elementary] master 01/01: inwin - the "greying out" fade looks just wrong - make it black.

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=e6b4ba8cf16e896ce71f966e3e5214c3192a7a02

commit e6b4ba8cf16e896ce71f966e3e5214c3192a7a02
Author: Carsten Haitzler (Rasterman) 
Date:   Wed Jan 22 15:14:15 2014 +0900

inwin - the "greying out" fade looks just wrong - make it black.
---
 data/themes/edc/elm/inwin.edc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/data/themes/edc/elm/inwin.edc b/data/themes/edc/elm/inwin.edc
index ddf65c3..99e596b 100644
--- a/data/themes/edc/elm/inwin.edc
+++ b/data/themes/edc/elm/inwin.edc
@@ -9,7 +9,7 @@ group { name: "elm/win/inwin/default";
  }
  description { state: "visible" 0.0;
 inherit: "default" 0.0;
-color: 150 150 150 64;
+color: 0 0 0 128;
  }
   }
   part { name: "pop"; mouse_events: 1;

-- 

[EGIT] [apps/rage] master 01/01: rage - print usage when the command line parameter is missing.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/apps/rage.git/commit/?id=f2cb079642731874bf48fec76b2edb93ebd3179c

commit f2cb079642731874bf48fec76b2edb93ebd3179c
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 14:11:13 2014 +0900

rage - print usage when the command line parameter is missing.
---
 src/bin/main.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/bin/main.c b/src/bin/main.c
index a718c5c..cf13709 100644
--- a/src/bin/main.c
+++ b/src/bin/main.c
@@ -980,7 +980,12 @@ elm_main(int argc, char **argv)
int i;
Inf *inf;

-   if (argc <= 1) goto end;
+   if (argc <= 1)
+ {
+printf("Usage: rage {file-name}\n");
+goto end;
+ }
+
for (i = 1; i < argc; i++)
  {
 list = eina_list_append(list, eina_stringshare_add(argv[i]));

-- 

[EGIT] [core/elementary] master 01/01: fix some typos in comment and description

[Jihoon Kim]

jihoon pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=6848ca4827238f8a9755bcd9745b4cad63708a6e

commit 6848ca4827238f8a9755bcd9745b4cad63708a6e
Author: Jihoon Kim 
Date:   Wed Jan 22 13:20:15 2014 +0900

fix some typos in comment and description
---
 src/lib/elc_ctxpopup.c | 2 +-
 src/lib/elm_image.c| 2 +-
 src/lib/elm_map.c  | 6 +++---
 src/lib/elm_store.c| 6 +++---
 src/lib/elm_toolbar.c  | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/lib/elc_ctxpopup.c b/src/lib/elc_ctxpopup.c
index ee756f6..8a953c5 100644
--- a/src/lib/elc_ctxpopup.c
+++ b/src/lib/elc_ctxpopup.c
@@ -258,7 +258,7 @@ _base_geometry_calc(Evas_Object *obj,
  base_size.x = min_size.x;
 
//Check the Which direction is available.
-   //If find a avaialble direction, it adjusts position and size.
+   //If find a available direction, it adjusts position and size.
for (idx = 0; idx < 4; idx++)
  {
 switch (sd->dir_priority[idx])
diff --git a/src/lib/elm_image.c b/src/lib/elm_image.c
index 7db1947..7215b15 100644
--- a/src/lib/elm_image.c
+++ b/src/lib/elm_image.c
@@ -1808,7 +1808,7 @@ static const Eo_Op_Description op_desc[] = {
  EO_OP_DESCRIPTION(ELM_OBJ_IMAGE_SUB_ID_FILE_SET, "Set the file that will 
be used as the image's source."),
  EO_OP_DESCRIPTION(ELM_OBJ_IMAGE_SUB_ID_FILE_GET, "Get the file that will 
be used as image."),
 
- EO_OP_DESCRIPTION(ELM_OBJ_IMAGE_SUB_ID_SIZING_EVAL, "'Virtual' function 
on evalutating the object's final geometry."),
+ EO_OP_DESCRIPTION(ELM_OBJ_IMAGE_SUB_ID_SIZING_EVAL, "'Virtual' function 
on evaluating the object's final geometry."),
 
  EO_OP_DESCRIPTION(ELM_OBJ_IMAGE_SUB_ID_SMOOTH_SCALE_SET, "'Virtual' 
function on setting whether the object's image should be scaled smoothly or 
not."),
  EO_OP_DESCRIPTION(ELM_OBJ_IMAGE_SUB_ID_SMOOTH_SCALE_GET, "'Virtual' 
function on retrieving whether the object's image is to scaled smoothly or 
not."),
diff --git a/src/lib/elm_map.c b/src/lib/elm_map.c
index eb579d1..0b92054 100644
--- a/src/lib/elm_map.c
+++ b/src/lib/elm_map.c
@@ -1089,7 +1089,7 @@ _zoom_do(Elm_Map_Smart_Data *sd,
sd->size.h = sd->size.w;
 
// Fix to zooming with (viewport center vx, vy) as the center to prevent
-   // from zooming with (0,0) as the cetner. (scroller default behavior)
+   // from zooming with (0,0) as the center. (scroller default behavior)
_viewport_coord_get(sd, &vx, &vy, &vw, &vh);
if ((vw > 0) && (vh > 0) && (ow > 0) && (oh > 0))
  {
@@ -1375,7 +1375,7 @@ _icon_dup(Evas_Object *icon,
if (!icon || !parent) return NULL;
dupp = evas_object_image_filled_add(evas_object_evas_get(parent));
evas_object_image_source_set(dupp, icon);
-   // Set size as origin' sizse for proxy
+   // Set size as origin' size for proxy
evas_object_geometry_get(icon, NULL, NULL, &w, &h);
if (w <= 0 || h <= 0)
  {
@@ -2581,7 +2581,7 @@ _overlay_place(Elm_Map_Smart_Data *sd)
   _overlay_bubble_coord_update(overlay->ovl);
  }
 
-   // Classify into group boss or follwer
+   // Classify into group boss or follower
EINA_LIST_FOREACH(sd->overlays, l, overlay)
  {
 Elm_Map_Overlay *boss;
diff --git a/src/lib/elm_store.c b/src/lib/elm_store.c
index fda2e0b..cd7bb22 100644
--- a/src/lib/elm_store.c
+++ b/src/lib/elm_store.c
@@ -144,7 +144,7 @@ _store_genlist_del(void *data, Evas *e EINA_UNUSED, 
Evas_Object *obj EINA_UNUSED
 //  WARNING ***
    * This function runs inside a thread outside efl mainloop. Be careful! *
 // 
-/* TODO: refactor lock part into core? this does not depend on filesystm part 
*/
+/* TODO: refactor lock part into core? this does not depend on filesystem part 
*/
 static void
 _store_filesystem_fetch_do(void *data, Ecore_Thread *th EINA_UNUSED)
 {
@@ -169,7 +169,7 @@ _store_filesystem_fetch_do(void *data, Ecore_Thread *th 
EINA_UNUSED)
 // 
    * End of separate thread function. *
 // 
-/* TODO: refactor lock part into core? this does not depend on filesystm part 
*/
+/* TODO: refactor lock part into core? this does not depend on filesystem part 
*/
 static void
 _store_filesystem_fetch_end(void *data, Ecore_Thread *th)
 {
@@ -180,7 +180,7 @@ _store_filesystem_fetch_end(void *data, Ecore_Thread *th)
if (th == sti->fetch_th) sti->fetch_th = NULL;
 }
 
-/* TODO: refactor lock part into core? this does not depend on filesystm part 
*/
+/* TODO: refactor lock part into core? this does not depend on filesystem part 
*/
 static void
 _store_filesystem_fetch_cancel(void *data, Ecore_Thread *th)
 {
diff --git a/src/lib/elm_toolbar.c b/src/lib/elm_toolbar.c
index

[EGIT] [core/elementary] master 01/02: config: Added more description about elm_config_indicator_service_get().

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=e6ae0898501cac239a648725e896b50c6cac693b

commit e6ae0898501cac239a648725e896b50c6cac693b
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 12:07:55 2014 +0900

config: Added more description about elm_config_indicator_service_get().
---
 src/lib/elm_config.h | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/lib/elm_config.h b/src/lib/elm_config.h
index 5ddb0c2..d878fc4 100644
--- a/src/lib/elm_config.h
+++ b/src/lib/elm_config.h
@@ -1206,9 +1206,14 @@ EAPI void  elm_config_clouseau_enabled_set(Eina_Bool 
enabled);
 /**
  * Get the indicator service name according to the rotation degree.
  *
- * @param rotation The rotation which related with the indicator service name, 
in degrees (0-360),
+ * @param rotation The rotation which related with the indicator service name,
+ * in degrees (0-360),
  *
- * @return The indicator service name according to the rotation degree.
+ * @return The indicator service name according to the rotation degree. The
+ * indicator service name can be either @c "elm_indicator_portrait" or
+ * @c "elm_indicator_landscape".
+ *
+ * @note Do not free the return string.
  */
 EAPI const char *elm_config_indicator_service_get(int rotation);
 

-- 

[EGIT] [core/elementary] master 02/02: test_conform_indicator: Refactor internal code of conform_indicator test code.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=8e178f2cabddc689da418cb888bbd8d87d6246f5

commit 8e178f2cabddc689da418cb888bbd8d87d6246f5
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 12:32:32 2014 +0900

test_conform_indicator: Refactor internal code of conform_indicator test
code.

- removed unnecessary casting.
- removed unnecessary internal variables.
- removed wrong window resize object addition.
- changed parent parameter correctly.
- fixed wrong grammar in command line message.
- fixed resource leak.
- enhanced comments.
- removed unnecessary size hint align set.
- removed unnecessary parameter passing.
---
 src/bin/test_conform_indicator.c | 65 
 1 file changed, 33 insertions(+), 32 deletions(-)

diff --git a/src/bin/test_conform_indicator.c b/src/bin/test_conform_indicator.c
index 8cda21b..d7c13b9 100644
--- a/src/bin/test_conform_indicator.c
+++ b/src/bin/test_conform_indicator.c
@@ -51,8 +51,9 @@ _rot_270(void *data, Evas_Object *obj EINA_UNUSED, void 
*event_info EINA_UNUSED)
 static void
 _visible_change_cb(void *data, Evas_Object *obj EINA_UNUSED, void *event_info 
EINA_UNUSED)
 {
-   printf("visible change before=%d\n",vis);
-   Evas_Object *win = (Evas_Object *) data;
+   Evas_Object *win = data;
+
+   printf("visible change before = %d\n", vis);
if (vis == 0)
  {
 elm_win_indicator_mode_set(win, ELM_WIN_INDICATOR_SHOW);
@@ -63,8 +64,9 @@ _visible_change_cb(void *data, Evas_Object *obj EINA_UNUSED, 
void *event_info EI
 elm_win_indicator_mode_set(win, ELM_WIN_INDICATOR_HIDE);
 vis = 0;
  }
+
/*Add App code here*/
-   printf("visible change after=%d\n",vis);
+   printf("visible change after = %d\n", vis);
 }
 
 static void
@@ -74,8 +76,6 @@ _launch_conformant_indicator_window_btn_cb(void *data 
EINA_UNUSED,
 {
Evas_Object *win, *conform, *bt, *bx;
Evas_Object *plug_port = NULL, *plug_land = NULL;
-   char *svr_name_port = "elm_indicator_portrait";
-   char *svr_name_land = "elm_indicator_landscape";
 
win = elm_win_util_standard_add("conformant-indicator",
"Conformant Indicator");
@@ -89,11 +89,10 @@ _launch_conformant_indicator_window_btn_cb(void *data 
EINA_UNUSED,
evas_object_show(conform);
 
bx = elm_box_add(conform);
-   evas_object_size_hint_weight_set(bx, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
-   elm_win_resize_object_add(win, bx);
+   elm_object_content_set(conform, bx);
evas_object_show(bx);
 
-   bt = elm_button_add(win);
+   bt = elm_button_add(bx);
elm_object_text_set(bt, "Rot 0");
evas_object_smart_callback_add(bt, "clicked", _rot_0, win);
evas_object_size_hint_weight_set(bt, EVAS_HINT_EXPAND, 0.0);
@@ -101,7 +100,7 @@ _launch_conformant_indicator_window_btn_cb(void *data 
EINA_UNUSED,
elm_box_pack_end(bx, bt);
evas_object_show(bt);
 
-   bt = elm_button_add(win);
+   bt = elm_button_add(bx);
elm_object_text_set(bt, "Rot 90");
evas_object_smart_callback_add(bt, "clicked", _rot_90, win);
evas_object_size_hint_weight_set(bt, EVAS_HINT_EXPAND, 0.0);
@@ -109,7 +108,7 @@ _launch_conformant_indicator_window_btn_cb(void *data 
EINA_UNUSED,
elm_box_pack_end(bx, bt);
evas_object_show(bt);
 
-   bt = elm_button_add(win);
+   bt = elm_button_add(bx);
elm_object_text_set(bt, "Rot 180");
evas_object_smart_callback_add(bt, "clicked", _rot_180, win);
evas_object_size_hint_weight_set(bt, EVAS_HINT_EXPAND, 0.0);
@@ -117,7 +116,7 @@ _launch_conformant_indicator_window_btn_cb(void *data 
EINA_UNUSED,
elm_box_pack_end(bx, bt);
evas_object_show(bt);
 
-   bt = elm_button_add(win);
+   bt = elm_button_add(bx);
elm_object_text_set(bt, "Rot 270");
evas_object_smart_callback_add(bt, "clicked", _rot_270, win);
evas_object_size_hint_weight_set(bt, EVAS_HINT_EXPAND, 0.0);
@@ -126,16 +125,18 @@ _launch_conformant_indicator_window_btn_cb(void *data 
EINA_UNUSED,
evas_object_show(bt);
 
/* portrait plug */
-   plug_port = elm_plug_add(win);
+   plug_port = elm_plug_add(bx);
if (!plug_port)
  {
-printf("fail to create plug to server[%s]\n", svr_name_port);
+printf("fail to create plug to server [elm_indicator_portrait]\n");
+evas_object_del(win);
 return;
  }
 
-   if (!elm_plug_connect(plug_port, svr_name_port, 0, EINA_FALSE))
+   if (!elm_plug_connect(plug_port, "elm_indicator_portrait", 0, EINA_FALSE))
  {
-printf("fail to connect to server[%s]\n", svr_name_port);
+printf("fail to connect to server [elm_indicator_portraits]\n");
+evas_object_del(win);
 return;
  }
evas_object_size_hint_weight_set(plug_port, EVAS_HINT_EXPAND, 
EVAS_HINT_EXPAND);
@@ -144,15 +145,17 @@ _launch_conformant_indicator_window_btn_cb(void *data 
EINA_UNUSED,
elm_box_pack_end(bx, plug_port);
 
/* landscape plug */
-   plug_lan

[EGIT] [core/enlightenment] master 01/01: shot - check zone null before using

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=8285b8ea6b2c5bfd60b60c9cedc4879ee7cb830b

commit 8285b8ea6b2c5bfd60b60c9cedc4879ee7cb830b
Author: Carsten Haitzler (Rasterman) 
Date:   Wed Jan 22 12:27:00 2014 +0900

shot - check zone null before using
---
 src/modules/shot/e_mod_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/modules/shot/e_mod_main.c b/src/modules/shot/e_mod_main.c
index 93171e6..718f748 100644
--- a/src/modules/shot/e_mod_main.c
+++ b/src/modules/shot/e_mod_main.c
@@ -840,7 +840,7 @@ _shot_now(E_Zone *zone, E_Client *ec, const char *params)
 if (sscanf(params, "%100s %100s %100s", smode, squal, sscreen) == 3)
   {
  screen = -1;
- if (!strcmp(sscreen, "current")) screen = zone->num;
+ if ((zone) && (!strcmp(sscreen, "current"))) screen = zone->num;
  else if (!strcmp(sscreen, "all")) screen = -1;
  else screen = atoi(sscreen);
  

-- 

[EGIT] [core/efl] master 01/01: eina: do not access dead pointer from within valgrind macro.

[Cedric BAIL]

cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=938aba36eb2e7fbd83ff7ee46b1b713cc8a46c32

commit 938aba36eb2e7fbd83ff7ee46b1b713cc8a46c32
Author: Cedric BAIL 
Date:   Wed Jan 22 12:21:43 2014 +0900

eina: do not access dead pointer from within valgrind macro.
---
 src/modules/eina/mp/one_big/eina_one_big.c | 12 
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/modules/eina/mp/one_big/eina_one_big.c 
b/src/modules/eina/mp/one_big/eina_one_big.c
index e384e52..4bfe2a8 100644
--- a/src/modules/eina/mp/one_big/eina_one_big.c
+++ b/src/modules/eina/mp/one_big/eina_one_big.c
@@ -160,6 +160,10 @@ eina_one_big_free(void *data, void *ptr)
  {
 eina_trash_push(&pool->empty, ptr);
 pool->usage--;
+
+#ifndef NVALGRIND
+VALGRIND_MEMPOOL_FREE(pool, ptr);
+#endif
  }
else
  {
@@ -178,13 +182,13 @@ eina_one_big_free(void *data, void *ptr)
 #endif
 
 pool->over_list = eina_inlist_remove(pool->over_list, il);
-free(ptr);
-pool->over--;
- }
 
 #ifndef NVALGRIND
-   VALGRIND_MEMPOOL_FREE(pool, ptr);
+VALGRIND_MEMPOOL_FREE(pool, ptr);
 #endif
+free(ptr);
+pool->over--;
+ }
 
eina_lock_release(&pool->mutex);
 }

-- 

[EGIT] [core/elementary] master 01/01: entry: Fixed to emit "*enabled" signal to scr_edje when it is not disabled.

[Youngbok Shin]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=a6f2538609f312a27aadb25c294c489fdba27448

commit a6f2538609f312a27aadb25c294c489fdba27448
Author: Youngbok Shin 
Date:   Wed Jan 22 11:32:08 2014 +0900

entry: Fixed to emit "*enabled" signal to scr_edje when it is not disabled.

Summary: This fixes coverity issue CID 1162751.

Reviewers: seoz, woohyun, tasn

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D482
---
 src/lib/elm_entry.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
index c34a31b..b5a3359 100644
--- a/src/lib/elm_entry.c
+++ b/src/lib/elm_entry.c
@@ -529,7 +529,7 @@ _elm_entry_smart_disable(Eo *obj, void *_pd, va_list *list)
 edje_object_signal_emit(sd->entry_edje, "elm,state,enabled", "elm");
 if (sd->scroll)
   {
- edje_object_signal_emit(sd->scr_edje, "elm,state,disabled", 
"elm");
+ edje_object_signal_emit(sd->scr_edje, "elm,state,enabled", "elm");
  eo_do(obj, elm_scrollable_interface_freeze_set(EINA_FALSE));
   }
 sd->disabled = EINA_FALSE;

-- 

Re: [E-devel] dev access for entrance for marcel hollerbach?

[Daniel Juyung Seo]

Great :)

So.. now it's time to make entrance commit atomic and more readable?
The time has come earlier than I expected.

Daniel Juyung Seo (SeoZ)



On Sat, Jan 18, 2014 at 4:25 AM, Andy Williams  wrote:

> Agreed! His help has been great already.
>
> Andy
>
> Sent from my iPhone
>
> > On 17 Jan 2014, at 05:46 pm, Chris Michael 
> wrote:
> >
> >> On 17/01/14 06:16, Carsten Haitzler (The Rasterman) wrote:
> >> marcel (bu5hm4n) seems to be quite active - especially on entrance.
> anyone
> >> object to giving him access for the purposes of working on entrance?
> >
> > No objections ...
> >
> > Would be nice to have a working Entrance :)
> >
> > dh
> >
> >
> >
> --
> > CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> > Learn Why More Businesses Are Choosing CenturyLink Cloud For
> > Critical Workloads, Development Environments & Everything In Between.
> > Get a Quote or Start a Free Trial Today.
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
> --
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/elementary] master 06/08: elm: Removed unnecessary null check for free.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=f873373e587b009169679d970e6712d07c3521b9

commit f873373e587b009169679d970e6712d07c3521b9
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 11:08:47 2014 +0900

elm: Removed unnecessary null check for free.
---
 src/lib/elc_fileselector_entry.c |  4 ++--
 src/lib/elm_access.c |  6 +++---
 src/lib/elm_cnp.c| 26 ++
 src/lib/elm_config.c |  2 +-
 src/lib/elm_dbus_menu.c  |  3 +--
 src/lib/elm_entry.c  | 29 ++---
 src/lib/elm_flip.c   |  3 +--
 src/lib/elm_image.c  |  6 +++---
 src/lib/elm_main.c   |  8 ++--
 src/lib/elm_map.c| 14 +++---
 src/lib/elm_photocam.c   |  7 +++
 src/lib/elm_prefs_data.c |  6 ++
 src/lib/elm_store.c  |  4 ++--
 src/lib/elm_transit.c|  8 +++-
 src/lib/elm_widget.c |  3 +--
 src/lib/elm_win.c|  4 ++--
 16 files changed, 53 insertions(+), 80 deletions(-)

diff --git a/src/lib/elc_fileselector_entry.c b/src/lib/elc_fileselector_entry.c
index 05e9a68..0431189 100644
--- a/src/lib/elc_fileselector_entry.c
+++ b/src/lib/elc_fileselector_entry.c
@@ -397,7 +397,7 @@ _elm_fileselector_entry_smart_del(Eo *obj, void *_pd, 
va_list *list EINA_UNUSED)
 {
Elm_Fileselector_Entry_Smart_Data *sd = _pd;
 
-   if (sd->path) free(sd->path);
+   free(sd->path);
 
eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
 }
@@ -569,7 +569,7 @@ _path_get(Eo *obj EINA_UNUSED, void *_pd, va_list *list)
const char **ret = va_arg(*list, const char **);
Elm_Fileselector_Entry_Smart_Data *sd = _pd;
 
-   if (sd->path) free(sd->path);
+   free(sd->path);
sd->path = elm_entry_markup_to_utf8(elm_object_text_get(sd->entry));
*ret = sd->path;
 }
diff --git a/src/lib/elm_access.c b/src/lib/elm_access.c
index 3fe5a1c..b9dd1de 100644
--- a/src/lib/elm_access.c
+++ b/src/lib/elm_access.c
@@ -68,7 +68,7 @@ _access_action_callback_call(Evas_Object *obj,
if (a && (a->fn[type].cb))
  ret = a->fn[type].cb(a->fn[type].user_data, obj, action_info);
 
-   if (ai) free(ai);
+   free(ai);
 
return ret;
 }
@@ -738,7 +738,7 @@ _elm_access_read(Elm_Access_Info *ac, int type, const 
Evas_Object *obj)
}
   }
  }
-   if (txt) free(txt);
+   free(txt);
 }
 
 EAPI void
@@ -1118,7 +1118,7 @@ _elm_access_object_unregister(Evas_Object *obj, 
Evas_Object *hoverobj)
Action_Info *a;
a = evas_object_data_get(obj, "_elm_access_action_info");
evas_object_data_del(obj,  "_elm_access_action_info");
-   if (a) free(a);
+   free(a);
 }
 
 EAPI void
diff --git a/src/lib/elm_cnp.c b/src/lib/elm_cnp.c
index daca9fb..5efcd05 100644
--- a/src/lib/elm_cnp.c
+++ b/src/lib/elm_cnp.c
@@ -936,7 +936,7 @@ _x11_notify_handler_uri(X11_Cnp_Selection *sel, 
Ecore_X_Event_Selection_Notify *
 cnp_debug("Couldn't find a file\n");
 return 0;
  }
-   if (savedtypes.imgfile) free(savedtypes.imgfile);
+   free(savedtypes.imgfile);
if (savedtypes.textreq)
  {
 savedtypes.textreq = 0;
@@ -1270,7 +1270,7 @@ _x11_dnd_enter(void *data EINA_UNUSED, int etype 
EINA_UNUSED, void *ev)
 
cnp_debug("Types\n");
savedtypes.ntypes = enter->num_types;
-   if (savedtypes.types) free(savedtypes.types);
+   free(savedtypes.types);
savedtypes.types = malloc(sizeof(char *) * enter->num_types);
if (!savedtypes.types) return EINA_FALSE;
 
@@ -1284,8 +1284,7 @@ _x11_dnd_enter(void *data EINA_UNUSED, int etype 
EINA_UNUSED, void *ev)
  /* Request it, so we know what it is */
  cnp_debug("Sending uri request\n");
  savedtypes.textreq = 1;
- if (savedtypes.imgfile) free(savedtypes.imgfile);
- savedtypes.imgfile = NULL;
+ ELM_SAFE_FREE(savedtypes.imgfile, free);
  ecore_x_selection_xdnd_request(enter->win, text_uri);
   }
  }
@@ -2303,7 +2302,7 @@ _wl_elm_cnp_selection_set(Evas_Object *obj, Elm_Sel_Type 
selection, Elm_Sel_Form
 
  ecore_wl_dnd_selection_set(ecore_wl_input_get(), types);
 
- if (sel->selbuf) free(sel->selbuf);
+ free(sel->selbuf);
  sel->buflen = buflen;
  sel->selbuf = strdup((char*)selbuf);
 
@@ -2658,8 +2657,7 @@ _wl_elm_drop_target_del(Evas_Object *obj, Elm_Sel_Format 
format,
   {
  drops = eina_list_remove(drops, dropable);
  eo_do(obj, eo_base_data_del("__elm_dropable"));
- free(dropable);
- dropable = NULL;
+ ELM_SAFE_FREE(dropable, free);
  evas_object_event_callback_del(obj, EVAS_CALLBACK_DEL,
_all_drop_targets_cbs_del);
   }
@@ -2708,7 +2706,7 @@ _wl_elm_drag_start(Evas_Object *obj, Elm_Sel_Format 
format EINA_UNUSED, const ch
ecore_wl_dnd_drag_ty

[EGIT] [core/elementary] master 07/08: elm: Removed unnecessary null check for eina_hash_free and elm_widget_stringlist_free.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=ac5d368b190eaa7920d43bd9253adf5c13e84340

commit ac5d368b190eaa7920d43bd9253adf5c13e84340
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 11:13:30 2014 +0900

elm: Removed unnecessary null check for eina_hash_free and
elm_widget_stringlist_free.
---
 src/lib/elm_module.c| 6 ++
 src/lib/elm_slideshow.c | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/lib/elm_module.c b/src/lib/elm_module.c
index f0e0903..777ea6c 100644
--- a/src/lib/elm_module.c
+++ b/src/lib/elm_module.c
@@ -56,12 +56,10 @@ _elm_module_shutdown(void)
 
 EINA_LIST_FREE(tl, m) _elm_module_del(m);
 
-eina_hash_free(modules);
-modules = NULL;
+ELM_SAFE_FREE(modules, eina_hash_free);
  }
 
-   if (modules_as) eina_hash_free(modules_as);
-   modules_as = NULL;
+   ELM_SAFE_FREE(modules_as, eina_hash_free);
 }
 
 void
diff --git a/src/lib/elm_slideshow.c b/src/lib/elm_slideshow.c
index 746f1de..f2eb4d2 100644
--- a/src/lib/elm_slideshow.c
+++ b/src/lib/elm_slideshow.c
@@ -354,7 +354,7 @@ _elm_slideshow_smart_del(Eo *obj, void *_pd, va_list *list 
EINA_UNUSED)
const char *layout;
 
elm_slideshow_clear(obj);
-   if (sd->transitions) elm_widget_stringlist_free(sd->transitions);
+   elm_widget_stringlist_free(sd->transitions);
ecore_timer_del(sd->timer);
 
EINA_LIST_FREE(sd->layout.list, layout)

-- 

[EGIT] [core/elementary] master 08/08: elm: Removed unnecessary null checks.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=7d689a4121779c0f456c68561ccfce5534c35820

commit 7d689a4121779c0f456c68561ccfce5534c35820
Merge: b2842f5 ac5d368
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 11:14:23 2014 +0900

elm: Removed unnecessary null checks.

As all efl public free apis  and free function get null as valid parameter,
we do not need to check null. I also used ELM_SAFE_FREE if necessary.
After this job code got cleaner.

This is a continue of a commit e3372339.

 src/lib/elc_ctxpopup.c | 14 +++--
 src/lib/elc_fileselector.c | 12 
 src/lib/elc_fileselector_button.c  |  6 ++--
 src/lib/elc_fileselector_entry.c   |  4 +--
 src/lib/elc_hoversel.c |  3 +-
 src/lib/elc_multibuttonentry.c | 10 +++
 src/lib/elc_naviframe.c|  8 ++---
 src/lib/elc_player.c   |  3 +-
 src/lib/elc_popup.c| 22 +-
 src/lib/elm_access.c   | 10 +++
 src/lib/elm_atspi_object.c |  4 +--
 src/lib/elm_bg.c   |  6 +---
 src/lib/elm_clock.c| 14 ++---
 src/lib/elm_cnp.c  | 26 +++--
 src/lib/elm_colorselector.c| 31 +++-
 src/lib/elm_config.c   | 31 ++--
 src/lib/elm_conform.c  |  2 +-
 src/lib/elm_dbus_menu.c|  6 ++--
 src/lib/elm_diskselector.c | 25 
 src/lib/elm_entry.c| 49 ---
 src/lib/elm_factory.c  |  2 +-
 src/lib/elm_flip.c |  5 ++--
 src/lib/elm_font.c |  8 ++---
 src/lib/elm_gengrid.c  |  2 +-
 src/lib/elm_genlist.c  | 26 +++--
 src/lib/elm_glview.c   | 11 ++-
 src/lib/elm_hover.c|  8 +
 src/lib/elm_icon.c | 12 +++-
 src/lib/elm_image.c| 14 -
 src/lib/elm_index.c| 21 +
 src/lib/elm_interface_scrollable.c | 28 --
 src/lib/elm_list.c |  6 +---
 src/lib/elm_main.c | 32 +++-
 src/lib/elm_map.c  | 60 +++---
 src/lib/elm_mapbuf.c   |  5 ++--
 src/lib/elm_menu.c | 23 +++
 src/lib/elm_module.c   |  6 ++--
 src/lib/elm_notify.c   |  2 +-
 src/lib/elm_photocam.c | 16 --
 src/lib/elm_prefs.c| 10 +++
 src/lib/elm_prefs_data.c   |  6 ++--
 src/lib/elm_progressbar.c  |  2 +-
 src/lib/elm_scroller.c |  2 +-
 src/lib/elm_segment_control.c  |  6 ++--
 src/lib/elm_slideshow.c|  5 ++--
 src/lib/elm_store.c|  4 +--
 src/lib/elm_theme.c|  2 +-
 src/lib/elm_thumb.c| 23 ---
 src/lib/elm_toolbar.c  | 23 +--
 src/lib/elm_transit.c  |  8 ++---
 src/lib/elm_widget.c   | 17 +--
 src/lib/elm_win.c  | 30 +++
 src/lib/els_cursor.c   | 12 ++--
 src/lib/els_tooltip.c  |  3 +-
 54 files changed, 267 insertions(+), 459 deletions(-)

-- 

[EGIT] [core/elementary] master 01/08: elm: Removed unnecessary null check for ecore_idler_del, ecore_idle_enterer_del.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=e64f4ff0ffb65a26c96bec98a3f9b728bab87b26

commit e64f4ff0ffb65a26c96bec98a3f9b728bab87b26
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 09:55:58 2014 +0900

elm: Removed unnecessary null check for ecore_idler_del, 
ecore_idle_enterer_del.
---
 src/lib/elc_fileselector.c |  6 +++---
 src/lib/elm_dbus_menu.c|  3 +--
 src/lib/elm_diskselector.c | 19 +++
 src/lib/elm_genlist.c  |  2 +-
 src/lib/elm_glview.c   | 11 +++
 src/lib/elm_interface_scrollable.c | 22 +-
 src/lib/elm_map.c  |  2 +-
 src/lib/elm_mapbuf.c   |  3 +--
 src/lib/elm_theme.c|  2 +-
 9 files changed, 19 insertions(+), 51 deletions(-)

diff --git a/src/lib/elc_fileselector.c b/src/lib/elc_fileselector.c
index ab6f051..49bfbd3 100644
--- a/src/lib/elc_fileselector.c
+++ b/src/lib/elc_fileselector.c
@@ -46,9 +46,9 @@ static const Evas_Smart_Cb_Description _smart_callbacks[] = {
 static void
 _elm_fileselector_smart_del_do(Elm_Fileselector_Smart_Data *sd)
 {
-   if (sd->path) eina_stringshare_del(sd->path);
-   if (sd->selection) eina_stringshare_del(sd->selection);
-   if (sd->populate_idler) free(ecore_idler_del(sd->populate_idler));
+   eina_stringshare_del(sd->path);
+   eina_stringshare_del(sd->selection);
+   free(ecore_idler_del(sd->populate_idler));
 
eo_do_super(sd->obj, MY_CLASS, evas_obj_smart_del());
 }
diff --git a/src/lib/elm_dbus_menu.c b/src/lib/elm_dbus_menu.c
index 088bb32..b70b132 100644
--- a/src/lib/elm_dbus_menu.c
+++ b/src/lib/elm_dbus_menu.c
@@ -920,8 +920,7 @@ _elm_dbus_menu_unregister(Eo *obj)
  _elm_dbus_menu_app_menu_unregister(obj);
eldbus_service_interface_unregister(sd->dbus_menu->iface);
eldbus_connection_unref(sd->dbus_menu->bus);
-   if (sd->dbus_menu->signal_idler)
- ecore_idler_del(sd->dbus_menu->signal_idler);
+   ecore_idler_del(sd->dbus_menu->signal_idler);
 
eina_hash_free(sd->dbus_menu->elements);
free(sd->dbus_menu);
diff --git a/src/lib/elm_diskselector.c b/src/lib/elm_diskselector.c
index b259083..077ef43 100644
--- a/src/lib/elm_diskselector.c
+++ b/src/lib/elm_diskselector.c
@@ -226,11 +226,7 @@ _string_check(void *data)
Evas_Object *obj = data;
ELM_DISKSELECTOR_DATA_GET(obj, sd);
 
-   if (sd->string_check_idle_enterer)
- {
-ecore_idle_enterer_del(sd->string_check_idle_enterer);
-sd->string_check_idle_enterer = NULL;
- }
+   ELM_SAFE_FREE(sd->string_check_idle_enterer, ecore_idle_enterer_del);
 
// call string check idle enterer directly
_string_check_idle_enterer_cb(data);
@@ -1421,17 +1417,8 @@ _elm_diskselector_smart_del(Eo *obj, void *_pd, va_list 
*list EINA_UNUSED)
  }
sd->r_items = eina_list_free(sd->r_items);
 
-   if (sd->scroller_move_idle_enterer)
- {
-ecore_idle_enterer_del(sd->scroller_move_idle_enterer);
-sd->scroller_move_idle_enterer = NULL;
- }
-
-   if (sd->string_check_idle_enterer)
- {
-ecore_idle_enterer_del(sd->string_check_idle_enterer);
-sd->string_check_idle_enterer = NULL;
- }
+   ELM_SAFE_FREE(sd->scroller_move_idle_enterer, ecore_idle_enterer_del);
+   ELM_SAFE_FREE(sd->string_check_idle_enterer, ecore_idle_enterer_del);
 
eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
 }
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index 8b7cf6a..3f15d67 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -4012,7 +4012,7 @@ _item_idle_enterer(void *data)
 static void
 _requeue_idle_enterer(Elm_Genlist_Smart_Data *sd)
 {
-   if (sd->queue_idle_enterer) ecore_idle_enterer_del(sd->queue_idle_enterer);
+   ecore_idle_enterer_del(sd->queue_idle_enterer);
sd->queue_idle_enterer = ecore_idle_enterer_add(_item_idle_enterer, 
sd->obj);
 }
 
diff --git a/src/lib/elm_glview.c b/src/lib/elm_glview.c
index 766fa44..8dccb85 100644
--- a/src/lib/elm_glview.c
+++ b/src/lib/elm_glview.c
@@ -171,12 +171,8 @@ _set_render_policy_callback(Evas_Object *obj)
switch (sd->render_policy)
  {
   case ELM_GLVIEW_RENDER_POLICY_ON_DEMAND:
-// Delete idle_enterer if it for some reason is around
-if (sd->render_idle_enterer)
-  {
- ecore_idle_enterer_del(sd->render_idle_enterer);
- sd->render_idle_enterer = NULL;
-  }
+ // Delete idle_enterer if it for some reason is around
+ ELM_SAFE_FREE(sd->render_idle_enterer, ecore_idle_enterer_del);
 
 // Set pixel getter callback
 evas_object_image_pixels_get_callback_set
@@ -267,8 +263,7 @@ _elm_glview_smart_del(Eo *obj, void *_pd, va_list *list 
EINA_UNUSED)
 sd->del_func(obj);
  }
 
-   if (sd->render_idle_enterer)
- ecore_idle_enterer_del(sd->render_idle_enterer);
+   ecore_idle_enterer_del(sd->render_idle_enterer);
 
if (sd->surface) evas_gl_surface_destroy(sd

[EGIT] [core/elementary] master 02/08: elm: Removed unnecessary null check for eina_stringshare_del.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=647dc0432b2de4e342e39c55ae538e46384cc011

commit 647dc0432b2de4e342e39c55ae538e46384cc011
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 10:12:44 2014 +0900

elm: Removed unnecessary null check for eina_stringshare_del.
---
 src/lib/elc_fileselector_button.c |  6 +++---
 src/lib/elc_multibuttonentry.c| 10 +-
 src/lib/elc_popup.c   |  4 +---
 src/lib/elm_access.c  |  4 ++--
 src/lib/elm_atspi_object.c|  4 ++--
 src/lib/elm_colorselector.c   |  8 
 src/lib/elm_config.c  | 26 +-
 src/lib/elm_entry.c   | 11 +--
 src/lib/elm_font.c|  8 
 src/lib/elm_genlist.c |  8 
 src/lib/elm_icon.c|  2 +-
 src/lib/elm_image.c   |  6 ++
 src/lib/elm_main.c| 18 ++
 src/lib/elm_map.c | 12 ++--
 src/lib/elm_menu.c| 16 
 src/lib/elm_progressbar.c |  2 +-
 src/lib/elm_segment_control.c |  4 ++--
 src/lib/elm_thumb.c   | 20 +---
 src/lib/elm_widget.c  | 11 +--
 src/lib/elm_win.c |  8 
 20 files changed, 83 insertions(+), 105 deletions(-)

diff --git a/src/lib/elc_fileselector_button.c 
b/src/lib/elc_fileselector_button.c
index 363c9a3..40c12b5 100644
--- a/src/lib/elc_fileselector_button.c
+++ b/src/lib/elc_fileselector_button.c
@@ -201,9 +201,9 @@ _elm_fileselector_button_smart_del(Eo *obj, void *_pd, 
va_list *list EINA_UNUSED
 {
Elm_Fileselector_Button_Smart_Data *sd = _pd;
 
-   if (sd->window_title) eina_stringshare_del(sd->window_title);
-   if (sd->fsd.path) eina_stringshare_del(sd->fsd.path);
-   if (sd->fsw) evas_object_del(sd->fsw);
+   eina_stringshare_del(sd->window_title);
+   eina_stringshare_del(sd->fsd.path);
+   evas_object_del(sd->fsw);
 
eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
 }
diff --git a/src/lib/elc_multibuttonentry.c b/src/lib/elc_multibuttonentry.c
index 62dc1d1..c89e2fe 100644
--- a/src/lib/elc_multibuttonentry.c
+++ b/src/lib/elc_multibuttonentry.c
@@ -1530,12 +1530,12 @@ _elm_multibuttonentry_smart_del(Eo *obj, void *_pd, 
va_list *list EINA_UNUSED)
 
sd->selected_it = NULL;
 
-   if (sd->label_str) eina_stringshare_del(sd->label_str);
-   if (sd->guide_text_str) eina_stringshare_del(sd->guide_text_str);
+   eina_stringshare_del(sd->label_str);
+   eina_stringshare_del(sd->guide_text_str);
evas_object_del(sd->entry);
-   if (sd->label) evas_object_del(sd->label);
-   if (sd->guide_text) evas_object_del(sd->guide_text);
-   if (sd->end) evas_object_del(sd->end);
+   evas_object_del(sd->label);
+   evas_object_del(sd->guide_text);
+   evas_object_del(sd->end);
 
eo_do_super(obj, MY_CLASS, evas_obj_smart_del());
 }
diff --git a/src/lib/elc_popup.c b/src/lib/elc_popup.c
index f9806ae..6573472 100644
--- a/src/lib/elc_popup.c
+++ b/src/lib/elc_popup.c
@@ -829,9 +829,7 @@ _item_del_pre_hook(Elm_Object_Item *item)
ELM_POPUP_ITEM_CHECK_OR_RETURN(it);
ELM_POPUP_DATA_GET(WIDGET(it), sd);
 
-   if (it->icon)
- evas_object_del(it->icon);
-
+   evas_object_del(it->icon);
eina_stringshare_del(it->label);
sd->items = eina_list_remove(sd->items, it);
if (!eina_list_count(sd->items))
diff --git a/src/lib/elm_access.c b/src/lib/elm_access.c
index 68dad7a..3fe5a1c 100644
--- a/src/lib/elm_access.c
+++ b/src/lib/elm_access.c
@@ -210,7 +210,7 @@ _access_add_set(Elm_Access_Info *ac, int type)
   {
  if (!ai->func)
{
-  if (ai->data) eina_stringshare_del(ai->data);
+  eina_stringshare_del(ai->data);
}
  ai->func = NULL;
  ai->data = NULL;
@@ -571,7 +571,7 @@ _elm_access_clear(Elm_Access_Info *ac)
  {
 if (!ai->func)
   {
- if (ai->data) eina_stringshare_del(ai->data);
+ eina_stringshare_del(ai->data);
   }
 free(ai);
  }
diff --git a/src/lib/elm_atspi_object.c b/src/lib/elm_atspi_object.c
index ab7979c..612130a 100644
--- a/src/lib/elm_atspi_object.c
+++ b/src/lib/elm_atspi_object.c
@@ -212,8 +212,8 @@ _destructor(Eo *obj, void *_pd EINA_UNUSED, va_list *list 
EINA_UNUSED)
 {
Atspi_Object_Data *ad = _pd;
 
-   if (ad->name) eina_stringshare_del(ad->name);
-   if (ad->description) eina_stringshare_del(ad->description);
+   eina_stringshare_del(ad->name);
+   eina_stringshare_del(ad->description);
 
eo_do_super(obj, ELM_ATSPI_CLASS, eo_destructor());
 }
diff --git a/src/lib/elm_colorselector.c b/src/lib/elm_colorselector.c
index 2c5cc20..bdd7f51 100644
--- a/src/lib/elm_colorselector.c
+++ b/src/lib/elm_colorselector.c
@@ -1587,12 +1587,12 @@ _elm_colorselector_smart_del(Eo *obj, void *_pd, 
va_list *list EINA_UNUSED)
evas_event_callback_de

[EGIT] [core/elementary] master 05/08: elm: Removed unnecessary null check for eina_list_free.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=c3403450ef916c4b971402e772372c9501924ad9

commit c3403450ef916c4b971402e772372c9501924ad9
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 10:47:33 2014 +0900

elm: Removed unnecessary null check for eina_list_free.
---
 src/lib/elm_gengrid.c | 2 +-
 src/lib/elm_genlist.c | 5 ++---
 src/lib/elm_map.c | 6 +++---
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/lib/elm_gengrid.c b/src/lib/elm_gengrid.c
index 6665c97..4040810 100644
--- a/src/lib/elm_gengrid.c
+++ b/src/lib/elm_gengrid.c
@@ -2262,7 +2262,7 @@ _elm_gengrid_clear(Evas_Object *obj,
sd->clear_me = EINA_FALSE;
sd->pan_changed = EINA_TRUE;
ELM_SAFE_FREE(sd->calc_job, ecore_job_del);
-   if (sd->selected) sd->selected = eina_list_free(sd->selected);
+   sd->selected = eina_list_free(sd->selected);
if (sd->clear_cb) sd->clear_cb(sd);
sd->pan_x = 0;
sd->pan_y = 0;
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index 925671a..72b6765 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -793,7 +793,7 @@ _item_tree_effect_finish(Elm_Genlist_Smart_Data *sd)
evas_object_lower(sd->alpha_bg);
evas_object_hide(sd->alpha_bg);
sd->move_effect_mode = ELM_GENLIST_TREE_EFFECT_NONE;
-   if (sd->move_items) sd->move_items = eina_list_free(sd->move_items);
+   sd->move_items = eina_list_free(sd->move_items);
 
evas_object_smart_callback_call(sd->pan_obj, "changed", NULL);
evas_object_smart_callback_call
@@ -6508,8 +6508,7 @@ elm_genlist_item_fields_update(Elm_Object_Item *item,
   {
  Evas_Object* eobj;
  Eina_List* l;
- eina_list_free(it->item_focus_chain);
- it->item_focus_chain = NULL;
+ it->item_focus_chain = eina_list_free(it->item_focus_chain);
  EINA_LIST_FOREACH(it->content_objs, l, eobj)
if (elm_object_focus_allow_get(eobj))
  it->item_focus_chain = eina_list_append(it->item_focus_chain, 
eobj);
diff --git a/src/lib/elm_map.c b/src/lib/elm_map.c
index b854982..3787566 100644
--- a/src/lib/elm_map.c
+++ b/src/lib/elm_map.c
@@ -1672,7 +1672,7 @@ _overlay_group_coord_member_update(Overlay_Group *grp,
_coord_to_region_convert
  (grp->wsd, x, y, grp->wsd->size.w, &grp->lon, &grp->lat);
 
-   if (grp->members) eina_list_free(grp->members);
+   eina_list_free(grp->members);
grp->members = members;
snprintf(text, sizeof(text), "%d", eina_list_count(members));
 
@@ -1728,9 +1728,9 @@ _overlay_group_free(Overlay_Group *grp)
 {
EINA_SAFETY_ON_NULL_RETURN(grp);
 
-   if (grp->overlay) free(grp->overlay);
+   free(grp->overlay);
if (grp->ovl) _overlay_default_free(grp->ovl);
-   if (grp->members) eina_list_free(grp->members);
+   eina_list_free(grp->members);
 
free(grp);
 }

-- 

[EGIT] [core/elementary] master 03/08: elm: Removed unnecessary null check for evas_object_del.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=907fc5c590751a304f1d6bc5a247f12cc64e48ca

commit 907fc5c590751a304f1d6bc5a247f12cc64e48ca
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 10:38:55 2014 +0900

elm: Removed unnecessary null check for evas_object_del.
---
 src/lib/elc_ctxpopup.c | 14 --
 src/lib/elc_fileselector.c |  6 ++
 src/lib/elc_hoversel.c |  3 +--
 src/lib/elc_naviframe.c|  8 
 src/lib/elc_player.c   |  3 +--
 src/lib/elc_popup.c| 18 ++
 src/lib/elm_bg.c   |  6 +-
 src/lib/elm_clock.c| 14 ++
 src/lib/elm_colorselector.c| 23 +++
 src/lib/elm_diskselector.c |  6 ++
 src/lib/elm_entry.c|  9 -
 src/lib/elm_factory.c  |  2 +-
 src/lib/elm_flip.c |  2 +-
 src/lib/elm_genlist.c  | 11 +++
 src/lib/elm_hover.c|  8 +---
 src/lib/elm_icon.c |  6 ++
 src/lib/elm_image.c|  2 +-
 src/lib/elm_index.c| 21 +++--
 src/lib/elm_interface_scrollable.c |  6 +-
 src/lib/elm_list.c |  6 +-
 src/lib/elm_map.c  | 26 +-
 src/lib/elm_mapbuf.c   |  2 +-
 src/lib/elm_menu.c |  7 +++
 src/lib/elm_notify.c   |  2 +-
 src/lib/elm_photocam.c |  9 ++---
 src/lib/elm_prefs.c| 10 --
 src/lib/elm_scroller.c |  2 +-
 src/lib/elm_segment_control.c  |  2 +-
 src/lib/elm_slideshow.c|  3 +--
 src/lib/elm_thumb.c|  3 +--
 src/lib/elm_toolbar.c  | 23 ---
 src/lib/elm_widget.c   |  3 +--
 src/lib/elm_win.c  | 18 +-
 src/lib/els_cursor.c   | 12 +++-
 src/lib/els_tooltip.c  |  3 +--
 35 files changed, 98 insertions(+), 201 deletions(-)

diff --git a/src/lib/elc_ctxpopup.c b/src/lib/elc_ctxpopup.c
index 4900765..ee756f6 100644
--- a/src/lib/elc_ctxpopup.c
+++ b/src/lib/elc_ctxpopup.c
@@ -786,7 +786,7 @@ _elm_ctxpopup_smart_content_set(Eo *obj, void *_pd, va_list 
*list)
 
if (content == sd->content) goto end;
 
-   if (sd->content) evas_object_del(sd->content);
+   evas_object_del(sd->content);
if (sd->content == sd->list) sd->list = NULL;
 
evas_object_size_hint_weight_set
@@ -1040,10 +1040,7 @@ _list_resize_cb(void *data,
 static void
 _list_del(Elm_Ctxpopup_Smart_Data *sd)
 {
-   if (!sd->list) return;
-
-   evas_object_del(sd->list);
-   sd->list = NULL;
+   ELM_SAFE_FREE(sd->list, evas_object_del);
 }
 
 static Eina_Bool
@@ -1158,11 +1155,8 @@ _elm_ctxpopup_smart_del(Eo *obj, void *_pd, va_list 
*list EINA_UNUSED)
_parent_detach(obj);
 
elm_ctxpopup_clear(obj);
-   evas_object_del(sd->arrow);
-   sd->arrow = NULL; /* stops _sizing_eval() from going on on deletion */
-
-   evas_object_del(sd->bg);
-   sd->bg = NULL;
+   ELM_SAFE_FREE(sd->arrow, evas_object_del); /* stops _sizing_eval() from 
going on on deletion */
+   ELM_SAFE_FREE(sd->bg, evas_object_del);
 
EINA_LIST_FREE(sd->items, it)
  elm_widget_item_free(it);
diff --git a/src/lib/elc_fileselector.c b/src/lib/elc_fileselector.c
index 49bfbd3..dcd9ad7 100644
--- a/src/lib/elc_fileselector.c
+++ b/src/lib/elc_fileselector.c
@@ -1583,10 +1583,8 @@ _buttons_ok_cancel_set(Eo *obj, void *_pd, va_list *list)
  }
else if (!visible)
  {
-evas_object_del(sd->cancel_button);
-sd->cancel_button = NULL;
-evas_object_del(sd->ok_button);
-sd->ok_button = NULL;
+ELM_SAFE_FREE(sd->cancel_button, evas_object_del);
+ELM_SAFE_FREE(sd->ok_button, evas_object_del);
  }
 }
 
diff --git a/src/lib/elc_hoversel.c b/src/lib/elc_hoversel.c
index a472122..d0321a9 100644
--- a/src/lib/elc_hoversel.c
+++ b/src/lib/elc_hoversel.c
@@ -449,8 +449,7 @@ _hover_end(Eo *obj, void *_pd, va_list *list EINA_UNUSED)
  {
 VIEW(it) = NULL;
  }
-   evas_object_del(sd->hover);
-   sd->hover = NULL;
+   ELM_SAFE_FREE(sd->hover, evas_object_del);
 
evas_object_smart_callback_call(obj, SIG_DISMISSED, NULL);
 }
diff --git a/src/lib/elc_naviframe.c b/src/lib/elc_naviframe.c
index 6143f2a..7441a02 100644
--- a/src/lib/elc_naviframe.c
+++ b/src/lib/elc_naviframe.c
@@ -548,7 +548,7 @@ _item_content_set(Elm_Naviframe_Item *it,
 {
if (it->content == content) return;
 
-   if (it->content) evas_object_del(it->content);
+   evas_object_del(it->content);
it->content = content;
 
if (!content) return;
@@ -565,7 +565,7 @@ _item_title_prev_btn_set(Elm_Naviframe_Item *it,
  Evas_Object *btn)
 {
if (it->title_prev_btn == btn) return;
-   if (it->title_prev_btn) evas_object_del(it->title_p

[EGIT] [core/elementary] master 04/08: elm: Removed unnecessary null check for ecore_event_handler_del.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=0d520bed357f0f721000ea22574d81ac41a6e271

commit 0d520bed357f0f721000ea22574d81ac41a6e271
Author: Daniel Juyung Seo 
Date:   Wed Jan 22 10:47:03 2014 +0900

elm: Removed unnecessary null check for ecore_event_handler_del.
---
 src/lib/elm_config.c  | 3 +--
 src/lib/elm_conform.c | 2 +-
 src/lib/elm_icon.c| 4 +---
 src/lib/elm_main.c| 6 ++
 4 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/lib/elm_config.c b/src/lib/elm_config.c
index 87e35e3..4cdc9b3 100644
--- a/src/lib/elm_config.c
+++ b/src/lib/elm_config.c
@@ -2685,8 +2685,7 @@ _elm_config_shutdown(void)
 #undef ENGINE_COMPARE
  {
 #ifdef HAVE_ELEMENTARY_X
-ecore_event_handler_del(_prop_change_handler);
-_prop_change_handler = NULL;
+ELM_SAFE_FREE(_prop_change_handler, ecore_event_handler_del);
 #endif
  }
ELM_SAFE_FREE(_elm_config, _config_free);
diff --git a/src/lib/elm_conform.c b/src/lib/elm_conform.c
index d487db0..65bd5f7 100644
--- a/src/lib/elm_conform.c
+++ b/src/lib/elm_conform.c
@@ -924,7 +924,7 @@ _elm_conformant_smart_del(Eo *obj, void *_pd, va_list *list 
EINA_UNUSED)
Elm_Conformant_Smart_Data *sd = _pd;
 
 #ifdef HAVE_ELEMENTARY_X
-   if (sd->prop_hdl) ecore_event_handler_del(sd->prop_hdl);
+   ecore_event_handler_del(sd->prop_hdl);
 #endif
 
ecore_job_del(sd->show_region_job);
diff --git a/src/lib/elm_icon.c b/src/lib/elm_icon.c
index 533de87..53663c5 100644
--- a/src/lib/elm_icon.c
+++ b/src/lib/elm_icon.c
@@ -601,9 +601,7 @@ _elm_icon_smart_del(Eo *obj, void *_pd, va_list *list 
EINA_UNUSED)
eina_stringshare_del(sd->thumb.file.key);
eina_stringshare_del(sd->thumb.thumb.path);
eina_stringshare_del(sd->thumb.thumb.key);
-
-   if (sd->thumb.eeh)
- ecore_event_handler_del(sd->thumb.eeh);
+   ecore_event_handler_del(sd->thumb.eeh);
 
_edje_signals_free(sd);
 
diff --git a/src/lib/elm_main.c b/src/lib/elm_main.c
index c4da84f..81734e5 100644
--- a/src/lib/elm_main.c
+++ b/src/lib/elm_main.c
@@ -326,10 +326,8 @@ elm_shutdown(void)
_elm_init_count--;
if (_elm_init_count > 0) return _elm_init_count;
 
-   if (system_handlers[0])
- ecore_event_handler_del(system_handlers[0]);
-   if (system_handlers[1])
- ecore_event_handler_del(system_handlers[1]);
+   ecore_event_handler_del(system_handlers[0]);
+   ecore_event_handler_del(system_handlers[1]);
 
_elm_win_shutdown();
while (_elm_win_deferred_free) ecore_main_loop_iterate();

-- 

[EGIT] [core/efl] master 01/01: ximimmodule: fix dereference after null check

[Jihoon Kim]

jihoon pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=2c0c2b0fed6bc5d696b3e85d2da0bd943edac68e

commit 2c0c2b0fed6bc5d696b3e85d2da0bd943edac68e
Author: Jihoon Kim 
Date:   Wed Jan 22 09:46:24 2014 +0900

ximimmodule: fix dereference after null check

CID 1162749:  Dereference after null check  (FORWARD_NULL)
/src/modules/ecore_imf/xim/ecore_imf_xim.c: 1027 in 
_ecore_imf_xim_preedit_draw_call()
---
 src/modules/ecore_imf/xim/ecore_imf_xim.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/modules/ecore_imf/xim/ecore_imf_xim.c 
b/src/modules/ecore_imf/xim/ecore_imf_xim.c
index 5598cac..66a355f 100644
--- a/src/modules/ecore_imf/xim/ecore_imf_xim.c
+++ b/src/modules/ecore_imf/xim/ecore_imf_xim.c
@@ -1024,7 +1024,10 @@ done:
  imf_context_data->feedbacks = 
calloc(imf_context_data->preedit_length, sizeof(XIMFeedback));
 
  for (i = 0; i < imf_context_data->preedit_length; i++)
-   imf_context_data->feedbacks[i] = t->feedback[i];
+   {
+  if (t)
+imf_context_data->feedbacks[i] = t->feedback[i];
+   }
   }
 
 ecore_imf_context_preedit_changed_event_add(ctx);

-- 

Re: [E-devel] [EGIT] [core/efl] master 01/01: okay, bring back xrandr < 1.4 compat for ecore_x_randr_output_name_get

[The Rasterman]

On Tue, 21 Jan 2014 21:35:09 + Chris Michael  said:

> Welcome to the wonderful world of XRandr version vs driver version vs E 
> version vs .. the world ;)
> 
> Lots of fun waiting for you and Seb here ;)
> 
> BTW, YOU BROKE MY RANDR STUFF !!!
> 
> Configuring monitors in the dialog is totally borked now :( 2 monitors 
> (1600x9000) and (1920x1080) in a side-by-side config does not work 
> anymore !!!
> 
> The 1600 is fine. The 1920 ends up w/ half a screen !!
> 
> FIX IT !!! You broke it, you bought it ;)

seb did say to revert his commit...

> dh
> 
> 
> 
> On 21/01/14 21:09, Mike Blumenkrantz wrote:
> > discomfitor pushed a commit to branch master.
> >
> > http://git.enlightenment.org/core/efl.git/commit/?id=052fc85cd34aec41d50e5d8333bac6ee9ba9c7d6
> >
> > commit 052fc85cd34aec41d50e5d8333bac6ee9ba9c7d6
> > Author: Mike Blumenkrantz 
> > Date:   Tue Jan 21 16:07:38 2014 -0500
> >
> >  okay, bring back xrandr < 1.4 compat for ecore_x_randr_output_name_get
> >
> >  apparently I read the commit order wrong and this fix went in for
> > 1.4.0, not 1.3.2, which means anyone who has 1.3.2 has been having lots of
> > fun crashes for the past 24 hours
> > ---
> >   configure.ac |  4 +---
> >   src/lib/ecore_x/xlib/ecore_x_randr.c | 15 +++
> >   2 files changed, 12 insertions(+), 7 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 2d2e377..373ea6d 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -2875,9 +2875,7 @@ if test "x${want_x11_xlib}" = "xyes" ; then
> >  ECORE_CHECK_X_EXTENSION([Xtest], [XTest.h], [Xtst],
> > [XTestFakeKeyEvent]) ECORE_CHECK_X_EXTENSION([Xss], [scrnsaver.h], [Xss],
> > [XScreenSaverSelectInput])
> >
> > -   if test echo "$ECORE_X_LIBS" | grep -q Xrandr ; then
> > -  PKG_CHECK_EXISTS([xrandr > 1.3.1], [], [AC_MSG_ERROR([Xrandr >=
> > 1.3.1 required])])
> > -   fi
> > +   PKG_CHECK_EXISTS([xrandr > 1.3.2], [AC_DEFINE([XRANDR_GOOD], [1], [good
> > xrandr])], [])
> >
> >  if test "${want_xpresent}" = "yes"; then
> > ECORE_CHECK_X_EXTENSION([Xpresent], [Xpresent.h], [Xpresent],
> > [XPresentQueryExtension]) diff --git a/src/lib/ecore_x/xlib/ecore_x_randr.c
> > b/src/lib/ecore_x/xlib/ecore_x_randr.c index b47..db1f109 100644
> > --- a/src/lib/ecore_x/xlib/ecore_x_randr.c
> > +++ b/src/lib/ecore_x/xlib/ecore_x_randr.c
> > @@ -2206,10 +2206,17 @@ ecore_x_randr_output_name_get(Ecore_X_Window root,
> > Ecore_X_Randr_Output output, {
> >if (info->name)
> >  {
> > -  ret = malloc(info->nameLen + 1);
> > -  memcpy(ret, info->name, info->nameLen);
> > -  ret[info->nameLen] = 0;
> > -  if (len) *len = info->nameLen;
> > +  size_t s;
> > +#ifdef XRANDR_GOOD
> > +  s = info->nameLen;
> > +#else
> > +  /* pre 1.4.0 does not fill in info->nameLen */
> > +  s = strlen(info->name);
> > +#endif
> > +  ret = malloc(s + 1);
> > +  memcpy(ret, info->name, s);
> > +  ret[s] = 0;
> > +  if (len) *len = s;
> >  }
> >
> >/* free the output info */
> >
> 
> 
> --
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today. 
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: feature: handle xrandr backlight using a single, accurate handler

[Chris Michael]

On 21/01/14 22:39, Michael Blumenkrantz wrote:
> On Tue, 21 Jan 2014 22:38:21 + Chris Michael
>  wrote:
>
>> Ok, I try to spell it out .. sobberly (if possible) ;)
>>
>> "which means we no longer have to be constantly checking to
> see if other apps have changed it "
>>
>> BUT What happens if Another app DOES change it ?? If we are not
>> longer listening, then how are we going to know that it was changed
>> by Any app ??
>>
>> That is my concern
>>
>> (hope this makes sense in some way)...
>>
>> dh
>>
>>
>> On 21/01/14 22:24, Michael Blumenkrantz wrote:
>>> I have no idea what you're saying here.
>>>
>>> On Tue, 21 Jan 2014 22:22:49 + Chris Michael
>>>  wrote:
>>>
 Careful here Mike ...

 We not have to Check that an app has changed it ... but that
 Does Not mean an App Did Not change it ;)

 think we should still have a listener/handler for that/those
 cases ... That being said, can we tell from the handler/signlar
 if it was an App change or an X change ? and handle accordingly
 ?

 dh
>
> Okay...the point of the handler is that it gets called on backlight
> events. So no matter what triggers it, we get the events.
>
> RandRing while drinking is hard mode for developers.
>

no worries. My concern has been addressed now by your Last commit on 
this topic. And yes, you are correct ... with the Handler now in place 
we catch it from anywhere regardless. THAT was my concern. The email I 
replied to originally did not have that handler in place (thus my 
concern). You have adequitly addressed that concern. Please disregard 
all previous noise on the topic ;)

Cheers :)

dh




 On 21/01/14 21:49, Mike Blumenkrantz wrote:
> discomfitor pushed a commit to branch master.
>
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=215c0409e00b435a2f87a7eca6e0f8dfe87da7a5
>
>
>
commit 215c0409e00b435a2f87a7eca6e0f8dfe87da7a5 Author: Mike
> Blumenkrantz  Date:   Tue Jan 21 16:48:09
> 2014 -0500
>
> feature: handle xrandr backlight using a single, accurate
> handler
>
> there's an event from ecore-x which tells us when this
> property has changed, which means we no longer have to be
> constantly checking to see if other apps have changed it ---
> src/bin/e_backlight.c | 88
>>>
>>
>


--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: emit backlight changed event for X backlight events

[Chris Michael]

AHHH ok, Disregard all previous mails on this subject. This commit 
addresses my concern(s) properly !! :)

As long as this is being raised, then we can catch is Somewhere (which 
was my concern num 1) regardless of WHo changes it (concern num 2).

Cheers !! This adresses all my prior concerns so please toss out previos 
mails on this topic ;)

Good Job !!

dh

On 21/01/14 22:26, Mike Blumenkrantz wrote:
> discomfitor pushed a commit to branch master.
>
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=a8d3a0e57f618029c142621a683bb2ff0b7de73f
>
> commit a8d3a0e57f618029c142621a683bb2ff0b7de73f
> Author: Mike Blumenkrantz 
> Date:   Tue Jan 21 17:26:21 2014 -0500
>
>  emit backlight changed event for X backlight events
> ---
>   src/bin/e_comp_x.c | 6 +-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/bin/e_comp_x.c b/src/bin/e_comp_x.c
> index 4e70d58..bd2fa42 100644
> --- a/src/bin/e_comp_x.c
> +++ b/src/bin/e_comp_x.c
> @@ -4314,7 +4314,11 @@ _e_comp_x_backlight_notify_cb(void *data EINA_UNUSED, 
> int t EINA_UNUSED, Ecore_X
>  x_bl = ecore_x_randr_output_backlight_level_get(0, ev->output);
>
>  if (x_bl >= 0.0)
> - e_bl_val = x_bl;
> + {
> +if (fabs(e_bl_val - x_bl) < DBL_EPSILON)
> +  ecore_event_add(E_EVENT_BACKLIGHT_CHANGE, NULL, NULL, NULL);;
> +e_bl_val = x_bl;
> + }
>  return ECORE_CALLBACK_RENEW;
>   }
>
>


--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: feature: handle xrandr backlight using a single, accurate handler

[Michael Blumenkrantz]

On Tue, 21 Jan 2014 22:38:21 +
Chris Michael  wrote:

> Ok, I try to spell it out .. sobberly (if possible) ;)
> 
> "which means we no longer have to be constantly checking to
>  >>> see if other apps have changed it "
> 
> BUT What happens if Another app DOES change it ?? If we are not longer 
> listening, then how are we going to know that it was changed by Any app ??
> 
> That is my concern
> 
> (hope this makes sense in some way)...
> 
> dh
> 
> 
> On 21/01/14 22:24, Michael Blumenkrantz wrote:
> > I have no idea what you're saying here.
> >
> > On Tue, 21 Jan 2014 22:22:49 +
> > Chris Michael  wrote:
> >
> >> Careful here Mike ...
> >>
> >> We not have to Check that an app has changed it ... but that Does Not
> >> mean an App Did Not change it ;)
> >>
> >> think we should still have a listener/handler for that/those cases ...
> >> That being said, can we tell from the handler/signlar if it was an App
> >> change or an X change ? and handle accordingly ?
> >>
> >> dh

Okay...the point of the handler is that it gets called on backlight events. So 
no matter what triggers it, we get the events.

RandRing while drinking is hard mode for developers.

> >>
> >>
> >> On 21/01/14 21:49, Mike Blumenkrantz wrote:
> >>> discomfitor pushed a commit to branch master.
> >>>
> >>> http://git.enlightenment.org/core/enlightenment.git/commit/?id=215c0409e00b435a2f87a7eca6e0f8dfe87da7a5
> >>>
> >>>   commit 215c0409e00b435a2f87a7eca6e0f8dfe87da7a5 Author: Mike
> >>> Blumenkrantz  Date:   Tue Jan 21 16:48:09 2014
> >>> -0500
> >>>
> >>> feature: handle xrandr backlight using a single, accurate handler
> >>>
> >>> there's an event from ecore-x which tells us when this property has
> >>> changed, which means we no longer have to be constantly checking to
> >>> see if other apps have changed it --- src/bin/e_backlight.c | 88
> >
> 

--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: feature: handle xrandr backlight using a single, accurate handler

[Chris Michael]

Ok, I try to spell it out .. sobberly (if possible) ;)

"which means we no longer have to be constantly checking to
 >>> see if other apps have changed it "

BUT What happens if Another app DOES change it ?? If we are not longer 
listening, then how are we going to know that it was changed by Any app ??

That is my concern

(hope this makes sense in some way)...

dh


On 21/01/14 22:24, Michael Blumenkrantz wrote:
> I have no idea what you're saying here.
>
> On Tue, 21 Jan 2014 22:22:49 +
> Chris Michael  wrote:
>
>> Careful here Mike ...
>>
>> We not have to Check that an app has changed it ... but that Does Not
>> mean an App Did Not change it ;)
>>
>> think we should still have a listener/handler for that/those cases ...
>> That being said, can we tell from the handler/signlar if it was an App
>> change or an X change ? and handle accordingly ?
>>
>> dh
>>
>>
>> On 21/01/14 21:49, Mike Blumenkrantz wrote:
>>> discomfitor pushed a commit to branch master.
>>>
>>> http://git.enlightenment.org/core/enlightenment.git/commit/?id=215c0409e00b435a2f87a7eca6e0f8dfe87da7a5
>>>
>>>   commit 215c0409e00b435a2f87a7eca6e0f8dfe87da7a5 Author: Mike
>>> Blumenkrantz  Date:   Tue Jan 21 16:48:09 2014
>>> -0500
>>>
>>> feature: handle xrandr backlight using a single, accurate handler
>>>
>>> there's an event from ecore-x which tells us when this property has
>>> changed, which means we no longer have to be constantly checking to
>>> see if other apps have changed it --- src/bin/e_backlight.c | 88
>


--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: feature: handle xrandr backlight using a single, accurate handler

[Michael Blumenkrantz]

I have no idea what you're saying here.

On Tue, 21 Jan 2014 22:22:49 +
Chris Michael  wrote:

> Careful here Mike ...
> 
> We not have to Check that an app has changed it ... but that Does Not 
> mean an App Did Not change it ;)
> 
> think we should still have a listener/handler for that/those cases ... 
> That being said, can we tell from the handler/signlar if it was an App 
> change or an X change ? and handle accordingly ?
> 
> dh
> 
> 
> On 21/01/14 21:49, Mike Blumenkrantz wrote:
> > discomfitor pushed a commit to branch master.
> >
> > http://git.enlightenment.org/core/enlightenment.git/commit/?id=215c0409e00b435a2f87a7eca6e0f8dfe87da7a5
> >
> >  commit 215c0409e00b435a2f87a7eca6e0f8dfe87da7a5 Author: Mike
> > Blumenkrantz  Date:   Tue Jan 21 16:48:09 2014
> > -0500
> >
> > feature: handle xrandr backlight using a single, accurate handler
> >
> > there's an event from ecore-x which tells us when this property has
> > changed, which means we no longer have to be constantly checking to
> > see if other apps have changed it --- src/bin/e_backlight.c | 88

--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/enlightenment] master 01/01: emit backlight changed event for X backlight events

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=a8d3a0e57f618029c142621a683bb2ff0b7de73f

commit a8d3a0e57f618029c142621a683bb2ff0b7de73f
Author: Mike Blumenkrantz 
Date:   Tue Jan 21 17:26:21 2014 -0500

emit backlight changed event for X backlight events
---
 src/bin/e_comp_x.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/bin/e_comp_x.c b/src/bin/e_comp_x.c
index 4e70d58..bd2fa42 100644
--- a/src/bin/e_comp_x.c
+++ b/src/bin/e_comp_x.c
@@ -4314,7 +4314,11 @@ _e_comp_x_backlight_notify_cb(void *data EINA_UNUSED, 
int t EINA_UNUSED, Ecore_X
x_bl = ecore_x_randr_output_backlight_level_get(0, ev->output);
 
if (x_bl >= 0.0)
- e_bl_val = x_bl;
+ {
+if (fabs(e_bl_val - x_bl) < DBL_EPSILON)
+  ecore_event_add(E_EVENT_BACKLIGHT_CHANGE, NULL, NULL, NULL);;
+e_bl_val = x_bl;
+ }
return ECORE_CALLBACK_RENEW;
 }
 

-- 

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: feature: handle xrandr backlight using a single, accurate handler

[Chris Michael]

Careful here Mike ...

We not have to Check that an app has changed it ... but that Does Not 
mean an App Did Not change it ;)

think we should still have a listener/handler for that/those cases ... 
That being said, can we tell from the handler/signlar if it was an App 
change or an X change ? and handle accordingly ?

dh


On 21/01/14 21:49, Mike Blumenkrantz wrote:
> discomfitor pushed a commit to branch master.
>
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=215c0409e00b435a2f87a7eca6e0f8dfe87da7a5
>
>  commit 215c0409e00b435a2f87a7eca6e0f8dfe87da7a5 Author: Mike
> Blumenkrantz  Date:   Tue Jan 21 16:48:09 2014
> -0500
>
> feature: handle xrandr backlight using a single, accurate handler
>
> there's an event from ecore-x which tells us when this property has
> changed, which means we no longer have to be constantly checking to
> see if other apps have changed it --- src/bin/e_backlight.c | 88
> ---
> src/bin/e_comp_x.c| 20 +++- 2 files changed, 19
> insertions(+), 89 deletions(-)
>
> diff --git a/src/bin/e_backlight.c b/src/bin/e_backlight.c index
> e1978d3..e9879b2 100644 --- a/src/bin/e_backlight.c +++
> b/src/bin/e_backlight.c @@ -17,20 +17,10 @@ static int sysmode =
> MODE_NONE; static Ecore_Animator *bl_anim = NULL; static Eina_List
> *bl_devs = NULL;
>
> -static Ecore_Event_Handler *_e_backlight_handler_config_mode =
> NULL; -static Ecore_Event_Handler
> *_e_backlight_handler_border_fullscreen = NULL; -static
> Ecore_Event_Handler *_e_backlight_handler_border_unfullscreen =
> NULL; -static Ecore_Event_Handler *_e_backlight_handler_border_remove
> = NULL; -static Ecore_Event_Handler
> *_e_backlight_handler_border_iconify = NULL; -static
> Ecore_Event_Handler *_e_backlight_handler_border_uniconify = NULL;
> -static Ecore_Event_Handler *_e_backlight_handler_border_desk_set =
> NULL; -static Ecore_Event_Handler *_e_backlight_handler_desk_show =
> NULL; - static void  _e_backlight_update(E_Zone *zone); static
> void  _e_backlight_set(E_Zone *zone, double val); static
> Eina_Bool _bl_anim(void *data, double pos); static Eina_Bool bl_avail
> = EINA_TRUE; -static Eina_Bool _e_backlight_handler(void *d, int
> type, void *ev); #ifndef WAYLAND_ONLY static Eina_Bool xbl_avail =
> EINA_FALSE; #endif @@ -57,30 +47,6 @@ e_backlight_init(void)
> eeze_init(); #endif
>
> -   _e_backlight_handler_config_mode = ecore_event_handler_add -
> (E_EVENT_CONFIG_MODE_CHANGED, _e_backlight_handler, NULL); - -
> _e_backlight_handler_border_fullscreen = ecore_event_handler_add -
> (E_EVENT_CLIENT_FULLSCREEN, _e_backlight_handler, NULL); - -
> _e_backlight_handler_border_unfullscreen = ecore_event_handler_add -
> (E_EVENT_CLIENT_UNFULLSCREEN, _e_backlight_handler, NULL); - -
> _e_backlight_handler_border_remove = ecore_event_handler_add -
> (E_EVENT_CLIENT_REMOVE, _e_backlight_handler, NULL); - -
> _e_backlight_handler_border_iconify = ecore_event_handler_add -
> (E_EVENT_CLIENT_ICONIFY, _e_backlight_handler, NULL); - -
> _e_backlight_handler_border_uniconify = ecore_event_handler_add -
> (E_EVENT_CLIENT_UNICONIFY, _e_backlight_handler, NULL); - -
> _e_backlight_handler_border_desk_set = ecore_event_handler_add -
> (E_EVENT_CLIENT_DESK_SET, _e_backlight_handler, NULL); - -
> _e_backlight_handler_desk_show = ecore_event_handler_add -
> (E_EVENT_DESK_SHOW, _e_backlight_handler, NULL); - #ifndef
> WAYLAND_ONLY if (e_comp_get(NULL)->man->root) xbl_avail =
> ecore_x_randr_output_backlight_available(); @@ -119,53 +85,7 @@
> e_backlight_shutdown(void) bl_sys_pending_set = EINA_FALSE;
> eeze_shutdown(); #endif -   if (_e_backlight_handler_config_mode) -
> { -
> ecore_event_handler_del(_e_backlight_handler_config_mode); -
> _e_backlight_handler_config_mode = NULL; - } - -   if
> (_e_backlight_handler_border_fullscreen) - { -
> ecore_event_handler_del(_e_backlight_handler_border_fullscreen); -
> _e_backlight_handler_border_fullscreen = NULL; - }
>
> -   if (_e_backlight_handler_border_unfullscreen) - { -
> ecore_event_handler_del(_e_backlight_handler_border_unfullscreen); -
> _e_backlight_handler_border_unfullscreen = NULL; - } - -   if
> (_e_backlight_handler_border_remove) - { -
> ecore_event_handler_del(_e_backlight_handler_border_remove); -
> _e_backlight_handler_border_remove = NULL; - } - -   if
> (_e_backlight_handler_border_iconify) - { -
> ecore_event_handler_del(_e_backlight_handler_border_iconify); -
> _e_backlight_handler_border_iconify = NULL; - } - -   if
> (_e_backlight_handler_border_uniconify) - { -
> ecore_event_handler_del(_e_backlight_handler_border_uniconify); -
> _e_backlight_handler_border_uniconify = NULL; - } - -   if
> (_e_backlight_handler_border_desk_set) - { -
> ecore_event_handler_del(_e_backlight_handler_border_desk_set); -
> _e_backlight_handler_border_desk_set = NULL; - } - -   if
> (_e_backlight_handler_desk_show) - { -
> ecore_event_handler_del(_e_backlight_handl

[EGIT] [core/enlightenment] enlightenment-0.18 02/02: no longer require elm < 1.9

[Mike Blumenkrantz]

discomfitor pushed a commit to branch enlightenment-0.18.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=d01d2f1b3b9c96cc1d39c4fd90e038ce0080d217

commit d01d2f1b3b9c96cc1d39c4fd90e038ce0080d217
Author: Mike Blumenkrantz 
Date:   Tue Jan 21 17:13:35 2014 -0500

no longer require elm < 1.9
---
 configure.ac | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 46c4b5a..5ac958d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -557,7 +557,6 @@ PKG_CHECK_MODULES(E, [
   eldbus >= ${efl_version}
   eio >= ${efl_version}
   elementary >= ${elm_version}
-  elementary < 1.8.99
   emotion >= ${efl_version}
   $eeze_mount
   $udisks_mount

-- 

[EGIT] [core/enlightenment] enlightenment-0.18 01/02: bugfix: backlight double comparison now less likely to fail

[Mike Blumenkrantz]

discomfitor pushed a commit to branch enlightenment-0.18.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=084f44747703251b2d8a66cf35637db8c8768367

commit 084f44747703251b2d8a66cf35637db8c8768367
Author: Mike Blumenkrantz 
Date:   Tue Jan 21 17:08:49 2014 -0500

bugfix: backlight double comparison now less likely to fail
---
 src/bin/e_backlight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/e_backlight.c b/src/bin/e_backlight.c
index ca2b7d9..4e5ae12 100644
--- a/src/bin/e_backlight.c
+++ b/src/bin/e_backlight.c
@@ -209,7 +209,7 @@ e_backlight_level_set(E_Zone *zone, double val, double tim)
if (val < 0.0) val = 0.0;
else if (val > 1.0)
  val = 1.0;
-   if ((val == bl_val) && (!bl_anim)) return;
+   if ((fabs(val - bl_val) < DBL_EPSILON) && (!bl_anim)) return;
if (!zone) zone = e_util_zone_current_get(e_manager_current_get());
ecore_event_add(E_EVENT_BACKLIGHT_CHANGE, NULL, NULL, NULL);
bl_now = bl_val;

-- 

[EGIT] [core/enlightenment] master 02/03: do Xrandr backlight updates in place upon recieving events instead of looping all outputs

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=0f938c9b785cf9d707e17c265c8c9996c2623e8f

commit 0f938c9b785cf9d707e17c265c8c9996c2623e8f
Author: Mike Blumenkrantz 
Date:   Tue Jan 21 17:07:21 2014 -0500

do Xrandr backlight updates in place upon recieving events instead of 
looping all outputs
---
 src/bin/e_comp_x.c | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/bin/e_comp_x.c b/src/bin/e_comp_x.c
index 98b312f..4e70d58 100644
--- a/src/bin/e_comp_x.c
+++ b/src/bin/e_comp_x.c
@@ -55,6 +55,7 @@ static Ecore_Timer *screensaver_idle_timer = NULL;
 static Eina_Bool screensaver_dimmed = EINA_FALSE;
 
 static Ecore_X_Atom backlight_atom = 0;
+extern double e_bl_val;
 
 static inline Ecore_X_Window
 _e_comp_x_client_window_get(const E_Client *ec)
@@ -4307,8 +4308,13 @@ _e_comp_x_screensaver_notify_cb(void *data __UNUSED__, 
int type __UNUSED__, Ecor
 static Eina_Bool
 _e_comp_x_backlight_notify_cb(void *data EINA_UNUSED, int t EINA_UNUSED, 
Ecore_X_Event_Randr_Output_Property_Notify *ev)
 {
-   if (ev->property == backlight_atom)
- e_backlight_update();
+   double x_bl;
+
+   if (ev->property != backlight_atom) return ECORE_CALLBACK_RENEW;
+   x_bl = ecore_x_randr_output_backlight_level_get(0, ev->output);
+
+   if (x_bl >= 0.0)
+ e_bl_val = x_bl;
return ECORE_CALLBACK_RENEW;
 }
 

-- 

[EGIT] [core/enlightenment] master 01/03: make current backlight value internally exported

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=84a3eb7af028e13f88bed7466fbc331383b39f88

commit 84a3eb7af028e13f88bed7466fbc331383b39f88
Author: Mike Blumenkrantz 
Date:   Tue Jan 21 17:06:27 2014 -0500

make current backlight value internally exported

display system backends should be handling this in the event of changes, 
and being able to set it directly makes that easier
---
 src/bin/e_backlight.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/bin/e_backlight.c b/src/bin/e_backlight.c
index e9879b2..86dc132 100644
--- a/src/bin/e_backlight.c
+++ b/src/bin/e_backlight.c
@@ -11,7 +11,7 @@
 #define MODE_RANDR 0
 #define MODE_SYS   1
 
-static double bl_val = 1.0;
+EINTERN double e_bl_val = 1.0;
 static double bl_animval = 1.0;
 static int sysmode = MODE_NONE;
 static Ecore_Animator *bl_anim = NULL;
@@ -121,11 +121,11 @@ e_backlight_level_set(E_Zone *zone, double val, double 
tim)
if (val < 0.0) val = 0.0;
else if (val > 1.0)
  val = 1.0;
-   if ((val == bl_val) && (!bl_anim)) return;
+   if ((val == e_bl_val) && (!bl_anim)) return;
if (!zone) zone = e_util_zone_current_get(e_manager_current_get());
ecore_event_add(E_EVENT_BACKLIGHT_CHANGE, NULL, NULL, NULL);
-   bl_now = bl_val;
-   bl_val = val;
+   bl_now = e_bl_val;
+   e_bl_val = val;
if (fabs(tim) < DBL_EPSILON)
  {
 _e_backlight_set(zone, val);
@@ -147,7 +147,7 @@ EAPI double
 e_backlight_level_get(E_Zone *zone __UNUSED__)
 {
// zone == NULL == everything
-   return bl_val;
+   return e_bl_val;
 }
 
 EAPI void
@@ -235,7 +235,7 @@ _e_backlight_update(E_Zone *zone)
  }
if (x_bl >= 0.0)
  {
-bl_val = x_bl;
+e_bl_val = x_bl;
 sysmode = MODE_RANDR;
 return;
  }
@@ -311,7 +311,7 @@ _bl_anim(void *data, double pos)
 
// FIXME: if zone is deleted while anim going... bad things.
pos = ecore_animator_pos_map(pos, ECORE_POS_MAP_DECELERATE, 0.0, 0.0);
-   v = (bl_animval * (1.0 - pos)) + (bl_val * pos);
+   v = (bl_animval * (1.0 - pos)) + (e_bl_val * pos);
_e_backlight_set(zone, v);
if (pos >= 1.0)
  {
@@ -440,14 +440,14 @@ _bl_sys_level_get(void)
eina_stringshare_del(str);
if ((!maxval) && (!val))
  {
-bl_val = 0;
+e_bl_val = 0;
 sysmode = MODE_NONE;
 return;
  }
if (!maxval) maxval = 255;
if ((val >= 0) && (val <= maxval))
- bl_val = (double)val / (double)maxval;
-//   fprintf(stderr, "GET: %i/%i (%1.3f)\n", val, maxval, bl_val);
+ e_bl_val = (double)val / (double)maxval;
+//   fprintf(stderr, "GET: %i/%i (%1.3f)\n", val, maxval, e_bl_val);
 }
 
 static Eina_Bool

-- 

[EGIT] [core/enlightenment] master 03/03: bugfix: backlight double comparison now less likely to fail

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=3ccdd6ab32fcccbf870e382cd830dc03891b5fec

commit 3ccdd6ab32fcccbf870e382cd830dc03891b5fec
Author: Mike Blumenkrantz 
Date:   Tue Jan 21 17:08:49 2014 -0500

bugfix: backlight double comparison now less likely to fail
---
 src/bin/e_backlight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/e_backlight.c b/src/bin/e_backlight.c
index 86dc132..f65127c 100644
--- a/src/bin/e_backlight.c
+++ b/src/bin/e_backlight.c
@@ -121,7 +121,7 @@ e_backlight_level_set(E_Zone *zone, double val, double tim)
if (val < 0.0) val = 0.0;
else if (val > 1.0)
  val = 1.0;
-   if ((val == e_bl_val) && (!bl_anim)) return;
+   if ((fabs(val - e_bl_val) < DBL_EPSILON) && (!bl_anim)) return;
if (!zone) zone = e_util_zone_current_get(e_manager_current_get());
ecore_event_add(E_EVENT_BACKLIGHT_CHANGE, NULL, NULL, NULL);
bl_now = e_bl_val;

-- 

[EGIT] [core/enlightenment] master 01/01: feature: handle xrandr backlight using a single, accurate handler

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=215c0409e00b435a2f87a7eca6e0f8dfe87da7a5

commit 215c0409e00b435a2f87a7eca6e0f8dfe87da7a5
Author: Mike Blumenkrantz 
Date:   Tue Jan 21 16:48:09 2014 -0500

feature: handle xrandr backlight using a single, accurate handler

there's an event from ecore-x which tells us when this property has 
changed, which means we no longer have to be constantly checking to see if 
other apps have changed it
---
 src/bin/e_backlight.c | 88 ---
 src/bin/e_comp_x.c| 20 +++-
 2 files changed, 19 insertions(+), 89 deletions(-)

diff --git a/src/bin/e_backlight.c b/src/bin/e_backlight.c
index e1978d3..e9879b2 100644
--- a/src/bin/e_backlight.c
+++ b/src/bin/e_backlight.c
@@ -17,20 +17,10 @@ static int sysmode = MODE_NONE;
 static Ecore_Animator *bl_anim = NULL;
 static Eina_List *bl_devs = NULL;
 
-static Ecore_Event_Handler *_e_backlight_handler_config_mode = NULL;
-static Ecore_Event_Handler *_e_backlight_handler_border_fullscreen = NULL;
-static Ecore_Event_Handler *_e_backlight_handler_border_unfullscreen = NULL;
-static Ecore_Event_Handler *_e_backlight_handler_border_remove = NULL;
-static Ecore_Event_Handler *_e_backlight_handler_border_iconify = NULL;
-static Ecore_Event_Handler *_e_backlight_handler_border_uniconify = NULL;
-static Ecore_Event_Handler *_e_backlight_handler_border_desk_set = NULL;
-static Ecore_Event_Handler *_e_backlight_handler_desk_show = NULL;
-
 static void  _e_backlight_update(E_Zone *zone);
 static void  _e_backlight_set(E_Zone *zone, double val);
 static Eina_Bool _bl_anim(void *data, double pos);
 static Eina_Bool bl_avail = EINA_TRUE;
-static Eina_Bool _e_backlight_handler(void *d, int type, void *ev);
 #ifndef WAYLAND_ONLY
 static Eina_Bool xbl_avail = EINA_FALSE;
 #endif
@@ -57,30 +47,6 @@ e_backlight_init(void)
eeze_init();
 #endif
 
-   _e_backlight_handler_config_mode = ecore_event_handler_add
-   (E_EVENT_CONFIG_MODE_CHANGED, _e_backlight_handler, NULL);
-
-   _e_backlight_handler_border_fullscreen = ecore_event_handler_add
-   (E_EVENT_CLIENT_FULLSCREEN, _e_backlight_handler, NULL);
-
-   _e_backlight_handler_border_unfullscreen = ecore_event_handler_add
-   (E_EVENT_CLIENT_UNFULLSCREEN, _e_backlight_handler, NULL);
-
-   _e_backlight_handler_border_remove = ecore_event_handler_add
-   (E_EVENT_CLIENT_REMOVE, _e_backlight_handler, NULL);
-
-   _e_backlight_handler_border_iconify = ecore_event_handler_add
-   (E_EVENT_CLIENT_ICONIFY, _e_backlight_handler, NULL);
-
-   _e_backlight_handler_border_uniconify = ecore_event_handler_add
-   (E_EVENT_CLIENT_UNICONIFY, _e_backlight_handler, NULL);
-
-   _e_backlight_handler_border_desk_set = ecore_event_handler_add
-   (E_EVENT_CLIENT_DESK_SET, _e_backlight_handler, NULL);
-
-   _e_backlight_handler_desk_show = ecore_event_handler_add
-   (E_EVENT_DESK_SHOW, _e_backlight_handler, NULL);
-
 #ifndef WAYLAND_ONLY
if (e_comp_get(NULL)->man->root)
  xbl_avail = ecore_x_randr_output_backlight_available();
@@ -119,53 +85,7 @@ e_backlight_shutdown(void)
bl_sys_pending_set = EINA_FALSE;
eeze_shutdown();
 #endif
-   if (_e_backlight_handler_config_mode)
- {
-ecore_event_handler_del(_e_backlight_handler_config_mode);
-_e_backlight_handler_config_mode = NULL;
- }
-
-   if (_e_backlight_handler_border_fullscreen)
- {
-ecore_event_handler_del(_e_backlight_handler_border_fullscreen);
-_e_backlight_handler_border_fullscreen = NULL;
- }
 
-   if (_e_backlight_handler_border_unfullscreen)
- {
-ecore_event_handler_del(_e_backlight_handler_border_unfullscreen);
-_e_backlight_handler_border_unfullscreen = NULL;
- }
-
-   if (_e_backlight_handler_border_remove)
- {
-ecore_event_handler_del(_e_backlight_handler_border_remove);
-_e_backlight_handler_border_remove = NULL;
- }
-
-   if (_e_backlight_handler_border_iconify)
- {
-ecore_event_handler_del(_e_backlight_handler_border_iconify);
-_e_backlight_handler_border_iconify = NULL;
- }
-
-   if (_e_backlight_handler_border_uniconify)
- {
-ecore_event_handler_del(_e_backlight_handler_border_uniconify);
-_e_backlight_handler_border_uniconify = NULL;
- }
-
-   if (_e_backlight_handler_border_desk_set)
- {
-ecore_event_handler_del(_e_backlight_handler_border_desk_set);
-_e_backlight_handler_border_desk_set = NULL;
- }
-
-   if (_e_backlight_handler_desk_show)
- {
-ecore_event_handler_del(_e_backlight_handler_desk_show);
-_e_backlight_handler_desk_show = NULL;
- }
return 1;
 }
 
@@ -273,14 +193,6 @@ e_backlight_devices_get(void)
 
 /* local subsystem functions */
 
-static Eina_Bool
-_e_backlight_handler(void *d __UNUSED__, int type __UNUSED__, void *ev 
__UNUSED__)
-{
-   if (!bl_anim)
- e

Re: [E-devel] [EGIT] [core/efl] master 01/01: okay, bring back xrandr < 1.4 compat for ecore_x_randr_output_name_get

[Chris Michael]

Welcome to the wonderful world of XRandr version vs driver version vs E 
version vs .. the world ;)

Lots of fun waiting for you and Seb here ;)

BTW, YOU BROKE MY RANDR STUFF !!!

Configuring monitors in the dialog is totally borked now :( 2 monitors 
(1600x9000) and (1920x1080) in a side-by-side config does not work 
anymore !!!

The 1600 is fine. The 1920 ends up w/ half a screen !!

FIX IT !!! You broke it, you bought it ;)

dh



On 21/01/14 21:09, Mike Blumenkrantz wrote:
> discomfitor pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=052fc85cd34aec41d50e5d8333bac6ee9ba9c7d6
>
> commit 052fc85cd34aec41d50e5d8333bac6ee9ba9c7d6
> Author: Mike Blumenkrantz 
> Date:   Tue Jan 21 16:07:38 2014 -0500
>
>  okay, bring back xrandr < 1.4 compat for ecore_x_randr_output_name_get
>
>  apparently I read the commit order wrong and this fix went in for 1.4.0, 
> not 1.3.2, which means anyone who has 1.3.2 has been having lots of fun 
> crashes for the past 24 hours
> ---
>   configure.ac |  4 +---
>   src/lib/ecore_x/xlib/ecore_x_randr.c | 15 +++
>   2 files changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 2d2e377..373ea6d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2875,9 +2875,7 @@ if test "x${want_x11_xlib}" = "xyes" ; then
>  ECORE_CHECK_X_EXTENSION([Xtest], [XTest.h], [Xtst], [XTestFakeKeyEvent])
>  ECORE_CHECK_X_EXTENSION([Xss], [scrnsaver.h], [Xss], 
> [XScreenSaverSelectInput])
>
> -   if test echo "$ECORE_X_LIBS" | grep -q Xrandr ; then
> -  PKG_CHECK_EXISTS([xrandr > 1.3.1], [], [AC_MSG_ERROR([Xrandr >= 1.3.1 
> required])])
> -   fi
> +   PKG_CHECK_EXISTS([xrandr > 1.3.2], [AC_DEFINE([XRANDR_GOOD], [1], [good 
> xrandr])], [])
>
>  if test "${want_xpresent}" = "yes"; then
> ECORE_CHECK_X_EXTENSION([Xpresent], [Xpresent.h], [Xpresent], 
> [XPresentQueryExtension])
> diff --git a/src/lib/ecore_x/xlib/ecore_x_randr.c 
> b/src/lib/ecore_x/xlib/ecore_x_randr.c
> index b47..db1f109 100644
> --- a/src/lib/ecore_x/xlib/ecore_x_randr.c
> +++ b/src/lib/ecore_x/xlib/ecore_x_randr.c
> @@ -2206,10 +2206,17 @@ ecore_x_randr_output_name_get(Ecore_X_Window root, 
> Ecore_X_Randr_Output output,
> {
>if (info->name)
>  {
> -  ret = malloc(info->nameLen + 1);
> -  memcpy(ret, info->name, info->nameLen);
> -  ret[info->nameLen] = 0;
> -  if (len) *len = info->nameLen;
> +  size_t s;
> +#ifdef XRANDR_GOOD
> +  s = info->nameLen;
> +#else
> +  /* pre 1.4.0 does not fill in info->nameLen */
> +  s = strlen(info->name);
> +#endif
> +  ret = malloc(s + 1);
> +  memcpy(ret, info->name, s);
> +  ret[s] = 0;
> +  if (len) *len = s;
>  }
>
>/* free the output info */
>


--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/efl] master 01/01: okay, bring back xrandr < 1.4 compat for ecore_x_randr_output_name_get

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=052fc85cd34aec41d50e5d8333bac6ee9ba9c7d6

commit 052fc85cd34aec41d50e5d8333bac6ee9ba9c7d6
Author: Mike Blumenkrantz 
Date:   Tue Jan 21 16:07:38 2014 -0500

okay, bring back xrandr < 1.4 compat for ecore_x_randr_output_name_get

apparently I read the commit order wrong and this fix went in for 1.4.0, 
not 1.3.2, which means anyone who has 1.3.2 has been having lots of fun crashes 
for the past 24 hours
---
 configure.ac |  4 +---
 src/lib/ecore_x/xlib/ecore_x_randr.c | 15 +++
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/configure.ac b/configure.ac
index 2d2e377..373ea6d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2875,9 +2875,7 @@ if test "x${want_x11_xlib}" = "xyes" ; then
ECORE_CHECK_X_EXTENSION([Xtest], [XTest.h], [Xtst], [XTestFakeKeyEvent])
ECORE_CHECK_X_EXTENSION([Xss], [scrnsaver.h], [Xss], 
[XScreenSaverSelectInput])
 
-   if test echo "$ECORE_X_LIBS" | grep -q Xrandr ; then
-  PKG_CHECK_EXISTS([xrandr > 1.3.1], [], [AC_MSG_ERROR([Xrandr >= 1.3.1 
required])])
-   fi
+   PKG_CHECK_EXISTS([xrandr > 1.3.2], [AC_DEFINE([XRANDR_GOOD], [1], [good 
xrandr])], [])
 
if test "${want_xpresent}" = "yes"; then
   ECORE_CHECK_X_EXTENSION([Xpresent], [Xpresent.h], [Xpresent], 
[XPresentQueryExtension])
diff --git a/src/lib/ecore_x/xlib/ecore_x_randr.c 
b/src/lib/ecore_x/xlib/ecore_x_randr.c
index b47..db1f109 100644
--- a/src/lib/ecore_x/xlib/ecore_x_randr.c
+++ b/src/lib/ecore_x/xlib/ecore_x_randr.c
@@ -2206,10 +2206,17 @@ ecore_x_randr_output_name_get(Ecore_X_Window root, 
Ecore_X_Randr_Output output,
   {
  if (info->name)
{
-  ret = malloc(info->nameLen + 1);
-  memcpy(ret, info->name, info->nameLen);
-  ret[info->nameLen] = 0;
-  if (len) *len = info->nameLen;
+  size_t s;
+#ifdef XRANDR_GOOD
+  s = info->nameLen;
+#else
+  /* pre 1.4.0 does not fill in info->nameLen */
+  s = strlen(info->name);
+#endif
+  ret = malloc(s + 1);
+  memcpy(ret, info->name, s);
+  ret[s] = 0;
+  if (len) *len = s;
}
 
  /* free the output info */

-- 

[EGIT] [core/efl] master 01/01: nul terminate string from ecore_x_randr_output_name_get

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=8cbd7c16227f6f40625257a02a026be29a576e0b

commit 8cbd7c16227f6f40625257a02a026be29a576e0b
Author: Mike Blumenkrantz 
Date:   Tue Jan 21 14:58:06 2014 -0500

nul terminate string from ecore_x_randr_output_name_get
---
 src/lib/ecore_x/xlib/ecore_x_randr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/lib/ecore_x/xlib/ecore_x_randr.c 
b/src/lib/ecore_x/xlib/ecore_x_randr.c
index a88fcff..b47 100644
--- a/src/lib/ecore_x/xlib/ecore_x_randr.c
+++ b/src/lib/ecore_x/xlib/ecore_x_randr.c
@@ -2206,8 +2206,9 @@ ecore_x_randr_output_name_get(Ecore_X_Window root, 
Ecore_X_Randr_Output output,
   {
  if (info->name)
{
-  ret = malloc(info->nameLen);
+  ret = malloc(info->nameLen + 1);
   memcpy(ret, info->name, info->nameLen);
+  ret[info->nameLen] = 0;
   if (len) *len = info->nameLen;
}
 

-- 

[EGIT] [misc/entrance] master 01/01: Test commit

[Marcel Hollerbach]

bu5hm4n pushed a commit to branch master.

http://git.enlightenment.org/misc/entrance.git/commit/?id=c64f88186bc1aff0700610aba41fe3a8abe3e75c

commit c64f88186bc1aff0700610aba41fe3a8abe3e75c
Author: Marcel Hollerbach 
Date:   Tue Jan 21 18:12:02 2014 +0100

Test commit
---
 TODO | 2 --
 1 file changed, 2 deletions(-)

diff --git a/TODO b/TODO
index 1ee5454..000d31b 100644
--- a/TODO
+++ b/TODO
@@ -10,5 +10,3 @@
 Study possibility to use it with wayland so we can have transition when 
switching from one terminal to another.
 white and black users list
 virtual keyboard support
-
-

-- 

[EGIT] [core/elementary] master 03/04: fileselector_entry: Moved declarations of deprecated APIs to elm_deprecated.h and marked them as EINA_DEPRECATED in c code.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=389ba85493c324fc0f5a9dbb75a34d5c589203aa

commit 389ba85493c324fc0f5a9dbb75a34d5c589203aa
Author: Daniel Juyung Seo 
Date:   Tue Jan 21 23:50:31 2014 +0900

fileselector_entry: Moved declarations of deprecated APIs to
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.
---
 src/lib/elc_fileselector_entry.c|  20 ++--
 src/lib/elc_fileselector_entry_legacy.h | 168 -
 src/lib/elm_deprecated.h| 186 
 3 files changed, 196 insertions(+), 178 deletions(-)

diff --git a/src/lib/elc_fileselector_entry.c b/src/lib/elc_fileselector_entry.c
index 8d2452f..05e9a68 100644
--- a/src/lib/elc_fileselector_entry.c
+++ b/src/lib/elc_fileselector_entry.c
@@ -420,7 +420,7 @@ _constructor(Eo *obj, void *_pd EINA_UNUSED, va_list *list 
EINA_UNUSED)
  evas_obj_smart_callbacks_descriptions_set(_smart_callbacks, NULL));
 }
 
-EAPI void
+EINA_DEPRECATED EAPI void
 elm_fileselector_entry_selected_set(Evas_Object *obj,
 const char *path)
 {
@@ -438,7 +438,7 @@ _selected_set(Eo *obj EINA_UNUSED, void *_pd, va_list *list)
elm_fileselector_path_set(sd->button, path);
 }
 
-EAPI const char *
+EINA_DEPRECATED EAPI const char *
 elm_fileselector_entry_selected_get(const Evas_Object *obj)
 {
ELM_FILESELECTOR_INTERFACE_CHECK(obj, NULL);
@@ -529,7 +529,7 @@ _window_size_get(Eo *obj EINA_UNUSED, void *_pd, va_list 
*list)
elm_fileselector_button_window_size_get(sd->button, width, height);
 }
 
-EAPI void
+EINA_DEPRECATED EAPI void
 elm_fileselector_entry_path_set(Evas_Object *obj,
 const char *path)
 {
@@ -554,7 +554,7 @@ _path_set(Eo *obj EINA_UNUSED, void *_pd, va_list *list)
  }
 }
 
-EAPI const char *
+EINA_DEPRECATED EAPI const char *
 elm_fileselector_entry_path_get(const Evas_Object *obj)
 {
ELM_FILESELECTOR_INTERFACE_CHECK(obj, NULL);
@@ -574,7 +574,7 @@ _path_get(Eo *obj EINA_UNUSED, void *_pd, va_list *list)
*ret = sd->path;
 }
 
-EAPI void
+EINA_DEPRECATED EAPI void
 elm_fileselector_entry_expandable_set(Evas_Object *obj,
   Eina_Bool value)
 {
@@ -591,7 +591,7 @@ _expandable_set(Eo *obj EINA_UNUSED, void *_pd, va_list 
*list)
elm_fileselector_expandable_set(sd->button, value);
 }
 
-EAPI Eina_Bool
+EINA_DEPRECATED EAPI Eina_Bool
 elm_fileselector_entry_expandable_get(const Evas_Object *obj)
 {
ELM_FILESELECTOR_INTERFACE_CHECK(obj, EINA_FALSE);
@@ -609,7 +609,7 @@ _expandable_get(Eo *obj EINA_UNUSED, void *_pd, va_list 
*list)
*ret = elm_fileselector_expandable_get(sd->button);
 }
 
-EAPI void
+EINA_DEPRECATED EAPI void
 elm_fileselector_entry_folder_only_set(Evas_Object *obj,
Eina_Bool value)
 {
@@ -626,7 +626,7 @@ _folder_only_set(Eo *obj EINA_UNUSED, void *_pd, va_list 
*list)
elm_fileselector_folder_only_set(sd->button, value);
 }
 
-EAPI Eina_Bool
+EINA_DEPRECATED EAPI Eina_Bool
 elm_fileselector_entry_folder_only_get(const Evas_Object *obj)
 {
ELM_FILESELECTOR_INTERFACE_CHECK(obj, EINA_FALSE);
@@ -644,7 +644,7 @@ _folder_only_get(Eo *obj EINA_UNUSED, void *_pd, va_list 
*list)
*ret = elm_fileselector_folder_only_get(sd->button);
 }
 
-EAPI void
+EINA_DEPRECATED EAPI void
 elm_fileselector_entry_is_save_set(Evas_Object *obj,
Eina_Bool value)
 {
@@ -661,7 +661,7 @@ _is_save_set(Eo *obj EINA_UNUSED, void *_pd, va_list *list)
elm_fileselector_is_save_set(sd->button, value);
 }
 
-EAPI Eina_Bool
+EINA_DEPRECATED EAPI Eina_Bool
 elm_fileselector_entry_is_save_get(const Evas_Object *obj)
 {
ELM_FILESELECTOR_INTERFACE_CHECK(obj, EINA_FALSE);
diff --git a/src/lib/elc_fileselector_entry_legacy.h 
b/src/lib/elc_fileselector_entry_legacy.h
index 89d9ce5..92e59d5 100644
--- a/src/lib/elc_fileselector_entry_legacy.h
+++ b/src/lib/elc_fileselector_entry_legacy.h
@@ -79,142 +79,6 @@ EAPI void
elm_fileselector_entry_window_size_set(Evas_Obj
 EAPI voidelm_fileselector_entry_window_size_get(const 
Evas_Object *obj, Evas_Coord *width, Evas_Coord *height);
 
 /**
- * Set the initial file system path and the entry's path string for
- * a given file selector entry widget
- *
- * @param obj The file selector entry widget
- * @param path The path string
- *
- * It must be a directory path, which will have the contents
- * displayed initially in the file selector's view, when invoked
- * from @p obj. The default initial path is the @c "HOME"
- * environment variable's value.
- *
- * @see elm_fileselector_entry_path_get()
- *
- * @ingroup File_Selector_Entry
- */
-EINA_DEPRECATED EAPI voidelm_fileselector_entry_path_set(Evas_Object 
*obj, const char *path);
-
-/**
- * Get the entry's path string for a given file selector entry
- * widget
- *
- * @param obj The 

[EGIT] [core/elementary] master 01/04: fileselector_button: Moved declarations of deprecated APIs to elm_deprecated.h and marked them as EINA_DEPRECATED in c code.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=4c9f0bcbd842c8c9435fb2b0e1349a5ca48da992

commit 4c9f0bcbd842c8c9435fb2b0e1349a5ca48da992
Author: Daniel Juyung Seo 
Date:   Tue Jan 21 23:42:56 2014 +0900

fileselector_button: Moved declarations of deprecated APIs to
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.
---
 src/lib/elc_fileselector_button.c|  16 ++--
 src/lib/elc_fileselector_button_legacy.h | 137 ---
 src/lib/elm_deprecated.h | 154 +++
 3 files changed, 162 insertions(+), 145 deletions(-)

diff --git a/src/lib/elc_fileselector_button.c 
b/src/lib/elc_fileselector_button.c
index 14259b0..363c9a3 100644
--- a/src/lib/elc_fileselector_button.c
+++ b/src/lib/elc_fileselector_button.c
@@ -315,7 +315,7 @@ _window_size_get(Eo *obj EINA_UNUSED, void *_pd, va_list 
*list)
if (height) *height = sd->h;
 }
 
-EAPI void
+EINA_DEPRECATED EAPI void
 elm_fileselector_button_path_set(Evas_Object *obj,
  const char *path)
 {
@@ -334,7 +334,7 @@ _path_set(Eo *obj EINA_UNUSED, void *_pd, va_list *list)
if (sd->fs) elm_fileselector_selected_set(sd->fs, sd->fsd.path);
 }
 
-EAPI const char *
+EINA_DEPRECATED EAPI const char *
 elm_fileselector_button_path_get(const Evas_Object *obj)
 {
ELM_FILESELECTOR_INTERFACE_CHECK(obj, NULL);
@@ -352,7 +352,7 @@ _path_get(Eo *obj EINA_UNUSED, void *_pd, va_list *list)
*ret = sd->fsd.path;
 }
 
-EAPI void
+EINA_DEPRECATED EAPI void
 elm_fileselector_button_expandable_set(Evas_Object *obj,
Eina_Bool value)
 {
@@ -371,7 +371,7 @@ _expandable_set(Eo *obj EINA_UNUSED, void *_pd, va_list 
*list)
if (sd->fs) elm_fileselector_expandable_set(sd->fs, sd->fsd.expandable);
 }
 
-EAPI Eina_Bool
+EINA_DEPRECATED EAPI Eina_Bool
 elm_fileselector_button_expandable_get(const Evas_Object *obj)
 {
ELM_FILESELECTOR_INTERFACE_CHECK(obj, EINA_FALSE);
@@ -389,7 +389,7 @@ _expandable_get(Eo *obj EINA_UNUSED, void *_pd, va_list 
*list)
*ret = sd->fsd.expandable;
 }
 
-EAPI void
+EINA_DEPRECATED EAPI void
 elm_fileselector_button_folder_only_set(Evas_Object *obj,
 Eina_Bool value)
 {
@@ -408,7 +408,7 @@ _folder_only_set(Eo *obj EINA_UNUSED, void *_pd, va_list 
*list)
if (sd->fs) elm_fileselector_folder_only_set(sd->fs, sd->fsd.folder_only);
 }
 
-EAPI Eina_Bool
+EINA_DEPRECATED EAPI Eina_Bool
 elm_fileselector_button_folder_only_get(const Evas_Object *obj)
 {
ELM_FILESELECTOR_INTERFACE_CHECK(obj, EINA_FALSE);
@@ -426,7 +426,7 @@ _folder_only_get(Eo *obj EINA_UNUSED, void *_pd, va_list 
*list)
*ret = sd->fsd.folder_only;
 }
 
-EAPI void
+EINA_DEPRECATED EAPI void
 elm_fileselector_button_is_save_set(Evas_Object *obj,
 Eina_Bool value)
 {
@@ -445,7 +445,7 @@ _is_save_set(Eo *obj EINA_UNUSED, void *_pd, va_list *list)
if (sd->fs) elm_fileselector_is_save_set(sd->fs, sd->fsd.is_save);
 }
 
-EAPI Eina_Bool
+EINA_DEPRECATED EAPI Eina_Bool
 elm_fileselector_button_is_save_get(const Evas_Object *obj)
 {
ELM_FILESELECTOR_INTERFACE_CHECK(obj, EINA_FALSE);
diff --git a/src/lib/elc_fileselector_button_legacy.h 
b/src/lib/elc_fileselector_button_legacy.h
index 2cf33aa..820a69a 100644
--- a/src/lib/elc_fileselector_button_legacy.h
+++ b/src/lib/elc_fileselector_button_legacy.h
@@ -78,143 +78,6 @@ EAPI void
elm_fileselector_button_window_size_set(Evas_Ob
 EAPI voidelm_fileselector_button_window_size_get(const 
Evas_Object *obj, Evas_Coord *width, Evas_Coord *height);
 
 /**
- * Set the initial file system path for a given file selector
- * button widget
- *
- * @param obj The file selector button widget
- * @param path The path string
- *
- * It must be a directory path, which will have the contents
- * displayed initially in the file selector's view, when invoked
- * from @p obj. The default initial path is the @c "HOME"
- * environment variable's value.
- *
- * @see elm_fileselector_button_path_get()
- *
- * @ingroup File_Selector_Button
- */
-EINA_DEPRECATED EAPI voidelm_fileselector_button_path_set(Evas_Object 
*obj, const char *path);
-
-/**
- * Get the initial file system path set for a given file selector
- * button widget
- *
- * @param obj The file selector button widget
- * @return path The path string
- *
- * @see elm_fileselector_button_path_set() for more details
- *
- * @ingroup File_Selector_Button
- */
-EINA_DEPRECATED EAPI const char *elm_fileselector_button_path_get(const 
Evas_Object *obj);
-
-/**
- * Enable/disable a tree view in the given file selector button
- * widget's internal file selector
- *
- * @param obj The file selector button widget
- * @param value @c EINA_TRUE to enable tree view, @c EINA_FALSE to
- * disable
- *
- * This has the same effect as elm_fileselector_expandable_set(),
- * but no

[EGIT] [core/elementary] master 04/04: test, examples fileselector_entry: Changed the usage of deprecated APIs to recommended APIs.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=b2842f5a940d0344ea2f8bf0cdb06dae981f9726

commit b2842f5a940d0344ea2f8bf0cdb06dae981f9726
Author: Daniel Juyung Seo 
Date:   Tue Jan 21 23:53:48 2014 +0900

test, examples fileselector_entry: Changed the usage of deprecated APIs
to recommended APIs.
---
 src/examples/fileselector_entry_example.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/examples/fileselector_entry_example.c 
b/src/examples/fileselector_entry_example.c
index 0696492..2aa18ce 100644
--- a/src/examples/fileselector_entry_example.c
+++ b/src/examples/fileselector_entry_example.c
@@ -44,8 +44,8 @@ _current_sel_toggle(void*data,
 void*event_info)
 {
Evas_Object *fs_entry = data;
-   Eina_Bool old_val = elm_fileselector_entry_is_save_get(fs_entry);
-   elm_fileselector_entry_is_save_set(fs_entry, !old_val);
+   Eina_Bool old_val = elm_fileselector_is_save_get(fs_entry);
+   elm_fileselector_is_save_set(fs_entry, !old_val);
 
printf("%s text entry with selected item's name\n",
   old_val ? "Disabling" : "Enabling");
@@ -57,8 +57,8 @@ _folder_only_toggle(void*data,
 void*event_info)
 {
Evas_Object *fs_entry = data;
-   Eina_Bool old_val = elm_fileselector_entry_folder_only_get(fs_entry);
-   elm_fileselector_entry_folder_only_set(fs_entry, !old_val);
+   Eina_Bool old_val = elm_fileselector_folder_only_get(fs_entry);
+   elm_fileselector_folder_only_set(fs_entry, !old_val);
 
printf("Folder only mode set to: %s\n", old_val ? "false" : "true");
 }
@@ -69,8 +69,8 @@ _expandable_toggle(void*data,
void*event_info)
 {
Evas_Object *fs_entry = data;
-   Eina_Bool old_val = elm_fileselector_entry_expandable_get(fs_entry);
-   elm_fileselector_entry_expandable_set(fs_entry, !old_val);
+   Eina_Bool old_val = elm_fileselector_expandable_get(fs_entry);
+   elm_fileselector_expandable_set(fs_entry, !old_val);
 
printf("Expandable folders mode set to: %s\n", old_val ? "false" : "true");
 }
@@ -98,7 +98,7 @@ elm_main(intargc,
/* file selector entry */
fs_entry = elm_fileselector_entry_add(win);
evas_object_size_hint_align_set(fs_entry, EVAS_HINT_FILL, 0);
-   elm_fileselector_entry_path_set(fs_entry, "/tmp");
+   elm_fileselector_path_set(fs_entry, "/tmp");
elm_object_text_set(fs_entry, "Select a file");
elm_object_part_content_set(fs_entry, "button icon", ic);
 
@@ -119,7 +119,7 @@ elm_main(intargc,
 
ck = elm_check_add(win);
elm_object_text_set(ck, "editable selection");
-   elm_check_state_set(ck, elm_fileselector_entry_is_save_get(fs_entry));
+   elm_check_state_set(ck, elm_fileselector_is_save_get(fs_entry));
evas_object_smart_callback_add(ck, "changed", _current_sel_toggle, 
fs_entry);
elm_box_pack_end(hbox, ck);
evas_object_show(ck);
@@ -133,14 +133,14 @@ elm_main(intargc,
 
ck = elm_check_add(win);
elm_object_text_set(ck, "folders only");
-   elm_check_state_set(ck, elm_fileselector_entry_folder_only_get(fs_entry));
+   elm_check_state_set(ck, elm_fileselector_folder_only_get(fs_entry));
evas_object_smart_callback_add(ck, "changed", _folder_only_toggle, 
fs_entry);
elm_box_pack_end(hbox, ck);
evas_object_show(ck);
 
ck = elm_check_add(win);
elm_object_text_set(ck, "expandable");
-   elm_check_state_set(ck, elm_fileselector_entry_expandable_get(fs_entry));
+   elm_check_state_set(ck, elm_fileselector_expandable_get(fs_entry));
evas_object_smart_callback_add(ck, "changed", _expandable_toggle, fs_entry);
elm_box_pack_end(hbox, ck);
evas_object_show(ck);

-- 

[EGIT] [core/elementary] master 02/04: test, examples fileselector_button: Changed the usage of deprecated APIs to recommended APIs.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=f272d437d5a3c11173f4222ef93f17fe11022d56

commit f272d437d5a3c11173f4222ef93f17fe11022d56
Author: Daniel Juyung Seo 
Date:   Tue Jan 21 23:43:59 2014 +0900

test, examples fileselector_button: Changed the usage of deprecated APIs to 
recommended
APIs.
---
 src/bin/test_eio.c |  2 +-
 src/examples/fileselector_button_example.c | 20 ++--
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/bin/test_eio.c b/src/bin/test_eio.c
index 55f85b5..51118b7 100644
--- a/src/bin/test_eio.c
+++ b/src/bin/test_eio.c
@@ -223,7 +223,7 @@ test_eio(void *data EINA_UNUSED, Evas_Object *obj 
EINA_UNUSED, void *event_info
elm_object_text_set(fs_bt, "Select a dir");
elm_object_part_content_set(fs_bt, "icon", ic);
elm_fileselector_button_inwin_mode_set(fs_bt, EINA_TRUE);
-   elm_fileselector_button_folder_only_set(fs_bt, EINA_TRUE);
+   elm_fileselector_folder_only_set(fs_bt, EINA_TRUE);
 
elm_box_pack_end(hbox, fs_bt);
elm_box_pack_end(vbox, hbox);
diff --git a/src/examples/fileselector_button_example.c 
b/src/examples/fileselector_button_example.c
index 3b1f0be..e8133e1 100644
--- a/src/examples/fileselector_button_example.c
+++ b/src/examples/fileselector_button_example.c
@@ -46,8 +46,8 @@ _current_sel_toggle(void*data,
 void *event_info)
 {
Evas_Object *fs_bt = data;
-   Eina_Bool old_val = elm_fileselector_button_is_save_get(fs_bt);
-   elm_fileselector_button_is_save_set(fs_bt, !old_val);
+   Eina_Bool old_val = elm_fileselector_is_save_get(fs_bt);
+   elm_fileselector_is_save_set(fs_bt, !old_val);
 
printf("%s text entry with selected item's name\n",
   old_val ? "Disabling" : "Enabling");
@@ -59,8 +59,8 @@ _folder_only_toggle(void*data,
 void *event_info)
 {
Evas_Object *fs_bt = data;
-   Eina_Bool old_val = elm_fileselector_button_folder_only_get(fs_bt);
-   elm_fileselector_button_folder_only_set(fs_bt, !old_val);
+   Eina_Bool old_val = elm_fileselector_folder_only_get(fs_bt);
+   elm_fileselector_folder_only_set(fs_bt, !old_val);
 
printf("Folder only mode set to: %s\n", old_val ? "false" : "true");
 }
@@ -71,8 +71,8 @@ _expandable_toggle(void*data,
void *event_info)
 {
Evas_Object *fs_bt = data;
-   Eina_Bool old_val = elm_fileselector_button_expandable_get(fs_bt);
-   elm_fileselector_button_expandable_set(fs_bt, !old_val);
+   Eina_Bool old_val = elm_fileselector_expandable_get(fs_bt);
+   elm_fileselector_expandable_set(fs_bt, !old_val);
 
printf("Expandable folders mode set to: %s\n", old_val ? "false" : "true");
 }
@@ -99,7 +99,7 @@ elm_main(intargc,
 
/* file selector button */
fs_bt = elm_fileselector_button_add(win);
-   elm_fileselector_button_path_set(fs_bt, "/tmp");
+   elm_fileselector_path_set(fs_bt, "/tmp");
elm_object_text_set(fs_bt, "Select a file");
elm_object_part_content_set(fs_bt, "icon", ic);
 
@@ -120,7 +120,7 @@ elm_main(intargc,
 
ck = elm_check_add(win);
elm_object_text_set(ck, "editable selection");
-   elm_check_state_set(ck, elm_fileselector_button_is_save_get(fs_bt));
+   elm_check_state_set(ck, elm_fileselector_is_save_get(fs_bt));
evas_object_smart_callback_add(ck, "changed", _current_sel_toggle, fs_bt);
elm_box_pack_end(hbox, ck);
evas_object_show(ck);
@@ -134,14 +134,14 @@ elm_main(intargc,
 
ck = elm_check_add(win);
elm_object_text_set(ck, "folders only");
-   elm_check_state_set(ck, elm_fileselector_button_folder_only_get(fs_bt));
+   elm_check_state_set(ck, elm_fileselector_folder_only_get(fs_bt));
evas_object_smart_callback_add(ck, "changed", _folder_only_toggle, fs_bt);
elm_box_pack_end(hbox, ck);
evas_object_show(ck);
 
ck = elm_check_add(win);
elm_object_text_set(ck, "expandable");
-   elm_check_state_set(ck, elm_fileselector_button_expandable_get(fs_bt));
+   elm_check_state_set(ck, elm_fileselector_expandable_get(fs_bt));
evas_object_smart_callback_add(ck, "changed", _expandable_toggle, fs_bt);
elm_box_pack_end(hbox, ck);
evas_object_show(ck);

-- 

[EGIT] [core/enlightenment] master 01/01: cleanup frame icon upon failing to use it

[Mike Blumenkrantz]

discomfitor pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=d2f9a2efbf826f4e16c26bd6a2ea5c6e3be031ef

commit d2f9a2efbf826f4e16c26bd6a2ea5c6e3be031ef
Author: Mike Blumenkrantz 
Date:   Tue Jan 21 09:31:30 2014 -0500

cleanup frame icon upon failing to use it
---
 src/bin/e_comp_object.c | 12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/bin/e_comp_object.c b/src/bin/e_comp_object.c
index ae9ce9e..24bf67b 100644
--- a/src/bin/e_comp_object.c
+++ b/src/bin/e_comp_object.c
@@ -2535,10 +2535,13 @@ e_comp_object_frame_icon_update(Evas_Object *obj)
 {
API_ENTRY;
 
-   evas_object_del(cw->frame_icon);
+   E_FREE_FUNC(cw->frame_icon, evas_object_del);
+   if (!edje_object_part_exists(cw->frame_object, "e.swallow.icon"))
+ return;
cw->frame_icon = e_client_icon_add(cw->ec, cw->comp->evas);
if (!cw->frame_icon) return;
-   edje_object_part_swallow(cw->frame_object, "e.swallow.icon", 
cw->frame_icon);
+   if (!edje_object_part_swallow(cw->frame_object, "e.swallow.icon", 
cw->frame_icon))
+ E_FREE_FUNC(cw->frame_icon, evas_object_del);
 }
 
 EAPI Eina_Bool
@@ -2619,7 +2622,10 @@ e_comp_object_frame_theme_set(Evas_Object *obj, const 
char *name)
 if (pbg)
   {
  if (cw->frame_icon)
-   edje_object_part_swallow(cw->frame_object, "e.swallow.icon", 
cw->frame_icon);
+   {
+  if (!edje_object_part_swallow(cw->frame_object, 
"e.swallow.icon", cw->frame_icon))
+E_FREE_FUNC(cw->frame_icon, evas_object_del);
+   }
   }
 else if (cw->ec)
   {

-- 

[EGIT] [core/elementary] master 01/01: url: Added underscore(_) to elm internal functions, elm_url_xxx.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=635916ce26bd87db9e8a78df53c33d5c0527fa6c

commit 635916ce26bd87db9e8a78df53c33d5c0527fa6c
Author: Daniel Juyung Seo 
Date:   Tue Jan 21 23:23:37 2014 +0900

url: Added underscore(_) to elm internal functions, elm_url_xxx.

- _elm_url_download, _elm_url_cancel, _elm_url_get
- other internal functions in elm_priv.h also have same prefix.
---
 src/lib/elm_image.c| 12 ++--
 src/lib/elm_photocam.c | 10 +-
 src/lib/elm_priv.h |  6 +++---
 src/lib/elm_url.c  |  6 +++---
 4 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/src/lib/elm_image.c b/src/lib/elm_image.c
index c669ea2..e4e59d1 100644
--- a/src/lib/elm_image.c
+++ b/src/lib/elm_image.c
@@ -496,7 +496,7 @@ _elm_image_smart_del(Eo *obj, void *_pd, va_list *list 
EINA_UNUSED)
ecore_timer_del(sd->anim_timer);
evas_object_del(sd->img);
evas_object_del(sd->prev_img);
-   if (sd->remote) elm_url_cancel(sd->remote);
+   if (sd->remote) _elm_url_cancel(sd->remote);
free(sd->remote_data);
eina_stringshare_del(sd->key);
 
@@ -922,10 +922,10 @@ _elm_image_smart_download_done(void *data, Elm_Url *url 
EINA_UNUSED, Eina_Binbuf
if (sd->remote_data) free(sd->remote_data);
length = eina_binbuf_length_get(download);
sd->remote_data = eina_binbuf_string_steal(download);
-   f = eina_file_virtualize(elm_url_get(url),
+   f = eina_file_virtualize(_elm_url_get(url),
 sd->remote_data, length,
 EINA_FALSE);
-   _elm_image_smart_internal_file_set(obj, sd, elm_url_get(url), f, sd->key, 
&ret);
+   _elm_image_smart_internal_file_set(obj, sd, _elm_url_get(url), f, sd->key, 
&ret);
eina_file_close(f);
 
if (!ret)
@@ -992,7 +992,7 @@ _elm_image_smart_file_set(Eo *obj, void *_pd, va_list *list)
 
unsigned int i;
 
-   if (sd->remote) elm_url_cancel(sd->remote);
+   if (sd->remote) _elm_url_cancel(sd->remote);
sd->remote = NULL;
 
for (i = 0; i < sizeof (remote_uri) / sizeof (remote_uri[0]); ++i)
@@ -1000,7 +1000,7 @@ _elm_image_smart_file_set(Eo *obj, void *_pd, va_list 
*list)
{
   // Found a remote target !
   evas_object_hide(sd->img);
-  sd->remote = elm_url_download(file,
+  sd->remote = _elm_url_download(file,
 _elm_image_smart_download_done,
 _elm_image_smart_download_cancel,
 _elm_image_smart_download_progress,
@@ -1027,7 +1027,7 @@ _elm_image_smart_mmap_set(Eo *obj, void *_pd, va_list 
*list)
 
   Elm_Image_Smart_Data *sd = _pd;
 
-  if (sd->remote) elm_url_cancel(sd->remote);
+  if (sd->remote) _elm_url_cancel(sd->remote);
   sd->remote = NULL;
 
   _elm_image_smart_internal_file_set(obj, sd,
diff --git a/src/lib/elm_photocam.c b/src/lib/elm_photocam.c
index bde52ad..661e183 100644
--- a/src/lib/elm_photocam.c
+++ b/src/lib/elm_photocam.c
@@ -1413,7 +1413,7 @@ _elm_photocam_smart_del(Eo *obj, void *_pd, va_list *list 
EINA_UNUSED)
 
if (sd->f) eina_file_close(sd->f);
free(sd->remote_data);
-   if (sd->remote) elm_url_cancel(sd->remote);
+   if (sd->remote) _elm_url_cancel(sd->remote);
eina_stringshare_del(sd->file);
ecore_job_del(sd->calc_job);
ecore_timer_del(sd->scr_timer);
@@ -1560,10 +1560,10 @@ _elm_photocam_download_done(void *data, Elm_Url *url 
EINA_UNUSED, Eina_Binbuf *d
if (sd->remote_data) free(sd->remote_data);
length = eina_binbuf_length_get(download);
sd->remote_data = eina_binbuf_string_steal(download);
-   f = eina_file_virtualize(elm_url_get(url),
+   f = eina_file_virtualize(_elm_url_get(url),
 sd->remote_data, length,
 EINA_FALSE);
-   _internal_file_set(obj, sd, elm_url_get(url), f, &ret);
+   _internal_file_set(obj, sd, _elm_url_get(url), f, &ret);
eina_file_close(f);
 
if (ret != EVAS_LOAD_ERROR_NONE)
@@ -1634,14 +1634,14 @@ _file_set(Eo *obj, void *_pd, va_list *list)
sd->f = NULL;
 
free(sd->remote_data);
-   if (sd->remote) elm_url_cancel(sd->remote);
+   if (sd->remote) _elm_url_cancel(sd->remote);
sd->remote = NULL;
 
for (i = 0; i < sizeof (remote_uri) / sizeof (remote_uri[0]); ++i)
  if (strncmp(remote_uri[i], file, strlen(remote_uri[i])) == 0)
{
   // Found a remote target !
-  sd->remote = elm_url_download(file,
+  sd->remote = _elm_url_download(file,
 _elm_photocam_download_done,
 _elm_photocam_download_cancel,
 _elm_photocam_download_progress,
diff --git a/src/lib/elm_priv.h b/src/lib/elm_priv.h
index c2e1948..0c997ed 100644
--- a/src/lib/elm_priv.h
+++ b/src/lib/elm_priv.h
@@ -475,9 +475,9 @@ typedef void (*Elm_Url_Done)(void *data, Elm_Url *url, 
Eina_Binbuf *do

[E-devel] Segmentation fault in e_desk.c

[Chris Seekamp]

I am getting a crash (segmentation) fault trying to start e18. I have 
built EFL with "--with-opengl=es" and have compositing with OpenGL 
working with e17 (0.17.6).  e17 starts and runs perfectly as far as I 
can tell.  I previously tried earlier versions of EFL and e18 and got 
the same segmentation fault. I am now using EFL 1.8.4 and e18 0.18.2.  I 
am attaching the output from enlightenment and the output of gdb showing 
the backtrace, but I will summarize here. The tail of the enlightenment 
output is:


ESTART: 0.32291 [0.3] - Screens Init
ESTART: 0.32293 [0.2] - screens: atoms
ESTART: 0.32324 [0.00031] - screens: manager
ESTART: 0.32330 [0.6] - screens: container
ESTART: 0.32332 [0.2] - screens: zone
ESTART: 0.32334 [0.2] - screens: desk
ESTART: 0.32336 [0.2] - screens: menu
ESTART: 0.32339 [0.3] - screens: exehist
ESTART: 0.32343 [0.4] - screens: get roots
ESTART: 0.32345 [0.2] - screens: focus
ESTART: 0.32346 [0.2] - screens: border
ESTART: 0.32351 [0.4] - E_Comp Init
ESTART: 0.32607 [0.00257] - E_Comp Init Done
ESTART: 0.32611 [0.3] - screens: win
ESTART: 0.32616 [0.6] - E_Xkb Init
INFe_xkb.c:147 SET XKB RUN: setxkbmap -layout 'us,' -variant ',' 
-model 'default'

ESTART: 0.32987 [0.00370] - E_Xkb Init Done
ESTART: 0.32993 [0.6] - E_Dnd Init
ESTART: 0.33024 [0.00032] - E_Dnd Init Done
ESTART: 0.33027 [0.2] - screens: manage roots

The backtrace from gdb is:

Core was generated by `/usr/bin/enlightenment'.
Program terminated with signal 11, Segmentation fault.
#0  0x000618e2 in e_desk_show (desk=) at e_desk.c:306
(gdb) bt
#0  0x000618e2 in e_desk_show (desk=) at e_desk.c:306
#1  0x000c58ea in e_zone_desk_count_set (zone=zone@entry=0x15c6fe8, 
x_count=, y_count=) at e_zone.c:685
#2  0x000c63b6 in e_zone_new (con=con@entry=0x15c5a38, num=out>, id=0, x=0, y=0, w=w@entry=1366, h=h@entry=768) at e_zone.c:251
#3  0x0005f7f4 in e_container_new (man=man@entry=0x150fb40) at 
e_container.c:127

#4  0x00035de0 in _e_main_screens_init () at e_main.c:1657
#5  main (argc=, argv=) at e_main.c:628

I can see that dbus is running and there there are X sockets.  I 
installed evas-generic-loaders, emotion-generic-players, terminology, 
and python-EFL but I get the same thing. The enlightenment output does 
show one error:


ERRmodules/emotion/generic/emotion_generic.c:1838 no 
generic players available


I don't know if that is significant or not.

Can someone tell me how what I might do to try to figure out what is 
going wrong? BTW, I have run as both root and non-root with the same 
result, so I don't think it is a permissions thing.  I know The 
Rasterman is swamped right now, but maybe someone else can give me some 
pointers?  Maybe even knowing what it is trying to do when it fails 
would be helpful. I have seen some other enlightenment traces that show 
some type of configuration or socket thing going on right after the 
"screens: manage roots" output, so maybe this means something to someone.


Thanks in advance.

--
Chris Seekamp
cseek...@acm.org
(using icedove on bodhi linux)

ESTART: 0.0 [0.0] - Begin Startup
ESTART: 0.00010 [0.00010] - Signal Trap
ESTART: 0.00012 [0.2] - Signal Trap Done
ESTART: 0.00017 [0.5] - Eina Init
ESTART: 0.00091 [0.00074] - Eina Init Done
ESTART: 0.00092 [0.1] - Determine Prefix
INF<e>e_prefix.c:25 =
INF<e>e_prefix.c:26 Enlightenment relocation handling
INF<e>e_prefix.c:27 =
INF<e>e_prefix.c:28 PREFIX:  /usr
INF<e>e_prefix.c:29 BINDIR:  /usr/bin
INF<e>e_prefix.c:30 LIBDIR:  
/usr/lib/arm-linux-gnueabihf
INF<e>e_prefix.c:31 DATADIR: /usr/share/enlightenment
INF<e>e_prefix.c:32 LOCALE:  /usr/share/locale
INF<e>e_prefix.c:33 =
ESTART: 0.00137 [0.00045] - Determine Prefix Done
ESTART: 0.00146 [0.9] - Environment Variables
ESTART: 0.00151 [0.5] - Environment Variables Done
ESTART: 0.00153 [0.2] - Parse Arguments
ESTART: 0.00156 [0.3] - Parse Arguments Done
ESTART: 0.00157 [0.2] - Eet Init
ESTART: 0.00765 [0.00608] - Eet Init Done
ESTART: 0.00769 [0.4] - Ecore Init
ESTART: 0.01407 [0.00638] - Ecore Init Done
ESTART: 0.01413 [0.5] - EIO Init
ESTART: 0.01432 [0.00019] - EIO Init Done
ESTART: 0.01435 [0.3] - Ecore Event Handlers
ESTART: 0.01437 [0.2] - Ecore Event Handlers Done
ESTART: 0.01438 [0.1] - Ecore_File Init
ESTART: 0.01620 [0.00182] - Ecore_File Init Done
ESTART: 0.01623 [0.3] - Ecore_Con Init
ESTART: 0.01626 [0.2] - Ecore_Con Init Done
ESTART: 0.01627 [0.1] - Ecore_Ipc Init
ESTART: 0.01632 [0.5] - Ecore_Ipc Init Done
ESTART: 0.01636 [0.4] - Ecore_X Init
ESTART: 0.02441 

[EGIT] [core/elementary] master 01/01: elm: Removed unnecessary null check for ecore_timer_del, ecore_animator_del, and ecore_job_del.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=e3372339d8dbfaa4d85eae118bb940021fe6b2ce

commit e3372339d8dbfaa4d85eae118bb940021fe6b2ce
Author: Daniel Juyung Seo 
Date:   Tue Jan 21 23:16:41 2014 +0900

elm: Removed unnecessary null check for ecore_timer_del,
 ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
---
 src/lib/elc_naviframe.c| 10 +++
 src/lib/elm_actionslider.c |  6 ++--
 src/lib/elm_box.c  |  2 +-
 src/lib/elm_calendar.c | 14 -
 src/lib/elm_clock.c|  8 ++---
 src/lib/elm_cnp.c  |  3 +-
 src/lib/elm_colorselector.c|  4 +--
 src/lib/elm_config.c   |  4 +--
 src/lib/elm_conform.c  | 12 
 src/lib/elm_entry.c| 30 ---
 src/lib/elm_flip.c |  6 ++--
 src/lib/elm_flipselector.c |  6 ++--
 src/lib/elm_gengrid.c  | 32 ++--
 src/lib/elm_genlist.c  | 61 +++---
 src/lib/elm_gesture_layer.c|  2 +-
 src/lib/elm_image.c|  6 ++--
 src/lib/elm_index.c|  6 ++--
 src/lib/elm_interface_scrollable.c | 16 +-
 src/lib/elm_list.c |  4 +--
 src/lib/elm_map.c  | 22 +++---
 src/lib/elm_notify.c   |  4 +--
 src/lib/elm_photo.c|  4 +--
 src/lib/elm_photocam.c | 29 +-
 src/lib/elm_slider.c   | 10 +++
 src/lib/elm_slideshow.c|  2 +-
 src/lib/elm_spinner.c  | 14 -
 src/lib/elm_store.c|  4 +--
 src/lib/elm_toolbar.c  |  8 ++---
 src/lib/elm_video.c|  2 +-
 src/lib/elm_web.c  | 10 +++
 src/lib/elm_win.c  | 21 ++---
 src/lib/els_tooltip.c  |  2 +-
 32 files changed, 175 insertions(+), 189 deletions(-)

diff --git a/src/lib/elc_naviframe.c b/src/lib/elc_naviframe.c
index cd23618..6143f2a 100644
--- a/src/lib/elc_naviframe.c
+++ b/src/lib/elc_naviframe.c
@@ -504,7 +504,7 @@ _item_del_pre_hook(Elm_Object_Item *it)
nit = (Elm_Naviframe_Item *)it;
ELM_NAVIFRAME_DATA_GET(WIDGET(nit), sd);
 
-   if (nit->animator) ecore_animator_del(nit->animator);
+   ecore_animator_del(nit->animator);
 
top = (it == elm_naviframe_top_item_get(WIDGET(nit)));
if (evas_object_data_get(VIEW(nit), "out_of_list"))
@@ -1397,7 +1397,7 @@ _elm_naviframe_smart_del(Eo *obj, void *_pd, va_list 
*list EINA_UNUSED)
//All popping items which are not called yet by animator.
EINA_LIST_FREE(sd->popping, it)
  {
-if (it->animator) ecore_animator_del(it->animator);
+ecore_animator_del(it->animator);
 elm_widget_item_del(it);
  }
 
@@ -1542,7 +1542,7 @@ _item_push(Eo *obj, void *_pd, va_list *list)
 prev_it->unfocusable = elm_widget_tree_unfocusable_get(VIEW(prev_it));
 elm_widget_tree_unfocusable_set(VIEW(prev_it), EINA_TRUE);
 
-if (it->animator) ecore_animator_del(it->animator);
+ecore_animator_del(it->animator);
 it->animator = ecore_animator_add(_push_transition_cb, it);
  }
else
@@ -1738,7 +1738,7 @@ _item_pop(Eo *obj, void *_pd, va_list *list)
 edje_object_message_signal_process(elm_layout_edje_get(VIEW(it)));
 edje_object_message_signal_process(elm_layout_edje_get(VIEW(prev_it)));
 
-if (it->animator) ecore_animator_del(it->animator);
+ecore_animator_del(it->animator);
 it->animator = ecore_animator_add(_pop_transition_cb, it);
 sd->popping = eina_list_append(sd->popping, it);
  }
@@ -1824,7 +1824,7 @@ elm_naviframe_item_promote(Elm_Object_Item *it)
 
edje_object_message_signal_process(elm_layout_edje_get(VIEW(prev_it)));
edje_object_message_signal_process(elm_layout_edje_get(VIEW(nit)));
-   if (nit->animator) ecore_animator_del(nit->animator);
+   ecore_animator_del(nit->animator);
nit->animator = ecore_animator_add(_push_transition_cb, nit);
 }
 
diff --git a/src/lib/elm_actionslider.c b/src/lib/elm_actionslider.c
index 7426417..8106f15 100644
--- a/src/lib/elm_actionslider.c
+++ b/src/lib/elm_actionslider.c
@@ -285,7 +285,7 @@ _drag_button_up_cb(void *data,
 sd->final_position = 0.5;
 evas_object_smart_callback_call(obj, SIG_SELECTED, (char *)center);
 
-if (sd->button_animator) ecore_animator_del(sd->button_animator);
+ecore_animator_del(sd->button_animator);
 sd->button_animator = ecore_animator_add(_button_animator, obj);
 
 return;
@@ -344,7 +344,7 @@ _drag_button_up_cb(void *data,
 else
   sd->final_

[EGIT] [apps/terminology] master 02/02: update - support gstreamer1 module for efl 1.9

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/apps/terminology.git/commit/?id=aef172b4c523b6200d71a9e14802d19ba530901c

commit aef172b4c523b6200d71a9e14802d19ba530901c
Author: Carsten Haitzler (Rasterman) 
Date:   Tue Jan 21 22:29:59 2014 +0900

update - support gstreamer1 module for efl 1.9
---
 src/bin/main.c  |  2 +-
 src/bin/options_video.c | 11 +++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/bin/main.c b/src/bin/main.c
index 5b166ae..caa761e 100644
--- a/src/bin/main.c
+++ b/src/bin/main.c
@@ -2536,7 +2536,7 @@ main_ipc_new(Ipc_Instance *inst)
 }
 
 static const char *emotion_choices[] = {
-  "auto", "gstreamer", "xine", "generic",
+  "auto", "gstreamer", "xine", "generic", "gstreamer1",
   NULL
 };
 
diff --git a/src/bin/options_video.c b/src/bin/options_video.c
index 1bfa279..74d5668 100644
--- a/src/bin/options_video.c
+++ b/src/bin/options_video.c
@@ -142,6 +142,17 @@ options_video(Evas_Object *opbox, Evas_Object *term)
evas_object_show(o);
evas_object_smart_callback_add(o, "changed",
   _cb_op_video_vidmod_chg, term);
+
+   o = elm_radio_add(opbox);
+   evas_object_size_hint_weight_set(o, EVAS_HINT_EXPAND, 0.0);
+   evas_object_size_hint_align_set(o, EVAS_HINT_FILL, 0.5);
+   elm_object_text_set(o, "Gstreamer 1.0");
+   elm_radio_state_value_set(o, 4);
+   elm_radio_group_add(o, op_vidmod);
+   elm_box_pack_end(bx0, o);
+   evas_object_show(o);
+   evas_object_smart_callback_add(o, "changed",
+  _cb_op_video_vidmod_chg, term);

elm_radio_value_set(o, config->vidmod);
 

-- 

[EGIT] [apps/terminology] master 01/02: update url handling to detect yourupe-dl output url streams

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/apps/terminology.git/commit/?id=c8f20f93121f6595315e26f5dcd095977056ef55

commit c8f20f93121f6595315e26f5dcd095977056ef55
Author: Carsten Haitzler (Rasterman) 
Date:   Tue Jan 21 22:27:10 2014 +0900

update url handling to detect yourupe-dl output url streams
---
 src/bin/media.c | 21 ++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/src/bin/media.c b/src/bin/media.c
index c22d363..1ea3e3a 100644
--- a/src/bin/media.c
+++ b/src/bin/media.c
@@ -680,8 +680,9 @@ _type_mov_init(Evas_Object *obj)
 NULL,
 "gstreamer",
 "xine",
-"vlc"
- };
+"vlc",
+"gstreamer1"
+};
char *mod = NULL;
 
Media *sd = evas_object_smart_data_get(obj);
@@ -1315,11 +1316,25 @@ media_src_type_get(const char *src)
 query = strchr(src, '?');
 if (query)
   {
- if (strchr(query + 1, '=') && strchr(query + 1, '&'))
+ if (strchr(query + 1, '=') && !strchr(query + 1, '&'))
+   {
+  const char *p = strstr(src, "www.youtube.com/watch");
+  
+  if (p && (p < query))
+type = TYPE_MOV;
+   }
+ else if (strchr(query + 1, '=') && strchr(query + 1, '&'))
{
   const char *p = strstr(src, ".youtube.com/");
+  
   if (p && (p < query))
 type = TYPE_MOV;
+  else
+{
+   p = strstr(src, ".googlevideo.com/");
+   if (p && (p < query))
+ type = TYPE_MOV;
+}
}
   }
  }

-- 

[EGIT] [core/elementary] master 02/02: spinner: Create an internal entry when it is really needed.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=5eee2aa4162193c600764fcd81248b6fde305cb2

commit 5eee2aa4162193c600764fcd81248b6fde305cb2
Author: Daniel Juyung Seo 
Date:   Tue Jan 21 22:12:53 2014 +0900

spinner: Create an internal entry when it is really needed.

Do not create the internal entry on smart add. Create that when it is
needed with editable mode.
---
 src/lib/elm_spinner.c | 57 +++
 1 file changed, 30 insertions(+), 27 deletions(-)

diff --git a/src/lib/elm_spinner.c b/src/lib/elm_spinner.c
index 99311a7..9fb3c7e 100644
--- a/src/lib/elm_spinner.c
+++ b/src/lib/elm_spinner.c
@@ -258,24 +258,46 @@ _entry_value_apply(Evas_Object *obj)
 }
 
 static void
-_entry_toggle_cb(void *data,
- Evas_Object *obj EINA_UNUSED,
+_entry_activated_cb(void *data,
+Evas_Object *obj EINA_UNUSED,
+void *event_info EINA_UNUSED)
+{
+   ELM_SPINNER_DATA_GET(data, sd);
+
+   _entry_value_apply(data);
+   evas_object_smart_callback_call(data, SIG_CHANGED, NULL);
+   if (sd->delay_timer) ecore_timer_del(sd->delay_timer);
+   sd->delay_timer = ecore_timer_add(0.2, _delay_change, data);
+}
+
+static void
+_entry_toggle_cb(void *data EINA_UNUSED,
+ Evas_Object *obj,
  const char *emission EINA_UNUSED,
  const char *source EINA_UNUSED)
 {
-   ELM_SPINNER_DATA_GET(data, sd);
+   ELM_SPINNER_DATA_GET(obj, sd);
 
if (sd->dragging)
  {
 sd->dragging = 0;
 return;
  }
-   if (elm_widget_disabled_get(data)) return;
+   if (elm_widget_disabled_get(obj)) return;
if (!sd->editable) return;
-   if (sd->entry_visible) _entry_value_apply(data);
+   if (sd->entry_visible) _entry_value_apply(obj);
else
  {
-elm_layout_signal_emit(data, "elm,state,active", "elm");
+if (!sd->ent)
+  {
+ sd->ent = elm_entry_add(obj);
+ elm_entry_single_line_set(sd->ent, EINA_TRUE);
+ evas_object_smart_callback_add
+(sd->ent, "activated", _entry_activated_cb, obj);
+ elm_layout_content_set(obj, "elm.swallow.entry", sd->ent);
+  }
+
+elm_layout_signal_emit(obj, "elm,state,active", "elm");
 _entry_show(sd);
 elm_entry_select_all(sd->ent);
 elm_widget_focus_set(sd->ent, EINA_TRUE);
@@ -402,19 +424,6 @@ _button_dec_stop_cb(void *data,
 }
 
 static void
-_entry_activated_cb(void *data,
-Evas_Object *obj EINA_UNUSED,
-void *event_info EINA_UNUSED)
-{
-   ELM_SPINNER_DATA_GET(data, sd);
-
-   _entry_value_apply(data);
-   evas_object_smart_callback_call(data, SIG_CHANGED, NULL);
-   if (sd->delay_timer) ecore_timer_del(sd->delay_timer);
-   sd->delay_timer = ecore_timer_add(0.2, _delay_change, data);
-}
-
-static void
 _elm_spinner_smart_sizing_eval(Eo *obj, void *_pd EINA_UNUSED, va_list *list 
EINA_UNUSED)
 {
Evas_Coord minw = -1, minh = -1;
@@ -482,7 +491,7 @@ _elm_spinner_smart_event(Eo *obj, void *_pd EINA_UNUSED, 
va_list *list)
  (!strcmp(ev->key, "KP_Enter")) ||
  (!strcmp(ev->key, "space")))
   {
- _entry_toggle_cb(obj, NULL, NULL, NULL);
+ _entry_toggle_cb(NULL, obj, NULL, NULL);
   }
  }
else if (type == EVAS_CALLBACK_KEY_UP)
@@ -710,14 +719,8 @@ _elm_spinner_smart_add(Eo *obj, void *_pd, va_list *list 
EINA_UNUSED)
edje_object_part_drag_value_set
  (wd->resize_obj, "elm.dragable.slider", 0.0, 0.0);
 
-   priv->ent = elm_entry_add(obj);
-   elm_entry_single_line_set(priv->ent, EINA_TRUE);
-   evas_object_smart_callback_add
- (priv->ent, "activated", _entry_activated_cb, obj);
-
-   elm_layout_content_set(obj, "elm.swallow.entry", priv->ent);
elm_layout_signal_callback_add
- (obj, "elm,action,entry,toggle", "*", _entry_toggle_cb, obj);
+ (obj, "elm,action,entry,toggle", "*", _entry_toggle_cb, NULL);
 
_label_write(obj);
elm_widget_can_focus_set(obj, EINA_TRUE);

-- 

[EGIT] [core/elementary] master 01/02: spinner: Toggle entry on Enter and space key.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=689763485b3a0bfb520dd6e84aeba2c5da056ef7

commit 689763485b3a0bfb520dd6e84aeba2c5da056ef7
Author: Daniel Juyung Seo 
Date:   Tue Jan 21 21:59:41 2014 +0900

spinner: Toggle entry on Enter and space key.
---
 src/lib/elm_spinner.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/src/lib/elm_spinner.c b/src/lib/elm_spinner.c
index be5121e..99311a7 100644
--- a/src/lib/elm_spinner.c
+++ b/src/lib/elm_spinner.c
@@ -478,6 +478,12 @@ _elm_spinner_smart_event(Eo *obj, void *_pd EINA_UNUSED, 
va_list *list)
 
  goto success;
   }
+else if ((!strcmp(ev->key, "Return")) ||
+ (!strcmp(ev->key, "KP_Enter")) ||
+ (!strcmp(ev->key, "space")))
+  {
+ _entry_toggle_cb(obj, NULL, NULL, NULL);
+  }
  }
else if (type == EVAS_CALLBACK_KEY_UP)
  {

-- 

[EGIT] [core/enlightenment] master 01/01: make example/syntac for app action useful.

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=9b4b003c40a3fcd431457ef54c3d19642fed99f1

commit 9b4b003c40a3fcd431457ef54c3d19642fed99f1
Author: Carsten Haitzler (Rasterman) 
Date:   Tue Jan 21 21:30:17 2014 +0900

make example/syntac for app action useful.
---
 src/bin/e_actions.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/e_actions.c b/src/bin/e_actions.c
index b70065f..3c8950f 100644
--- a/src/bin/e_actions.c
+++ b/src/bin/e_actions.c
@@ -3312,7 +3312,7 @@ e_actions_init(void)
/* app */
ACT_GO(app);
e_action_predef_name_set(N_("Launch"), N_("Application"), "app", NULL,
-"syntax: , example:", 1);
+"syntax: [file:file.desktop|name:App 
Name|generic:Generic Name|exe:exename], example: file:terminology.desktop | 
file:/path/to/terminology.desktop | name:Terminology | generic:Terminal 
Emulator | exe:xterm", 1);
 
/* new instance of focused app */
ACT_GO(app_new_instance);

-- 

[EGIT] [core/enlightenment] master 01/01: e shot - allow params to share/save now (also specify quality and screen)

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=b399b6a9cadb353e120ea66bbd6ea465337df412

commit b399b6a9cadb353e120ea66bbd6ea465337df412
Author: Carsten Haitzler (Rasterman) 
Date:   Tue Jan 21 21:21:13 2014 +0900

e shot - allow params to share/save now (also specify quality and screen)
---
 src/modules/shot/e_mod_main.c | 82 +++
 1 file changed, 59 insertions(+), 23 deletions(-)

diff --git a/src/modules/shot/e_mod_main.c b/src/modules/shot/e_mod_main.c
index 2efdfea..93171e6 100644
--- a/src/modules/shot/e_mod_main.c
+++ b/src/modules/shot/e_mod_main.c
@@ -171,9 +171,12 @@ _save_to(const char *file)
   snprintf(opts, sizeof(opts), "quality=%i", quality);
if (screen == -1)
  {
-if (!evas_object_image_save(o_img, file, NULL, opts))
-  e_util_dialog_show(_("Error saving screenshot file"),
- _("Path: %s"), file);
+if (o_img)
+  {
+ if (!evas_object_image_save(o_img, file, NULL, opts))
+ e_util_dialog_show(_("Error saving screenshot file"),
+_("Path: %s"), file);
+  }
  }
else
  {
@@ -189,25 +192,29 @@ _save_to(const char *file)
 if (z)
   {
  unsigned char *src, *dst, *s, *d;
- int sstd, y;
+ int sstd, dstd, y;
  
  o = evas_object_image_add(evas_object_evas_get(o_img));
  evas_object_image_colorspace_set(o, EVAS_COLORSPACE_ARGB);
  evas_object_image_alpha_set(o, EINA_FALSE);
  evas_object_image_size_set(o, z->w, z->h);
+ dstd = evas_object_image_stride_get(o);
  src = evas_object_image_data_get(o_img, EINA_FALSE);
  sstd = evas_object_image_stride_get(o_img);
  dst = evas_object_image_data_get(o, EINA_TRUE);
- d = dst;
- for (y = z->y; y < z->y + z->h; y++)
+ if ((dstd > 0) && (sstd > 0) && (src) && (dst))
{
-  s = src + (sstd * y) + (z->x * 4);
-  memcpy(d, s, z->w * 4);
-  d += z->w * 4;
+  d = dst;
+  for (y = z->y; y < z->y + z->h; y++)
+{
+   s = src + (sstd * y) + (z->x * 4);
+   memcpy(d, s, z->w * 4);
+   d += dstd;
+}
+  if (!evas_object_image_save(o, file, NULL, opts))
+  e_util_dialog_show(_("Error saving screenshot file"),
+ _("Path: %s"), file);
}
- if (!evas_object_image_save(o, file, NULL, opts))
-   e_util_dialog_show(_("Error saving screenshot file"),
-  _("Path: %s"), file);
 
  evas_object_del(o);
   }
@@ -601,7 +608,7 @@ _rect_down_cb(void *data __UNUSED__, Evas *e __UNUSED__, 
Evas_Object *obj __UNUS
 }
 
 static void
-_shot_now(E_Zone *zone, E_Client *ec)
+_shot_now(E_Zone *zone, E_Client *ec, const char *params)
 {
Ecore_X_Image *img;
unsigned char *src;
@@ -825,17 +832,44 @@ _shot_now(E_Zone *zone, E_Client *ec)
e_win_resize(win, w, h);
e_win_size_min_set(win, w, h);
e_win_size_max_set(win, 9, 9);
-   e_win_show(win);
-   e_win_client_icon_set(win, "screenshot");

-   if (!e_widget_focus_get(o_bg)) e_widget_focus_set(o_box, 1);
+   if (params)
+ {
+char smode[128], squal[128], sscreen[128];
+
+if (sscanf(params, "%100s %100s %100s", smode, squal, sscreen) == 3)
+  {
+ screen = -1;
+ if (!strcmp(sscreen, "current")) screen = zone->num;
+ else if (!strcmp(sscreen, "all")) screen = -1;
+ else screen = atoi(sscreen);
+ 
+ quality = 90;
+ if (!strcmp(squal, "perfect")) quality = 100;
+ else if (!strcmp(squal, "high")) quality = 90;
+ else if (!strcmp(squal, "medium")) quality = 70;
+ else if (!strcmp(squal, "low")) quality = 50;
+ else quality = atoi(squal);
+ 
+ if (!strcmp(smode, "save")) _win_save_cb(NULL, NULL);
+ else if (!strcmp(smode, "share"))  _win_share_cb(NULL, NULL);
+ return;
+  }
+ }
+   else
+ {
+e_win_show(win);
+e_win_client_icon_set(win, "screenshot");
+
+if (!e_widget_focus_get(o_bg)) e_widget_focus_set(o_box, 1);
+ }
 }
 
 static Eina_Bool
 _shot_delay(void *data)
 {
timer = NULL;
-   _shot_now(data, NULL);
+   _shot_now(data, NULL, NULL);
return EINA_FALSE;
 }
 
@@ -843,7 +877,7 @@ static Eina_Bool
 _shot_delay_border(void *data)
 {
border_timer = NULL;
-   _shot_now(NULL, data);
+   _shot_now(NULL, data, NULL);
return EINA_FALSE;
 }
 
@@ -884,11 +918,11 @@ _e_mod_action_bor

[EGIT] [core/elementary] master 01/01: entry: NULL should be set to the correct position of tmpbuf.

[WooHyun Jung]

woohyun pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=6d5a1a3d25a671ddb7d6c007596274ceb77ef2e6

commit 6d5a1a3d25a671ddb7d6c007596274ceb77ef2e6
Author: WooHyun Jung 
Date:   Tue Jan 21 21:00:29 2014 +0900

entry: NULL should be set to the correct position of tmpbuf.

If edje_object_part_text_get gives different text from original one,
length of text can be changed. So the last position of tmpbuf should
be calculated again refering to the current text to be returned.
---
 src/lib/elm_entry.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c
index 29991b9..51d321f 100644
--- a/src/lib/elm_entry.c
+++ b/src/lib/elm_entry.c
@@ -2829,12 +2829,12 @@ proceed:
if (sd->append_text_len > 0)
  {
 char *tmpbuf;
-size_t tlen;
+size_t len, tlen;
 
 tlen = strlen(text);
+len = tlen + sd->append_text_len - sd->append_text_position;
 /* FIXME: need that or we do copy uninitialised data */
-tmpbuf = calloc(1, tlen + sd->append_text_len -
-sd->append_text_position + 1);
+tmpbuf = calloc(1, len + 1);
 if (!tmpbuf)
   {
  ERR("Failed to allocate memory for entry's text %p", obj);
@@ -2846,7 +2846,7 @@ proceed:
   memcpy(tmpbuf + tlen, sd->append_text_left
  + sd->append_text_position, sd->append_text_len
  - sd->append_text_position);
-tmpbuf[sd->append_text_len] = '\0';
+tmpbuf[len] = '\0';
 eina_stringshare_replace(&sd->text, tmpbuf);
 free(tmpbuf);
  }

-- 

Re: [E-devel] Efreer init error

[David Seikel]

On Tue, 21 Jan 2014 12:16:34 +0900 Carsten Haitzler (The Rasterman)
 wrote:

> On Tue, 21 Jan 2014 02:59:16 + Prathamesh P Ghanekar
>  said:
> 
> > Hi Carsten,
> > 
> > > either the filesystem is read-only or it doesn't have permissions
> > File system is not read only, and all folders have 777 permission.
> > 
> > Could it be the other possibility mentioned in the error message
> > i.e. " out of memory or disk space"?? I am confused, since we are
> > hosting file system on the network(NFS),so memory issue seems
> > unlikely.
> 
> it could be the nfs server refusing writes despite apparent
> permissions. like a read-only filesystem mount. either way when it
> tries to make that directory - it fails and thus barfs. why the
> directory creation fails is in your ballcourt. it's your system and
> setup. you built it and configured it. this works correctly in all
> normal cases where your .cache dir is on a writable filesystem. every
> linux distro i know of ships this way out of the box. what you have
> created does not. /opt/home already is totally non-standard and
> bizarre soit's now your job to figure out why your bizarre setup is
> broken. :)

All is not lost though, you do get the bonus of getting to keep all the
pieces.  B-)

> > Regards,
> > Prathamesh
> > 
> > 
> > 
> > -Original Message-
> > From: Carsten Haitzler [mailto:ras...@rasterman.com] 
> > Sent: 20 January 2014 18:41
> > To: Prathamesh P Ghanekar
> > Cc: enlightenment-devel@lists.sourceforge.net
> > Subject: Re: Efreer init error
> > 
> > On Mon, 20 Jan 2014 09:52:32 + Prathamesh P Ghanekar
> >  said:
> > 
> > > Hi,
> > > 
> > > We are getting the following error on running the Enlightenment
> > > binary.
> > > 
> > > ESTART: 0.70869 [0.8] - Efreet Init ERR<2624>:efreet_cache 
> > > efreet_cache.c:140 efreet_cache_init() Failed to create directory 
> > > '/opt/home/app/.cache/efreet'  Enlightenment Error  
> > > Enlightenment cannot initialize the FDO desktop system.
> > > Perhaps you lack permissions on ~/.cache/efreet or are out of
> > > memory or disk space?
> > > E17: Begin Shutdown Procedure!
> > > 
> > > We checked the permissions of the directories etc., all seems
> > > ok..! This is w.r.t enlightenment binary that comes with
> > > Tizen-IVI pre-built image.Can you help us solve this issue?
> > 
> > that issue literally means it can't create that directory. either
> > the filesystem is read-only or it doesn't have permissions. you
> > know tizen likes to be extra-annoying permission-wise with smack?
> > this isn't easily visible via normal tools.
> > 
> > --
> > - Codito, ergo sum - "I code, therefore I am"
> > -- The Rasterman (Carsten Haitzler)
> > ras...@rasterman.com
> > 
> > 
> > ~~Disclaimer~~~
> > Information contained and transmitted by this e-mail is
> > confidential and proprietary to iGATE and its affiliates and is
> > intended for use only by the recipient. If you are not the intended
> > recipient, you are hereby notified that any dissemination,
> > distribution, copying or use of this e-mail is strictly prohibited
> > and you are requested to delete this e-mail immediately and notify
> > the originator or mailad...@igate.com .
> > iGATE does not enter into any agreement with any party by e-mail.
> > Any views expressed by an individual do not necessarily reflect the
> > view of iGATE. iGATE is not responsible for the consequences of any
> > actions taken on the basis of information provided, through this
> > email. The contents of an attachment to this e-mail may contain
> > software viruses, which could damage your own computer system.
> > While iGATE has taken every reasonable precaution to minimise this
> > risk, we cannot accept liability for any damage which you sustain
> > as a result of software viruses. You should carry out your own
> > virus checks before opening an attachment. To know more about iGATE
> > please visit www.igate.com .
> > 
> > 
> 
> 


-- 
A big old stinking pile of genius that no one wants
coz there are too many silver coated monkeys in the world.


signature.asc
Description: PGP signature
--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenmen

[EGIT] [core/elementary] master 02/03: elm: Fixed formatting about EINA_LOG stuff.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=c814ac54e3a80d05be722a3dd2720ddd6362d883

commit c814ac54e3a80d05be722a3dd2720ddd6362d883
Author: Daniel Juyung Seo 
Date:   Tue Jan 21 12:08:20 2014 +0900

elm: Fixed formatting about EINA_LOG stuff.
---
 src/edje_externals/private.h | 2 +-
 src/lib/elm_priv.h   | 2 +-
 src/modules/prefs/private.h  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/edje_externals/private.h b/src/edje_externals/private.h
index b8ff7a7..22b863f 100644
--- a/src/edje_externals/private.h
+++ b/src/edje_externals/private.h
@@ -10,7 +10,7 @@
 #undef INF
 #undef DBG
 
-#define CRI(...) EINA_LOG_DOM_CRIT(_elm_ext_log_dom, __VA_ARGS__)
+#define CRI(...)  EINA_LOG_DOM_CRIT(_elm_ext_log_dom, __VA_ARGS__)
 #define ERR(...)  EINA_LOG_DOM_ERR (_elm_ext_log_dom, __VA_ARGS__)
 #define WRN(...)  EINA_LOG_DOM_WARN(_elm_ext_log_dom, __VA_ARGS__)
 #define INF(...)  EINA_LOG_DOM_INFO(_elm_ext_log_dom, __VA_ARGS__)
diff --git a/src/lib/elm_priv.h b/src/lib/elm_priv.h
index 5b1c494..c2e1948 100644
--- a/src/lib/elm_priv.h
+++ b/src/lib/elm_priv.h
@@ -47,7 +47,7 @@
 # include 
 #endif
 
-#define CRI(...) EINA_LOG_DOM_CRIT(_elm_log_dom, __VA_ARGS__)
+#define CRI(...)  EINA_LOG_DOM_CRIT(_elm_log_dom, __VA_ARGS__)
 #define ERR(...)  EINA_LOG_DOM_ERR(_elm_log_dom, __VA_ARGS__)
 #define WRN(...)  EINA_LOG_DOM_WARN(_elm_log_dom, __VA_ARGS__)
 #define INF(...)  EINA_LOG_DOM_INFO(_elm_log_dom, __VA_ARGS__)
diff --git a/src/modules/prefs/private.h b/src/modules/prefs/private.h
index 22e8317..f65370b 100644
--- a/src/modules/prefs/private.h
+++ b/src/modules/prefs/private.h
@@ -9,7 +9,7 @@
 #undef INF
 #undef DBG
 
-#define CRI(...) EINA_LOG_DOM_CRIT(_elm_prefs_log_dom, __VA_ARGS__)
+#define CRI(...)  EINA_LOG_DOM_CRIT(_elm_prefs_log_dom, __VA_ARGS__)
 #define ERR(...)  EINA_LOG_DOM_ERR (_elm_prefs_log_dom, __VA_ARGS__)
 #define WRN(...)  EINA_LOG_DOM_WARN(_elm_prefs_log_dom, __VA_ARGS__)
 #define INF(...)  EINA_LOG_DOM_INFO(_elm_prefs_log_dom, __VA_ARGS__)

-- 

[EGIT] [core/elementary] master 01/03: test_focus: Call window object show after its content creation.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=fb135d2ca4994cbbb99c3a010dea563b9e807756

commit fb135d2ca4994cbbb99c3a010dea563b9e807756
Author: Daniel Juyung Seo 
Date:   Thu Jan 16 09:34:16 2014 +0900

test_focus: Call window object show after its content creation.

This is a successor commit of 64fd5a825b24591aedb9cac695d03f5b4d867442.
Window show call triggers all smart objects' smart calculation and in case 
of
X11, XMapWindow() is called directly.
Also moved resize of window accordingly.
---
 src/bin/test_focus3.c | 12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/bin/test_focus3.c b/src/bin/test_focus3.c
index 2ff932d..de951fe 100644
--- a/src/bin/test_focus3.c
+++ b/src/bin/test_focus3.c
@@ -56,7 +56,6 @@ test_focus3(void *data EINA_UNUSED, Evas_Object *obj 
EINA_UNUSED, void *event_in
 
win = elm_win_util_standard_add("focus3", "Focus 3");
elm_win_focus_highlight_enabled_set(win, EINA_TRUE);
-   evas_object_resize(win, 320, 480);
elm_win_autodel_set(win, EINA_TRUE);
 
bx = elm_box_add(win);
@@ -102,6 +101,7 @@ test_focus3(void *data EINA_UNUSED, Evas_Object *obj 
EINA_UNUSED, void *event_in
elm_box_pack_end(bx, bt);
evas_object_show(bt);
 
+   evas_object_resize(win, 320, 480);
evas_object_show(win);
 }
 
@@ -219,8 +219,6 @@ test_focus4(void *data EINA_UNUSED, Evas_Object *obj 
EINA_UNUSED, void *event_in
elm_win_autodel_set(win, EINA_TRUE);
elm_win_focus_highlight_enabled_set(win, EINA_TRUE);
elm_win_focus_highlight_animate_set(win, EINA_TRUE);
-   evas_object_resize(win, 320, 320);
-   evas_object_show(win);
 
fr = elm_frame_add(win);
evas_object_size_hint_weight_set(fr, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
@@ -341,6 +339,9 @@ test_focus4(void *data EINA_UNUSED, Evas_Object *obj 
EINA_UNUSED, void *event_in
evas_object_smart_callback_add(tg, "changed", custom_chain_unset_cb, bx);
elm_box_pack_end(bx, tg);
evas_object_show(tg);
+
+   evas_object_resize(win, 320, 320);
+   evas_object_show(win);
 }
 
 static void
@@ -375,8 +376,6 @@ test_focus_custom(void *data EINA_UNUSED, Evas_Object *obj 
EINA_UNUSED, void *ev
elm_win_focus_highlight_enabled_set(win, EINA_TRUE);
elm_win_focus_highlight_animate_set(win, EINA_TRUE);
elm_win_focus_highlight_style_set(win, "glow");
-   evas_object_resize(win, 320, 320);
-   evas_object_show(win);
 
fr = elm_frame_add(win);
evas_object_size_hint_weight_set(fr, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
@@ -453,4 +452,7 @@ test_focus_custom(void *data EINA_UNUSED, Evas_Object *obj 
EINA_UNUSED, void *ev
evas_object_size_hint_align_set(bt, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_box_pack_end(bx2, bt);
evas_object_show(bt);
+
+   evas_object_resize(win, 320, 320);
+   evas_object_show(win);
 }

-- 

[EGIT] [core/elementary] master 03/03: toolbar: Do not check ev->string for Return key and react on space key.

[Daniel Juyung Seo]

seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=b25e2bf0a67d47ce9ec0afa46d23569f49e0b74f

commit b25e2bf0a67d47ce9ec0afa46d23569f49e0b74f
Author: Daniel Juyung Seo 
Date:   Tue Jan 21 19:57:22 2014 +0900

toolbar: Do not check ev->string for Return key and react on space key.

space key works as same as Return key.
---
 src/lib/elm_toolbar.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/lib/elm_toolbar.c b/src/lib/elm_toolbar.c
index 4ca9a37..4cd9e6e 100644
--- a/src/lib/elm_toolbar.c
+++ b/src/lib/elm_toolbar.c
@@ -666,7 +666,8 @@ _elm_toolbar_smart_event(Eo *obj, void *_pd, va_list *list)
if (!sd->items) return;
 
if ((!strcmp(ev->key, "Return")) ||
-   ((!strcmp(ev->key, "KP_Enter")) && !ev->string))
+   (!strcmp(ev->key, "KP_Enter")) ||
+   (!strcmp(ev->key, "space")))
  {
 if (sd->highlighted_item)
   _item_select(sd->highlighted_item);

-- 

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: enlightenment - removed warnings.

[ChunEon Park]

ok, i agree on the commit msg blame.
but i don't agree on your own debuggin function.

it's not used so it's commented out.
Who knows the function will be used again?

but you can simply removed the comments whenever you need in you local.


-Regards, Hermet-

-Original Message-
From: "Michael Blumenkrantz" 
To: "Enlightenment developer list"; 
Cc: 
Sent: 2014-01-19 (일) 05:14:04
Subject: Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: enlightenment 
- removed warnings.

On Sat, 18 Jan 2014 02:37:10 -0800
ChunEon Park @hermet.pe.kr> wrote:

> hermet pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=747403614046ae392004118fa6497dc523125947
> 
> commit 747403614046ae392004118fa6497dc523125947
> Author: ChunEon Park @hermet.pe.kr>
> Date:   Sat Jan 18 19:37:02 2014 +0900
> 
> enlightenment - removed warnings.
> ---
>  src/bin/e_auth.c 10 --
>  src/bin/e_comp_x.c3 ++-
>  src/bin/e_randr.c 4 ++--
>  src/modules/conf_randr/e_int_config_randr.c   3 ++-
>  4 files changed, 14 insertions(+), 6 deletions(-)
> 
> diff --git a/src/bin/e_auth.c b/src/bin/e_auth.c
> index 27abf51..356be0a 100644
> --- a/src/bin/e_auth.c
> +++ b/src/bin/e_auth.c
> @@ -131,9 +131,9 @@ _auth_pam_init(E_Auth *da)
>  #endif
>  
>  EAPI int
> +#ifdef HAVE_PAM
>  e_auth_begin(char *passwd)
>  {
> -#ifdef HAVE_PAM
> /* child */
> int pamerr;
> E_Auth da;
> @@ -180,9 +180,15 @@ e_auth_begin(char *passwd)
>   }
> free(current_user);
> exit(-1);
> -#endif
> +
> return 0;
>  }
> +#else
> +e_auth_begin(char *passwd EINA_UNUSED)
> +{
> +   return 0;
> +}
> +#endif
>  
>  EAPI char *
>  e_auth_hostname_get(void)
> diff --git a/src/bin/e_comp_x.c b/src/bin/e_comp_x.c
> index 8a157c7..802fdf8 100644
> --- a/src/bin/e_comp_x.c
> +++ b/src/bin/e_comp_x.c
> @@ -101,6 +101,7 @@ _e_comp_x_client_event_free(void *d EINA_UNUSED, void *e)
> free(ev);
>  }
>  
> +/*
>  static void
>  _e_comp_x_print_win(Ecore_X_Window win)
>  {
> @@ -111,7 +112,7 @@ _e_comp_x_print_win(Ecore_X_Window win)
> vis = ecore_x_window_visible_get(win);
> fprintf(stderr, "%s 0x%x: %d,%d @ %dx%d\n", vis ? "VIS" : "HID", win, x, 
> y, w, h);
>  }
> -
> +*/
>  
>  static void
>  _e_comp_x_focus_setup(E_Client *ec)
> diff --git a/src/bin/e_randr.c b/src/bin/e_randr.c
> index 2453372..73f3b41 100644
> --- a/src/bin/e_randr.c
> +++ b/src/bin/e_randr.c
> @@ -807,8 +807,8 @@ _e_randr_config_output_mode_update(E_Randr_Output_Config 
> *cfg)
>   {
>  for (i = 0; i < nmode_infos; i++)
>{
> - if ((mode_infos[i]->width == cfg->geo.w) &&
> - (mode_infos[i]->height == cfg->geo.h))
> + if ((mode_infos[i]->width == (unsigned int)cfg->geo.w) &&
> + (mode_infos[i]->height == (unsigned int)cfg->geo.h))
> {
>cfg->mode = mode_infos[i]->xid;
>break;
> diff --git a/src/modules/conf_randr/e_int_config_randr.c 
> b/src/modules/conf_randr/e_int_config_randr.c
> index 885e403..44cce14 100644
> --- a/src/modules/conf_randr/e_int_config_randr.c
> +++ b/src/modules/conf_randr/e_int_config_randr.c
> @@ -9,7 +9,8 @@ struct _E_Config_Dialog_Data
>  {
> Evas_Object *o_randr;
>  
> -   int restore, primary;
> +   unsigned char restore;
> +   unsigned int primary;
>  };
>  
>  /* local function prototypes */
> 


please don't do drive-by warning cleanup commits like this. you ended up adding 
even more warnings than you fixed, AND you commented out my still necessary 
debugging function.

--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [core/elementary] master 01/01: widget: doxygen fix

[Yakov Goldberg]

yakov pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=2ab029a41303d45cf24546cfde3048d6a5446f24

commit 2ab029a41303d45cf24546cfde3048d6a5446f24
Author: Yakov Goldberg 
Date:   Tue Jan 21 11:29:57 2014 +0200

widget: doxygen fix
---
 src/lib/elm_widget.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/elm_widget.h b/src/lib/elm_widget.h
index 6ca272b..834d68e 100644
--- a/src/lib/elm_widget.h
+++ b/src/lib/elm_widget.h
@@ -1285,7 +1285,7 @@ typedef void * (*list_data_get_func_type)(const Eina_List 
* l);
 #define elm_wdg_disable(ret) ELM_WIDGET_ID(ELM_WIDGET_SUB_ID_DISABLE), 
EO_TYPECHECK(Eina_Bool *, ret)
 
 /**
- * @def elm_wdg_theme
+ * @def elm_wdg_theme_apply
  * @since 1.8
  *
  * 'Virtual' function on the widget being re-themed.

-- 

[EGIT] [apps/rage] master 01/01: todo++

[Rasterman]

raster pushed a commit to branch master.

http://git.enlightenment.org/apps/rage.git/commit/?id=2e0659be1dae5f77e52cd35bb5e7b1dac04890bf

commit 2e0659be1dae5f77e52cd35bb5e7b1dac04890bf
Author: Carsten Haitzler (Rasterman) 
Date:   Tue Jan 21 18:26:46 2014 +0900

todo++
---
 TODO | 1 +
 1 file changed, 1 insertion(+)

diff --git a/TODO b/TODO
index de96138..28b4ad4 100644
--- a/TODO
+++ b/TODO
@@ -18,3 +18,4 @@
 * show busy anim until opened cb or failure
 * quality option (smooth)
 * make Home/End/Insert/Delete/Tab/Pause do something vaguely sensible
+* add button/control top-left next to audio to do fullscreen/normal toggle

-- 

[EGIT] [apps/rage] master 01/01: add todo notes.

[Rasterman]

raster pushed a commit to branch master.

http://git.enlightenment.org/apps/rage.git/commit/?id=cae4548aa2f45865d8ce13c216f250601e22b46f

commit cae4548aa2f45865d8ce13c216f250601e22b46f
Author: Carsten Haitzler (Rasterman) 
Date:   Tue Jan 21 18:23:58 2014 +0900

add todo notes.
---
 TODO | 1 +
 1 file changed, 1 insertion(+)

diff --git a/TODO b/TODO
index 12836a5..de96138 100644
--- a/TODO
+++ b/TODO
@@ -17,3 +17,4 @@
 * loop all option
 * show busy anim until opened cb or failure
 * quality option (smooth)
+* make Home/End/Insert/Delete/Tab/Pause do something vaguely sensible

-- 

[EGIT] [apps/rage] master 01/01: add slight bevelling on sides/bottom and on top to look nicer.

[Rasterman]

raster pushed a commit to branch master.

http://git.enlightenment.org/apps/rage.git/commit/?id=048b0b9e92e7f04d5d0907055140b7dd1b1b5cce

commit 048b0b9e92e7f04d5d0907055140b7dd1b1b5cce
Author: Carsten Haitzler (Rasterman) 
Date:   Tue Jan 21 18:14:13 2014 +0900

add slight bevelling on sides/bottom and on top to look nicer.
---
 data/themes/default.edc   |  18 ++
 data/themes/images/Makefile.am|   4 +++-
 data/themes/images/bevel_dark_out.png | Bin 0 -> 93 bytes
 data/themes/images/bg_bevel.png   | Bin 0 -> 255 bytes
 4 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/data/themes/default.edc b/data/themes/default.edc
index a443fda..f7af145 100644
--- a/data/themes/default.edc
+++ b/data/themes/default.edc
@@ -3,6 +3,8 @@ collections {
 //
 the background and general container for the terminal
group { name: "rage/core";
+  images.image: "bg_bevel.png" COMP;
+  images.image: "bevel_dark_out.png" COMP;
   images.image: "pm_fill.png" COMP;
   images.image: "pm_overlay.png" COMP;
   images.image: "pm_shadow.png" COMP;
@@ -72,6 +74,22 @@ collections {
fill.smooth: 0;
 }
  }
+ part { name: "bevel";
+description { state: "default" 0.0;
+   image.normal: "bevel_dark_out.png";
+   image.border: 1 1 1 1;
+   image.middle: 0;
+   fill.smooth: 0;
+}
+ }
+ part { name: "bevel2";
+description { state: "default" 0.0;
+   image.normal: "bg_bevel.png";
+   image.border: 1 1 1 1;
+   image.middle: 0;
+   fill.smooth: 0;
+}
+ }
  part { name: "shadow"; mouse_events: 0;
 description { state: "default" 0.0;
fixed: 1 1;
diff --git a/data/themes/images/Makefile.am b/data/themes/images/Makefile.am
index 6ecd7bb..dd6357c 100644
--- a/data/themes/images/Makefile.am
+++ b/data/themes/images/Makefile.am
@@ -26,4 +26,6 @@ icon_pause2.png \
 icon_spanner.png \
 icon_spanner2.png \
 icon_volume2.png \
-pos_indicator_big.png
+pos_indicator_big.png \
+bevel_dark_out.png \
+bg_bevel.png
diff --git a/data/themes/images/bevel_dark_out.png 
b/data/themes/images/bevel_dark_out.png
new file mode 100644
index 000..f22c0ae
Binary files /dev/null and b/data/themes/images/bevel_dark_out.png differ
diff --git a/data/themes/images/bg_bevel.png b/data/themes/images/bg_bevel.png
new file mode 100644
index 000..61c6105
Binary files /dev/null and b/data/themes/images/bg_bevel.png differ

-- 

Re: [E-devel] [EGIT] [core/elementary] master 01/01: PackageKit theme: pass make distcheck

[Davide Andreoli]

2014/1/21 Stefan Schmidt 

> Hello.
>
> On Mon, 2014-01-20 at 11:24, davemds wrote:
> > davemds pushed a commit to branch master.
> >
> >
> http://git.enlightenment.org/core/elementary.git/commit/?id=bbb5975c8c4ef64b613aaf1ed654142dafa23224
> >
> > commit bbb5975c8c4ef64b613aaf1ed654142dafa23224
> > Author: davemds 
> > Date:   Mon Jan 20 20:22:41 2014 +0100
> >
> > PackageKit theme: pass make distcheck
> >
> > Also the image used by the edc need to be included in the tarball
>
> Thanks for this!. I only have seen the problem with the edc file and
> haven't realized that you also added images. Nice to see that it is
> fixed now.
>

Thanks goes to you to remember me about distcheck :)
dave



>
> regards
> Stefan Schmidt
>
>
> --
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Efreer init error

[The Rasterman]

On Tue, 21 Jan 2014 02:59:16 + Prathamesh P Ghanekar
 said:

> Hi Carsten,
> 
> > either the filesystem is read-only or it doesn't have permissions
> File system is not read only, and all folders have 777 permission.
> 
> Could it be the other possibility mentioned in the error message i.e. " out
> of memory or disk space"?? I am confused, since we are hosting file system on
> the network(NFS),so memory issue seems unlikely.

it could be the nfs server refusing writes despite apparent permissions. like a
read-only filesystem mount. either way when it tries to make that directory -
it fails and thus barfs. why the directory creation fails is in your ballcourt.
it's your system and setup. you built it and configured it. this works
correctly in all normal cases where your .cache dir is on a writable
filesystem. every linux distro i know of ships this way out of the box. what
you have created does not. /opt/home already is totally non-standard and
bizarre soit's now your job to figure out why your bizarre setup is broken. :)

> Regards,
> Prathamesh
> 
> 
> 
> -Original Message-
> From: Carsten Haitzler [mailto:ras...@rasterman.com] 
> Sent: 20 January 2014 18:41
> To: Prathamesh P Ghanekar
> Cc: enlightenment-devel@lists.sourceforge.net
> Subject: Re: Efreer init error
> 
> On Mon, 20 Jan 2014 09:52:32 + Prathamesh P Ghanekar
>  said:
> 
> > Hi,
> > 
> > We are getting the following error on running the Enlightenment binary.
> > 
> > ESTART: 0.70869 [0.8] - Efreet Init ERR<2624>:efreet_cache 
> > efreet_cache.c:140 efreet_cache_init() Failed to create directory 
> > '/opt/home/app/.cache/efreet'  Enlightenment Error  
> > Enlightenment cannot initialize the FDO desktop system.
> > Perhaps you lack permissions on ~/.cache/efreet or are out of memory 
> > or disk space?
> > E17: Begin Shutdown Procedure!
> > 
> > We checked the permissions of the directories etc., all seems ok..!
> > This is w.r.t enlightenment binary that comes with Tizen-IVI pre-built 
> > image.Can you help us solve this issue?
> 
> that issue literally means it can't create that directory. either the
> filesystem is read-only or it doesn't have permissions. you know tizen likes
> to be extra-annoying permission-wise with smack? this isn't easily visible
> via normal tools.
> 
> --
> - Codito, ergo sum - "I code, therefore I am" --
> The Rasterman (Carsten Haitzler)ras...@rasterman.com
> 
> 
> ~~Disclaimer~~~
> Information contained and transmitted by this e-mail is confidential and
> proprietary to iGATE and its affiliates and is intended for use only by the
> recipient. If you are not the intended recipient, you are hereby notified
> that any dissemination, distribution, copying or use of this e-mail is
> strictly prohibited and you are requested to delete this e-mail immediately
> and notify the originator or mailad...@igate.com
> . iGATE does not enter into any agreement with
> any party by e-mail. Any views expressed by an individual do not necessarily
> reflect the view of iGATE. iGATE is not responsible for the consequences of
> any actions taken on the basis of information provided, through this email.
> The contents of an attachment to this e-mail may contain software viruses,
> which could damage your own computer system. While iGATE has taken every
> reasonable precaution to minimise this risk, we cannot accept liability for
> any damage which you sustain as a result of software viruses. You should
> carry out your own virus checks before opening an attachment. To know more
> about iGATE please visit www.igate.com .
> 
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: edje: use luajit by default, if you want lua use --enable-lua-old

[The Rasterman]

On Tue, 21 Jan 2014 11:35:34 +1000 David Seikel  said:

> On Tue, 21 Jan 2014 09:28:01 +0900 Carsten Haitzler (The Rasterman)
>  wrote:
> 
> > On Mon, 20 Jan 2014 16:45:29 +0100 Stefan Schmidt
> >  said:
> > 
> > > Hello.
> > > 
> > > On Sat, 2014-01-18 at 15:08, Stefan Schmidt wrote:
> > > > 
> > > > On Fri, 2014-01-17 at 11:08, Daniel Kolesa wrote:
> > > > > quaker pushed a commit to branch master.
> > > > > 
> > > > > http://git.enlightenment.org/core/efl.git/commit/?id=6db16915951af61d28f62f4de7c14c76e4303f18
> > > > > 
> > > > > commit 6db16915951af61d28f62f4de7c14c76e4303f18
> > > > > Author: Daniel Kolesa 
> > > > > Date:   Fri Jan 17 19:07:59 2014 +
> > > > > 
> > > > > edje: use luajit by default, if you want lua use
> > > > > --enable-lua-old
> > > > 
> > > > I'm unhappy with this commit.
> > > > 
> > > > Where and when was it decided to switch on a new default
> > > > dependency? For instance jenkins is broken for all efl related
> > > > builds now because nobody told me or beber in advance that luajit
> > > > will be needed from now on. And as I have a busy weekend I will
> > > > only be anle to look into this from Monday. I think something
> > > > like this should be communicated before the actual change hits
> > > > the repo.
> > > 
> > > All efl builds (changely as well as nightly) have been failing after
> > > this.
> > > 
> > > Beber has now installed luajit on our x86 and x86_64 slaves which
> > > brings them back to a working state. For the mingw builds I had to
> > > switch back to lua-old. This is something for the luajit crowd to
> > > keep in mind. Check out if it supports windows builds and provide
> > > beber with detailed instructions how to set it up.
> > 
> > cedric should chime in here.
> 
> As part of my big plans, I'll sooner or later be checking LuaJIT 2.0
> compatibility on Windows and Mac.  Might be a month or three before I
> get to that though.  At the same time I'll be making sure that EFL and
> Elementary work for my purposes on those platforms.  You'll probably
> see patches coming out of that effort.

luajit is meant to work on windows - hell in their faq they discuss issues
which directx/3d create for luajit (fpu ones). so really - this should be
perfectly doable. it's just another dep/change of default dep. luajit2 is not
that new and is available for most platforms we care about. we have
--enable-lua-old for those unwilling to provide the dep. hat won't last forever
though.

-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[EGIT] [admin/devs] master 01/01: devs - add marcel (bu5hm4n)

[Rasterman]

raster pushed a commit to branch master.

http://git.enlightenment.org/admin/devs.git/commit/?id=2b87fc06df910e55fb2be1476fb34087cf2caef6

commit 2b87fc06df910e55fb2be1476fb34087cf2caef6
Author: Carsten Haitzler (Rasterman) 
Date:   Tue Jan 21 17:14:34 2014 +0900

devs - add marcel (bu5hm4n)
---
 developers/bu5hm4n/id_rsa.pub  |   1 +
 developers/bu5hm4n/img_big.png | Bin 0 -> 42457 bytes
 developers/bu5hm4n/img_med.png | Bin 0 -> 13071 bytes
 developers/bu5hm4n/img_sml.png | Bin 0 -> 4151 bytes
 developers/bu5hm4n/info.txt|   9 +
 5 files changed, 10 insertions(+)

diff --git a/developers/bu5hm4n/id_rsa.pub b/developers/bu5hm4n/id_rsa.pub
new file mode 100644
index 000..f271a45
--- /dev/null
+++ b/developers/bu5hm4n/id_rsa.pub
@@ -0,0 +1 @@
+ssh-rsa 
B3NzaC1yc2EDAQABgQDPNOGBZVtZpaFWgEb9Ia5+6gOLs2NFA9jK81OeQJXlwsa0inFMFj27YRt3hbjcC1lNKseAhWBiJbhN0D9WcBhS/GFbndgMzi2Vma4FDA2i2AAT6dpAQMDDh9JHTsweKFNEfGi1AFeHckOH3syyYA2ewFpz46dy6rg7HKB6mUAJlQ==
 marcel@localhost-2014-01-12
diff --git a/developers/bu5hm4n/img_big.png b/developers/bu5hm4n/img_big.png
new file mode 100644
index 000..b6362ca
Binary files /dev/null and b/developers/bu5hm4n/img_big.png differ
diff --git a/developers/bu5hm4n/img_med.png b/developers/bu5hm4n/img_med.png
new file mode 100644
index 000..2a9b36b
Binary files /dev/null and b/developers/bu5hm4n/img_med.png differ
diff --git a/developers/bu5hm4n/img_sml.png b/developers/bu5hm4n/img_sml.png
new file mode 100644
index 000..93d7083
Binary files /dev/null and b/developers/bu5hm4n/img_sml.png differ
diff --git a/developers/bu5hm4n/info.txt b/developers/bu5hm4n/info.txt
new file mode 100644
index 000..4035d27
--- /dev/null
+++ b/developers/bu5hm4n/info.txt
@@ -0,0 +1,9 @@
+Login:bu5hm4n
+IRC Nick: bu5hm4n
+Name: Marcel Hollerbach
+GeoData:  47.61692 7.67092
+Location: Loerrach, Germany
+E-Mail:   marcel-hollerb...@t-online.de
+Contributing: entrance, terminology
+Group:Applications,
+Platform: Arch Linux (Linux)

-- 

[EGIT] [apps/terminology] master 01/01: Rewrote the Wallpaper Settings,

[Marcel Hollerbach]

raster pushed a commit to branch master.

http://git.enlightenment.org/apps/terminology.git/commit/?id=b80c2f6f88c5db450a9ab7583687e7ddbff4935a

commit b80c2f6f88c5db450a9ab7583687e7ddbff4935a
Author: Marcel Hollerbach 
Date:   Tue Jan 21 17:04:45 2014 +0900

Rewrote the Wallpaper Settings,

Summary:
- Removed the list of paths in the config.c
- The users selects directly the path of the folder where the
  Backgrounds are located, terminology will not show up the Pictures
  located in subdirectorys you can easyly go in the subdir with the
  fileselector.
- With a double click on a picture you can import the picture to your
  user config directory so you can cleanup your Downloads directory for
  example without loosing your Background
- If a Background is imported the new Background URL in the config will
  point to the imported file.

Test Plan:
- The Bufferting of the Backgrounds is not asyncron, but I have tested it
  with a directory with more than 300 pictures and it runs very very fast,
  in my eyes no asyncron buffering is needed!

Reviewers: billiob, raster

CC: cedric

Differential Revision: https://phab.enlightenment.org/D471
---
 src/bin/config.c|  19 --
 src/bin/config.h|   1 -
 src/bin/options_wallpaper.c | 614 +++-
 3 files changed, 322 insertions(+), 312 deletions(-)

diff --git a/src/bin/config.c b/src/bin/config.c
index f831fa4..d063682 100644
--- a/src/bin/config.c
+++ b/src/bin/config.c
@@ -72,8 +72,6 @@ config_init(void)
  (edd_base, Config, "theme", theme, EET_T_STRING);
EET_DATA_DESCRIPTOR_ADD_BASIC
  (edd_base, Config, "background", background, EET_T_STRING);
-   EET_DATA_DESCRIPTOR_ADD_LIST_STRING
- (edd_base, Config, "wallpaper_paths", wallpaper_paths);
EET_DATA_DESCRIPTOR_ADD_BASIC
  (edd_base, Config, "wordsep", wordsep, EET_T_STRING);
EET_DATA_DESCRIPTOR_ADD_BASIC
@@ -181,9 +179,6 @@ config_save(Config *config, const char *key)
 void
 config_sync(const Config *config_src, Config *config)
 {
-   Eina_List *l; 
-   const char *path;
-
// SOME fields have to be consistent between configs
config->font.size = config_src->font.size;
eina_stringshare_replace(&(config->font.name), config_src->font.name);
@@ -199,14 +194,6 @@ config_sync(const Config *config_src, Config *config)
eina_stringshare_replace(&(config->theme), config_src->theme);
eina_stringshare_replace(&(config->wordsep), config_src->wordsep);
config->scrollback = config_src->scrollback;
-   if (config->wallpaper_paths)
-  EINA_LIST_FREE(config->wallpaper_paths, path)
- eina_stringshare_del(path);
-   
-   config->wallpaper_paths = NULL;
-   EINA_LIST_FOREACH(config_src->wallpaper_paths, l, path)
-  config->wallpaper_paths = eina_list_append(config->wallpaper_paths, 
eina_stringshare_add(path));
-   
config->tab_zoom = config_src->tab_zoom;
config->vidmod = config_src->vidmod;
config->jump_on_keypress = config_src->jump_on_keypress;
@@ -496,7 +483,6 @@ config_load(const char *key)
  config->tab_zoom = 0.5;
  config->theme = eina_stringshare_add("default.edj");
  config->background = NULL;
- config->wallpaper_paths = NULL;
  config->translucent = EINA_FALSE;
  config->jump_on_change = EINA_TRUE;
  config->jump_on_keypress = EINA_TRUE;
@@ -573,7 +559,6 @@ config_fork(Config *config)
CPY(helper.inline_please);
SCPY(theme);
SCPY(background);
-   SLSTCPY(wallpaper_paths);
SCPY(wordsep);
CPY(scrollback);
CPY(tab_zoom);
@@ -606,12 +591,8 @@ config_fork(Config *config)
 void
 config_del(Config *config)
 {
-   const char *path;
if (!config) return;

-   EINA_LIST_FREE(config->wallpaper_paths, path)
- eina_stringshare_del(path);
-   
eina_stringshare_del(config->font.name);
eina_stringshare_del(config->font.orig_name);
eina_stringshare_del(config->theme);
diff --git a/src/bin/config.h b/src/bin/config.h
index 3a6677f..e83b6b9 100644
--- a/src/bin/config.h
+++ b/src/bin/config.h
@@ -33,7 +33,6 @@ struct _Config
} helper;
const char   *theme;
const char   *background; 
-   Eina_List*wallpaper_paths;
const char   *wordsep;
int   scrollback;
doubletab_zoom;
diff --git a/src/bin/options_wallpaper.c b/src/bin/options_wallpaper.c
index f35e57b..d393d1a 100644
--- a/src/bin/options_wallpaper.c
+++ b/src/bin/options_wallpaper.c
@@ -16,26 +16,81 @@ typedef struct _Background_Item
const char *path;
Eina_Bool selected;
Elm_Object_Item *item;
-   Evas_Object *term;
 }
 Background_Item;
 
-typedef struct _Wallpaper_Path_Item
+typedef struct _Insert_Gen_Grid_Item_Notify
 {
-   const char *path;
+   Elm_Gengrid_Item_Class *class;
+   Background_Item *item;
+}
+Insert_Gen_Grid_Item_Notify;
+
+
+static const