date:20171113

Re: [E-devel] [EGIT] [core/efl] master 01/01: calendar: Remove invalid ref to elm enum

2017-11-13 Thread Carsten Haitzler

On Mon, 13 Nov 2017 23:24:09 +0200 Daniel Zaoui  said:

> Well, sorry to disagree with you :P My first day is Sunday.

:-P

> On Tue, 14 Nov 2017 00:11:44 +0900
> Carsten Haitzler  wrote:
> 
> > On Mon, 13 Nov 2017 13:47:28 +0200 Daniel Zaoui
> >  said:
> > 
> > > Thanks for the fix. And for having excited my curiosity. I didn't
> > > know that US, Canada... consider Sunday as the first day. Always
> > > good to know.  
> > 
> > They are just being silly. Monday is of course! :)
> > 
> > > On Mon, 13 Nov 2017 02:40:37 -0800
> > > Jean-Philippe ANDRÉ  wrote:
> > >   
> > > > jpeg pushed a commit to branch master.
> > > > 
> > > > http://git.enlightenment.org/core/efl.git/commit/?id=4255c34f7a8dfcba7fe585fd773fa6f9157f2829
> > > > 
> > > > commit 4255c34f7a8dfcba7fe585fd773fa6f9157f2829
> > > > Author: Jean-Philippe Andre 
> > > > Date:   Mon Nov 13 15:39:53 2017 +0900
> > > > 
> > > > calendar: Remove invalid ref to elm enum
> > > > 
> > > > Thanks @JackDanielz for the report. This does not solve your
> > > > actual concern, though.
> > > > ---
> > > >  src/lib/elementary/efl_ui_calendar.eo | 13 +++--
> > > >  1 file changed, 7 insertions(+), 6 deletions(-)
> > > > 
> > > > diff --git a/src/lib/elementary/efl_ui_calendar.eo
> > > > b/src/lib/elementary/efl_ui_calendar.eo index
> > > > 43d4508516..5125f2e9cd 100644 ---
> > > > a/src/lib/elementary/efl_ui_calendar.eo +++
> > > > b/src/lib/elementary/efl_ui_calendar.eo @@ -26,13 +26,14 @@ class
> > > > Efl.Ui.Calendar (Efl.Ui.Layout, Efl.Ui.Focus.Composition,
> > > > Elm.Interface.At ]] methods {
> > > >@property first_day_of_week {
> > > > - [[The first day of week to use on calendar widgets'.]]
> > > > - set {
> > > > - }
> > > > - get {
> > > > - }
> > > > + [[The first day of week to use on calendar widgets.
> > > > +
> > > > +   This is the day that will appear in the left-most
> > > > column (eg. Monday
> > > > +   in France or Sunday in the US).
> > > > + ]]
> > > >   values {
> > > > -day:
> > > > Efl.Ui.Calendar.Weekday(Efl.Ui.Calendar.Weekday.sunday); [[Weekday
> > > > enum value, see @Elm.Calendar.Weekday]]
> > > > +day:
> > > > Efl.Ui.Calendar.Weekday(Efl.Ui.Calendar.Weekday.sunday);
> > > > +   [[The first day of the week.]]
> > > >   }
> > > >}
> > > >@property date_min {
> > > >   
> > > 
> > > 
> > > --
> > > Check out the vibrant tech community on one of the world's most
> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel  
> > 
> > 
> 
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


-- 
- Codito, ergo sum - "I code, therefore I am" --
Carsten Haitzler - ras...@rasterman.com


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: calendar: Remove invalid ref to elm enum

2017-11-13 Thread Daniel Zaoui

Well, sorry to disagree with you :P My first day is Sunday.

On Tue, 14 Nov 2017 00:11:44 +0900
Carsten Haitzler  wrote:

> On Mon, 13 Nov 2017 13:47:28 +0200 Daniel Zaoui
>  said:
> 
> > Thanks for the fix. And for having excited my curiosity. I didn't
> > know that US, Canada... consider Sunday as the first day. Always
> > good to know.  
> 
> They are just being silly. Monday is of course! :)
> 
> > On Mon, 13 Nov 2017 02:40:37 -0800
> > Jean-Philippe ANDRÉ  wrote:
> >   
> > > jpeg pushed a commit to branch master.
> > > 
> > > http://git.enlightenment.org/core/efl.git/commit/?id=4255c34f7a8dfcba7fe585fd773fa6f9157f2829
> > > 
> > > commit 4255c34f7a8dfcba7fe585fd773fa6f9157f2829
> > > Author: Jean-Philippe Andre 
> > > Date:   Mon Nov 13 15:39:53 2017 +0900
> > > 
> > > calendar: Remove invalid ref to elm enum
> > > 
> > > Thanks @JackDanielz for the report. This does not solve your
> > > actual concern, though.
> > > ---
> > >  src/lib/elementary/efl_ui_calendar.eo | 13 +++--
> > >  1 file changed, 7 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/src/lib/elementary/efl_ui_calendar.eo
> > > b/src/lib/elementary/efl_ui_calendar.eo index
> > > 43d4508516..5125f2e9cd 100644 ---
> > > a/src/lib/elementary/efl_ui_calendar.eo +++
> > > b/src/lib/elementary/efl_ui_calendar.eo @@ -26,13 +26,14 @@ class
> > > Efl.Ui.Calendar (Efl.Ui.Layout, Efl.Ui.Focus.Composition,
> > > Elm.Interface.At ]] methods {
> > >@property first_day_of_week {
> > > - [[The first day of week to use on calendar widgets'.]]
> > > - set {
> > > - }
> > > - get {
> > > - }
> > > + [[The first day of week to use on calendar widgets.
> > > +
> > > +   This is the day that will appear in the left-most
> > > column (eg. Monday
> > > +   in France or Sunday in the US).
> > > + ]]
> > >   values {
> > > -day:
> > > Efl.Ui.Calendar.Weekday(Efl.Ui.Calendar.Weekday.sunday); [[Weekday
> > > enum value, see @Elm.Calendar.Weekday]]
> > > +day:
> > > Efl.Ui.Calendar.Weekday(Efl.Ui.Calendar.Weekday.sunday);
> > > +   [[The first day of the week.]]
> > >   }
> > >}
> > >@property date_min {
> > >   
> > 
> > 
> > --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel  
> 
> 


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: calendar: Remove invalid ref to elm enum

2017-11-13 Thread Carsten Haitzler

On Mon, 13 Nov 2017 13:47:28 +0200 Daniel Zaoui  said:

> Thanks for the fix. And for having excited my curiosity. I didn't know that
> US, Canada... consider Sunday as the first day. Always good to know.

They are just being silly. Monday is of course! :)

> On Mon, 13 Nov 2017 02:40:37 -0800
> Jean-Philippe ANDRÉ  wrote:
> 
> > jpeg pushed a commit to branch master.
> > 
> > http://git.enlightenment.org/core/efl.git/commit/?id=4255c34f7a8dfcba7fe585fd773fa6f9157f2829
> > 
> > commit 4255c34f7a8dfcba7fe585fd773fa6f9157f2829
> > Author: Jean-Philippe Andre 
> > Date:   Mon Nov 13 15:39:53 2017 +0900
> > 
> > calendar: Remove invalid ref to elm enum
> > 
> > Thanks @JackDanielz for the report. This does not solve your
> > actual concern, though.
> > ---
> >  src/lib/elementary/efl_ui_calendar.eo | 13 +++--
> >  1 file changed, 7 insertions(+), 6 deletions(-)
> > 
> > diff --git a/src/lib/elementary/efl_ui_calendar.eo
> > b/src/lib/elementary/efl_ui_calendar.eo index 43d4508516..5125f2e9cd
> > 100644 --- a/src/lib/elementary/efl_ui_calendar.eo
> > +++ b/src/lib/elementary/efl_ui_calendar.eo
> > @@ -26,13 +26,14 @@ class Efl.Ui.Calendar (Efl.Ui.Layout,
> > Efl.Ui.Focus.Composition, Elm.Interface.At ]]
> > methods {
> >@property first_day_of_week {
> > - [[The first day of week to use on calendar widgets'.]]
> > - set {
> > - }
> > - get {
> > - }
> > + [[The first day of week to use on calendar widgets.
> > +
> > +   This is the day that will appear in the left-most column
> > (eg. Monday
> > +   in France or Sunday in the US).
> > + ]]
> >   values {
> > -day:
> > Efl.Ui.Calendar.Weekday(Efl.Ui.Calendar.Weekday.sunday); [[Weekday
> > enum value, see @Elm.Calendar.Weekday]]
> > +day:
> > Efl.Ui.Calendar.Weekday(Efl.Ui.Calendar.Weekday.sunday);
> > +   [[The first day of the week.]]
> >   }
> >}
> >@property date_min {
> > 
> 
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


-- 
- Codito, ergo sum - "I code, therefore I am" --
Carsten Haitzler - ras...@rasterman.com


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Git Feature/ Proposal

2017-11-13 Thread Tom Hacohen

So what has been decided? What should I do? I need specs, preferably
already added to the git wiki page so there are docs for this thing.

On Wed, Nov 8, 2017 at 11:57 PM, Carsten Haitzler  wrote:
> On Wed, 08 Nov 2017 21:39:15 + Mike Blumenkrantz
>  said:
>
>> Key points for the implementation:
>>
>> * all commits send mails to the list
>> * no rewrite of pushed commits
>>
>> Things to consider:
>> * how are feature/ branches deleted?
>>  - maybe anyone can delete?
>
> Good point. these need deletion. after a few years it'll be a mess of old
> feature branches no one will ever look at again. The merge to master should
> contain all the history and log that is needed at that point for history
> digging.
>
>> * do probies get feature/ push access?
>>  - seems like they should?
>>
>> On Wed, Nov 8, 2017 at 2:42 PM Tom Hacohen  wrote:
>>
>> > Yeah, good idea.
>> >
>> > I'll take a look into implementing it soon.
>> >
>> > On Tue, Nov 7, 2017 at 8:50 PM, Andrew Williams 
>> > wrote:
>> > > Hi,
>> > >
>> > > That sounds great - the ability to work together on features off-master
>> > > would be really helpful.
>> > >
>> > > Andy
>> > >
>> > > On Tue, 7 Nov 2017 at 16:15, Mike Blumenkrantz <
>> > > michael.blumenkra...@gmail.com> wrote:
>> > >
>> > >> After some discussions about git organization, it's become clear to me
>> > that
>> > >> we should be trying to enact some changes which facilitate
>> > collaboration,
>> > >> both between existing contributors and keeping in mind future
>> > contributors.
>> > >>
>> > >> The current git branch policy is this:
>> > >>
>> > >> * master
>> > >> * $project-$version
>> > >> * devs/$name/$branchname
>> > >>
>> > >> No others are allowed. This fits many use cases, but it does not
>> > actually
>> > >> help us work towards collaborating on features/patchsets and instead
>> > >> promotes developing in isolation.
>> > >>
>> > >> A simple proposal could improve this without requiring or significantly
>> > >> changing our workflow: add "feature/" branches. For example, if Cedric
>> > and
>> > >> I decide to work on a "feature" which scrapes the archive of this
>> > mailing
>> > >> list and then crashes the session of anyone who replies to this thread,
>> > we
>> > >> might jointly create a branch named "feature/discussion_helper" and push
>> > >> commits to it.
>> > >>
>> > >> A key point of this proposal would be that the feature/ branches must
>> > >> trigger mails to the mailing list just like stable branches. This would
>> > >> increase visibility for feature branches as well as promote further
>> > >> collaboration even from those who are not directly involved in creating
>> > the
>> > >> feature. The initial feature development could be done in a dev/ branch,
>> > >> and then it could later move to a feature/ branch once it has
>> > progressed to
>> > >> the point where it is ready for public visibility and increased
>> > >> collaboration.
>> > >>
>> > >> Lastly, feature branches would not be required use, just encouraged.
>> > This
>> > >> allows people to continue the current EFL standard of always committing
>> > >> only to master without any prior testing or branching, the need for
>> > which
>> > >> has defeated other proposals which would prevent such action.
>> > >>
>> > >> I think this could yield significant improvements to the community's
>> > >> overall workflow without massively changing the structure under which
>> > the
>> > >> everyone has been functioning.
>> > >>
>> > >>
>> > --
>> > >> Check out the vibrant tech community on one of the world's most
>> > >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> > >> ___
>> > >> enlightenment-devel mailing list
>> > >> enlightenment-devel@lists.sourceforge.net
>> > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> > >>
>> > > --
>> > > http://andywilliams.me
>> > > http://ajwillia.ms
>> > >
>> > --
>> > > Check out the vibrant tech community on one of the world's most
>> > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> > > ___
>> > > enlightenment-devel mailing list
>> > > enlightenment-devel@lists.sourceforge.net
>> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >
>> >
>> > --
>> > Check out the vibrant tech community on one of the world's most
>> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> > ___
>> > enlightenment-devel mailing list
>> > enlightenment-devel@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >
>>

Re: [E-devel] [EGIT] [core/efl] master 01/01: calendar: Remove invalid ref to elm enum

2017-11-13 Thread Daniel Zaoui

Thanks for the fix. And for having excited my curiosity. I didn't know that US, 
Canada... consider Sunday as the first day. Always good to know.

On Mon, 13 Nov 2017 02:40:37 -0800
Jean-Philippe ANDRÉ  wrote:

> jpeg pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/efl.git/commit/?id=4255c34f7a8dfcba7fe585fd773fa6f9157f2829
> 
> commit 4255c34f7a8dfcba7fe585fd773fa6f9157f2829
> Author: Jean-Philippe Andre 
> Date:   Mon Nov 13 15:39:53 2017 +0900
> 
> calendar: Remove invalid ref to elm enum
> 
> Thanks @JackDanielz for the report. This does not solve your
> actual concern, though.
> ---
>  src/lib/elementary/efl_ui_calendar.eo | 13 +++--
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/src/lib/elementary/efl_ui_calendar.eo
> b/src/lib/elementary/efl_ui_calendar.eo index 43d4508516..5125f2e9cd
> 100644 --- a/src/lib/elementary/efl_ui_calendar.eo
> +++ b/src/lib/elementary/efl_ui_calendar.eo
> @@ -26,13 +26,14 @@ class Efl.Ui.Calendar (Efl.Ui.Layout,
> Efl.Ui.Focus.Composition, Elm.Interface.At ]]
> methods {
>@property first_day_of_week {
> - [[The first day of week to use on calendar widgets'.]]
> - set {
> - }
> - get {
> - }
> + [[The first day of week to use on calendar widgets.
> +
> +   This is the day that will appear in the left-most column
> (eg. Monday
> +   in France or Sunday in the US).
> + ]]
>   values {
> -day:
> Efl.Ui.Calendar.Weekday(Efl.Ui.Calendar.Weekday.sunday); [[Weekday
> enum value, see @Elm.Calendar.Weekday]]
> +day:
> Efl.Ui.Calendar.Weekday(Efl.Ui.Calendar.Weekday.sunday);
> +   [[The first day of the week.]]
>   }
>}
>@property date_min {
> 


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] Eo installed files issue

2017-11-13 Thread Daniel Zaoui

On Mon, 13 Nov 2017 11:37:43 +0900
Jean-Philippe André  wrote:

Yo,

> Hi,
> 
> 2017-11-13 3:12 GMT+09:00 Daniel Zaoui :
> 
> > Hi guys,
> >
> > I have some issue concerning the parsing of the installed Eo files.
> > It is now impossible to parse some of them because of the
> > dependency on internal Eo files/types.
> >
> > A simple case is efl_ui_calendar.eo that fails during Eolian parsing
> > because it references Elm.Calendar.Weekday in the comments. We have
> > another case where efl_ui_text.eo imports elm_entry that is
> > internal, leading to a parsing error. I am sure there are/will be
> > other cases. 
> 
> Calendar is a small issue, entry is a larger problem, as I see
> Efl.Ui.Text still has quite a few APIs that aren't really "eo-ready"
> yet (item providers, cnp, context menu in particular).
> 
> 
> > So now, I try to understand which solution we have:
> > - Don't install Eo files at all: shitty.
> > - Fix the failing Eo files so they dont depend on internals.
> >  
> 
> Solution 2 is the only correct way here.
> As far as I'm concerned, if make distcheck passes and I can build
> external apps (E, terminology) there isn't much more I can do to
> verify install is fine.

The problem with distcheck is that almost no one runs it. So checking there 
will not help people to fix stuff before pushing.

> 
> Maybe we should check the Eo files validity during installation, by
> running
> > eolian_gen on the files to install. Is it do-able?
> >  
> 
> It would be fine for me if there was a tool to run on the installed
> files. After installation is fine.
> Maybe run the documentation generator?

I think eolian_gen can do the job. We just need some option to just validate 
some Eo file. No generation.

> 
> Anyhow I'm sorry that I broke everything for you with that change. As
> we discussed earlier, this had to be done, and I think now is a good
> time to try and fix everything. Having errors is a good way to know
> what to fix :) If you have any specific issue or a tool I can run,
> let me know so I can help!

You know I will never excuse you for that!!!

Seriously, I know why you did that and I fully understand. The best tool seems 
eolian_gen that is run on the installed Eo files, as it is already inside EFL 
and needs one more simple option. We only should need to run it after the 
installation.

> 


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [EGIT] [core/efl] master 01/01: calendar: Remove invalid ref to elm enum

Re: [E-devel] [EGIT] [core/efl] master 01/01: calendar: Remove invalid ref to elm enum

Re: [E-devel] [EGIT] [core/efl] master 01/01: calendar: Remove invalid ref to elm enum

Re: [E-devel] Git Feature/ Proposal

Re: [E-devel] [EGIT] [core/efl] master 01/01: calendar: Remove invalid ref to elm enum

Re: [E-devel] Eo installed files issue

6 matches

Site Navigation

Mail list logo

Footer information