Re: [E-devel] [EGIT] [core/efl] master 03/05: efl: Introduce interface Efl.Dup
On Fri, Dec 1, 2017 at 3:49 AM, Davide Andreoli
wrote:
> 2017-11-30 3:36 GMT+01:00 Jean-Philippe ANDRÉ :
>
> > jpeg pushed a commit to branch master.
> >
> > http://git.enlightenment.org/core/efl.git/commit/?id=
> > bd5b76508b0b3bdc5d92f5f7db9741c100d47d3c
> >
> > commit bd5b76508b0b3bdc5d92f5f7db9741c100d47d3c
> > Author: Jean-Philippe Andre
> > Date: Wed Nov 29 20:03:16 2017 +0900
> >
> > efl: Introduce interface Efl.Dup
> >
> > A few classes allow their objects to be duplicated, so they should
> all
> > use the same interface.
> >
> > Also, rename VG's dup to copy_from as it's not conforming to the
> > definition of dup.
> >
>
> Is'nt the last rename (vg_dup) an abi break ?
>
> python-efl apps now crash like this:
> Traceback (most recent call last):
> File "/usr/bin/epymc", line 5, in
> from epymc.main import start_epymc
> File "/usr/lib/python3.6/site-packages/epymc/main.py", line 32, in
>
> from efl import edje
> ImportError: /usr/local/lib/libedje.so.1: undefined symbol:
> evas_vg_node_dup
>
> A python-efl rebuild fixed the issue, this is why I think it's an abi
> break.
>
> note that the bindings do not use/expose evas_vg in any way
>
I was under the impression that Evas VG was still "beta".
In fact I can see EFL_BETA_API_SUPPORT.
Could you double-check on your side what's happening?
Where is this symbol used?
TIA,
>
>
>
> > ---
> > src/Makefile_Efl.am | 1 +
> > src/bin/elementary/test_events.c | 10 +-
> > src/lib/edje/edje_calc.c | 2 +-
> > src/lib/efl/Efl.h | 1 +
> > src/lib/efl/interfaces/efl_dup.eo | 17 +
> > src/lib/efl/interfaces/efl_gfx_path.c | 4 ++--
> > src/lib/efl/interfaces/efl_gfx_path.eo| 3 ++-
> > src/lib/efl/interfaces/efl_gfx_shape.c| 12 +++-
> > src/lib/efl/interfaces/efl_gfx_shape.eo | 12 +++-
> > src/lib/efl/interfaces/efl_interfaces_main.c | 1 +
> > src/lib/evas/canvas/efl_canvas_vg.c | 2 +-
> > src/lib/evas/canvas/efl_input_event.eo| 13 +
> > src/lib/evas/canvas/efl_input_focus.c | 2 +-
> > src/lib/evas/canvas/efl_input_focus.eo| 10 +-
> > src/lib/evas/canvas/efl_input_hold.c | 2 +-
> > src/lib/evas/canvas/efl_input_hold.eo | 10 +-
> > src/lib/evas/canvas/efl_input_key.c | 2 +-
> > src/lib/evas/canvas/efl_input_key.eo | 10 +-
> > src/lib/evas/canvas/efl_input_pointer.c | 2 +-
> > src/lib/evas/canvas/efl_input_pointer.eo | 10 +-
> > src/lib/evas/canvas/efl_vg.eo | 7 ++-
> > src/lib/evas/canvas/efl_vg_container.eo | 2 +-
> > src/lib/evas/canvas/efl_vg_gradient.eo| 2 +-
> > src/lib/evas/canvas/efl_vg_gradient_linear.eo | 2 +-
> > src/lib/evas/canvas/efl_vg_gradient_radial.eo | 2 +-
> > src/lib/evas/canvas/efl_vg_shape.eo | 2 +-
> > src/lib/evas/canvas/evas_device.c | 2 +-
> > src/lib/evas/canvas/evas_events.c | 22
> +++---
> > src/lib/evas/canvas/evas_vg_container.c | 6 +++---
> > src/lib/evas/canvas/evas_vg_gradient.c| 4 ++--
> > src/lib/evas/canvas/evas_vg_gradient_linear.c | 4 ++--
> > src/lib/evas/canvas/evas_vg_gradient_radial.c | 4 ++--
> > src/lib/evas/canvas/evas_vg_node.c| 4 ++--
> > src/lib/evas/canvas/evas_vg_shape.c | 16
> > src/lib/evas/vg/evas_vg_cache.c | 2 +-
> > 35 files changed, 121 insertions(+), 86 deletions(-)
> >
> > diff --git a/src/Makefile_Efl.am b/src/Makefile_Efl.am
> > index 769abd6298..0584602894 100644
> > --- a/src/Makefile_Efl.am
> > +++ b/src/Makefile_Efl.am
> > @@ -16,6 +16,7 @@ efl_eolian_files = \
> >lib/efl/interfaces/efl_canvas.eo \
> >lib/efl/interfaces/efl_config.eo \
> >lib/efl/interfaces/efl_control.eo \
> > + lib/efl/interfaces/efl_dup.eo \
> >lib/efl/interfaces/efl_file.eo \
> >lib/efl/interfaces/efl_image_load.eo \
> >lib/efl/interfaces/efl_part.eo \
> > diff --git a/src/bin/elementary/test_events.c b/src/bin/elementary/test_
> > events.c
> > index c6a3ca5a0e..30831e8329 100644
> > --- a/src/bin/elementary/test_events.c
> > +++ b/src/bin/elementary/test_events.c
> > @@ -22,7 +22,7 @@ _pointer_down(void *data, const Efl_Event *ev)
> > testdata *td = data;
> > td->down = 1;
> > efl_unref(td->evdown);
> > - td->evdown = efl_input_dup(ev->info);
> > + td->evdown = efl_dup(ev->info);
> > }
> >
> > static void
> > @@ -30,7 +30,7 @@ _pointer_move(void *data, const Efl_Event *ev)
> > {
> > testdata *td = data;
> > efl_unref(td->evmove);
> > - td->evmove = efl_input_dup(ev->info);
> > + td->evmove = efl_dup(ev->info);
> > }
> >
> > static void
> > @@ -39,7 +39,7 @@ _pointer_up(void *data, const Efl_Event *ev)
> > te
Re: [E-devel] [EGIT] [core/efl] master 03/05: efl: Introduce interface Efl.Dup
2017-11-30 3:36 GMT+01:00 Jean-Philippe ANDRÉ :
> jpeg pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=
> bd5b76508b0b3bdc5d92f5f7db9741c100d47d3c
>
> commit bd5b76508b0b3bdc5d92f5f7db9741c100d47d3c
> Author: Jean-Philippe Andre
> Date: Wed Nov 29 20:03:16 2017 +0900
>
> efl: Introduce interface Efl.Dup
>
> A few classes allow their objects to be duplicated, so they should all
> use the same interface.
>
> Also, rename VG's dup to copy_from as it's not conforming to the
> definition of dup.
>
Is'nt the last rename (vg_dup) an abi break ?
python-efl apps now crash like this:
Traceback (most recent call last):
File "/usr/bin/epymc", line 5, in
from epymc.main import start_epymc
File "/usr/lib/python3.6/site-packages/epymc/main.py", line 32, in
from efl import edje
ImportError: /usr/local/lib/libedje.so.1: undefined symbol: evas_vg_node_dup
A python-efl rebuild fixed the issue, this is why I think it's an abi break.
note that the bindings do not use/expose evas_vg in any way
> ---
> src/Makefile_Efl.am | 1 +
> src/bin/elementary/test_events.c | 10 +-
> src/lib/edje/edje_calc.c | 2 +-
> src/lib/efl/Efl.h | 1 +
> src/lib/efl/interfaces/efl_dup.eo | 17 +
> src/lib/efl/interfaces/efl_gfx_path.c | 4 ++--
> src/lib/efl/interfaces/efl_gfx_path.eo| 3 ++-
> src/lib/efl/interfaces/efl_gfx_shape.c| 12 +++-
> src/lib/efl/interfaces/efl_gfx_shape.eo | 12 +++-
> src/lib/efl/interfaces/efl_interfaces_main.c | 1 +
> src/lib/evas/canvas/efl_canvas_vg.c | 2 +-
> src/lib/evas/canvas/efl_input_event.eo| 13 +
> src/lib/evas/canvas/efl_input_focus.c | 2 +-
> src/lib/evas/canvas/efl_input_focus.eo| 10 +-
> src/lib/evas/canvas/efl_input_hold.c | 2 +-
> src/lib/evas/canvas/efl_input_hold.eo | 10 +-
> src/lib/evas/canvas/efl_input_key.c | 2 +-
> src/lib/evas/canvas/efl_input_key.eo | 10 +-
> src/lib/evas/canvas/efl_input_pointer.c | 2 +-
> src/lib/evas/canvas/efl_input_pointer.eo | 10 +-
> src/lib/evas/canvas/efl_vg.eo | 7 ++-
> src/lib/evas/canvas/efl_vg_container.eo | 2 +-
> src/lib/evas/canvas/efl_vg_gradient.eo| 2 +-
> src/lib/evas/canvas/efl_vg_gradient_linear.eo | 2 +-
> src/lib/evas/canvas/efl_vg_gradient_radial.eo | 2 +-
> src/lib/evas/canvas/efl_vg_shape.eo | 2 +-
> src/lib/evas/canvas/evas_device.c | 2 +-
> src/lib/evas/canvas/evas_events.c | 22 +++---
> src/lib/evas/canvas/evas_vg_container.c | 6 +++---
> src/lib/evas/canvas/evas_vg_gradient.c| 4 ++--
> src/lib/evas/canvas/evas_vg_gradient_linear.c | 4 ++--
> src/lib/evas/canvas/evas_vg_gradient_radial.c | 4 ++--
> src/lib/evas/canvas/evas_vg_node.c| 4 ++--
> src/lib/evas/canvas/evas_vg_shape.c | 16
> src/lib/evas/vg/evas_vg_cache.c | 2 +-
> 35 files changed, 121 insertions(+), 86 deletions(-)
>
> diff --git a/src/Makefile_Efl.am b/src/Makefile_Efl.am
> index 769abd6298..0584602894 100644
> --- a/src/Makefile_Efl.am
> +++ b/src/Makefile_Efl.am
> @@ -16,6 +16,7 @@ efl_eolian_files = \
>lib/efl/interfaces/efl_canvas.eo \
>lib/efl/interfaces/efl_config.eo \
>lib/efl/interfaces/efl_control.eo \
> + lib/efl/interfaces/efl_dup.eo \
>lib/efl/interfaces/efl_file.eo \
>lib/efl/interfaces/efl_image_load.eo \
>lib/efl/interfaces/efl_part.eo \
> diff --git a/src/bin/elementary/test_events.c b/src/bin/elementary/test_
> events.c
> index c6a3ca5a0e..30831e8329 100644
> --- a/src/bin/elementary/test_events.c
> +++ b/src/bin/elementary/test_events.c
> @@ -22,7 +22,7 @@ _pointer_down(void *data, const Efl_Event *ev)
> testdata *td = data;
> td->down = 1;
> efl_unref(td->evdown);
> - td->evdown = efl_input_dup(ev->info);
> + td->evdown = efl_dup(ev->info);
> }
>
> static void
> @@ -30,7 +30,7 @@ _pointer_move(void *data, const Efl_Event *ev)
> {
> testdata *td = data;
> efl_unref(td->evmove);
> - td->evmove = efl_input_dup(ev->info);
> + td->evmove = efl_dup(ev->info);
> }
>
> static void
> @@ -39,7 +39,7 @@ _pointer_up(void *data, const Efl_Event *ev)
> testdata *td = data;
> td->down = 0;
> efl_unref(td->evup);
> - td->evup = efl_input_dup(ev->info);
> + td->evup = efl_dup(ev->info);
> }
>
> static void
> @@ -64,7 +64,7 @@ _key_down(void *data, const Efl_Event *ev)
> if (!efl_input_fake_get(ev->info))
> {
> efl_unref(td->evkeydown);
> -td->evkeydown = efl_input_dup(ev->info);
> +td->evkeydown = efl_dup(ev->info);
> }
> }
>
> @@ -84,7 +84,7 @@ _key_up(void *data,
Re: [E-devel] [EGIT] [core/efl] master 01/01: elm_code: Reload grid colours on theme change
Hi,
I called the parent method as indicated.
Unfortunately that returned FAILED and broke the functionality so, for now,
I don't check the return of the super call.
I guess I need to look more into theme application and swapping out layouts
to understand why it's not working as expected.
Thanks for the pointer,
Andy
On Tue, 28 Nov 2017 at 04:52 Jean-Philippe André wrote:
> Hi Andy,
>
> On Tue, Nov 28, 2017 at 6:23 AM, Andy Williams
> wrote:
>
> > ajwillia-ms pushed a commit to branch master.
> >
> > http://git.enlightenment.org/core/efl.git/commit/?id=
> > d43fe6c16fd763215e2741b37baa8df913f151c0
> >
> > commit d43fe6c16fd763215e2741b37baa8df913f151c0
> > Author: Andy Williams
> > Date: Mon Nov 27 21:23:11 2017 +
> >
> > elm_code: Reload grid colours on theme change
> > ---
> > src/lib/elementary/elm_code_widget.c | 34
> +++---
> >
> > src/lib/elementary/elm_code_widget.eo | 1 +
> > 2 files changed, 28 insertions(+), 7 deletions(-)
> >
> > diff --git a/src/lib/elementary/elm_code_widget.c
> > b/src/lib/elementary/elm_code_widget.c
> > index e61aa6afea..774e763c78 100644
> > --- a/src/lib/elementary/elm_code_widget.c
> > +++ b/src/lib/elementary/elm_code_widget.c
> > @@ -1874,7 +1874,7 @@ _elm_code_widget_ensure_n_grid_rows(Elm_Code_Widget
> > *widget, int rows)
> > evas_object_size_hint_weight_set(grid, EVAS_HINT_EXPAND, 0.0);
> > evas_object_size_hint_align_set(grid, EVAS_HINT_FILL, 0.0);
> > evas_object_show(grid);
> > -_elm_code_widget_setup_palette(grid,
> > efl_parent_get(pd->scroller));
> > +_elm_code_widget_setup_palette(grid, widget);
> >
> > elm_box_pack_end(pd->gridbox, grid);
> > pd->grids = eina_list_append(pd->grids, grid);
> > @@ -2192,13 +2192,35 @@ _elm_code_widget_cursor_position_get(Eo *obj
> > EINA_UNUSED, Elm_Code_Widget_Data *
> > *col = pd->cursor_col;
> > }
> >
> > +EOLIAN static Efl_Ui_Theme_Apply
> > +_elm_code_widget_elm_widget_theme_apply(Eo *obj, Elm_Code_Widget_Data
> > *pd)
> > +{
> > + Eo *edje;
> > + int r, g, b, a;
> > + unsigned int i;
> > + Evas_Object *grid, *background;
> > +
> > + edje = elm_layout_edje_get(obj);
> > + edje_object_color_class_get(edje, "elm/code/status/default", &r, &g,
> > &b, &a,
> > + NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> > NULL);
> > +
> > + background = elm_object_part_content_get(pd->scroller,
> > "elm.swallow.background");
> > + evas_object_color_set(background, r, g, b, a);
> > +
> > + for (i = 0; i < eina_list_count(pd->grids); i++)
> > + {
> > +grid = eina_list_nth(pd->grids, i);
> > +_elm_code_widget_setup_palette(grid, obj);
> > + }
> > +
> > + return EFL_UI_THEME_APPLY_SUCCESS;
> > +}
> >
>
> I don't see any call to efl_super() so I wonder how the new edje is
> supposed to be loaded?
> You may want to refer to _efl_ui_button_elm_widget_theme_apply() for
> instance.
>
> Best regards,
> --
> JP
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
http://andywilliams.me
http://ajwillia.ms
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Efl.Ui.Text.Interactive events
Hi, I have an EFL_UI_TEXT_CLASS object in my app and I have registered for 2 interactive text events efl_event_callback_add(efl_added, EFL_UI_TEXT_INTERACTIVE_EVENT_SELECTION_CHANGED, _editor_selection_changed, NULL), efl_event_callback_add(efl_added, EFL_UI_TEXT_INTERACTIVE_EVENT_CHANGED_USER, _editor_changed, NULL), Neither of these are called. Am I doing something wrong or should I report a bug? Thanks, Andrew -- http://andywilliams.me http://ajwillia.ms -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Git Feature/ Proposal
I meant that you *should* configure something like this. I don't remember if it was per project or global, but I remember there was something. -- Tom. On Thu, Nov 30, 2017 at 7:46 AM, Stefan Schmidt wrote: > Hello. > > > On 11/29/2017 06:04 PM, Tom Hacohen wrote: >> You need to add them to "ignore branches" on phab. Stefan? :P > > I never configured something like this on Phab. Did you mean someone else? > > regards > Stefan Schmidt > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
